From nobody Mon Feb 9 17:23:51 2026 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F85634F24D for ; Wed, 28 Jan 2026 09:56:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769594167; cv=none; b=G6t5iAhd23JKpJ7etq1qo/VROrR2UezwMb3hZn6L0aCEuCXRwG7lSWjyhysWtgwd9h11RSTYhYY6zk5QzXlokHwijXa5lYK3JBNd4hDO9WUU3sITe4HUUSEeConyaIKpZFdkpT1uual1bI09pY1J0izZ1VMwOLTVj47D4er8vhY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769594167; c=relaxed/simple; bh=4ReMl82RqipyTUSEdc7YEI1timhoJg+iviW3wSo7Lps=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tzUJUV4sb+QJXYezSFMEuIDGdCaSYjsxQv0BoqaP/gEWgzHt/fKszwkWM6lUSj34xtq+QbOTvbWPOmw42RFulOlulXYaT8YJgF72PY9nUGJ3ASEShS2F8ltJcRhxza4KPvfPnPwKNu+Ah4OnQF/G3u42akeqwUtGKx/kW3hLh8I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=z54dZ4p0; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=C9QQo2sb; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="z54dZ4p0"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="C9QQo2sb" From: Sebastian Andrzej Siewior DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1769594162; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UjVnojV1go+ZhPEqkbYPb3kyNLwRxEkLwFz7kKFGU4M=; b=z54dZ4p07rsUzj6BmhrhG7EGh21JuSNvw3LHICD8VNZB/LGKgLczLuRF26E+KDmO3AbuXM qiaW/XyKUF/c803K4q9QmxLEqAGkf32OVqcwIsLC7Zjr+FTc/P/mMoaO25VWGERFr9qCg9 VLTlXXTgdrLa+1XsCpMohj9gdjetCPs0cZcnI8qEBBxy/mP/UotAYywXIPHEOCP/NTJNLu uT5HhxjLkT9MkBg5KB+BlFtia76UrZ/Xsp3i7eL1mE0Lv81wZ/uqxwx2LU045IhpAihixj xLNPIkDmNcGZRNQPQ68H4hvF6pGnRVlJbqivjmw8MBqMHku0HUExRDieqW5zqg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1769594162; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UjVnojV1go+ZhPEqkbYPb3kyNLwRxEkLwFz7kKFGU4M=; b=C9QQo2sbQPG0k1UWIP9QHQQYpmG02QiULfX8Ni3tyyVK4Aqwr9DXkQ7fdLI4mbWO+bsusK 18Ynm/lCb/aHKICQ== To: linux-kernel@vger.kernel.org Cc: "Thomas Gleixner" , Sebastian Andrzej Siewior , Charles Keepax , Lee Jones , Andy Shevchenko , patches@opensource.cirrus.com, Mark Brown Subject: [PATCH v2 15/20] mfd: wm8350-core: Use IRQF_ONESHOT Date: Wed, 28 Jan 2026 10:55:35 +0100 Message-ID: <20260128095540.863589-16-bigeasy@linutronix.de> In-Reply-To: <20260128095540.863589-1-bigeasy@linutronix.de> References: <20260128095540.863589-1-bigeasy@linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using a threaded interrupt without a dedicated primary handler mandates the IRQF_ONESHOT flag to mask the interrupt source while the threaded handler is active. Otherwise the interrupt can fire again before the threaded handler had a chance to run. Mark explained that this should not happen with this hardware since it is a slow irqchip which is behind an I2C/ SPI bus but the IRQ-core will refuse to accept such a handler. Set IRQF_ONESHOT so the interrupt source is masked until the secondary handler is done. Fixes: 1c6c69525b40e ("genirq: Reject bogus threaded irq requests") Reviewed-by: Charles Keepax Signed-off-by: Sebastian Andrzej Siewior Reviewed-by: Andy Shevchenko --- Cc: Lee Jones Cc: Andy Shevchenko Cc: patches@opensource.cirrus.com Cc: Mark Brown --- include/linux/mfd/wm8350/core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/mfd/wm8350/core.h b/include/linux/mfd/wm8350/cor= e.h index 5f70d3b5d1b1a..097ef4dfcdac8 100644 --- a/include/linux/mfd/wm8350/core.h +++ b/include/linux/mfd/wm8350/core.h @@ -667,7 +667,7 @@ static inline int wm8350_register_irq(struct wm8350 *wm= 8350, int irq, return -ENODEV; =20 return request_threaded_irq(irq + wm8350->irq_base, NULL, - handler, flags, name, data); + handler, flags | IRQF_ONESHOT, name, data); } =20 static inline void wm8350_free_irq(struct wm8350 *wm8350, int irq, void *d= ata) --=20 2.51.0