From nobody Sat Feb 7 06:54:56 2026 Received: from mail-dl1-f48.google.com (mail-dl1-f48.google.com [74.125.82.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A2BC32AAAD for ; Wed, 28 Jan 2026 08:30:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769589014; cv=none; b=BzhWRb6QbjjwcGB4JGeI9cNWSvgRjIvzXtasN+BbiR6hXweTewEedIVmMf1AxlADMuUsgmQjug+ZlzukruAlFeDDhSPf2pokR52r3e6zAlMBoHK8AJvPfabnKDWMc08/vUHqU6cqWU2IjatKz+5SVrVJFR0smslijtthMMg5lJo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769589014; c=relaxed/simple; bh=i7jIMtgn5v7k2mHdb0BICegbJX4JV3eIH5WClHRS1vg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=UJiXpqRsSQ/xyKvdY7tX3yongBCh4POBb1G0w2jEn7O2haH8vYIVO6l83LI50AA8Z5t7Buqqy6oA/Rks5rIIjtbLp0nYFiu7dpznd4kNVAIEpd5ioyYrmIU9MlmYn2uqmcMmllT1wskHqOMWYYJYHoy7RObX3fuQHnd4WPkPlzk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cO1jMpWX; arc=none smtp.client-ip=74.125.82.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cO1jMpWX" Received: by mail-dl1-f48.google.com with SMTP id a92af1059eb24-11f36012fb2so9364505c88.1 for ; Wed, 28 Jan 2026 00:30:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769589011; x=1770193811; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=UWNDXOn4e3ISKUfrp4YI7kPUB09IKnTiOMAEzDBRtkg=; b=cO1jMpWXOrxr8Lok2WclqSPtn2IfZUmiR5LCksNoHWTvJJgKxmqW4bpNn7BZPi2TSe FQspOQHTiKpHEXDey44xKcutCJBaCDbQbkSI+VY287+JUv6g4/Ro/i/6XXCKHQ9ZasLs MxmgRjH5bsxs16KLeHfRryuM251P3AOVMMW/ZScIniZj0WgMQ5InS3bY/nUb0B0iJyBk tzoD1UPq/IPrMLDPCu7FPSWr9AzK9+BBW+pZLPO1akDt56jXfWlbltSBXsy2MQk845Zz fmZTEIV5qISTvJ6AYeAVxCXErWZHfoeyjFDHkQEOmSQhblzMfZbwzN9wRmX8C+JafDc8 QCEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769589011; x=1770193811; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UWNDXOn4e3ISKUfrp4YI7kPUB09IKnTiOMAEzDBRtkg=; b=MP9nJdEp9jFuGbG8ezHHtWHpIdYYLkPBplmnOrjKuqAdi+Gfc6EY/a9ayfuoqpO8Mr 6uLdO/TlbDURD6kWPV0GC9sEvtRI/27kg1qXeFeBl4gUxEshzr7agFinVg6+r9RBNIgz FmDFxW+sWkSRqYnOLGcqmOUqqav0ZNm4PJxkH0MBkMYzrY9U9Fc9hcg6GgDQg8r5XyWY hrVqelbD4yWYQQyTPVstkJmtfhTloMj8r7y1ZlefUAd9yvE+gb9+2f1Aq20Gh6gJSgZt a+N6aCkAwSbbyLt5Dt65JzGMGBsmVi+PO1J72PZ4XhQzPV5McP+lVoNHiL7DnLT2QCjw qW5g== X-Gm-Message-State: AOJu0Yz1pf7nxu3GJpQt/yq8PhpGXc6IzmWIAvPNk0Ewux6xVerHpBqe nr+RJ37xrglt5XfIxyq4yFepX/SGMKSvYu4DXfCo3HTUMeuF4UMPAIv4 X-Gm-Gg: AZuq6aIdxBqRTOgZvj2NWpPUsndpLnkUu363Xnfu6Uze04bDACp6zQyLrWKZmcj2S4H K/QK4277XjiCT/pCt1YuPpuIB9ky0Xq8RqIHYFcRU2GRtqRahxLrD+CGWngt0CMPmwFbRSKxyFb QIPpeevcBlDo+bJZUxpVBQTGGWOR8stqUxuhsX/U9jdkl2a8qDo40tqPEHV+zecqXrzcxcbjtYR hZHRWe/rMeoUy70Rtq3iljvXOLnBWKvnJEA6Hzt2C7xcgDVhL9fGQm5lv3ORbuoaJb/16AUVdAk GaJ33KM99qk88YRY01gFgInkcjr3XaioMUu1PXcMLfcf6CNGa7pmByhleW4b2Bq0GLCM1QsU0WL BPHqStc/t2xSx7mmVxCHI/51lRCuSQn9H4s9xncqTj02trS70xYcfp5vjPLv6BdCqkAc6FszXMM gR54X4kOlVRlzsNmJJUF0CtfoHy2v5UfdW4w== X-Received: by 2002:a05:7022:b90:b0:119:e56b:91da with SMTP id a92af1059eb24-124a006e3b7mr2906966c88.11.1769589010506; Wed, 28 Jan 2026 00:30:10 -0800 (PST) Received: from VM-16-24-fedora.. ([43.153.32.141]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b7a1abe938sm1750841eec.16.2026.01.28.00.30.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jan 2026 00:30:09 -0800 (PST) From: alexjlzheng@gmail.com X-Google-Original-From: alexjlzheng@tencent.com To: oleg@redhat.com, usamaarif642@gmail.com, david@kernel.org, akpm@linux-foundation.org, lorenzo.stoakes@oracle.com, mingo@kernel.org, alexjlzheng@tencent.com, ruippan@tencent.com, mjguzik@gmail.com Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: [PATCH v2] procfs: fix missing RCU protection when reading real_parent in do_task_stat() Date: Wed, 28 Jan 2026 16:30:07 +0800 Message-ID: <20260128083007.3173016-1-alexjlzheng@tencent.com> X-Mailer: git-send-email 2.49.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Jinliang Zheng When reading /proc/[pid]/stat, do_task_stat() accesses task->real_parent without proper RCU protection, which leads: cpu 0 cpu 1 ----- ----- do_task_stat var =3D task->real_parent release_task call_rcu(delayed_put_task_struct) task_tgid_nr_ns(var) rcu_read_lock <--- Too late to protect task->real_parent! task_pid_ptr <--- UAF! rcu_read_unlock This patch use task_ppid_nr_ns() instead of task_tgid_nr_ns() to adds proper RCU protection for accessing task->real_parent. Fixes: 06fffb1267c9 ("do_task_stat: don't take rcu_read_lock()") Signed-off-by: Jinliang Zheng Acked-by: Oleg Nesterov --- changelog: v2: - use task_ppid_nr_ns(), suggested by Oleg Nesterov - clear commit message v1: https://lore.kernel.org/linux-fsdevel/20260127150450.2073236-1-alexjlzh= eng@tencent.com/ --- fs/proc/array.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/proc/array.c b/fs/proc/array.c index 42932f88141a..5571177e0435 100644 --- a/fs/proc/array.c +++ b/fs/proc/array.c @@ -528,7 +528,7 @@ static int do_task_stat(struct seq_file *m, struct pid_= namespace *ns, } =20 sid =3D task_session_nr_ns(task, ns); - ppid =3D task_tgid_nr_ns(task->real_parent, ns); + ppid =3D task_ppid_nr_ns(task, ns); pgid =3D task_pgrp_nr_ns(task, ns); =20 unlock_task_sighand(task, &flags); --=20 2.49.0