From nobody Sun Feb 8 02:56:16 2026 Received: from out30-133.freemail.mail.aliyun.com (out30-133.freemail.mail.aliyun.com [115.124.30.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D822B2144D7 for ; Wed, 28 Jan 2026 04:59:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769576351; cv=none; b=eq0G13fgaea8AMbV0eAPrUfG6XoJB+BNkkremtJ4nPcgqWkXPYbPQF+yp205bgOLz9+6wTARdnQm/RnAG+VjUNsYWf8t2wWPYMh9asGv1p/3UKAnIvqahwFI5Zg0M56N/w1josi4KB519ESCtk6o2f6xVNGKYeEUAAld5HUzbeI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769576351; c=relaxed/simple; bh=sQlDYv/QlT4l4TM66D2ISHkJ76VGdEv+vDcV+sLRv5I=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=XQW3OAA7rie7GXMpdYXLy/+Hdndang/iccGNb0/5zO4Ya79G5zZQxDnFs1+uPP2Y2YeuAavriHDwu/CJhr74mLajCXximYgeP4OzSKY+MyeSwxBK6qLSOd6Y0CJ5TuBsB8IPWP85hRqIqiwsNqsppxi+3yNPrnaOObe7xSMNRH8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=LmsKBNTp; arc=none smtp.client-ip=115.124.30.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="LmsKBNTp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1769576339; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=tKhmk0cBya/+peKFA+lhG9Qk30qlWXsRLkZ+A1hgQ60=; b=LmsKBNTpoqVS6HOzel0gcXBWBpZjNR/+0Yh/JPz9iJyXixf9TID0eRpPDpr1wnP5ZArsVDRfJsDJ1Ge6wTmv4RqnDqR1yr4Sb9aghnrPUhlzdrwgwr6GhX8mY1c7gjg3aDZqOrNlgJBHeeSqcSfj3UqRr93JgyIMsQ86d8vEmZE= Received: from x31i01179.sqa.na131.tbsite.net(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0Wy29ZgF_1769576335 cluster:ay36) by smtp.aliyun-inc.com; Wed, 28 Jan 2026 12:58:59 +0800 From: Gao Xiang To: linux-erofs@lists.ozlabs.org Cc: LKML , Gao Xiang Subject: [PATCH] erofs: use inode_set_cached_link() Date: Wed, 28 Jan 2026 12:58:54 +0800 Message-ID: <20260128045854.2266287-1-hsiangkao@linux.alibaba.com> X-Mailer: git-send-email 2.43.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Symlink lengths are now cached in in-memory inodes directly so that readlink can be sped up. Signed-off-by: Gao Xiang --- fs/erofs/inode.c | 28 +++++++++++++++------------- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/fs/erofs/inode.c b/fs/erofs/inode.c index 2e02d4b466ce..6afe487eb9be 100644 --- a/fs/erofs/inode.c +++ b/fs/erofs/inode.c @@ -8,21 +8,23 @@ #include #include =20 -static int erofs_fill_symlink(struct inode *inode, void *kaddr, - unsigned int m_pofs) +static int erofs_fill_symlink(struct inode *inode, void *bptr, unsigned in= t ofs) { struct erofs_inode *vi =3D EROFS_I(inode); - loff_t off; - - m_pofs +=3D vi->xattr_isize; - /* check if it cannot be handled with fast symlink scheme */ - if (vi->datalayout !=3D EROFS_INODE_FLAT_INLINE || - check_add_overflow(m_pofs, inode->i_size, &off) || - off > i_blocksize(inode)) - return 0; - - inode->i_link =3D kmemdup_nul(kaddr + m_pofs, inode->i_size, GFP_KERNEL); - return inode->i_link ? 0 : -ENOMEM; + char *link; + loff_t end; + + ofs +=3D vi->xattr_isize; + /* check whether the symlink data is small enough to be inlined */ + if (vi->datalayout =3D=3D EROFS_INODE_FLAT_INLINE && + !check_add_overflow(ofs, inode->i_size, &end) && + end <=3D i_blocksize(inode)) { + link =3D kmemdup_nul(bptr + ofs, inode->i_size, GFP_KERNEL); + if (!link) + return -ENOMEM; + inode_set_cached_link(inode, link, inode->i_size); + } + return 0; } =20 static int erofs_read_inode(struct inode *inode) --=20 2.43.5