From nobody Sun Feb 8 16:50:41 2026 Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E82E21019E for ; Wed, 28 Jan 2026 00:40:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769560827; cv=none; b=mrSdT59fl+7slPrYsnchRjmKn/wxs9HAn1F3Ey8zeU4pTPYVr73rNMXqtivwX+4T5Yyv4yF7191eSjrQBzGT7k1pajtgYiSNaUckrYawQFhkUf1IO5XkMqgYVbNtdOIR4VV8BKsTWTUgUMoDPD2Q3GahSBBRawMz9DiWj3FMVqI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769560827; c=relaxed/simple; bh=MP9dXB0QtlVz5EFY8zq0rqzCjlp6FtqlHmoyAcHdpOk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NrKKxsNLhDadDkfC85462aPdI4pKPFhK9k9nYeaNrzYgpqcyDIlnll81OuTvnK9ZbpH0XMpUWP4GN7AkilZ3ZLBqCy9moSmLAh1pN+zuHrV2uOiTdjWNigOXunkFmvn8B8y+4rUTRbNelXv+QuZih7imldaP0rEJlMaJOhTxpUE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TdKX1K32; arc=none smtp.client-ip=209.85.128.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TdKX1K32" Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-7947072d0f6so20155837b3.1 for ; Tue, 27 Jan 2026 16:40:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769560825; x=1770165625; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2li4MWATGVuQb49gIaL2/wEm7/uj/Idq/ACN32Jca5M=; b=TdKX1K32Ewf0GYZOqowAmoJERJDNx2HIs2q2cZ2a+ldcxrYNZtPNl9vjmaBt61FZlI Zhpui/ae/MFBl3ryXLIg5WvPBvBOPPEtSojvuB4hU7a+8wgoLoPHg5AKGJjnyudPa44z feZHr3SzfAOk4k4i+L/lNImte01vVz9VqRpfbim/cgBkk+jnHRqCOx73dViT7eZrhKs6 EovKwO4ebJ54kSKCeDl+21dgdtmuxFoGUprph6Tr4KuxeO9z9DqawxUEGiAtlm+dHyQT Dt5+JkjC/852xn+cmnS9k5slQmbS6IXfBt7EN9N/ij/+yzi+4V4EAXtgldDAWVIfVghh AZgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769560825; x=1770165625; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2li4MWATGVuQb49gIaL2/wEm7/uj/Idq/ACN32Jca5M=; b=qZebysb/5GuPbmM1wlPHMMeMqQIgUL6QfMT53e9y4lnOk5lze7tPncrmYLFKgzk4nz SsKZWIJBRCDb4LMngDHu9xkk+RbXFKueSRKrCEEcYdptAipbX92kkjqeW/1WVKZm8WNj lWfyJDSCfO9DpzkCb73OL6MM5iFOfHcM4uPo2uqoZ6aYdvk6Ypfk0WRIigSACWcAPZ5L MiAZcCc3TgUjQTl1XQQ0MYuRX4iNVH6FAc95DrzvnWoni2X0XGP/2EkV4Gj5A+BfzHBc HAZ33U0KelnXjzEoIeLWPlBBun72Xkh88in8lrLh34bpsSbPYhvzNRoEcSHraMJeh8mb Ttug== X-Forwarded-Encrypted: i=1; AJvYcCXYvGS0sj/H3KRun/sao4bBRxFdDK65uFLEEJMTzNvKH0t2H2YNcmWpPkQ6SRj7Y8xV9+N8kKBH/n78W4A=@vger.kernel.org X-Gm-Message-State: AOJu0YwRTVxMXndG3Qw/4B7aPvZdKn36uReioBVMB9k74l8/VeCVKUHI ELleo0WL29VFFfTUOjXbkUF98qvvtFFvoOmmk+3vOjS+bkNFilZ9DtFbWATcqg== X-Gm-Gg: AZuq6aIxf9RS8nnAy06lIfed3RB226ra4SBcyRnT9TDgLSlj9jhcRJAqpz4Ec/CEZ+1 7jzw+dHAGn/otPNRAq5xTr0Qb3Edb9xoN6qif5FJNaPyjkYm2rgybl73AIDkvYo4cagV/lRiEFM F9uUgyXwOnj9qhsZhwvwvZU5KzotSulTb6gG1kNd5hYAit5453QC0NLNoW8v3aCHOP4m/23s7IZ S3+D/iKz/7jOqIuTxSIk/5DWcpHIR9JP2pRBTyRoqVe94z37cysAEnfVrh0GXbmwnnQOS7NU9x/ rrB8UisyVnAWfbGrfr7V1lVH6cFHSeKKmQz8MOA6TNR/s26dJX++fNoZ1JmnJUiRODevc4vvf3/ E+GvzK7VulL695dzPNP8XnOR43MufMbKgxYRdS/FaVmn6JB7fwIoTi1zCy4+BP2XPlPM= X-Received: by 2002:a05:690c:dc9:b0:794:2c3d:7947 with SMTP id 00721157ae682-7947ac1857amr33107487b3.38.1769560825272; Tue, 27 Jan 2026 16:40:25 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::9944]) by smtp.gmail.com with ESMTPSA id 00721157ae682-794827625d3sm4791867b3.11.2026.01.27.16.40.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jan 2026 16:40:24 -0800 (PST) From: Ethan Tidmore To: Greg Kroah-Hartman Cc: Michael Straube , Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH v2 2/4] staging: rtl8723bs: remove dead RX FIFO overflow logic Date: Tue, 27 Jan 2026 18:40:06 -0600 Message-ID: <20260128004009.51095-3-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260128004009.51095-1-ethantidmore06@gmail.com> References: <20260128004009.51095-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function rtw_hal_check_rxfifo_full() populates debug variables in struct debug_priv that are never read. These variables (dbg_rx_fifo_*) are write-only and the function itself is a skeletal implementation. Additionally, remove a redundant hw_init_completed check in the caller rtl8723b_HalDmWatchDog(), as it is already covered by a guard clause. Removing this dead code saves unnecessary I/O cycles and cleans up the driver's internal debug structures. Signed-off-by: Ethan Tidmore --- drivers/staging/rtl8723bs/hal/hal_com.c | 19 ------------------- drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 7 ------- drivers/staging/rtl8723bs/include/hal_com.h | 1 - 3 files changed, 27 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8= 723bs/hal/hal_com.c index 70b5b289f9cb..fae251c332d3 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com.c +++ b/drivers/staging/rtl8723bs/hal/hal_com.c @@ -780,25 +780,6 @@ bool GetU1ByteIntegerFromStringInDecimal(char *Str, u8= *pInt) return true; } =20 -void rtw_hal_check_rxfifo_full(struct adapter *adapter) -{ - struct dvobj_priv *psdpriv =3D adapter->dvobj; - struct debug_priv *pdbgpriv =3D &psdpriv->drv_dbg; - int save_cnt =3D false; - - /* switch counter to RX fifo */ - rtw_write8(adapter, REG_RXERR_RPT+3, rtw_read8(adapter, REG_RXERR_RPT+3)|= 0xf0); - save_cnt =3D true; - /* todo: other chips */ - - if (save_cnt) { - /* rtw_write8(adapter, REG_RXERR_RPT+3, rtw_read8(adapter, REG_RXERR_RPT= +3)|0xa0); */ - pdbgpriv->dbg_rx_fifo_last_overflow =3D pdbgpriv->dbg_rx_fifo_curr_overf= low; - pdbgpriv->dbg_rx_fifo_curr_overflow =3D rtw_read16(adapter, REG_RXERR_RP= T); - pdbgpriv->dbg_rx_fifo_diff_overflow =3D pdbgpriv->dbg_rx_fifo_curr_overf= low-pdbgpriv->dbg_rx_fifo_last_overflow; - } -} - static u32 Array_kfreemap[] =3D { 0xf8, 0xe, 0xf6, 0xc, diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c b/drivers/staging/= rtl8723bs/hal/rtl8723b_dm.c index 928226679ab4..3e1ec33fe829 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c @@ -137,13 +137,6 @@ void rtl8723b_HalDmWatchDog(struct adapter *Adapter) fw_current_in_ps_mode =3D adapter_to_pwrctl(Adapter)->fw_current_in_ps_mo= de; rtw_hal_get_hwreg(Adapter, HW_VAR_FWLPS_RF_ON, (u8 *)(&bFwPSAwake)); =20 - if ( - (hw_init_completed =3D=3D true) && - ((!fw_current_in_ps_mode) && bFwPSAwake) - ) { - rtw_hal_check_rxfifo_full(Adapter); - } - /* ODM */ if (hw_init_completed =3D=3D true) { u8 bLinked =3D false; diff --git a/drivers/staging/rtl8723bs/include/hal_com.h b/drivers/staging/= rtl8723bs/include/hal_com.h index 74d6c892c401..24e7fd8ee4dc 100644 --- a/drivers/staging/rtl8723bs/include/hal_com.h +++ b/drivers/staging/rtl8723bs/include/hal_com.h @@ -136,7 +136,6 @@ void rtw_hal_update_sta_rate_mask(struct adapter *padap= ter, struct sta_info *pst =20 void SetHwReg(struct adapter *padapter, u8 variable, u8 *val); void GetHwReg(struct adapter *padapter, u8 variable, u8 *val); -void rtw_hal_check_rxfifo_full(struct adapter *adapter); =20 u8 GetHalDefVar(struct adapter *adapter, enum hal_def_variable variable, void *value); --=20 2.52.0