From nobody Sat Feb 7 08:23:23 2026 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C2B434D93B for ; Wed, 28 Jan 2026 09:55:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769594112; cv=none; b=RSwCLjTU3UqAEF2ZjiWy9MGv85O27qDbozZ16Gyq9AH2wuSgD8zx0yY+OsBclXmaGstFK8nIYZFW7nfW0O/SE6Qfv+yCGQy8OCYe6bPjYb7uM3cf7XKTGDefIAJdtvLQ8TXFlR/g9V426VnVgAucqDw5QCvpSaCgwFlH8nTo3zI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769594112; c=relaxed/simple; bh=NgWDqx3izSY9aW9W75gFytkLHJndTcTMdemaHAZbfa4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HOdV59CNkRcq/I5DQy+jIwSujZHXUdrJ+7TM8GJJOcG3qiAHcSk0yP89QmQqdFd1TQksUGg1ZlTQNkQX0u+jICXsVmEHlVV8G8/lilS7Ao95EMVRppjtoNpi5DWCscChejYKIevFltk6LE2WpI/XXEXyOdeujPQIlnreMBX7fGM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DJmFpmIg; arc=none smtp.client-ip=209.85.167.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DJmFpmIg" Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-59dd7bfeb8aso8215751e87.0 for ; Wed, 28 Jan 2026 01:55:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769594109; x=1770198909; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=hgLydv0OAbPSYmy/7mtUdSMM6gy3g70cS63c1sKd/bM=; b=DJmFpmIgtYyTUCS0CkFoPb9BVhzBYuPbW+qiq6GdEED0QfSkp2gqib3halH2nhmt0j GosmtWI6TEsUS+KKCPn5+WkO1W5+vEn7o/cX0ephjRlPMZQ7lOV9WRlyvJktrSGwjO6x mQCg6/ML3MFTxqQXN9ZkGzK2/G2ltkP9jyPH0ZU+qjkhGlaBqKoLc0/VLz9RuKgjp80l Cm4vqWS5HrvlwJrQ6t9IuVjJgGEgVoHxs0kKPQxtpwCN/f8VTSok8awKBCttWsecmSFI 68PDBY28fF3WThr2/AGxBfT6rKTrDLMbyIG262jSwGnOSYrFddwRreuBWqnzrJ1DGEuy xcgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769594109; x=1770198909; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=hgLydv0OAbPSYmy/7mtUdSMM6gy3g70cS63c1sKd/bM=; b=v8a3RBpnMSYse9qgKFEHo3Hk4JlZRCxU/YyfHQmv6r38HEI77VDuuJaLYKMdid7PQ0 SP76MQxUpCtupjbvQUpPccWOkSUj/mgdVkZDfhc47cMp66CO+J5FZc2VzK5+RnR8XKy4 huGqUH/uVHJ9TrzcnEzbaz5X7sSgNCG0ak0seD6UxUaamcT4HMUBvqnf8ENWeZZG1M46 lRm4HGwuX0u89zdpBC/s3DoDRyMHwPDce5b22TREBLGUvxzLGbh5iaSbPvyEqs49I/dQ Dmq35ySC9ck6Fgu2JxhEB/o5+pVkwWJmzJ8E21osOylcw9cNn381XUJJ4x6N0sVFPUNd +NRQ== X-Forwarded-Encrypted: i=1; AJvYcCXIWG5EqnSnPHWYn+5we0xaU8nvqTn3rKQjlWWdWXxkI5W3xktkY0bO4lAVSkUwf7NDc8fxOZ33zJwBdrA=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+Im6c0NnoAuwenhWzBUvbSjsU9i933E6M5seEwzLm8VKX61AJ FawNc3wN+V9ma8HAbFzjV/nOKrFuzsDfgzq04+Wgbjp895kCDu54GoWQ X-Gm-Gg: AZuq6aK67WupA+KvquCx2SHUPp+XKCOJOKnKwVZpGFAHJh6CjcoHYNBDCBoVejR2HTC RBmIFDrpMx8rGdCCuWLr/zxQKl2UYCPH+5qSF1GXDrtYZG6YZXeIV8n6XcpL3dBEi1j3EhuEVpR gXz+FyT/SnXjkHwVePjuZANzrvuZ4BSH6+YQdxfMAkuicsPrp0wRrtYqdufAZ2wLT/ztqCsN5dY LQO5/wxfD4tcHtskyz+/xFi7hQzaju6PQRtJQQUzAdeF1DI6DL7YibnvVxTHvDLGr3BZcLpJ2Me Tg+NzbIQrGp5g1s6A64meWTDqaVx0a5OBAmXwDgLV3fxbilIB6zYY/Qkwi4PvGz+fW2FqXYpSxj PotKa/9CxONltK43A85hg9BXgU/yoeE4Gkrt2Pck+awrBHd44kEXK7MKGrU2RJObwiP7vCQeIY+ xbFQdEqtZo4dAtBwwXCjsgHCb3jWI2yFRySKJv9/9WyylKzL0BzXjk9PRPPdb6YDJ2Ee0= X-Received: by 2002:a05:6512:b97:b0:59b:9ff8:468e with SMTP id 2adb3069b0e04-59e0412c83amr2449893e87.31.1769594108946; Wed, 28 Jan 2026 01:55:08 -0800 (PST) Received: from [192.168.1.135] (83-233-6-197.cust.bredband2.com. [83.233.6.197]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59e074bfe83sm459483e87.97.2026.01.28.01.55.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jan 2026 01:55:07 -0800 (PST) From: Marcus Folkesson Date: Wed, 28 Jan 2026 10:54:29 +0100 Subject: [PATCH v4 3/5] i2c: davinci: calculate bus freq from Hz instead of kHz Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260128-i2c-mux-v4-3-dee49ce276c0@gmail.com> References: <20260128-i2c-mux-v4-0-dee49ce276c0@gmail.com> In-Reply-To: <20260128-i2c-mux-v4-0-dee49ce276c0@gmail.com> To: Wolfram Sang , Peter Rosin , Michael Hennerich , Bartosz Golaszewski , Andi Shyti , Bartosz Golaszewski Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Marcus Folkesson , Bartosz Golaszewski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2849; i=marcus.folkesson@gmail.com; h=from:subject:message-id; bh=NgWDqx3izSY9aW9W75gFytkLHJndTcTMdemaHAZbfa4=; b=owEBbQKS/ZANAwAKAYiATm9ZXVIyAcsmYgBpedztECNc3VxUquFpfx8TQoFrSB7cIxNlSZrqJ OhN7zzlH9eJAjMEAAEKAB0WIQQFUaLotmy1TWTBLGWIgE5vWV1SMgUCaXnc7QAKCRCIgE5vWV1S MlXrD/sE0/W8x83hap7Dhta6qJH+6wF6kDCcG1nxuNfBbrETgbLx4/lBqTEH+JGM1kh6cLk+cBC OXhIvL0znx8Ye6vGhce2X3A05Vxr81wpEbQbRe9QUN6obI9cvRO9lgAgQbU/G1E3LN0WuPUDpGq 2keTYvwNLTRFhKa3oNJ0jVezTvxaBjegypn7VqGh/2wsAKFBac0He5JPPm5Y0QHZ0HynM7e6eKR vLjy2123DV8Y37F8GNwXvsgh/V8ArPWLz/AFWJgKnP1Jg71uGQkpoE/o+KHJg0VPmGzjdhecORg INeawLbjnZElkte5DoMf0b3Cgmef5Ai/CydViiGWFB5LtjrnpIOTC6nPXsekboiTW5n+BS5ce0r z8mC53lIH+iNWjMK/EloWDzWZRW9c5r+F5fRIedKlapVON883bMtMNPt6rfwpTjUWxPDfeOzbGr WAu806t53dfko2sVuyMr9WpeZcneLS+p0leVem6G+fD7tjUPct3N7Rt/g+0IY1ZFsDPZkMXxBq3 awFcReXJ0Q0+/CwQCoZrfLAo8FZuVAwXO5fShHCu+8VuzXvmOkM+bsW+bF9VkSmRzrtPGDV3P5J LIVRvkRAjDPrO5S+pppy0mF3xvBoxjiUycdjY8TxrWA8CkRLSZqyUEosPD2ifkHPGiGF3stiWZs PhoubjCsc3jj1wA== X-Developer-Key: i=marcus.folkesson@gmail.com; a=openpgp; fpr=AB91D46C7E0F6E6FB2AB640EC0FE25D598F6C127 The bus frequency is unnecessarily converted between Hz and kHz in several places. This is probably an old legacy from the old times (pre-devicetrees) when the davinci_i2c_platform_data took the bus_freq in kHz. Stick to Hz. Reviewed-by: Bartosz Golaszewski Signed-off-by: Marcus Folkesson --- drivers/i2c/busses/i2c-davinci.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davi= nci.c index a773ba082321..761de5a814df 100644 --- a/drivers/i2c/busses/i2c-davinci.c +++ b/drivers/i2c/busses/i2c-davinci.c @@ -117,8 +117,6 @@ /* timeout for pm runtime autosuspend */ #define DAVINCI_I2C_PM_TIMEOUT 1000 /* ms */ =20 -#define DAVINCI_I2C_DEFAULT_BUS_FREQ 100 - struct davinci_i2c_dev { struct device *dev; void __iomem *base; @@ -134,8 +132,8 @@ struct davinci_i2c_dev { #ifdef CONFIG_CPU_FREQ struct notifier_block freq_transition; #endif - /* standard bus frequency (kHz) */ - unsigned int bus_freq; + /* standard bus frequency */ + unsigned int bus_freq_hz; /* Chip has a ICPFUNC register */ bool has_pfunc; }; @@ -209,16 +207,16 @@ static void i2c_davinci_calc_clk_dividers(struct davi= nci_i2c_dev *dev) if (device_is_compatible(dev->dev, "ti,keystone-i2c")) d =3D 6; =20 - clk =3D ((input_clock / (psc + 1)) / (dev->bus_freq * 1000)); + clk =3D ((input_clock / (psc + 1)) / (dev->bus_freq_hz)); /* Avoid driving the bus too fast because of rounding errors above */ - if (input_clock / (psc + 1) / clk > dev->bus_freq * 1000) + if (input_clock / (psc + 1) / clk > dev->bus_freq_hz) clk++; /* * According to I2C-BUS Spec 2.1, in FAST-MODE LOW period should be at * least 1.3uS, which is not the case with 50% duty cycle. Driving HIGH * to LOW ratio as 1 to 2 is more safe. */ - if (dev->bus_freq > 100) + if (dev->bus_freq_hz > 100000) clkl =3D (clk << 1) / 3; else clkl =3D (clk >> 1); @@ -269,7 +267,7 @@ static int i2c_davinci_init(struct davinci_i2c_dev *dev) davinci_i2c_read_reg(dev, DAVINCI_I2C_CLKL_REG)); dev_dbg(dev->dev, "CLKH =3D %d\n", davinci_i2c_read_reg(dev, DAVINCI_I2C_CLKH_REG)); - dev_dbg(dev->dev, "bus_freq =3D %dkHz\n", dev->bus_freq); + dev_dbg(dev->dev, "bus_freq_hz =3D %dHz\n", dev->bus_freq_hz); =20 =20 /* Take the I2C module out of reset: */ @@ -760,9 +758,9 @@ static int davinci_i2c_probe(struct platform_device *pd= ev) =20 r =3D device_property_read_u32(&pdev->dev, "clock-frequency", &prop); if (r) - prop =3D DAVINCI_I2C_DEFAULT_BUS_FREQ; + prop =3D I2C_MAX_STANDARD_MODE_FREQ; =20 - dev->bus_freq =3D prop / 1000; + dev->bus_freq_hz =3D prop; =20 dev->has_pfunc =3D device_property_present(&pdev->dev, "ti,has-pfunc"); =20 --=20 2.52.0