From nobody Mon Feb 9 19:06:55 2026 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E74A630DD3A for ; Wed, 28 Jan 2026 16:10:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769616662; cv=none; b=Ks+fVm6LKSkRAYjzLTf4uPzmO0HqxvpKIsO6uSNXeDuFnczBxSheIpLka8GRsPxUl/3cviJDuy9J8siuR7S9IvD2W4w/Z+nVO1fgFFr1gtJazHecXy051PLffo6HkuLu9ON9eey3BSNKJ6M9Jvg0o/t9l3CLjI4H7eDGUmxEgqw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769616662; c=relaxed/simple; bh=ZYxzBg9tkVWzCzaxuPaae5TIGD91nZXT5GPxtR4tPNQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tQmPIpomv/U6zXjKXgVWfgDiecy6CIDAnimdNg8pJiIKUaaClDlny5NCxkEUcOEqLBoa7SrnulXDMKhfXUthzjHqKygaPXihU1INQmUrYiEPjTBVatx+2x8SLrrRWIloXTvFTZSBEo4MDYicpEaf8B0Oriq5xwLuzFmFCGy5sxY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=aOwci1JH; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="aOwci1JH" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-64b92abe63aso123286a12.0 for ; Wed, 28 Jan 2026 08:10:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769616656; x=1770221456; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=9J9mAVn8R3b4lSWOfrbKrodX1tmUBpKSiHbvrB/eirA=; b=aOwci1JHIkQcJgyHu9Y1mf2aJ3de79GIiCo4W27OV7FX/DAPhEPUF14G1MfhlPyx9u EjpXgHy2y2d3sqzYCemE835xJKRA+XllCN2WMtrqi4ViqpA5ArmZkFaUaLkN1/2RrjGb oj5bTs7rWnv/UWtOT01HtTcES/4p/ZATxkkQFKH5+Xq8dhBBbiMv2nOl8UJTdDg90Mmy 2MpfTFKhDIODwAx7w/P+iGb81mCNtCTbFdloi49fjMPNnUOnKjToL2PXwGrZ/eu1wsin 9qNSJ1pJXPZL4WP9ETPS3J5E/memQx6n4prPrWK5XHyBmsSwZUdYHPeD4OvvXuzR1rAb yDiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769616656; x=1770221456; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=9J9mAVn8R3b4lSWOfrbKrodX1tmUBpKSiHbvrB/eirA=; b=h7L2YvReZJW5EsMRt9Vq6Iz/9an8xdsXHCqHUH39uJ83gNj3GXkpfyKLW8KnosLw1t 4tGZm8PtIMXE5vYeAvy6TuwAZ5uV6oxIT15CtP1VCqMqzvATIukRR1CKeLiRF9Gk7CEg gGAoLplmKaOqlwrRdsjRhln/NGjwUsHlvwc46LcRCVsdba8yRr0yao2lHLg57DKaE9vj EAqslPgci+IWXayxr0trVU+CJo37A9awMl1qGP/9vDqa8ySjJVSyYA/IRZqIeuYlGy1q f1VWv7TgK6DUR4WbEk56H/XmzvVRNw1gtD2M+YatbRj7nvxjF4r3i6BJODpH/H1EbRfd Qcxg== X-Forwarded-Encrypted: i=1; AJvYcCW+npL8T1MNaFwHWCCiMkF7geqMZQ2GWaIuwWxOSOPrv2fPjAyMuQubsMaheioSoCDgB1090bOyuauFwIA=@vger.kernel.org X-Gm-Message-State: AOJu0YwycCfjImsVpy4GNgugzwPfK6+27uARtN29XcGxWL1nzafTVWBD bFFfWCAd7VEcwrILWaLKYtoiMRwJjrwKrbauwgpZAoRHqmYaq6LTrJh2m7jjuiBGi7Y= X-Gm-Gg: AZuq6aLBuEWN7AzP5ie/qpRJq6ql9BY+CuNLMTUI0jNECMHMvoek0NDyeHa0du4zGGq X0qR2Rst4IpRBP+/tnjV4IvxRz9pnfrAdxLZ866MGP8g5jVklRioOGTguiPmddmQiyVTgWjnyUD fwzkX0G4HNbFzLSz1yQpWhI2BmrRMSj3L55tr3hT+Qn/qUv9C/19F+nAGBoq4l6HIjJkmZuO5T9 HYnYPs+y+Cgojv2TGkrvITjSvVPNNcnBqZNccQJUMQP++Vas5KwZMFj+eBcRv0de5ADv4jPtapb e6j5mF7DFcfAicPV+rcN6LTpTfxZaIUW8tW/B+Eim8dAJo2/bi8LuAV3jxDOWxWU7yW0YsqE67r 9kiZP/eP/wjS0LCWI4AomU6Rkpg+hq+hdvi1yC0lfaYhjjBVWducJsQT9iwCxq1VmmBfmyuU3kE lonrTA+p5z2x7Xd1y57ZMoFg3G5k1a2POlqbjO4O6QGOegRIDpvrjwrT0ED7rv15ovwpqyWtqVi zOejVTaNivZ9kql X-Received: by 2002:a17:907:3f93:b0:b87:892:f43b with SMTP id a640c23a62f3a-b8dab4455a7mr396560766b.42.1769616656353; Wed, 28 Jan 2026 08:10:56 -0800 (PST) Received: from puffmais2.c.googlers.com (244.175.141.34.bc.googleusercontent.com. [34.141.175.244]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8dbf1c021fsm148553366b.49.2026.01.28.08.10.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jan 2026 08:10:56 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Wed, 28 Jan 2026 16:10:55 +0000 Subject: [PATCH v4 06/10] pmdomain: samsung: don't hard-code offset for registers to 0 and 4 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260128-gs101-pd-v4-6-cbe7bd5a4060@linaro.org> References: <20260128-gs101-pd-v4-0-cbe7bd5a4060@linaro.org> In-Reply-To: <20260128-gs101-pd-v4-0-cbe7bd5a4060@linaro.org> To: Krzysztof Kozlowski , Alim Akhtar , Rob Herring , Conor Dooley , Krzysztof Kozlowski , Ulf Hansson , Liam Girdwood , Mark Brown Cc: Peter Griffin , Tudor Ambarus , Juan Yescas , Will McVicker , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= , Marek Szyprowski X-Mailer: b4 0.14.2 On platforms such as Google gs101, direct mmio register access to the PMU registers doesn't necessarily work and access must happen via a regmap created by the PMU driver instead. When such a regmap is used it will cover the complete PMU memory region rather than individual power domains. This means the register offsets for the configuration and status registers will have to take the power domain offsets into account, rather than unconditionally hard-coding 0 and 4 respectively. Update the code to allow that. Tested-by: Marek Szyprowski Signed-off-by: Andr=C3=A9 Draszik --- drivers/pmdomain/samsung/exynos-pm-domains.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/pmdomain/samsung/exynos-pm-domains.c b/drivers/pmdomai= n/samsung/exynos-pm-domains.c index 3bcba7d38ac1572ef4bc2f4052c904dd6c4a7bfd..8df46b41f9bc8f0b2a03300169a= 4b52457faaf4d 100644 --- a/drivers/pmdomain/samsung/exynos-pm-domains.c +++ b/drivers/pmdomain/samsung/exynos-pm-domains.c @@ -30,6 +30,8 @@ struct exynos_pm_domain { struct regmap *regmap; struct generic_pm_domain pd; u32 local_pwr_cfg; + u32 configuration_reg; + u32 status_reg; }; =20 static int exynos_pd_power(struct generic_pm_domain *domain, bool power_on) @@ -41,7 +43,7 @@ static int exynos_pd_power(struct generic_pm_domain *doma= in, bool power_on) pd =3D container_of(domain, struct exynos_pm_domain, pd); =20 pwr =3D power_on ? pd->local_pwr_cfg : 0; - err =3D regmap_write(pd->regmap, 0, pwr); + err =3D regmap_write(pd->regmap, pd->configuration_reg, pwr); if (err) { pr_err("Regmap write for power domain %s %sable failed: %d\n", domain->name, power_on ? "en" : "dis", err); @@ -53,7 +55,7 @@ static int exynos_pd_power(struct generic_pm_domain *doma= in, bool power_on) while (timeout-- > 0) { unsigned int val; =20 - err =3D regmap_read(pd->regmap, 0x4, &val); + err =3D regmap_read(pd->regmap, pd->status_reg, &val); if (err || ((val & pd->local_pwr_cfg) !=3D pwr)) { cpu_relax(); usleep_range(80, 100); @@ -164,6 +166,8 @@ static int exynos_pd_probe(struct platform_device *pdev) pd->pd.power_off =3D exynos_pd_power_off; pd->pd.power_on =3D exynos_pd_power_on; pd->local_pwr_cfg =3D pm_domain_cfg->local_pwr_cfg; + pd->configuration_reg +=3D 0; + pd->status_reg +=3D 4; =20 /* * Some Samsung platforms with bootloaders turning on the splash-screen @@ -174,7 +178,7 @@ static int exynos_pd_probe(struct platform_device *pdev) of_device_is_compatible(np, "samsung,exynos4210-pd")) exynos_pd_power_off(&pd->pd); =20 - ret =3D regmap_read(pd->regmap, 0x4, &val); + ret =3D regmap_read(pd->regmap, pd->status_reg, &val); if (ret) return dev_err_probe(dev, ret, "failed to read status"); =20 --=20 2.52.0.457.g6b5491de43-goog