From nobody Mon Feb 9 19:06:51 2026 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43FE4318B91 for ; Wed, 28 Jan 2026 16:11:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769616665; cv=none; b=VPdrECphE9G9PWztdACyxlJeV4Zrb2TY2aidFYk/uMTOCEEa6hvs6Cc6f108YRaZtPwzaw2yvTZZGg9pMGqd/M38p576boRT+rdTfUM57+sqOz2QfJLv0j4xiJtDojGc1oxvi3IIFmHmPgonecGzYieuO0H7Y/gmf8HQ6lXDKgY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769616665; c=relaxed/simple; bh=JnjfvK+MHgibmXdj8c8QyUL8Q5i+pDFvx54OCA4Mehc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=m5MLTp+Sp4JB2bQ7eBwNcVMtozXJ/u78UVClfMNGUHNpym2RFZyiJbiIBhEt5At+k7XpziyQa5cdZpS4OGWG0OX5F9wV9dQg+lXAWmo0QLy45Hk8KITc0FRw+mKf0f2ObqbXRQ/YJd3bHyplQVvSHpMTFf4rSgojC8uJg/LVGIQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=M1a+HWFu; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="M1a+HWFu" Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-658ad86082dso101517a12.0 for ; Wed, 28 Jan 2026 08:11:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769616658; x=1770221458; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=kov2pn4auGP7KnNGCEIBpS1LmUNVpZnSgM4Kim/Xeow=; b=M1a+HWFu6T15gKjZ0K74uqkZreQ+DrsmvCWoA/WiSiJ67d5lxxS68++U8Y87bc0Reo /j2HMN4IEqnEzIcitkAwT/TDHqq34PqB0RRrAV4E5sb5UXLno70/DbsKlnDpe6TWiatV fulSoIZceU3LaWGnhk+uX7nwvlC/lCKr5bC36O1+7kg78ZkhXeNSMTG5nEvAimTRpMH7 +dGsT0qHqopLXizz+DUcZBLPvuGXxHSwEUfIzLL6amtbjxkgJgQVXRtO47pxJlhMv/KE abK9pj7RTXzzyspIAjSjfuFGVLtojLQSGeQZYWoc7hd+NXLBduB5kmxi26e2XpnOh/jg ik+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769616658; x=1770221458; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=kov2pn4auGP7KnNGCEIBpS1LmUNVpZnSgM4Kim/Xeow=; b=ebhQnHAyqqAd9KSAtzOCjZljPpDEvF8sHVztfjwDS4tZgtmEAJSZ76Bhcq6pz6nigS BPUQPZtgy4hfCKTcs2rqowz+m57mpwRKVAdHJSbOQKJT7wKZLbU/MgfFkNCjDmfz9f79 KZm8AWxJMT7hhhjlGAIOLx02qlV1V4WfSr6ptDH/7emIW1lvqX4NnOW/NHNhWTc0JP64 AGnZGr/SART5VWdCKun3K8oIP/MfMYYI7XaP0xbNfQw9zmEp4fWC5XXjCzE8kIjktICO 3NTJytp8Lj7iImgmX0XZsxobhximfObvtGcEpWRHKGr4dClWqZsubX501RmQukF57X2T tjCA== X-Forwarded-Encrypted: i=1; AJvYcCUlSTh5W20A12Dl0CD0yFESNaPNs/E3CoYFX5XrEUt0FTg3QADa2itJtoVWhBURzCqbeBerd9GJ3Dvkajs=@vger.kernel.org X-Gm-Message-State: AOJu0YwQ4fyAl/0Ew8VZHHp/fhItnfr4wsgSuUmWykK93dyKxbpQGBEv F82Ds4hY9YTxFsHcXGB+jHVCrCEHI4uALy8q2LfWKiCX2AbzPDQBbdVCNsA82ruSURM= X-Gm-Gg: AZuq6aI3T2g4oDUjpXbNGHhbmH6Vq/rgK5DUQ7FOmxDA8XvW1MwaZHG7SvkZXSQm3If URsmroQyPIO/HUMrQ1QGryEV8G+a/Fuy1gz+JgKK21CI5THawNJH3GPH+IBt5PiRj6UCPA0potY npZ/eEb1U8R0MslF07CHMC/Mds+NwaucSJB/JopTWIav/TVGNGjWxJMPjIJePwGa47x0MAl9rQo v+1+KEdr50NqVBgEwSiiUIOBTBBLuKNrCUnzieMiy8DpbBZ/0Mss7HyMptH4Vd5G3Q6jVl/PInt 4BhNzUY7JIarW0ljGUii5IJVSROZde7gM1Hwiv88a6V4qDr2M6n5Ywh1BTzuPtZk+MBm+3c4Dbn NYOKjfdnUGwVSK4RwN3L6KJGICbFqIzKyiyFtGimfjjk41ApS74zK3uVOvQiGYQ2eVw18XDSmLZ ukSPwKNq0sUYZwpwKL6w7gdFE8+3S6tTYrc1nYIw9cyeu4U9t6iprAuIztVx5oCVsItRtYPSEYg guEDw== X-Received: by 2002:a17:907:94c4:b0:b87:2780:1b29 with SMTP id a640c23a62f3a-b8dab32edfdmr423420166b.37.1769616658444; Wed, 28 Jan 2026 08:10:58 -0800 (PST) Received: from puffmais2.c.googlers.com (244.175.141.34.bc.googleusercontent.com. [34.141.175.244]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8dbf1c021fsm148553366b.49.2026.01.28.08.10.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jan 2026 08:10:58 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Wed, 28 Jan 2026 16:10:59 +0000 Subject: [PATCH v4 10/10] pmdomain: samsung: implement domain-supply regulator Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260128-gs101-pd-v4-10-cbe7bd5a4060@linaro.org> References: <20260128-gs101-pd-v4-0-cbe7bd5a4060@linaro.org> In-Reply-To: <20260128-gs101-pd-v4-0-cbe7bd5a4060@linaro.org> To: Krzysztof Kozlowski , Alim Akhtar , Rob Herring , Conor Dooley , Krzysztof Kozlowski , Ulf Hansson , Liam Girdwood , Mark Brown Cc: Peter Griffin , Tudor Ambarus , Juan Yescas , Will McVicker , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 Some power domains on Exynos are fed by a regulator rail and therefore regulator control needs be implemented for Exynos power domains. On Google gs101, HSI0 (USB) is one example of such a power domain. While at it, add a to_exynos_pd() to avoid direct use of container_of() in various additional places, and update existing code to use it. Signed-off-by: Andr=C3=A9 Draszik --- drivers/pmdomain/samsung/exynos-pm-domains.c | 53 ++++++++++++++++++++++++= +--- 1 file changed, 48 insertions(+), 5 deletions(-) diff --git a/drivers/pmdomain/samsung/exynos-pm-domains.c b/drivers/pmdomai= n/samsung/exynos-pm-domains.c index f59986b56213dfcc470d9cccc61a36a81954bdcc..ed7a5807555bcf86e4ec88166bf= d5f6c06c9322c 100644 --- a/drivers/pmdomain/samsung/exynos-pm-domains.c +++ b/drivers/pmdomain/samsung/exynos-pm-domains.c @@ -20,12 +20,15 @@ #include #include #include +#include =20 #define EXYNOS_SMC_CMD_PREPARE_PD_ONOFF 0x82000410 #define EXYNOS_GET_IN_PD_DOWN 0 #define EXYNOS_WAKEUP_PD_DOWN 1 #define EXYNOS_RUNTIME_PM_TZPC_GROUP 2 =20 +#define to_exynos_pd(gpd) container_of_const(gpd, struct exynos_pm_domain,= pd) + struct exynos_pm_domain_config { /* Value for LOCAL_PWR_CFG and STATUS fields for each domain */ u32 local_pwr_cfg; @@ -39,6 +42,7 @@ struct exynos_pm_domain_config { struct exynos_pm_domain { struct regmap *regmap; struct device *dev; + struct regulator *supply; struct generic_pm_domain pd; const struct exynos_pm_domain_config *cfg; u32 configuration_reg; @@ -64,12 +68,10 @@ static int exynos_pd_access_controller_power(struct exy= nos_pm_domain *pd, =20 static int exynos_pd_power(struct generic_pm_domain *domain, bool power_on) { - struct exynos_pm_domain *pd; + struct exynos_pm_domain *pd =3D to_exynos_pd(domain); u32 timeout, pwr; int err; =20 - pd =3D container_of(domain, struct exynos_pm_domain, pd); - if (!power_on) { err =3D exynos_pd_access_controller_power(pd, power_on); if (err) { @@ -126,14 +128,45 @@ static int exynos_pd_power(struct generic_pm_domain *= domain, bool power_on) return err; } =20 +static int exynos_pd_regulator_enable(struct regulator *supply) +{ + return supply ? regulator_enable(supply) : 0; +} + +static int exynos_pd_regulator_disable(struct regulator *supply) +{ + return supply ? regulator_disable(supply) : 0; +} + static int exynos_pd_power_on(struct generic_pm_domain *domain) { - return exynos_pd_power(domain, true); + struct exynos_pm_domain *pd =3D to_exynos_pd(domain); + int ret; + + ret =3D exynos_pd_regulator_enable(pd->supply); + if (ret) + return ret; + + ret =3D exynos_pd_power(domain, true); + if (ret) + exynos_pd_regulator_disable(pd->supply); + + return ret; } =20 static int exynos_pd_power_off(struct generic_pm_domain *domain) { - return exynos_pd_power(domain, false); + struct exynos_pm_domain *pd =3D to_exynos_pd(domain); + int ret; + + ret =3D exynos_pd_power(domain, false); + if (ret) + return ret; + + /* Ignore regulator errors - the domain was disabled after all. */ + exynos_pd_regulator_disable(pd->supply); + + return 0; } =20 static const struct exynos_pm_domain_config exynos4210_cfg =3D { @@ -283,6 +316,16 @@ static int exynos_pd_probe(struct platform_device *pde= v) if (ret) return ret; =20 + /* get the domain power supply if required */ + pd->supply =3D devm_regulator_get_optional(dev, "domain"); + if (IS_ERR(pd->supply)) { + if (PTR_ERR(pd->supply) !=3D -ENODEV) + return dev_err_probe(dev, PTR_ERR(pd->supply), + "failed to get domain supply"); + + pd->supply =3D NULL; + } + /* * Some Samsung platforms with bootloaders turning on the splash-screen * and handing it over to the kernel, requires the power-domains to be --=20 2.52.0.457.g6b5491de43-goog