From nobody Tue Feb 10 03:36:55 2026 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 080A830E834 for ; Wed, 28 Jan 2026 15:51:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769615488; cv=none; b=QdzQkb8JdjjfEBYqOBgOh23EA4NskV6huxcZlzdcJNc3Lv8MknZXpD9FvLB2RnkI5bssegkFYJTaDqe6r5T+ZR1Kd5lYuNju+gnCa1yxjlHOgl1X9+M3K3GbWTNGQDCIz8Cyy76nxncPHWXPzIkVYVDoFRqJw4LZtoyLu4aXtHQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769615488; c=relaxed/simple; bh=JDOblUMv3CRigfo3XzUT9pA2bSBe1pUX+IfX4UM2YmQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZIh26ZwtASkkuBH4mXiD9Jfkqgz/Wjw6/xGDSdv5mbbxuzHy4F6WljVIwNC9Z45ZXHFT+aYD45n5sFmYtctAsoExE/HulRRongIn4MSYbLP6JgkipKvUJHduscyjJ5LhMpTfn6rQteIyhvSkoI1Bl0Si9sEgPao0Mr3XZb7+KwE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=KRa7ZL4s; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="KRa7ZL4s" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-655af782859so32995a12.2 for ; Wed, 28 Jan 2026 07:51:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1769615484; x=1770220284; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=jy/mJos/LokpB1A73skiAstLSnipJqyWtRQg1NLBe6o=; b=KRa7ZL4sIsqGlZ2RPUCqXlsembvEEXhaCRo1UKHJl2Dtv7IBpPa9WnUd0L2QMW0t2L 9nLHl2bvAJwNC1kFgn9viySVa4tM7bzTJ3K9aCrue+ej4UuLkEkosMNQSuXIl9bu8iyQ cUoXVNg0UxAzYEhaZq7ZEFrCXIR3H0awH8nobrteaEPTbmjgSEegB+f2os9dv1ob7dLY 9Y4xdANncLpgoJ02tbS9xsjUTXkwlWbzGPyTrTHE4Elm7nrr1+VUA6Ma28eDac14P27c tellhGD3VzR1eKX5M9QOHbhLdRuJbhF1kNp9aS1AU9c/eAT12Gbv+jfbyAjA+us6UgWW 8iPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769615484; x=1770220284; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=jy/mJos/LokpB1A73skiAstLSnipJqyWtRQg1NLBe6o=; b=RuKwRH62/5XNXaQp/v48fhoZeJFEZPM++tKFaxq74qQhIPjGujcArdjpW7xgs4Wrdo e9eAFCucsR9RVpnN2RBsjprRvH1C/99ls0/I+SxyzniiE2SSV2cY+H1rgZJpog8kG3Ie dbThg91XXuVPh4TSF4krP0ln8CHSnkEO7CH6ni80XMMzaTt8ErIhxea7eCVE8q8bob3R 29eOfDOaCIrZEAhs8hUUs2wQfqoVMhG29Lc31QTJx4/JYu+NXvT7bTBjGk0o8GsgwSk6 SMtR08RVI9/7fLXAvrOEL834ednUktLgWU6v3j44LF0LZhBK5neASHPHHrP08zotaA0d iPuw== X-Forwarded-Encrypted: i=1; AJvYcCWIiswIXU/sXtybLfc4epdevl1INs74f+bKiezDdakHWY6ElbYc7x09hI/wSZzzgJ5yfFGT8lO7iqJRPf0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+/4EYfryYIwA5jyW0xYIyNoyBEgJR57tnU4QuETIsek7RkKaj jymHTeEiI5OFtJ++MWp+fD81G0jTLdOwfJUh/OL7+VJJk14/0G4hoAS9Bw1H5aX1HHI= X-Gm-Gg: AZuq6aIxM81AFcL6d29aSYdXeeZXA0bTqE+SKy3xMRri5zFqEDISXFfBhoPzKQAUgGl i9+gqDY+MG/P+XPrAqv6XzXiZzVfIIiGfEJMW2WvBk+mYYIYjP6CZo06jpo/mxKDEdvS/kUhf3n Pn3d/f/fNtWaLHIIn27Ra+87QxL0Vc7Fd6Hj6/b1mZvRjxJSksJ3mBExd0lfuv1lRO5t9UH7pya utsG8EGw8PewRc79tpjNTcBIQIzWZI7woZlY/E8MLA3ERy2CjZQ/txB6H2okQPV4YDDeJOzsuJS D5LRIoj6L3N+4k7XPlFE2c9sEeUCprZ+yrcNGbKoxoANYhE+dq8JNpr01SEKRkZ0j0S3h62YGlO SGlfSSdRZxdqV+Wh65nOCpqOcRBH69r7Gd3F6m0gNFaVJd/lDIN5jqyakqWq0cT9YDT5ax9zcuu B89ZzbBmPdvMZVMyuv02hd0XeaWgOqUUMkjc3lnJj22EN29Wy9dQLkmLfAj2dYDOZm5XP5 X-Received: by 2002:a05:6402:51cb:b0:64b:3225:b771 with SMTP id 4fb4d7f45d1cf-658a6018e43mr3846931a12.6.1769615484396; Wed, 28 Jan 2026 07:51:24 -0800 (PST) Received: from [172.16.220.227] (144-178-202-139.static.ef-service.nl. [144.178.202.139]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-658b469eb9fsm1727223a12.28.2026.01.28.07.51.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jan 2026 07:51:23 -0800 (PST) From: Griffin Kroah-Hartman Date: Wed, 28 Jan 2026 16:51:14 +0100 Subject: [PATCH v2 2/3] Input: aw86938 - add driver for Awinic AW86938 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260128-aw86938-driver-v2-2-b51ee086aaf5@fairphone.com> References: <20260128-aw86938-driver-v2-0-b51ee086aaf5@fairphone.com> In-Reply-To: <20260128-aw86938-driver-v2-0-b51ee086aaf5@fairphone.com> To: Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Luca Weiss Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Griffin Kroah-Hartman X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1769615481; l=4691; i=griffin.kroah@fairphone.com; s=20250804; h=from:subject:message-id; bh=JDOblUMv3CRigfo3XzUT9pA2bSBe1pUX+IfX4UM2YmQ=; b=et6GkIyi92KWoO/S/6DS/Hfau2CUkKGZJ27uF0md++Mep35qYbak3CGWu/+wZv+bAGxYGHu6C oc3J2ZgvRkbALztNnXMctfqhvGhlQY79UhWlQzfTOLAEMwx1Lewgql0 X-Developer-Key: i=griffin.kroah@fairphone.com; a=ed25519; pk=drSBvqKFiR+xucmLWONHSq/wGrW+YvcVtBXFYnYzn8U= Add support for the I2C-connected Awinic AW86938 LRA haptic driver. The AW86938 has a similar but slightly different register layout. In particular, the boost mode register values. The AW86938 also has some extra features that aren't implemented in this driver yet. Signed-off-by: Griffin Kroah-Hartman --- drivers/input/misc/aw86927.c | 65 ++++++++++++++++++++++++++++++++++++----= ---- 1 file changed, 53 insertions(+), 12 deletions(-) diff --git a/drivers/input/misc/aw86927.c b/drivers/input/misc/aw86927.c index 8ad361239cfe3a888628b15e4dbdeed0c9ca3d1a..28ec6e42fd452a0edf1e1b9a961= 4e2723c6d9f93 100644 --- a/drivers/input/misc/aw86927.c +++ b/drivers/input/misc/aw86927.c @@ -43,6 +43,12 @@ #define AW86927_PLAYCFG1_BST_VOUT_VREFSET_MASK GENMASK(6, 0) #define AW86927_PLAYCFG1_BST_8500MV 0x50 =20 +#define AW86938_PLAYCFG1_REG 0x06 +#define AW86938_PLAYCFG1_BST_MODE_MASK GENMASK(5, 5) +#define AW86938_PLAYCFG1_BST_MODE_BYPASS 0 +#define AW86938_PLAYCFG1_BST_VOUT_VREFSET_MASK GENMASK(4, 0) +#define AW86938_PLAYCFG1_BST_7000MV 0x11 + #define AW86927_PLAYCFG2_REG 0x07 =20 #define AW86927_PLAYCFG3_REG 0x08 @@ -140,6 +146,7 @@ #define AW86927_CHIPIDH_REG 0x57 #define AW86927_CHIPIDL_REG 0x58 #define AW86927_CHIPID 0x9270 +#define AW86938_CHIPID 0x9380 =20 #define AW86927_TMCFG_REG 0x5b #define AW86927_TMCFG_UNLOCK 0x7d @@ -173,7 +180,13 @@ enum aw86927_work_mode { AW86927_RAM_MODE, }; =20 +enum aw86927_model { + AW86927, + AW86938, +}; + struct aw86927_data { + enum aw86927_model model; struct work_struct play_work; struct device *dev; struct input_dev *input_dev; @@ -377,7 +390,7 @@ static int aw86927_play_sine(struct aw86927_data *hapti= cs) return err; =20 /* set gain to value lower than 0x80 to avoid distorted playback */ - err =3D regmap_write(haptics->regmap, AW86927_PLAYCFG2_REG, 0x7c); + err =3D regmap_write(haptics->regmap, AW86927_PLAYCFG2_REG, 0x45); if (err) return err; =20 @@ -565,13 +578,26 @@ static int aw86927_haptic_init(struct aw86927_data *h= aptics) if (err) return err; =20 - err =3D regmap_update_bits(haptics->regmap, - AW86927_PLAYCFG1_REG, - AW86927_PLAYCFG1_BST_VOUT_VREFSET_MASK, - FIELD_PREP(AW86927_PLAYCFG1_BST_VOUT_VREFSET_MASK, - AW86927_PLAYCFG1_BST_8500MV)); - if (err) - return err; + switch (haptics->model) { + case AW86927: + err =3D regmap_update_bits(haptics->regmap, + AW86927_PLAYCFG1_REG, + AW86927_PLAYCFG1_BST_VOUT_VREFSET_MASK, + FIELD_PREP(AW86927_PLAYCFG1_BST_VOUT_VREFSET_MASK, + AW86927_PLAYCFG1_BST_8500MV)); + if (err) + return err; + break; + case AW86938: + err =3D regmap_update_bits(haptics->regmap, + AW86938_PLAYCFG1_REG, + AW86938_PLAYCFG1_BST_VOUT_VREFSET_MASK, + FIELD_PREP(AW86938_PLAYCFG1_BST_VOUT_VREFSET_MASK, + AW86938_PLAYCFG1_BST_7000MV)); + if (err) + return err; + break; + } =20 err =3D regmap_update_bits(haptics->regmap, AW86927_PLAYCFG3_REG, @@ -599,6 +625,9 @@ static int aw86927_ram_init(struct aw86927_data *haptic= s) FIELD_PREP(AW86927_SYSCTRL3_EN_RAMINIT_MASK, AW86927_SYSCTRL3_EN_RAMINIT_ON)); =20 + /* AW86938 wants a 1ms delay here */ + usleep_range(1000, 1500); + /* Set base address for the start of the SRAM waveforms */ err =3D regmap_write(haptics->regmap, AW86927_BASEADDRH_REG, AW86927_BASEADDRH_VAL); @@ -717,9 +746,19 @@ static int aw86927_detect(struct aw86927_data *haptics) =20 chip_id =3D be16_to_cpu(read_buf); =20 - if (chip_id !=3D AW86927_CHIPID) { - dev_err(haptics->dev, "Unexpected CHIPID value 0x%x\n", chip_id); - return -ENODEV; + switch (haptics->model) { + case AW86927: + if (chip_id !=3D AW86927_CHIPID) { + dev_err(haptics->dev, "Unexpected CHIPID value 0x%x\n", chip_id); + return -ENODEV; + } + break; + case AW86938: + if (chip_id !=3D AW86938_CHIPID) { + dev_err(haptics->dev, "Unexpected CHIPID value 0x%x\n", chip_id); + return -ENODEV; + } + break; } =20 return 0; @@ -736,6 +775,7 @@ static int aw86927_probe(struct i2c_client *client) =20 haptics->dev =3D &client->dev; haptics->client =3D client; + haptics->model =3D (enum aw86927_model)device_get_match_data(&client->dev= ); =20 i2c_set_clientdata(client, haptics); =20 @@ -825,7 +865,8 @@ static int aw86927_probe(struct i2c_client *client) } =20 static const struct of_device_id aw86927_of_id[] =3D { - { .compatible =3D "awinic,aw86927" }, + { .compatible =3D "awinic,aw86927", .data =3D (void *)AW86927 }, + { .compatible =3D "awinic,aw86938", .data =3D (void *)AW86938 }, { /* sentinel */ } }; =20 --=20 2.43.0