From nobody Sun Feb 8 06:54:23 2026 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FFFC2848B2 for ; Tue, 27 Jan 2026 20:04:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769544287; cv=none; b=UaPIEwE/U9lXfmiTbA8Ac3GGW3fFgSd8ZHLsFz9XFrNPc4zXCrzLePwtSc2BBqp6k8K73Ox3m1m1HV9QNmKkjVa1grYiTcFDWS7FXnC/N0Yw1631YYUQeWzH0lmJffuf9Z8D/gel107QfXR+pUPKexWfoLFVGaImtfgxXxq66l0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769544287; c=relaxed/simple; bh=DUj73dpWvUOs0SJwzs0brB8xwJyrnqPA8rObzZywce4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NPfokXVorv44CqnLrnS7ZnkQkZFsTU8lgD3SzmbjR2/6N7njCw4GsJKL6+MOeTjqylFudWbX8iGKOaMjRSLxkm+PgqkOUXdSa/NKjhAzbiVEz0ENE1n5MbRQTLqffei4ikxqFEGsRh2wahr+my+dh7MbcxYLfJF5fGDz7ufmD4k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dVz52v9Y; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dVz52v9Y" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-81f47610542so3256332b3a.0 for ; Tue, 27 Jan 2026 12:04:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769544284; x=1770149084; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xGjbMrQgBawKbwUUinu/j0+8frJya7hwRgmP5T/sjNw=; b=dVz52v9YS5nFKXTK9/QI2Tx9aTDdFTRn0i7i4TiFJgNqxmY8L5bBcdHSJA15g2G7rf GF/c3L5E84n+70YkP5AYKafczYAnmWnmorvVeyXBNIWctuaDjzOKJZSgnEBavVpYo/SY 3EnPt17A11BfTHSYVFN7qJ39Yrg+eeMPtj9TYoyMV7uIR10WDVmjlo9T+XfsqwRSuhgX eV0RZTEHN3EqOncGqYi+XmM29Rompo/IjFzR00H2xbgpkeEbQhmFoC9bohYsxJ6zss0W 2+w6amEs5Dw/lospBUvdfER9850w/G1RgavYbHdgt1ykcugZN6aaJKEjO1y+wwGH9hUj Ounw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769544284; x=1770149084; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xGjbMrQgBawKbwUUinu/j0+8frJya7hwRgmP5T/sjNw=; b=jawRPhejlEhPgBWgGDz4PCeaEgEWyrrt5W1ouHyDaOErikRhFCcU3+VMdNi0Qls7Rw nvGmO7Jr+gZCak67BwP5fpuyKXdD29KfdwrLwn7P2mJ7Zc6Yvyn/HUmDrEtC5qBONxVO PXklMhOEamSc2TCqxwlOcV5BxlZiYBUJ9ww+zWeOeLT+NbUYgrLvEL2aiSh/CnCPtpGP Ga1P1/ARVo90ijMCb/onKRmatFtT3w5d3VW2E/xoBD5B1J0rmAfMBMkrc/EJp81qGt1S PcoJaB5XKf5XY4izIdsQKE+Xy8ax8q9W9vKhy9qUULzj5mI0Lqw6xwOd4It+pn3a5EbR +f1Q== X-Forwarded-Encrypted: i=1; AJvYcCVke95/2LlkYyzKGz/jXBoA5IbyuxrkjiKwTRt6PDBNnKifg80xh0JPvkYhk/0GSsNMqCjvwG/1r+9KVAM=@vger.kernel.org X-Gm-Message-State: AOJu0YyoR6ojqD5R7m+2g9dzS8alxafEWsH4kGFBkzcfexFSocE/TnjL pUFQKhVTvAMThvNpVsfUh6O5/ie1qYCkVo5s6m8eRQNiqEgrn+PuJG2H9lcLHg== X-Gm-Gg: AZuq6aKmK0bl3RgCzXrFYYHLKk7VFDMHB4X/1JWN23F4jH5XCCt5poh7jyB7A8oRB66 smiI0FPsu+MBkWM3Iv/l1mHgFppFxd55I8pBnDi85i2nXXc7sSl4zosksukHK6PqqZFNj6oxhtu ptWpf0hVrzUYZk/D9Q2BY/vJ2zvHxrpGxYOceeW5Cq5wxZ6ZGcgbRR4lOIUzhfdxyM3VD1e5E5/ Q2LeBruD8VSunB+k5A65XIWCSRdCXM+gugNJtVkePY0xbRnEAGfOt2xFPgobPYgC5IVdKe53Trg 5iEdYbJ6Hi2qK8iNKqTFjdJoS1vPvS/Tq6ZGBgBkOUvntyv4UdlPhKHVo/g8cpExwvoE2v2H8GZ fDvWpFCMpPj4HlUa4MbNHlowevRbt5tE4RB01KBQsiQ9Y7p88iRoskypu0V65fUP1HdWjRpUg0f KhVdteM/9EMCdr5LQb X-Received: by 2002:a05:6a00:1d86:b0:81f:41c8:765a with SMTP id d2e1a72fcca58-8236914c62cmr2980358b3a.4.1769544283631; Tue, 27 Jan 2026 12:04:43 -0800 (PST) Received: from snowman ([2401:4900:646d:9a6e:84d0:c92:d353:cd21]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82379b59e10sm377771b3a.25.2026.01.27.12.04.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jan 2026 12:04:43 -0800 (PST) From: Khushal Chitturi To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, straube.linux@gmail.com, hansg@kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Khushal Chitturi Subject: [PATCH v5 1/3] staging: rtl8723bs: simplify boolean expressions Date: Wed, 28 Jan 2026 01:34:25 +0530 Message-ID: <20260127200427.3669-2-khushalchitturi@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260127200427.3669-1-khushalchitturi@gmail.com> References: <20260127200427.3669-1-khushalchitturi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Simplify boolean expressions in rtw_xmit.c to comply with the kernel coding style Signed-off-by: Khushal Chitturi --- Changelog: v4 -> v5: Rebased onto current staging-testing. v3 -> v4: Fixed alignment and removed extra parentheses. v2 -> v3: Resubmitted as a versioned series to avoid threading confusion. v1 -> v2: Corrected commit messages. drivers/staging/rtl8723bs/core/rtw_xmit.c | 40 ++++++++++++----------- 1 file changed, 21 insertions(+), 19 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 9cead1455bfa..314027ea79a4 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -384,8 +384,9 @@ static void update_attrib_vcs_info(struct adapter *pada= pter, struct xmit_frame * } else { while (true) { /* IOT action */ - if ((pmlmeinfo->assoc_AP_vendor =3D=3D HT_IOT_PEER_ATHEROS) && (pattrib= ->ampdu_en =3D=3D true) && - (padapter->securitypriv.dot11PrivacyAlgrthm =3D=3D _AES_)) { + if (pmlmeinfo->assoc_AP_vendor =3D=3D HT_IOT_PEER_ATHEROS && + pattrib->ampdu_en && + padapter->securitypriv.dot11PrivacyAlgrthm =3D=3D _AES_) { pattrib->vcs_mode =3D CTS_TO_SELF; break; } @@ -420,7 +421,7 @@ static void update_attrib_vcs_info(struct adapter *pada= pter, struct xmit_frame * /* to do list: check MIMO power save condition. */ =20 /* check AMPDU aggregation for TXOP */ - if (pattrib->ampdu_en =3D=3D true) { + if (pattrib->ampdu_en) { pattrib->vcs_mode =3D RTS_CTS; break; } @@ -482,10 +483,10 @@ static s32 update_attrib_sec_info(struct adapter *pad= apter, struct pkt_attrib *p memset(pattrib->dot11tkiptxmickey.skey, 0, 16); pattrib->mac_id =3D psta->mac_id; =20 - if (psta->ieee8021x_blocked =3D=3D true) { + if (psta->ieee8021x_blocked) { pattrib->encrypt =3D 0; =20 - if ((pattrib->ether_type !=3D 0x888e) && (check_fwstate(pmlmepriv, WIFI_= MP_STATE) =3D=3D false)) { + if (pattrib->ether_type !=3D 0x888e && !check_fwstate(pmlmepriv, WIFI_MP= _STATE)) { res =3D _FAIL; goto exit; } @@ -639,8 +640,8 @@ static s32 update_attrib(struct adapter *padapter, stru= ct sk_buff *pkt, struct p memcpy(pattrib->dst, ðerhdr.h_dest, ETH_ALEN); memcpy(pattrib->src, ðerhdr.h_source, ETH_ALEN); =20 - if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) =3D=3D true) || - (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true)) { + if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) || + check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE)) { memcpy(pattrib->ra, pattrib->dst, ETH_ALEN); memcpy(pattrib->ta, pattrib->src, ETH_ALEN); } else if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) { @@ -704,7 +705,8 @@ static s32 update_attrib(struct adapter *padapter, stru= ct sk_buff *pkt, struct p if (!psta) { /* if we cannot get psta =3D> drop the pkt */ res =3D _FAIL; goto exit; - } else if ((check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D true) && (!(p= sta->state & _FW_LINKED))) { + } else if (check_fwstate(pmlmepriv, WIFI_AP_STATE) && + !(psta->state & _FW_LINKED)) { res =3D _FAIL; goto exit; } @@ -881,7 +883,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr,= struct pkt_attrib *pattr SetFrameSubType(fctrl, pattrib->subtype); =20 if (pattrib->subtype & WIFI_DATA_TYPE) { - if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) =3D=3D true) { + if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) { /* to_ds =3D 1, fr_ds =3D 0; */ =20 { @@ -895,7 +897,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr,= struct pkt_attrib *pattr =20 if (pqospriv->qos_option) qos_option =3D true; - } else if (check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D true) { + } else if (check_fwstate(pmlmepriv, WIFI_AP_STATE)) { /* to_ds =3D 0, fr_ds =3D 1; */ SetFrDs(fctrl); memcpy(pwlanhdr->addr1, pattrib->dst, ETH_ALEN); @@ -904,8 +906,8 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr,= struct pkt_attrib *pattr =20 if (pattrib->qos_en) qos_option =3D true; - } else if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) =3D=3D true) || - (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true)) { + } else if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) || + check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE)) { memcpy(pwlanhdr->addr1, pattrib->dst, ETH_ALEN); memcpy(pwlanhdr->addr2, pattrib->src, ETH_ALEN); memcpy(pwlanhdr->addr3, get_bssid(pmlmepriv), ETH_ALEN); @@ -963,7 +965,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr,= struct pkt_attrib *pattr pattrib->ampdu_en =3D true; =20 /* re-check if enable ampdu by BA_starting_seqctrl */ - if (pattrib->ampdu_en =3D=3D true) { + if (pattrib->ampdu_en) { u16 tx_seq; =20 tx_seq =3D psta->BA_starting_seqctrl[pattrib->priority & 0x0f]; @@ -1114,7 +1116,7 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter, = struct sk_buff *pkt, struct =20 frg_inx++; =20 - if (bmcst || (rtw_endofpktfile(&pktfile) =3D=3D true)) { + if (bmcst || rtw_endofpktfile(&pktfile)) { pattrib->nr_frags =3D frg_inx; =20 pattrib->last_txcmdsz =3D pattrib->hdrlen + pattrib->iv_len + @@ -1140,7 +1142,7 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter, = struct sk_buff *pkt, struct =20 xmitframe_swencrypt(padapter, pxmitframe); =20 - if (bmcst =3D=3D false) + if (!bmcst) update_attrib_vcs_info(padapter, pxmitframe); else pattrib->vcs_mode =3D NONE_VCS; @@ -1977,14 +1979,14 @@ s32 rtw_xmit(struct adapter *padapter, struct sk_bu= ff **ppkt) do_queue_select(padapter, &pxmitframe->attrib); =20 spin_lock_bh(&pxmitpriv->lock); - if (xmitframe_enqueue_for_sleeping_sta(padapter, pxmitframe) =3D=3D true)= { + if (xmitframe_enqueue_for_sleeping_sta(padapter, pxmitframe)) { spin_unlock_bh(&pxmitpriv->lock); return 1; } spin_unlock_bh(&pxmitpriv->lock); =20 /* pre_xmitframe */ - if (rtw_hal_xmit(padapter, pxmitframe) =3D=3D false) + if (!rtw_hal_xmit(padapter, pxmitframe)) return 1; =20 return 0; @@ -2028,7 +2030,7 @@ signed int xmitframe_enqueue_for_sleeping_sta(struct = adapter *padapter, struct x signed int bmcst =3D is_multicast_ether_addr(pattrib->ra); bool update_tim =3D false; =20 - if (check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D false) + if (!check_fwstate(pmlmepriv, WIFI_AP_STATE)) return ret; psta =3D rtw_get_stainfo(&padapter->stapriv, pattrib->ra); if (pattrib->psta !=3D psta) @@ -2153,7 +2155,7 @@ static void dequeue_xmitframes_to_sleeping_queue(stru= ct adapter *padapter, struc =20 ret =3D xmitframe_enqueue_for_sleeping_sta(padapter, pxmitframe); =20 - if (true =3D=3D ret) { + if (ret) { ptxservq =3D rtw_get_sta_pending(padapter, psta, pattrib->priority, (u8= *)(&ac_index)); =20 ptxservq->qcnt--; --=20 2.52.0