From nobody Mon Feb 9 11:04:45 2026 Received: from mail-dy1-f201.google.com (mail-dy1-f201.google.com [74.125.82.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEE6535EDB2 for ; Tue, 27 Jan 2026 18:45:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769539559; cv=none; b=IlkKaXejTJ1IsyF0EdDnlmZqjcYQNbh3unm7QvK0zr2DQodMsfx+UnvCho+C+Ng8f1eLGHSpG3ttAEmKaoywn4MOaEE3ImDC75x5IKwkRg2x6Tnhc8+9jH3FP/3RsqZ4wtag0JXaNvyXilNrKTMP5KBnKM0nJHFo7QLa0DIxU8g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769539559; c=relaxed/simple; bh=Tg0u9xgINTvX1H6FGlOJHenHBu6latCGVtmFgleOH30=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=XJkcIPzipNZXfS8ToIvvlDSFgOOPR3gUS5AkXI7z4NQ5BP2luFlxVzto5hfXeWgHPMuYKdR9xKKPNV9DkuWGgQSL+bV4nMsmqbPkSFSMAuYpYFcKf63P16otmuv2nX3oQu72SWssVuwxKS+p8tibYf+GJE3kbUtckyVSo8NU5Go= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=bEwtQxXX; arc=none smtp.client-ip=74.125.82.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="bEwtQxXX" Received: by mail-dy1-f201.google.com with SMTP id 5a478bee46e88-2b70d8095daso5754028eec.1 for ; Tue, 27 Jan 2026 10:45:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1769539557; x=1770144357; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=U6hcFPxi9yX1voNwD9X4pnHV7jvDzOlcX84euGlTBqw=; b=bEwtQxXXM9DPR/NmuS4/qRLFp6uPpjwRTzH6Vod4t81L94wWcZ2Co1p27k8+dJsEJV huWuQKBPuyNT+I/hnE4JaVs2xeJoIAwhnJpSEzKx9crfwokXw30Xwvxh6umUuRGqvvk/ xQYZfrilku3x+MRUikx2mCNNzuO37tLnTUpqjg+g6MMH3svHSl+f6A+0JcrVFAymv6wl 0R3q/sf5QAg0ZCdL6WFn2ZTbq5hfwIvNVvCt/hIUdyrkxhh7gnwaqRnaVBciDreKA0nG fREi93xNwhra9Cm2zyxkteUJfWUmUs//qSN8Bzi8uxTk29VSIplI3hugL9x9e52zV1W8 L5ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769539557; x=1770144357; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=U6hcFPxi9yX1voNwD9X4pnHV7jvDzOlcX84euGlTBqw=; b=jYZjiWhkAeBQiKQ8MFzPrvmVuqj93EJgM/cyX8hh8VeT5XFo2vWk0m/wleu3MGgm1n v8zk8DzXqt0cUlV5XEaZnghz9LcE2kuQ3gQag7/SV2E0JOEtSlsC+UnKi5p8HC4C7rRP pYGqWr7LY2Dm0gYsk73d/mKQT4Dh7K3QaV/oDi2Cp5qyXpVzPZ8BMoIggGkcNfF20smC AKoC/0/xUD1veiULPZKUR3Ec3lMIRjxHF85+v/QcTejV+11EcTXc4n4nXIRej8viXcQs 6IRiz9P2f5l3mSltin+snmQYtNg9egVK2UyswCKQT9oN/ecP5STdcS1BTFaqhSCGiZRg ooEQ== X-Forwarded-Encrypted: i=1; AJvYcCVznUFlOh1Y+3o1rgMda7Op1PXBzEVNsOrld3rKQ5DELxUwIulwcPy2hMGrLAwaEOvXFWMVPni5G6qZBjA=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4GvEi8TgAlk3rP4Sy5H4odMj5Gk+8iX/FBLkwxlUzr6lIjO2W PkTwFV38i0U8y+ZEUp0RsQiJlucn635YjIvCenguwo6+J1Si3yxBSE/JHjqaFeKsyOApdhRNMg6 bQkeUMgZd7w== X-Received: from dlai16.prod.google.com ([2002:a05:701b:2710:b0:11a:51f9:d69]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:1284:b0:123:35a4:e8be with SMTP id a92af1059eb24-124a006ef1cmr1274154c88.13.1769539557024; Tue, 27 Jan 2026 10:45:57 -0800 (PST) Date: Tue, 27 Jan 2026 10:44:47 -0800 In-Reply-To: <20260127184506.3059493-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260127184506.3059493-1-irogers@google.com> X-Mailer: git-send-email 2.52.0.457.g6b5491de43-goog Message-ID: <20260127184506.3059493-17-irogers@google.com> Subject: [PATCH v11 16/35] perf jevents: Mark metrics with experimental events as experimental From: Ian Rogers To: Adrian Hunter , Alexander Shishkin , Arnaldo Carvalho de Melo , Benjamin Gray , Caleb Biggers , Edward Baker , Ian Rogers , Ingo Molnar , James Clark , Jing Zhang , Jiri Olsa , John Garry , Leo Yan , Namhyung Kim , Perry Taylor , Peter Zijlstra , Sandipan Das , Thomas Falcon , Weilin Wang , Xu Yang , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When metrics are made with experimental events it is desirable the metric description also carries this information in case of metric inaccuracies. Suggested-by: Perry Taylor Tested-by: Thomas Falcon Signed-off-by: Ian Rogers --- tools/perf/pmu-events/metric.py | 44 +++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) diff --git a/tools/perf/pmu-events/metric.py b/tools/perf/pmu-events/metric= .py index 62d1a1e1d458..2029b6e28365 100644 --- a/tools/perf/pmu-events/metric.py +++ b/tools/perf/pmu-events/metric.py @@ -10,11 +10,13 @@ from typing import Dict, List, Optional, Set, Tuple, Un= ion =20 all_pmus =3D set() all_events =3D set() +experimental_events =3D set() =20 def LoadEvents(directory: str) -> None: """Populate a global set of all known events for the purpose of validati= ng Event names""" global all_pmus global all_events + global experimental_events all_events =3D { "context\\-switches", "cpu\\-cycles", @@ -32,6 +34,8 @@ def LoadEvents(directory: str) -> None: all_pmus.add(x["Unit"]) if "EventName" in x: all_events.add(x["EventName"]) + if "Experimental" in x and x["Experimental"] =3D=3D "1": + experimental_events.add(x["EventName"]) elif "ArchStdEvent" in x: all_events.add(x["ArchStdEvent"]) except json.decoder.JSONDecodeError: @@ -61,6 +65,18 @@ def CheckEvent(name: str) -> bool: return name in all_events =20 =20 +def IsExperimentalEvent(name: str) -> bool: + global experimental_events + if ':' in name: + # Remove trailing modifier. + name =3D name[:name.find(':')] + elif '/' in name: + # Name could begin with a PMU or an event, for now assume it is not ex= perimental. + return False + + return name in experimental_events + + class MetricConstraint(Enum): GROUPED_EVENTS =3D 0 NO_GROUP_EVENTS =3D 1 @@ -82,6 +98,10 @@ class Expression: """Returns a simplified version of self.""" raise NotImplementedError() =20 + def HasExperimentalEvents(self) -> bool: + """Are experimental events used in the expression?""" + raise NotImplementedError() + def Equals(self, other) -> bool: """Returns true when two expressions are the same.""" raise NotImplementedError() @@ -249,6 +269,9 @@ class Operator(Expression): =20 return Operator(self.operator, lhs, rhs) =20 + def HasExperimentalEvents(self) -> bool: + return self.lhs.HasExperimentalEvents() or self.rhs.HasExperimentalEve= nts() + def Equals(self, other: Expression) -> bool: if isinstance(other, Operator): return self.operator =3D=3D other.operator and self.lhs.Equals( @@ -297,6 +320,10 @@ class Select(Expression): =20 return Select(true_val, cond, false_val) =20 + def HasExperimentalEvents(self) -> bool: + return (self.cond.HasExperimentalEvents() or self.true_val.HasExperime= ntalEvents() or + self.false_val.HasExperimentalEvents()) + def Equals(self, other: Expression) -> bool: if isinstance(other, Select): return self.cond.Equals(other.cond) and self.false_val.Equals( @@ -345,6 +372,9 @@ class Function(Expression): =20 return Function(self.fn, lhs, rhs) =20 + def HasExperimentalEvents(self) -> bool: + return self.lhs.HasExperimentalEvents() or (self.rhs and self.rhs.HasE= xperimentalEvents()) + def Equals(self, other: Expression) -> bool: if isinstance(other, Function): result =3D self.fn =3D=3D other.fn and self.lhs.Equals(other.lhs) @@ -384,6 +414,9 @@ class Event(Expression): global all_events raise Exception(f"No event {error} in:\n{all_events}") =20 + def HasExperimentalEvents(self) -> bool: + return IsExperimentalEvent(self.name) + def ToPerfJson(self): result =3D re.sub('/', '@', self.name) return result @@ -416,6 +449,9 @@ class MetricRef(Expression): def Simplify(self) -> Expression: return self =20 + def HasExperimentalEvents(self) -> bool: + return False + def Equals(self, other: Expression) -> bool: return isinstance(other, MetricRef) and self.name =3D=3D other.name =20 @@ -443,6 +479,9 @@ class Constant(Expression): def Simplify(self) -> Expression: return self =20 + def HasExperimentalEvents(self) -> bool: + return False + def Equals(self, other: Expression) -> bool: return isinstance(other, Constant) and self.value =3D=3D other.value =20 @@ -465,6 +504,9 @@ class Literal(Expression): def Simplify(self) -> Expression: return self =20 + def HasExperimentalEvents(self) -> bool: + return False + def Equals(self, other: Expression) -> bool: return isinstance(other, Literal) and self.value =3D=3D other.value =20 @@ -527,6 +569,8 @@ class Metric: self.name =3D name self.description =3D description self.expr =3D expr.Simplify() + if self.expr.HasExperimentalEvents(): + self.description +=3D " (metric should be considered experimental as= it contains experimental events)." # Workraound valid_only_metric hiding certain metrics based on unit. scale_unit =3D scale_unit.replace('/sec', ' per sec') if scale_unit[0].isdigit(): --=20 2.52.0.457.g6b5491de43-goog