From nobody Sat Feb 7 08:07:36 2026 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 140DB35FF52 for ; Tue, 27 Jan 2026 16:48:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769532513; cv=none; b=sXhfHSah6bmBsedLwjTgCNR6af1/YGoDTFH9xTDrmLYQUVGisde13KaR8LoHp0h1Qf8R70dvFsiLNsi6J03paT8HxXLXKxdz7ib72RxYokO5haHFJMi8SgGCq/D5Yez/Iu1WNT30+NuyexkR9oCGTyqpqTN4T6GeGyfnCR34Ji4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769532513; c=relaxed/simple; bh=aFDX34ybk/Kqa5bE8bFWwCkyvn6Pr2LS21JJKYV7n2Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Er+4aaiEnkDt6dNAlXhRPPQovdEV/eR7VnZRhvnUKeAnS/YMQijyHIGKu/SRtuoUNNrm0rB4smsOdbHVJW7N9k/locbUp1fruYNlu1C2lcp6EjlF8fSDGXI3wm0whspkatYsoSOXHtTZAs/QdrwDZ0NMA7wemCQMUW5dcsCDoKo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mzKVqXvK; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mzKVqXvK" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4801d21c411so31598565e9.3 for ; Tue, 27 Jan 2026 08:48:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769532510; x=1770137310; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vxdGKRED/GezH50A93RC3QHz4tAJqHqw5Wvg3bxqlKY=; b=mzKVqXvKzwiYckjJPKBzs5TnIWh7JmUTkKlRn2lC8rUFZgy/Yl0L3giy2N/siPXPNj HPBvVXOXFHdQ7fJepEYpQcUsP0Zt4LujrlIBMCSBwoD2VItGsI/SkZCvTZY6/E4KDYQP XuqTLBVBUbqviq3f953FyWKyRRCfOD4b3RW1R0VNMwAs3PM8YYl3VJpq7dRw5h7vAMu1 n8Netvv41Yzk0AgX2OaO8KFUpyOSX7oP54YNWLUf0YSW50qLH30Wm32TsG10yOSCUFap NJfnCAVmXIVgx5JxhM1EZMNjW/n+2vZDqZmB048tnr5JQuWMH/7eFxA9hW00O2hsNwLD 9xqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769532510; x=1770137310; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=vxdGKRED/GezH50A93RC3QHz4tAJqHqw5Wvg3bxqlKY=; b=clFn4c2nv4bCOsxLh6lWaKF1eeAgZpy4VBMhW209rcOqSZTo4pqHrhl/h8cUDrKqgm FNoJymHnWYJzNs3Huou+nctWVv8VH3xAVJwrANbUfRVc0tLEm4e8GcrU4/f9ZA+b1gCF 5eGKBguqRPt2gWsRCUv9yTqAUj3tb3osolqgHKo6zzw9lG525wtSRNkcBZlhT4Y3kGXr b1/PvEKj87HRIDuEz3MgMgx7uucVrZFzkIxuzZHHwiBAvJ6QaiK7GonSPZGt6AWHUYLP Kl49W0bGDQKyd834ju2OdvZop/z93117ksUrnsaWo9qKqvIzu9QY7xHhF+sZFGf+1FVh N/nA== X-Forwarded-Encrypted: i=1; AJvYcCXBrokcufMtofVP8rHH5NVYi3xlwtF6Nh6uGWQnXacBj1l+BjOILHR/3r5D/agVXDqGCBPnYAU5LmWa+9g=@vger.kernel.org X-Gm-Message-State: AOJu0YwZ9j40IBVPlexQz6YId5cKRgEBSrA/O91NYk+/rtTIzpkxfTLf w+lhS7GeURpa7KdSTv5UdNV6C6sT1mVLlDJJ0MVJD5I5DSgerYoUbnqkbCxBxg== X-Gm-Gg: AZuq6aKeW1Y/QBEyC70xKa/gA55ni3q/jElYKmut+L/mUSMarrYMlRUA6XNnjNPTZFQ J93ochBE6y+PV4EoNy/LGtG5zMIdHA1Qh/o4r+coI2O6Tu9iKw+QXACF3InJRlCwaxMyQZ6+92w K4kxBDqSCboiUvxcN/Gx6nEyEFw77AHTcXjrAe1MRCjw+ep7yjFMdmqXNaq3ORE83TVA5LjsBPT Lt0384U+YFJ/bta1iQzMN/kGEpj8fvZdraZgjq6agg0MYuhDpmAn9byAlQ+kY48vNpkN7eQ8IPk ypxQZSGL7zpQnMk7OsY3iYIXOrEkVC3jT4SWW1twC/SFI1MiDqs6Iaea0gfxk+wqKEV8kz/Sdcj 0vNkFw/PdtN8bsxdqmnLhYnALdiUpFTbKr0fOiMUL49ujLYFpMVW2cJf6qxxVZsIccFtkKy8w32 XFvXQV49rBmxGG99xhwA4= X-Received: by 2002:a05:600c:474d:b0:480:1d0b:2d15 with SMTP id 5b1f17b1804b1-48069c53fdbmr29083465e9.27.1769532510148; Tue, 27 Jan 2026 08:48:30 -0800 (PST) Received: from Madhu.broadband ([83.106.123.52]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4806cdebf86sm3887455e9.8.2026.01.27.08.48.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jan 2026 08:48:29 -0800 (PST) From: Madhumitha Sundar To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Madhumitha Sundar Subject: [PATCH v2] staging: sm750fb: replace magic number with jiffies timeout Date: Tue, 27 Jan 2026 16:48:16 +0000 Message-ID: <20260127164816.91481-2-madhuananda18@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260127164816.91481-1-madhuananda18@gmail.com> References: <20260127164816.91481-1-madhuananda18@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The hardware wait loop in hw_sm750_de_wait used a hardcoded loop counter (0x10000000), which depends on CPU speed and is unreliable. Replace the loop counter with a jiffies-based timeout (1 second) using time_before(). This ensures consistent delays across architectures. Signed-off-by: Madhumitha Sundar --- Changes in v2: - Switched from loop counter to jiffies + cpu_relax() as requested by Greg= KH. --- drivers/staging/sm750fb/sm750_hw.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/s= m750_hw.c index ce46f240c..b24d27a77 100644 --- a/drivers/staging/sm750fb/sm750_hw.c +++ b/drivers/staging/sm750fb/sm750_hw.c @@ -523,19 +523,32 @@ int hw_sm750le_de_wait(void) =20 int hw_sm750_de_wait(void) { - int i =3D 0x10000000; + /* Wait for 1 second (HZ) */ + unsigned long timeout =3D jiffies + HZ; unsigned int mask =3D SYSTEM_CTRL_DE_STATUS_BUSY | SYSTEM_CTRL_DE_FIFO_EMPTY | SYSTEM_CTRL_DE_MEM_FIFO_EMPTY; + unsigned int val; =20 - while (i--) { - unsigned int val =3D peek32(SYSTEM_CTRL); + /* Run while Current Time is BEFORE the Deadline */ + while (time_before(jiffies, timeout)) { + val =3D peek32(SYSTEM_CTRL); =20 + /* If Not Busy (0) AND Buffers Empty (1), we are good */ if ((val & mask) =3D=3D (SYSTEM_CTRL_DE_FIFO_EMPTY | SYSTEM_CTRL_DE_MEM_FIFO_EMPTY)) return 0; + + /* Polite pause to save power */ + cpu_relax(); } - /* timeout error */ + + /* Final check in case we succeeded at the last millisecond */ + val =3D peek32(SYSTEM_CTRL); + if ((val & mask) =3D=3D + (SYSTEM_CTRL_DE_FIFO_EMPTY | SYSTEM_CTRL_DE_MEM_FIFO_EMPTY)) + return 0; + return -1; } =20 --=20 2.43.0