From nobody Sat Feb 7 17:48:50 2026 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B320357731 for ; Tue, 27 Jan 2026 13:28:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769520488; cv=none; b=s3DKz3M6GcVFPEhy2bza+sMHh/ARk7XrBIZZ9fJD9OwIwtcR4fY99zbvqvItRxzFg+99CSiSjolpHMbDYc+uUyCY/9pK6HW0IV0k+QQtVSyw8Zwytg0qslASJYaJmCVudQg1vuiNCigtwYz49sSem/xaFuiNBRQnlN7FeHkwp6w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769520488; c=relaxed/simple; bh=oFuZ/HRtloYM9iYhuq4BViSywKCjv8X7x4OXI/5MwlY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Qhk0JNAsEPaoJzWyQ7oBkkQ17YVKlu+z4VUeso+e+Ubn7Xn+6ibQe9TOfJMeV4GS/f88IywhDagI4dfMIQyYGaXRp9+jNhbn7iH1kxkSE4Cf+RW3cQZCegcBFngqUe8ZIn/QEZ0Lgc7lh139dyKQ1dYIvGsrHCebHU6NetdmjHQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JaG56xM6; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JaG56xM6" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-42fed090e5fso3473700f8f.1 for ; Tue, 27 Jan 2026 05:28:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769520485; x=1770125285; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Vt46RssgikEJSElwuUT//rA9kswfqTzUa3QvVRbgabw=; b=JaG56xM6nWo7I4a9NBif4bgC4S9yhzciEPCTxyICjWGbvgQPOpErLXwF6YbneTONVe zRCRn88/o+pn96UdsxikXayU0eSwrPdohKA/CGAh5TopEXO+fuGGhmX8fJLpUzq65fh+ mSpJqEGxVZH9yq7ojRs0ldAQzu0xDh5xJWbG6mwse5OQsLFzXtXIwsPe8FjebzSSNkaM Eoy/u4cQQ6Fi/jKjv20SzRlixyU4W+mlTddKQgfM8QMReo3nijo8Hpo4kO2eZAMFjL5h JSjR5Eu8+TtROL9kWyO2lMz61DHcS+ctbOuOmoXayNl4/1NZlkPBQBepgskzmZ7vvt+2 ftnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769520486; x=1770125286; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Vt46RssgikEJSElwuUT//rA9kswfqTzUa3QvVRbgabw=; b=vDV2QZ9xwRY9IkLfTkGMu+SErb9Fs8U+JZCD5vfEPotJevEDW/SKUXSLe9NhWkO3MD zkzgCCUCO2n9x6KWV7POiVNLqrecrwjz0eWVWaUEkbN2A2pZMwTYHiNs1atPYNwyOUmE llMESCRcUUYHCD1FMGQuzmoaXgIlyMpl8nb8Ji+OUqwe5FBDTV6aKOs/n8gnZocF1pRX GbmLnnm0nIvJBItpPO48NR68j7pI/Mv8am5fReD4jLS/H37Cg6Nc+J7zOFm5RrCmEjj6 GRLRIrgtEoQgQLzNSNDzpt1Fu01ZNvSV+z7y2JfORrRWuTcIKxoSY/EW5Mp9BckzM95L TQ6w== X-Forwarded-Encrypted: i=1; AJvYcCWuDEU/CFvyJk0kTuH8+HuSSR5vdBFOX6/Wy8tN0rjseBPdP9h26ilenkMCaTptW+G2irQiZZAVSVqzhMY=@vger.kernel.org X-Gm-Message-State: AOJu0YzLZJjsiM6zf8z68Sl4MZaFKoRmrDDOQO9pkrQEVf1pmHpMkuEB CitKjjSOd8zMZM5AoXpuZUEieJwCfn9D09exB/dcHtvHmRQ8/MWUbcquCkwLNQ== X-Gm-Gg: AZuq6aLIQx33egtNWKY7JWgyXKWE/Bl2uE6M5tU2suWHsynrg3WbKkoXkRu/V2qtxb/ ikfrpwmH+mUtYocm3lwMIbdOBgyb4RGDmqsxaXdKr00fCkKNFqM7OJYW+aOogcjEh7iWbLvzgkr MxyIcXNcAuN0VKeSaS6xQTtU6Nm4Y4rXcXNM6bAU0FfcmQBrd7Wont6twMwk6SUwNtyndZ7lNr1 eVWGrVKm3HzZPpou2zaTRQIX0OZY51QDj9E8hE7F97SLPmkQTmoQkNAOpcox7+z9W0fbgbbXbkR aX3jBYTmPVFa2GROyPLJ9CgRhGq9ddM0kyP3VIMLUScUsYylbnt5QojLwggmfFaIt2pRriodTQA Sk+6ZDhb4pExHiTYPmrdL/Oz98noGjNkKE1X5h5wVd2JTpbnKfrSO90dHKm4AcHmRNJD/dhUkdc TQ0BwacRji1gcVNEOuE8k= X-Received: by 2002:a5d:5d0a:0:b0:42b:3131:5437 with SMTP id ffacd0b85a97d-435dd0a3e50mr2509020f8f.34.1769520485372; Tue, 27 Jan 2026 05:28:05 -0800 (PST) Received: from Madhu.broadband ([83.106.123.52]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435b1f7ba0bsm38902304f8f.40.2026.01.27.05.28.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jan 2026 05:28:05 -0800 (PST) From: Madhumitha Sundar To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org Cc: linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Madhumitha Sundar Subject: [PATCH] staging: sm750fb: replace magic number with defined constant Date: Tue, 27 Jan 2026 13:27:58 +0000 Message-ID: <20260127132758.49650-1-madhuananda18@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The hardware wait loop in hw_sm750_de_wait uses a hardcoded magic number (0x10000000) for the timeout counter. Define a constant SM750_MAX_LOOP in sm750.h and use it to improve code readability and maintainability. Signed-off-by: Madhumitha Sundar --- drivers/staging/sm750fb/sm750.h | 2 ++ drivers/staging/sm750fb/sm750_hw.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm75= 0.h index fcb7d586e..ae07ceec1 100644 --- a/drivers/staging/sm750fb/sm750.h +++ b/drivers/staging/sm750fb/sm750.h @@ -12,6 +12,8 @@ #define SM750LE_REVISION_ID ((unsigned char)0xfe) #endif =20 +#define SM750_MAX_LOOP 0x10000000 + enum sm750_pnltype { sm750_24TFT =3D 0, /* 24bit tft */ sm750_dualTFT =3D 2, /* dual 18 bit tft */ diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/s= m750_hw.c index ce46f240c..f051bd75f 100644 --- a/drivers/staging/sm750fb/sm750_hw.c +++ b/drivers/staging/sm750fb/sm750_hw.c @@ -523,7 +523,7 @@ int hw_sm750le_de_wait(void) =20 int hw_sm750_de_wait(void) { - int i =3D 0x10000000; + int i =3D SM750_MAX_LOOP; unsigned int mask =3D SYSTEM_CTRL_DE_STATUS_BUSY | SYSTEM_CTRL_DE_FIFO_EMPTY | SYSTEM_CTRL_DE_MEM_FIFO_EMPTY; --=20 2.43.0