From nobody Mon Feb 9 14:31:33 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 297CF342177 for ; Tue, 27 Jan 2026 10:40:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769510445; cv=none; b=G3DXqTPt8aD7W2MkS3Z7Cba1HhgBNFh1CZaJc9MiMcpVuCHpcLjrPs0+DT625OGCuU0G7I47w0KYR1MI/r997Jb4wSKCoJSwlf2rKji58Uk9LmptL69WdBWn+ZY2FvpjB7aWri3Cn9dTagoSxR7T7UFQFWXjz+jBBQgwxkDDqmU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769510445; c=relaxed/simple; bh=EHO8zs+g1Ko8UHjpjUG4wCs7CJMj3UxzMt+d6rQqm7c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gvk1bY1j1suOncCuwkmUtw+BP9DOc0VC8wW9nP0ZUWV2cKeLjbgBCp240RSlM3VrILoM96/PYglpyRkaxt648tgukZ+L4NBqszadbeMiLd9P2XpzuXjKokhzAaB8qm3XeNPVQANmwvaYd/3XOK8UE9QH5auUSDxts20KM1KFCtc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fNg0nf9k; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fNg0nf9k" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2a0c20ee83dso51443705ad.2 for ; Tue, 27 Jan 2026 02:40:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769510443; x=1770115243; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=w5DU1y+/2ttdbcr+v/9sCW2fX8t95H3Z19WR35X2oK4=; b=fNg0nf9ka1mEDu8+WR1YmmZyYgnBmf1BK7YmSSapIj1HMnmWwk5tiUFjBMdMk5nsWo QAP4HaGVTJvWz7EIrOPVNXMmwHRhfBPVkC32cq1xKMhdAoS+bbiHJhMXfjr8sGyzjT5N YbQ29q8nK2F5dF9pDRJXWT8GQWjz9xfYhZgj5cV+6gENF/i7RHYPXL3Ny3ipjQ0K70m2 mOB7ikShd6HwPEA44GjMkkXn88d656amDhJ1d+28epx79IoJSiyH5SqMZ4bLliKlXXS9 io2zIsPyN3CaNGbGFTI15wMFQL7aYScfjVkBikbNj8vqcxT4gr2hY0Gzq/CoHC+8sdLB 8ASA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769510443; x=1770115243; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=w5DU1y+/2ttdbcr+v/9sCW2fX8t95H3Z19WR35X2oK4=; b=pMM241MG5+q/gnS0j/Cdp5Pfr09BuT3T2UR5Tdgkoyj63GWtfMIDl04im+GMJGFbrW i/WDpYNrYV/0DgmXpG9XEKX9LGBByp7ToRLgmfZULnoGhnNjdqsDD+aJ5C3BDGyZPboa kuKi2yuHjKpoiLdeyzacZSi0CPPJa0Q9+pyRbqIB0X6ZggWYlISYUpHx6KvQdd8YRpsa roPk7P8UbpX2ORdnbQZYW9B4Jl+b6HayNGlydaZ9fdoaz9SlyhsSttb2KkKiox569LSC 2GU1C/qTDBQaHw1Ku0ekR6c6BrMqbxBE0s6svWj1krDP5vsLE3uDUn3z2ATr7myeKSU3 S8Jw== X-Forwarded-Encrypted: i=1; AJvYcCVn0BTmmDRT+NafiynQsOxPH3Pz7+/0gVAJSU3xDC7ok5rJ0zXLHwBrWYyrL9d0SEtrGml6dFJNcPi6Nfg=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9tQTtAqgiz4Im5V2UNAq4OLqmkPZOO4nKDtJAs0pQg3NOEbBN 7Q4QA0K7lwRiFlMTrvUvkIw9YnNwJRM1zBOiiHnbFRhXMf4ckt31/ExH X-Gm-Gg: AZuq6aLj5dZ9flA8GzUePPsGmn12pElHLahKpXU8m1CzBUk2Sc83JW92A4xgbkUo3m4 xNagL3WMBi7FEG6vVC4HScsb5nmtfStwLNf8b7hSfEV00+dPYdtlIw+LbbLx5iYebMby7k/owxu 1MPJsZyShNGEP3+xMn03iEloLtPQvF3TWE+ydEj7oOYvpvp5gldmSLaRmEU7DGI88apS6bHkdjx H4J5UCJEUMcSFeVKMO/Wo2QaOt0su7A9OcY23w8vAE8UR3d6mK8Ug4n2XZIMgl7tJV9lCC83JSJ zWjf75Wxw57tjbYze2NcjnuDVoHM2q3bXr+rH/hh47XLG6eH4TTHsLFwRhS5XzANclZXRdoOA+W L+BRw2hNvnhTjaF4Y2wb+48T+nIUEjakaSRWPUmwtv1hdUIm9CoTeG8RQ7Jf7PMP2L8+u7Al/O+ UqVzZ+XZHGGqXri44lfeWU+x82QtrOJ5PkaAKOZw== X-Received: by 2002:a17:903:2f0e:b0:2a7:561e:690b with SMTP id d9443c01a7336-2a870df1966mr14406385ad.58.1769510443442; Tue, 27 Jan 2026 02:40:43 -0800 (PST) Received: from c12-ThinkPad-X1-Carbon-Gen-12 ([2400:2410:5f2b:700:38fe:3edc:7f99:7e99]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82339095c85sm7218907b3a.67.2026.01.27.02.40.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jan 2026 02:40:42 -0800 (PST) From: Vishnu Sankar To: mpearson-lenovo@squebb.ca, dmitry.torokhov@gmail.com, hmh@hmh.eng.br, hansg@kernel.org, corbet@lwn.net, derekjohn.clark@gmail.com, ilpo.jarvinen@linux.intel.com Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, ibm-acpi-devel@lists.sourceforge.net, linux-doc@vger.kernel.org, platform-driver-x86@vger.kernel.org, vsankar@lenovo.com, Vishnu Sankar Subject: [PATCH v6 2/3] platform/x86: thinkpad_acpi: Add sysfs control for TrackPoint double-tap Date: Tue, 27 Jan 2026 19:39:06 +0900 Message-ID: <20260127103907.20269-3-vishnuocv@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260127103907.20269-1-vishnuocv@gmail.com> References: <20260127103907.20269-1-vishnuocv@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a sysfs attribute to enable or disable TrackPoint double-tap hotkey events at the kernel level. The TrackPoint firmware enables double-tap support automatically. This interface allows userspace to control whether double-tap events are forwarded to userspace. The attribute is available at: /sys/devices/platform/thinkpad_acpi/doubletap_enable 0 - Disable double-tap hotkey events 1 - Enable double-tap hotkey events (default) Filtering is implemented by suppressing ACPI hotkey delivery without injecting synthetic input events. Signed-off-by: Vishnu Sankar Suggested-by: Mark Pearson --- Changes in v2: - Updated commit message to clarify dependency on trackpoint driver - Now handling sysfs read/write of trackpoint driver using file read/write - Removed sysfs attribute creation of trackpoint double tap here - Reversed the logic and return false right away - Dropped unnecessary debug messages - Using dev_dbg() instead of pr_xxxx() Changes in v3: - No changes Changes in v4: - Simplified approach: single sysfs attribute for user control - Clear naming: doubletap_filter instead of doubletap_enabled - Intuitive behavior: 0=3Dprocess events, 1=3Dfilter events - No cross-driver dependencies or complex interactions - Minimal code changes using existing thinkpad_acpi infrastructure Changes in v5: - Rename doubletap_filter to doubletap_enable to match actual behavior - Fix inverted logic so events are emitted only when doubletap is enabled - Register sysfs attribute via hotkey_attributes[] (no device_create_file) --- --- drivers/platform/x86/lenovo/thinkpad_acpi.c | 42 +++++++++++++++++---- 1 file changed, 35 insertions(+), 7 deletions(-) diff --git a/drivers/platform/x86/lenovo/thinkpad_acpi.c b/drivers/platform= /x86/lenovo/thinkpad_acpi.c index cc19fe520ea9..ca01323c990a 100644 --- a/drivers/platform/x86/lenovo/thinkpad_acpi.c +++ b/drivers/platform/x86/lenovo/thinkpad_acpi.c @@ -373,7 +373,7 @@ static struct { u32 hotkey_poll_active:1; u32 has_adaptive_kbd:1; u32 kbd_lang:1; - u32 trackpoint_doubletap:1; + u32 trackpoint_doubletap_enable:1; struct quirk_entry *quirks; } tp_features; =20 @@ -3018,6 +3018,31 @@ static const struct attribute_group adaptive_kbd_att= r_group =3D { .attrs =3D adaptive_kbd_attributes, }; =20 +/* sysfs doubletap enable --------------------------------------------- */ +static ssize_t doubletap_enable_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + return sysfs_emit(buf, "%d\n", tp_features.trackpoint_doubletap_enable); +} + +static ssize_t doubletap_enable_store(struct device *dev, + struct device_attribute *attr, + const char *buf, size_t count) +{ + bool enable; + int err; + + err =3D kstrtobool(buf, &enable); + if (err) + return err; + + tp_features.trackpoint_doubletap_enable =3D enable; + return count; +} + +static DEVICE_ATTR_RW(doubletap_enable); + /* --------------------------------------------------------------------- */ =20 static struct attribute *hotkey_attributes[] =3D { @@ -3032,6 +3057,7 @@ static struct attribute *hotkey_attributes[] =3D { &dev_attr_hotkey_recommended_mask.attr, &dev_attr_hotkey_tablet_mode.attr, &dev_attr_hotkey_radio_sw.attr, + &dev_attr_doubletap_enable.attr, #ifdef CONFIG_THINKPAD_ACPI_HOTKEY_POLL &dev_attr_hotkey_source_mask.attr, &dev_attr_hotkey_poll_freq.attr, @@ -3557,8 +3583,8 @@ static int __init hotkey_init(struct ibm_init_struct = *iibm) =20 hotkey_poll_setup_safe(true); =20 - /* Enable doubletap by default */ - tp_features.trackpoint_doubletap =3D 1; + /* Enable TrackPoint doubletap event reporting by default. */ + tp_features.trackpoint_doubletap_enable =3D 1; =20 return 0; } @@ -3863,9 +3889,9 @@ static bool hotkey_notify_8xxx(const u32 hkey, bool *= send_acpi_ev) { switch (hkey) { case TP_HKEY_EV_TRACK_DOUBLETAP: - if (tp_features.trackpoint_doubletap) - tpacpi_input_send_key(hkey, send_acpi_ev); - + /* Only send event if doubletap is enabled */ + if (!tp_features.trackpoint_doubletap_enable) + *send_acpi_ev =3D false; return true; default: return false; @@ -11285,7 +11311,9 @@ static bool tpacpi_driver_event(const unsigned int = hkey_event) mutex_unlock(&tpacpi_inputdev_send_mutex); return true; case TP_HKEY_EV_DOUBLETAP_TOGGLE: - tp_features.trackpoint_doubletap =3D !tp_features.trackpoint_doubletap; + /* Toggle kernel-level doubletap event filtering */ + tp_features.trackpoint_doubletap_enable =3D + !tp_features.trackpoint_doubletap_enable; return true; case TP_HKEY_EV_PROFILE_TOGGLE: case TP_HKEY_EV_PROFILE_TOGGLE2: --=20 2.51.0