From nobody Sun Feb 8 05:29:48 2026 Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010051.outbound.protection.outlook.com [52.101.193.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A9552D47FF; Tue, 27 Jan 2026 08:51:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.193.51 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769503885; cv=fail; b=i3pu21AbJrWSzTfenUp3WGofPhuQsrdrobFH5lPvpb/Kv/3jyojKILU2ZAEmj9/7+eNhyCOubaQLEBiVhX7Pmef9wLyePc+KjhNo4qpWUzVR+AGiL+4xOzjLNPRUHYoF7SAA4BSZAayN1CiiEe2m8q84u8aD5GBo4rT+hsUwBrk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769503885; c=relaxed/simple; bh=x/cLJAqyVzbrWydRZh+2fJpjaHVdKTbPVeQB61ijpOk=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NjG8BodhIYtvucrPW+PWfFHBocjhBihnKsv9+bWaYR1Trbhac8Dhl6Dkkm/X+4GyyzXcnSUm9HGsrzUGgRV/aIzu1MrwX7jULWdCrJ9iaKETVQ3318j9XSHVMtFOhGcSLY+GarWeUhJR80vThyJvJo+7XY8AKbeHejHOSz43X2A= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=mGlOA1ip; arc=fail smtp.client-ip=52.101.193.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="mGlOA1ip" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=L9qLXdgNjlpXSMPsIwAipQuNw7JC5zSz9VaCIahbO0tfmtUOnZKHxjiWlAR4qP+/aYJhUhE/YDgWDVcdyhdBHI680loa3p2pRa9Eiw/N63aSiPSgXN/77vV6ep+oIti5szLkmr8fiGLZH+pkoEbcnyk+FKrnzD8cZjnLKw8QTbVxdOWyLvmtfSTMAEtF0ub2qVIUkK6Cq+jFOboBNIwASZuKzRdsVQWrvFUDq+iIzR5aHgLw7Jb7kr329ptWJEBahnl9c9SPLrFNVqZlfQ6mE7OLxNJFc5BlfoZvU7Yh30gko74QMx1fY91PDObtRfUkM2iFRI3JBW5cK/KUe3RzWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VXzheLLFf6eEqwDmMMK4tVhNhSPlLNWjs8VbslRg3qw=; b=TkES7G4trx/dD7H+z00LIOJf0MqKJzK2SjNoFlkZq1ml0PaqlQfP+W4v7GofSuk/p1KsTwbAvjVfaUZVzNLhfqePDD+7X2q5iAwWq0kscl1K/wIs1JAzup2sl0ghOLGG5JvL8Qj56fJUG1SRzbHWGflen1uZaTzMne1XTrDi4lThUjTUjiz8IW7l0GHJ6zi4y4lBoO1ga8nM8hwhP3s3dDMNrLCYqYWI9JRjf867UeSm0hZwkApFSlp/jTvCvVm0LMECyvtufcpUQGPyplmTDTHkq+OoxN7nHaFdHyResoNT2j+3hEjYtVOGzg11Q8gwhXny8SmF2Wr+k/gSuYyEgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VXzheLLFf6eEqwDmMMK4tVhNhSPlLNWjs8VbslRg3qw=; b=mGlOA1ipEsqLZd86N+3RXGJCWCdqDyB0Nay6ZIhZTrvmVNUcXc1XIop1eJsH7RnupQT4k+cR3h03GHOfFyISD7+2elU24yycxXPUPVtrPUWtzF2NQNlWBsFlQCRmGu3SOm5xcWb4zXs92QiOWzdQwanM2R8ib+mOxDGNQNKiNvg= Received: from PH0PR07CA0073.namprd07.prod.outlook.com (2603:10b6:510:f::18) by DS0PR10MB7248.namprd10.prod.outlook.com (2603:10b6:8:fc::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9542.15; Tue, 27 Jan 2026 08:51:20 +0000 Received: from CY4PEPF0000EE37.namprd05.prod.outlook.com (2603:10b6:510:f:cafe::7f) by PH0PR07CA0073.outlook.office365.com (2603:10b6:510:f::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9542.16 via Frontend Transport; Tue, 27 Jan 2026 08:51:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.194; helo=flwvzet200.ext.ti.com; pr=C Received: from flwvzet200.ext.ti.com (198.47.21.194) by CY4PEPF0000EE37.mail.protection.outlook.com (10.167.242.43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9564.3 via Frontend Transport; Tue, 27 Jan 2026 08:51:18 +0000 Received: from DFLE208.ent.ti.com (10.64.6.66) by flwvzet200.ext.ti.com (10.248.192.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 27 Jan 2026 02:50:56 -0600 Received: from DFLE207.ent.ti.com (10.64.6.65) by DFLE208.ent.ti.com (10.64.6.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 27 Jan 2026 02:50:56 -0600 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE207.ent.ti.com (10.64.6.65) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Tue, 27 Jan 2026 02:50:56 -0600 Received: from a0507033-hp.dhcp.ti.com (a0507033-hp.dhcp.ti.com [172.24.231.225]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 60R8ol4d4071462; Tue, 27 Jan 2026 02:50:52 -0600 From: Aksh Garg To: , , , , , , , , , , CC: , , , Aksh Garg Subject: [PATCH v3 1/3] PCI: dwc: ep: Fix resizable BAR support for multi-PF configurations Date: Tue, 27 Jan 2026 14:20:08 +0530 Message-ID: <20260127085010.446116-2-a-garg7@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260127085010.446116-1-a-garg7@ti.com> References: <20260127085010.446116-1-a-garg7@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE37:EE_|DS0PR10MB7248:EE_ X-MS-Office365-Filtering-Correlation-Id: cbe7fa00-a5cd-43b8-976d-08de5d813ca1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|82310400026|7416014|376014|921020; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?4tv95Tkn8mGSCQrqDWxvg24v8Obsd+KRnxvupI/1LC54popAnDx/fKP7CHP9?= =?us-ascii?Q?7AfWrSc4o9oBmt4io0NFIwLwvgqAlkEA5YKK9zsXx231HNUXH0o6a3uxIpDg?= =?us-ascii?Q?B4BeiPrXIR2gaoESH+Ds5EWITCkqLSd13iA4JLmAADJ6ecePx9XuPXc0cWad?= =?us-ascii?Q?rkDocgefFvD4aQBfsz1cgRHyosufTOgSo8ddoqnD7/beHQGxjD9QvNZKOTL9?= =?us-ascii?Q?ZMdq9MteHzTDWvMjiA3mgHVSUyRJ/nmFYdvIuT3SSKDpCW1PRuKj4GRlFsrg?= =?us-ascii?Q?uSRk3kgZL7+71cMyta7ZyU16ZxOQKSXtHMWnOjLGlQNRH43p0JUnN6V3qsup?= =?us-ascii?Q?3AN3HYlat4arM2SvxkAHEGjfgkT8rqafD+ucWtlAIVDNo+bmsdKU4KRAUmj0?= =?us-ascii?Q?8sNBGKVCNiQagAhmG8o2jUVmrubNuaKKhmObzmePw79RzziFMa79T+hONMuW?= =?us-ascii?Q?uJUnt6uVuz88hdq/IxROSsU6NmAGKcOjNWoReMI0w+eo5NuGw4epOIcGFZit?= =?us-ascii?Q?1rQ4hXxph1pcCevtQURutdsRxbnAhPRObYfsSRMemC7amaBqgGte6ylJ6vn2?= =?us-ascii?Q?hUcFvLC2Ab3fJrJ/vHAAT5QwqQTQvhhby+Q0v+JOkNKY7Q8boZGJ0NfUGkxA?= =?us-ascii?Q?uAEnR1JMnobAbC6mYFL4NpAJT3rU67ftfi++b67whCeZJ8r7HxkqOwLaDUHt?= =?us-ascii?Q?ZsDfzRXiDUS4loxhYgQs+RsGwiufQTqnIn+F7oigtIqjcIRP5TR6vrYd8t+i?= =?us-ascii?Q?A3i0K/s07oRFOo94McFs/yKO7GqOgKYP54N5bpKypg4Bky+1BWfO2bbXkchl?= =?us-ascii?Q?FHNd0zbA98H6jxnpBZh0usHny+sZePo0y5HgT4TMUJoNmikcEM/KoU+wQqD4?= =?us-ascii?Q?tlikiNKbL9Mgj/LpGacUk1TC94dSyGKJJ6XnGJK5U0m/CuCR8PNqti7KkvKo?= =?us-ascii?Q?txalyGxK7VFKxHq2UiXwsLLYSritp+3ixvunySMOyjCgMVfSvv6CrSWyOvtA?= =?us-ascii?Q?3uAmNidXrwB25MsWM8GLHZ9pSJ5Zbw3TSy/RNLahAkQAGBiMj/6cJlJR0m2i?= =?us-ascii?Q?hv+Ppp1Dzxb7uQosfx4ee0fwvuoyq+pMWdzHrRhbevLu7UpQchxw3MTsAd/q?= =?us-ascii?Q?PA3yiYz64KnBOGx+5Pu380AfLMInzuQBrvEQrjR52z4gGmC1kO4AcK89l/JO?= =?us-ascii?Q?/i/wlq5p/YYVpbSKMDDVdBSrSGCgHP6QitnFjEVJivOkKH2YU/eVAvd5IO6r?= =?us-ascii?Q?UkETHYYX9Zz26ZXWooe2LGFexoa4Pq+xIns7KtCxrpdDNE9sKZL8aendCgkB?= =?us-ascii?Q?IRYAKGy6miYeE5XBsmyKtV7LTuwhoVUnnW5L858gkRBZFqzuZ4p4uJ7gEMdm?= =?us-ascii?Q?Z+YOazxRgijStW7Mwz804JpdNyEi3OZ4M8YPjeEWpwpncNjHcRJZT1wlBZTI?= =?us-ascii?Q?8t5YY3I3sElcsTFlrtu0+hNN0nIOfHGCRLcs2XwgNrHWbJMWdCsBbjDjj1ym?= =?us-ascii?Q?8Fu1FS1ZyQ1TwbOV0Q/yIwqETEoc2xpc1yDIz1mGVOiEH/Bu6jxFxlO+udD7?= =?us-ascii?Q?qlSCHeqeFVMHCMky1POvGYLt6f3ryXvJKPXTKaAdBzs/2D+8TqOfmRS4i9/h?= =?us-ascii?Q?b5+Tt1AOM2OQoaKE64s8YxXcaAT/YSFULc60PsvHp61uxu4evUSdDFnWmdOX?= =?us-ascii?Q?TBhiA3zUEwScUOJ9m49vzMhNyNA=3D?= X-Forefront-Antispam-Report: CIP:198.47.21.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet200.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(82310400026)(7416014)(376014)(921020);DIR:OUT;SFP:1101; X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2026 08:51:18.1648 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cbe7fa00-a5cd-43b8-976d-08de5d813ca1 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.194];Helo=[flwvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE37.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB7248 Content-Type: text/plain; charset="utf-8" The resizable BAR support added by the commit 3a3d4cabe681 ("PCI: dwc: ep: Allow EPF drivers to configure the size of Resizable BARs") incorrectly configures the resizable BARs only for the first Physical Function (PF0) in EP mode. The resizable BAR configuration functions use generic dw_pcie_*_dbi operations instead of physical function specific dw_pcie_ep_*_dbi operations. This causes resizable BAR configuration to always target PF0 regardless of the requested function number. Additionally, dw_pcie_ep_init_non_sticky_registers() only initializes resizable BAR registers for PF0, leaving other PFs unconfigured during the execution of this function. Fix this by using physical function specific configuration space access operations throughout the resizable BAR code path and initializing registers for all the physical functions that support resizable BARs. Fixes: 3a3d4cabe681 ("PCI: dwc: ep: Allow EPF drivers to configure the size= of Resizable BARs") Signed-off-by: Aksh Garg Reviewed-by: Niklas Cassel --- Changes from v2 to v3: - Changed function name from __dw_pcie_ep_init_non_sticky_registers() to dw_pcie_ep_init_rebar_registers() Changes from v1 to v2: - Fixed the suggested nit v2: https://lore.kernel.org/all/20260122082538.309122-2-a-garg7@ti.com/ v1: https://lore.kernel.org/all/20260121054214.274429-2-a-garg7@ti.com/ .../pci/controller/dwc/pcie-designware-ep.c | 48 ++++++++++++------- 1 file changed, 32 insertions(+), 16 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/= controller/dwc/pcie-designware-ep.c index 19571ac2b961..659a56aa8664 100644 --- a/drivers/pci/controller/dwc/pcie-designware-ep.c +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c @@ -75,6 +75,13 @@ static u8 dw_pcie_ep_find_capability(struct dw_pcie_ep *= ep, u8 func_no, u8 cap) cap, ep, func_no); } =20 +static u16 dw_pcie_ep_find_ext_capability(struct dw_pcie_ep *ep, + u8 func_no, u8 cap) +{ + return PCI_FIND_NEXT_EXT_CAP(dw_pcie_ep_read_cfg, 0, + cap, ep, func_no); +} + /** * dw_pcie_ep_hide_ext_capability - Hide a capability from the linked list * @pci: DWC PCI device @@ -217,22 +224,22 @@ static void dw_pcie_ep_clear_bar(struct pci_epc *epc,= u8 func_no, u8 vfunc_no, ep->bar_to_atu[bar] =3D 0; } =20 -static unsigned int dw_pcie_ep_get_rebar_offset(struct dw_pcie *pci, +static unsigned int dw_pcie_ep_get_rebar_offset(struct dw_pcie_ep *ep, u8 = func_no, enum pci_barno bar) { u32 reg, bar_index; unsigned int offset, nbars; int i; =20 - offset =3D dw_pcie_find_ext_capability(pci, PCI_EXT_CAP_ID_REBAR); + offset =3D dw_pcie_ep_find_ext_capability(ep, func_no, PCI_EXT_CAP_ID_REB= AR); if (!offset) return offset; =20 - reg =3D dw_pcie_readl_dbi(pci, offset + PCI_REBAR_CTRL); + reg =3D dw_pcie_ep_readl_dbi(ep, func_no, offset + PCI_REBAR_CTRL); nbars =3D FIELD_GET(PCI_REBAR_CTRL_NBAR_MASK, reg); =20 for (i =3D 0; i < nbars; i++, offset +=3D PCI_REBAR_CTRL) { - reg =3D dw_pcie_readl_dbi(pci, offset + PCI_REBAR_CTRL); + reg =3D dw_pcie_ep_readl_dbi(ep, func_no, offset + PCI_REBAR_CTRL); bar_index =3D FIELD_GET(PCI_REBAR_CTRL_BAR_IDX, reg); if (bar_index =3D=3D bar) return offset; @@ -253,7 +260,7 @@ static int dw_pcie_ep_set_bar_resizable(struct dw_pcie_= ep *ep, u8 func_no, u32 rebar_cap, rebar_ctrl; int ret; =20 - rebar_offset =3D dw_pcie_ep_get_rebar_offset(pci, bar); + rebar_offset =3D dw_pcie_ep_get_rebar_offset(ep, func_no, bar); if (!rebar_offset) return -EINVAL; =20 @@ -283,16 +290,16 @@ static int dw_pcie_ep_set_bar_resizable(struct dw_pci= e_ep *ep, u8 func_no, * 1 MB to 128 TB. Bits 31:16 in PCI_REBAR_CTRL define "supported sizes" * bits for sizes 256 TB to 8 EB. Disallow sizes 256 TB to 8 EB. */ - rebar_ctrl =3D dw_pcie_readl_dbi(pci, rebar_offset + PCI_REBAR_CTRL); + rebar_ctrl =3D dw_pcie_ep_readl_dbi(ep, func_no, rebar_offset + PCI_REBAR= _CTRL); rebar_ctrl &=3D ~GENMASK(31, 16); - dw_pcie_writel_dbi(pci, rebar_offset + PCI_REBAR_CTRL, rebar_ctrl); + dw_pcie_ep_writel_dbi(ep, func_no, rebar_offset + PCI_REBAR_CTRL, rebar_c= trl); =20 /* * The "selected size" (bits 13:8) in PCI_REBAR_CTRL are automatically * updated when writing PCI_REBAR_CAP, see "Figure 3-26 Resizable BAR * Example for 32-bit Memory BAR0" in DWC EP databook 5.96a. */ - dw_pcie_writel_dbi(pci, rebar_offset + PCI_REBAR_CAP, rebar_cap); + dw_pcie_ep_writel_dbi(ep, func_no, rebar_offset + PCI_REBAR_CAP, rebar_ca= p); =20 dw_pcie_dbi_ro_wr_dis(pci); =20 @@ -836,20 +843,17 @@ void dw_pcie_ep_deinit(struct dw_pcie_ep *ep) } EXPORT_SYMBOL_GPL(dw_pcie_ep_deinit); =20 -static void dw_pcie_ep_init_non_sticky_registers(struct dw_pcie *pci) +static void dw_pcie_ep_init_rebar_registers(struct dw_pcie_ep *ep, u8 func= _no) { - struct dw_pcie_ep *ep =3D &pci->ep; unsigned int offset; unsigned int nbars; enum pci_barno bar; u32 reg, i, val; =20 - offset =3D dw_pcie_find_ext_capability(pci, PCI_EXT_CAP_ID_REBAR); - - dw_pcie_dbi_ro_wr_en(pci); + offset =3D dw_pcie_ep_find_ext_capability(ep, func_no, PCI_EXT_CAP_ID_REB= AR); =20 if (offset) { - reg =3D dw_pcie_readl_dbi(pci, offset + PCI_REBAR_CTRL); + reg =3D dw_pcie_ep_readl_dbi(ep, func_no, offset + PCI_REBAR_CTRL); nbars =3D FIELD_GET(PCI_REBAR_CTRL_NBAR_MASK, reg); =20 /* @@ -870,16 +874,28 @@ static void dw_pcie_ep_init_non_sticky_registers(stru= ct dw_pcie *pci) * the controller when RESBAR_CAP_REG is written, which * is why RESBAR_CAP_REG is written here. */ - val =3D dw_pcie_readl_dbi(pci, offset + PCI_REBAR_CTRL); + val =3D dw_pcie_ep_readl_dbi(ep, func_no, offset + PCI_REBAR_CTRL); bar =3D FIELD_GET(PCI_REBAR_CTRL_BAR_IDX, val); if (ep->epf_bar[bar]) pci_epc_bar_size_to_rebar_cap(ep->epf_bar[bar]->size, &val); else val =3D BIT(4); =20 - dw_pcie_writel_dbi(pci, offset + PCI_REBAR_CAP, val); + dw_pcie_ep_writel_dbi(ep, func_no, offset + PCI_REBAR_CAP, val); } } +} + +static void dw_pcie_ep_init_non_sticky_registers(struct dw_pcie *pci) +{ + struct dw_pcie_ep *ep =3D &pci->ep; + u8 funcs =3D ep->epc->max_functions; + u8 func_no; + + dw_pcie_dbi_ro_wr_en(pci); + + for (func_no =3D 0; func_no < funcs; func_no++) + dw_pcie_ep_init_rebar_registers(ep, func_no); =20 dw_pcie_setup(pci); dw_pcie_dbi_ro_wr_dis(pci); --=20 2.34.1 From nobody Sun Feb 8 05:29:48 2026 Received: from CY7PR03CU001.outbound.protection.outlook.com (mail-westcentralusazon11010050.outbound.protection.outlook.com [40.93.198.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FED5149C6F; Tue, 27 Jan 2026 08:51:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.198.50 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769503867; cv=fail; b=hZlNfLX4kaYlowmVpmXYNSXvQXw3pxuIxIJIDh2NNYof2pIFPBLb4fdMb7Rjgt74uDrhA3nxQKMPCYZnVKQfMevZ/PSECFT3I/Rdgb3YXZHxrW3VCT5XcYy/k9Cd6+GlKJDH2Lm5glKkGR3P12biDpwFNNmMBrnfrx/FLAxo1Ng= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769503867; c=relaxed/simple; bh=reKsKUFRB2d1GObq2e/ty+SlMcR24bCrlDxc/8xVpPI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=RVcciDbK42hBoZb/B46qHNzF60ijYSRtbBfH9VwEmDFvx1MYGBBAy6r0P3jCVJ4j5DGxg4NgcJa5Dc7MIvVqNy6wPP6fGf/KGV6A82xDxWEj8RibDnTj+I7FdO0Ofxg1yfkc+0GuWuIwQiUiWq+BNSt0ql3qs0BaKLCI+KoGp0o= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=haOwNCKf; arc=fail smtp.client-ip=40.93.198.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="haOwNCKf" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=A0LNKzDM3qYwzOTaj5zLCd6jTxTQBSQTXwWXYXENdb0u/QH1u7DVmmtCArpcrTtS48ldDjDs5ltjm2f1cAmFxNPfFn/CV+l+5k4FkiaiGMZhYXZoSY6VY81xGjzi8tkNOoh7PE6pfM3HNSxlyKeA6JVm8NbzYl99FqILDbhO4On6avuMl5WjHpmYXUxFNkThdebVlYuvqf5kNKNaDL1+6o+/YQOiZqDD6zjr/q0cOpn3nZPMVqFTK2z+qduHs6FijbBbUhud5+UMiIT2aim08tGoTRskyqOipMLU6k14u3kkyNg3aX11TDfyqZCRjaasx6vVAXU7KvZ52FurXKUgow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VDj+OFkOUJWwBJSdeRSBvamqqgkd3gz5rWH7zUC4Iwc=; b=tynjJbJlSLB0Ki/7HgDR5d7tjIKWKaA2ELRJD0BKDEtONouEabQN9emfPl5Brpq0NedSfSnU+aBOT6VYcGapW5w6gFjpGZVdiwi2kTopl3EGrAS106QYm5qeG/OlA/+qe1y4Ip9bVGwChTddywEE3ZRLnUhD8p03XQb6XWoRAOqkaTzcfMKckqZyanfv+YpcZbxD8geqRVPvnkrrhsZpIBDbW78fpE1Aou7Nxx44YiZdHUPFpSXjFiSCgRyj1esabyWLQNkj7abLwmrFHXwwQOfhx+Sd1JhG8lTLr99y9b75nxMtNdznPTVFXq4XAbMd69P9JmlGu6zSBlYw0elqzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.195) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VDj+OFkOUJWwBJSdeRSBvamqqgkd3gz5rWH7zUC4Iwc=; b=haOwNCKfXFt9xU+I+JeL7vZ2uv0Zxgl/otzWK86jEsCVMJcU5OK6vNTAcSgwYwTdpR9VON3Z4/0srgcxPaxs6aF15rUrSyst0vZX0FQIJ2G7TVTEdkr49nZsfv0v5veP8N2KnRc0Pqakmp9pkAwdiOBdK1ZCCAeOQcUx++A07/s= Received: from CH0PR07CA0027.namprd07.prod.outlook.com (2603:10b6:610:32::32) by SJ0PR10MB5694.namprd10.prod.outlook.com (2603:10b6:a03:3ed::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9542.15; Tue, 27 Jan 2026 08:51:02 +0000 Received: from DS2PEPF00003448.namprd04.prod.outlook.com (2603:10b6:610:32:cafe::92) by CH0PR07CA0027.outlook.office365.com (2603:10b6:610:32::32) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9564.7 via Frontend Transport; Tue, 27 Jan 2026 08:51:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C Received: from lewvzet201.ext.ti.com (198.47.23.195) by DS2PEPF00003448.mail.protection.outlook.com (10.167.17.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9564.3 via Frontend Transport; Tue, 27 Jan 2026 08:51:01 +0000 Received: from DLEE208.ent.ti.com (157.170.170.97) by lewvzet201.ext.ti.com (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 27 Jan 2026 02:51:01 -0600 Received: from DLEE204.ent.ti.com (157.170.170.84) by DLEE208.ent.ti.com (157.170.170.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 27 Jan 2026 02:51:00 -0600 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE204.ent.ti.com (157.170.170.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Tue, 27 Jan 2026 02:51:00 -0600 Received: from a0507033-hp.dhcp.ti.com (a0507033-hp.dhcp.ti.com [172.24.231.225]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 60R8ol4e4071462; Tue, 27 Jan 2026 02:50:56 -0600 From: Aksh Garg To: , , , , , , , , , , CC: , , , Aksh Garg Subject: [PATCH v3 2/3] PCI: dwc: ep: Add per-PF BAR and inbound ATU mapping support Date: Tue, 27 Jan 2026 14:20:09 +0530 Message-ID: <20260127085010.446116-3-a-garg7@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260127085010.446116-1-a-garg7@ti.com> References: <20260127085010.446116-1-a-garg7@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PEPF00003448:EE_|SJ0PR10MB5694:EE_ X-MS-Office365-Filtering-Correlation-Id: 9fbfa8a9-e5a2-4075-e049-08de5d8132ba X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|82310400026|7416014|376014|921020; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?tPnZDPxI0XE9ynQ65Jhoatleyv0QCISsOm7jnebdIowH7n2TYbDbcqoWPWWs?= =?us-ascii?Q?2RCFsiEW7UTPkit0ChHErlVo3yO83clVisrhswpp+KgSaPKZefLnLvA+2rHr?= =?us-ascii?Q?GmGnY4ouENUmosjaSO8o8k9fRZVOdbEvNTx+cItQIRs3PfNV2Fbc5neKgit0?= =?us-ascii?Q?kjtrxZ0YQxYMQie4Zxx1fuck+4Cy5PI32pHDkOr0LwiGXy/rRO37JRHFdy6Y?= =?us-ascii?Q?El+Gmd1QI00kpm1lhhl/nKxGS5jekEgsi5ZJyAQrbN6JO9I+VffIQxf1RoP1?= =?us-ascii?Q?kOwwXIOJ4eofMobomzhAvZDIBZRAeIPxe2r/+TU1STY/5hHkh9/gwdprOFnE?= =?us-ascii?Q?s90y3z6wiC5YUyrkkV+dhkC6Gd6aG+QCppp08FJyqd/1ghSaQYpKkPARR0M+?= =?us-ascii?Q?b3NsaEWLs+0i5zN7RxNaSUEAqK6Q21ihNyjNwNBBjCNy4GrbcDpEvjTykMoN?= =?us-ascii?Q?lIngG22V8b+zod3jE2jaUDQxxkTUUp4JibYHRmKFAQ728z4bX9/AqMOBpGGq?= =?us-ascii?Q?yw+6fNt7/O2I6Etn3O0Eh/zcFquSZFs/Unbi9/U0hQklHhUGfIEyLSxT3tu1?= =?us-ascii?Q?TAYb5dzJ0PwS+keFo+sGhU63i3+9Hkb3zh25ztB4MFus4dwWKsZxO2Y+fjID?= =?us-ascii?Q?BRcZc3hahsoaC/iQ/bQUlkPLXF2CND54bQZjtbN5270z5I7QizXDH5iEO8NI?= =?us-ascii?Q?rI7VE3hRDygq7c6cOps9ZyLiTa6Gsag8ZHzN/fJvPLPXVbH6VKcmwwjDmtBi?= =?us-ascii?Q?hBDcGZ1cCcyFh/RHjRQS/Ab3G4T3+GVZg0M6zfK7qGiJ3QM0LeiOu58PCOau?= =?us-ascii?Q?GYglFrplGX9E25ZftVdCBZBItz9Bkzr/kvo8bpc8sLo6YjXbNgbUYEuwRMGZ?= =?us-ascii?Q?qHvRhZIKWhIrGDW+wq1YT+eXbGiDLFw3fWnQ0QUlwyqzG5faBbhEP0f1xEGY?= =?us-ascii?Q?EwMIYARILIUa6bD6/rsodaI6XgKkxAnXvtVWD2i88OZLjhC2691+8Jiho6qW?= =?us-ascii?Q?ErKi32VB9LU7Ms1cXSfor1PlzRiANdjC36N8rz5iIHRvpnISt2OKjeKbuUdN?= =?us-ascii?Q?2s35NAe8P8h4RURSawsoIaiME1TNDXJX/ihlnQqonH3H2T7NRHnPldVtMTiV?= =?us-ascii?Q?GpgMSiXV6BclWQhgHojn654xfNF9gC/cYr0OhvuXQuNr8JMz28mEHf9RE/W3?= =?us-ascii?Q?rE2eXSMCcluw8st1aJ5ZzAvr1BaYF26IkmQvs5jpzkZytPw9vv9Jx46HK/ia?= =?us-ascii?Q?Kg9o761hNiUmjcDGg6eTpdEloMj+29L5d7bpA/xrAQrqX9Dfa33Aljh4zZ7m?= =?us-ascii?Q?3Cr0wbXuRuetVX3bf0glpP1dPTXbJeqoflePmgLFSWBu2i/ERowUsSH/VKTL?= =?us-ascii?Q?gNuUvPilfooF4USdv8f10bAQGEB69o5tSi5H17wW1danshgc4AjCz+RpItD8?= =?us-ascii?Q?EftjzIkqXflHoMpaEB9i9fHJ5nQHoTaaCxXDabZYPGfKsZH2kknggBASVrhb?= =?us-ascii?Q?v5eEKRbTuQcDqueSaUiRiXpEyRcATbUAqVFfY4ySjmmkdnePq6GYXr4l8flJ?= =?us-ascii?Q?x/dcvur75wC/LcR7olSmzT/Uz1yPWOKRtlcZ3dp6UTOABvNhUVtMvrqAuJ5w?= =?us-ascii?Q?Vva/nsx+8uKpH65O2lu50Csdi9ypWjwgOenu464Zadjn5KB8RseUEm7lo34o?= =?us-ascii?Q?KMAHPOlazAW1s1i4U66oyxKT+zA=3D?= X-Forefront-Antispam-Report: CIP:198.47.23.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet201.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(82310400026)(7416014)(376014)(921020);DIR:OUT;SFP:1101; X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2026 08:51:01.5420 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9fbfa8a9-e5a2-4075-e049-08de5d8132ba X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.195];Helo=[lewvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: DS2PEPF00003448.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5694 Content-Type: text/plain; charset="utf-8" The commit 24ede430fa49 ("PCI: designware-ep: Add multiple PFs support for DWC") added support for multiple PFs in the DWC driver, but the implementation was incomplete. It did not properly support MSI/MSI-X, as well as BAR and inbound ATU mapping for multiple PFs. The MSI/MSI-X issue was later fixed by commit 47a062609a30 ("PCI: designware-ep: Modify MSI and MSIX CAP way of finding") by introducing a per-PF struct dw_pcie_ep_func. However, even with both commits, the multiple PF support in the driver remains broken because BAR configuration and ATU mappings are managed globally in struct dw_pcie_ep, meaning all PFs share the same BAR-to-ATU mapping table. This causes one PF's EPF to overwrite the address translation of another PF's EPF in the internal ATU region, creating conflicts when multiple physical functions attempt to configure their BARs independently. Fix this by moving bar_to_atu and epf_bar from struct dw_pcie_ep to struct dw_pcie_ep_func, similar to what commit 47a062609a30 ("PCI: designware-ep: Modify MSI and MSIX CAP way of finding") did for MSI/MSI-X capability support, to allow proper multi-function endpoint operation, where each PF can configure its BARs and corresponding internal ATU region without interfering with other PFs. Fixes: 24ede430fa49 ("PCI: designware-ep: Add multiple PFs support for DWC") Signed-off-by: Aksh Garg Reviewed-by: Niklas Cassel --- Changes from v2 to v3: - None Changes from v1 to v2: - Fixed the suggested nits - Rephrased the commit message with a proper Fixes tag v2: https://lore.kernel.org/all/20260122082538.309122-3-a-garg7@ti.com/ v1: https://lore.kernel.org/all/20260121054214.274429-3-a-garg7@ti.com/ .../pci/controller/dwc/pcie-designware-ep.c | 46 ++++++++++++------- drivers/pci/controller/dwc/pcie-designware.h | 4 +- 2 files changed, 31 insertions(+), 19 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/= controller/dwc/pcie-designware-ep.c index 659a56aa8664..095362143363 100644 --- a/drivers/pci/controller/dwc/pcie-designware-ep.c +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c @@ -153,11 +153,15 @@ static int dw_pcie_ep_inbound_atu(struct dw_pcie_ep *= ep, u8 func_no, int type, int ret; u32 free_win; struct dw_pcie *pci =3D to_dw_pcie_from_ep(ep); + struct dw_pcie_ep_func *ep_func =3D dw_pcie_ep_get_func_from_ep(ep, func_= no); =20 - if (!ep->bar_to_atu[bar]) + if (!ep_func) + return -EINVAL; + + if (!ep_func->bar_to_atu[bar]) free_win =3D find_first_zero_bit(ep->ib_window_map, pci->num_ib_windows); else - free_win =3D ep->bar_to_atu[bar] - 1; + free_win =3D ep_func->bar_to_atu[bar] - 1; =20 if (free_win >=3D pci->num_ib_windows) { dev_err(pci->dev, "No free inbound window\n"); @@ -175,7 +179,7 @@ static int dw_pcie_ep_inbound_atu(struct dw_pcie_ep *ep= , u8 func_no, int type, * Always increment free_win before assignment, since value 0 is used to = identify * unallocated mapping. */ - ep->bar_to_atu[bar] =3D free_win + 1; + ep_func->bar_to_atu[bar] =3D free_win + 1; set_bit(free_win, ep->ib_window_map); =20 return 0; @@ -211,17 +215,18 @@ static void dw_pcie_ep_clear_bar(struct pci_epc *epc,= u8 func_no, u8 vfunc_no, struct dw_pcie_ep *ep =3D epc_get_drvdata(epc); struct dw_pcie *pci =3D to_dw_pcie_from_ep(ep); enum pci_barno bar =3D epf_bar->barno; - u32 atu_index =3D ep->bar_to_atu[bar] - 1; + struct dw_pcie_ep_func *ep_func =3D dw_pcie_ep_get_func_from_ep(ep, func_= no); + u32 atu_index =3D ep_func->bar_to_atu[bar] - 1; =20 - if (!ep->bar_to_atu[bar]) + if (!ep_func || !ep_func->bar_to_atu[bar]) return; =20 __dw_pcie_ep_reset_bar(pci, func_no, bar, epf_bar->flags); =20 dw_pcie_disable_atu(pci, PCIE_ATU_REGION_DIR_IB, atu_index); clear_bit(atu_index, ep->ib_window_map); - ep->epf_bar[bar] =3D NULL; - ep->bar_to_atu[bar] =3D 0; + ep_func->epf_bar[bar] =3D NULL; + ep_func->bar_to_atu[bar] =3D 0; } =20 static unsigned int dw_pcie_ep_get_rebar_offset(struct dw_pcie_ep *ep, u8 = func_no, @@ -348,12 +353,16 @@ static int dw_pcie_ep_set_bar(struct pci_epc *epc, u8= func_no, u8 vfunc_no, { struct dw_pcie_ep *ep =3D epc_get_drvdata(epc); struct dw_pcie *pci =3D to_dw_pcie_from_ep(ep); + struct dw_pcie_ep_func *ep_func =3D dw_pcie_ep_get_func_from_ep(ep, func_= no); enum pci_barno bar =3D epf_bar->barno; size_t size =3D epf_bar->size; enum pci_epc_bar_type bar_type; int flags =3D epf_bar->flags; int ret, type; =20 + if (!ep_func) + return -EINVAL; + /* * DWC does not allow BAR pairs to overlap, e.g. you cannot combine BARs * 1 and 2 to form a 64-bit BAR. @@ -367,14 +376,14 @@ static int dw_pcie_ep_set_bar(struct pci_epc *epc, u8= func_no, u8 vfunc_no, * calling clear_bar() would clear the BAR's PCI address assigned by the * host). */ - if (ep->epf_bar[bar]) { + if (ep_func->epf_bar[bar]) { /* * We can only dynamically change a BAR if the new BAR size and * BAR flags do not differ from the existing configuration. */ - if (ep->epf_bar[bar]->barno !=3D bar || - ep->epf_bar[bar]->size !=3D size || - ep->epf_bar[bar]->flags !=3D flags) + if (ep_func->epf_bar[bar]->barno !=3D bar || + ep_func->epf_bar[bar]->size !=3D size || + ep_func->epf_bar[bar]->flags !=3D flags) return -EINVAL; =20 /* @@ -420,7 +429,7 @@ static int dw_pcie_ep_set_bar(struct pci_epc *epc, u8 f= unc_no, u8 vfunc_no, if (ret) return ret; =20 - ep->epf_bar[bar] =3D epf_bar; + ep_func->epf_bar[bar] =3D epf_bar; =20 return 0; } @@ -782,7 +791,7 @@ int dw_pcie_ep_raise_msix_irq(struct dw_pcie_ep *ep, u8= func_no, bir =3D FIELD_GET(PCI_MSIX_TABLE_BIR, tbl_offset); tbl_offset &=3D PCI_MSIX_TABLE_OFFSET; =20 - msix_tbl =3D ep->epf_bar[bir]->addr + tbl_offset; + msix_tbl =3D ep_func->epf_bar[bir]->addr + tbl_offset; msg_addr =3D msix_tbl[(interrupt_num - 1)].msg_addr; msg_data =3D msix_tbl[(interrupt_num - 1)].msg_data; vec_ctrl =3D msix_tbl[(interrupt_num - 1)].vector_ctrl; @@ -845,11 +854,14 @@ EXPORT_SYMBOL_GPL(dw_pcie_ep_deinit); =20 static void dw_pcie_ep_init_rebar_registers(struct dw_pcie_ep *ep, u8 func= _no) { - unsigned int offset; - unsigned int nbars; + struct dw_pcie_ep_func *ep_func =3D dw_pcie_ep_get_func_from_ep(ep, func_= no); + unsigned int offset, nbars; enum pci_barno bar; u32 reg, i, val; =20 + if (!ep_func) + return; + offset =3D dw_pcie_ep_find_ext_capability(ep, func_no, PCI_EXT_CAP_ID_REB= AR); =20 if (offset) { @@ -876,8 +888,8 @@ static void dw_pcie_ep_init_rebar_registers(struct dw_p= cie_ep *ep, u8 func_no) */ val =3D dw_pcie_ep_readl_dbi(ep, func_no, offset + PCI_REBAR_CTRL); bar =3D FIELD_GET(PCI_REBAR_CTRL_BAR_IDX, val); - if (ep->epf_bar[bar]) - pci_epc_bar_size_to_rebar_cap(ep->epf_bar[bar]->size, &val); + if (ep_func->epf_bar[bar]) + pci_epc_bar_size_to_rebar_cap(ep_func->epf_bar[bar]->size, &val); else val =3D BIT(4); =20 diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/con= troller/dwc/pcie-designware.h index 31685951a080..a4d1733f5c6a 100644 --- a/drivers/pci/controller/dwc/pcie-designware.h +++ b/drivers/pci/controller/dwc/pcie-designware.h @@ -463,6 +463,8 @@ struct dw_pcie_ep_func { u8 func_no; u8 msi_cap; /* MSI capability offset */ u8 msix_cap; /* MSI-X capability offset */ + u8 bar_to_atu[PCI_STD_NUM_BARS]; + struct pci_epf_bar *epf_bar[PCI_STD_NUM_BARS]; }; =20 struct dw_pcie_ep { @@ -472,13 +474,11 @@ struct dw_pcie_ep { phys_addr_t phys_base; size_t addr_size; size_t page_size; - u8 bar_to_atu[PCI_STD_NUM_BARS]; phys_addr_t *outbound_addr; unsigned long *ib_window_map; unsigned long *ob_window_map; void __iomem *msi_mem; phys_addr_t msi_mem_phys; - struct pci_epf_bar *epf_bar[PCI_STD_NUM_BARS]; }; =20 struct dw_pcie_ops { --=20 2.34.1 From nobody Sun Feb 8 05:29:48 2026 Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazon11013019.outbound.protection.outlook.com [40.93.196.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7E0B2D374F; Tue, 27 Jan 2026 08:51:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.196.19 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769503891; cv=fail; b=uM4PU0JnjCcbHNY/vW9ahffsGok7vaiMO2opSABG87g1rMnEF3w19YLpxpXSJB8ftSz9tyfVfBiqHwwrKfhZjMtfF2EsITaQJCQiodamkB4zyX0/CKWn8WKyx1Gs+X7kCtBSZyLA//rdSFyOOgrItizXOZZ4jxR+ocNYSAGJ5Kg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769503891; c=relaxed/simple; bh=/RdyJr6MHpN9T1g6VoBVvSPQkKWbc4etgsVbn7AMkdo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=P7LzL97xM8eWeC8R/4LbSj58gT0dElWhl/adngL5VAo7HmE1PGFHjiB2KamW+TzbLzZTb0eFP72V0TWt9xBfINbCAXCxEO6pJTGtmYCWUoz2SsjQrmecsyVL+peVIBVT8x72npGoCcqkPCjIy3sEyF265VbOhRnwynJf2RATabo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=i6wcj4kk; arc=fail smtp.client-ip=40.93.196.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="i6wcj4kk" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TXjAfGmZ5NBbmEp9CggxD+fZJdHZ3ugW5Zp5S10vRjfCm5/3NBjzPBRkDueMJTrRXTzr/icsCLc+rG+/qaJ/v9c9rcPzDwsQ2272Q4RFUCAq1PjPq7ld7hwpZSwEnsXnOSueIsjNGt9UoYO7Bn3TVypUqQ6wuL4jtG6H+m5r+HhhsEF+u+y9l5G9WDmcLlPjmJe/klaOC44uNHft6ZmOxl70CNTWqVyAt0IJJ3b+n00lfesXo9bNaqaz5LVlUfzX3ZEF4kmRtyTw7LgYaLlFduwLV9B5ONV1DoJjzgEy1yYoaqSyt3NI4PCSXhrpVmOs+CPqarmlKoEZo6v7eBfPCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QVVN8qiHrgllaCb1gsvXDypnADygOJSoVVYC6lgGwaE=; b=NJPdJy6j5KNLhd/qli+7EYxSUyFOii0FmflR/a+fiQtuhgg9gAxKt2iyfKbIbodmaTNM2UQDCC/fIsUFR6d8C4ovWiFKSlfDQOL1/eOICssN5bj4x6nmRjTtJgBZoyNAPypAbZkXVaFm6cWjfuoUc5yzwcwAtCxwuHP/2gBZ8P1UA9GmnZ8g5Hni1vuBSjaYTkQzLBmvDwzpGsP3UmT4hPFQuAgHOSGGOXRsoSMEzO2vJAdanV9w41YVqtJGuDJRG/U4Ig2XLqV03wUrMUHQRF//BbyYyritPHO+0udcrknnROQdkyjrEFA+DjaRX4pmRcy7a+ZwrXswfLDad1YZmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QVVN8qiHrgllaCb1gsvXDypnADygOJSoVVYC6lgGwaE=; b=i6wcj4kksB1Y9pCuPM7ytBHuwx9Jrwldfexyd9HJdx+z68ziMmK9AuON77dpMn4JjWnhgeZ7ptUV1PFmtfruDsMz8YINNiMoUzmLyAM3VckKKsiQkmqDfG9/GQN9Jhd6FS2JtmxNACYt8I7PwloxyPM/vl2Cm1TQ6qCF+Q52NMM= Received: from DS7PR03CA0243.namprd03.prod.outlook.com (2603:10b6:5:3b3::8) by BLAPR10MB5089.namprd10.prod.outlook.com (2603:10b6:208:330::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9564.7; Tue, 27 Jan 2026 08:51:28 +0000 Received: from CY4PEPF0000EE36.namprd05.prod.outlook.com (2603:10b6:5:3b3:cafe::4b) by DS7PR03CA0243.outlook.office365.com (2603:10b6:5:3b3::8) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9542.16 via Frontend Transport; Tue, 27 Jan 2026 08:51:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.194; helo=flwvzet200.ext.ti.com; pr=C Received: from flwvzet200.ext.ti.com (198.47.21.194) by CY4PEPF0000EE36.mail.protection.outlook.com (10.167.242.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9564.3 via Frontend Transport; Tue, 27 Jan 2026 08:51:26 +0000 Received: from DFLE204.ent.ti.com (10.64.6.62) by flwvzet200.ext.ti.com (10.248.192.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 27 Jan 2026 02:51:05 -0600 Received: from DFLE215.ent.ti.com (10.64.6.73) by DFLE204.ent.ti.com (10.64.6.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 27 Jan 2026 02:51:05 -0600 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE215.ent.ti.com (10.64.6.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Tue, 27 Jan 2026 02:51:05 -0600 Received: from a0507033-hp.dhcp.ti.com (a0507033-hp.dhcp.ti.com [172.24.231.225]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 60R8ol4f4071462; Tue, 27 Jan 2026 02:51:01 -0600 From: Aksh Garg To: , , , , , , , , , , CC: , , , Aksh Garg Subject: [PATCH v3 3/3] PCI: dwc: ep: Add comment explaining controller-level PTM access Date: Tue, 27 Jan 2026 14:20:10 +0530 Message-ID: <20260127085010.446116-4-a-garg7@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260127085010.446116-1-a-garg7@ti.com> References: <20260127085010.446116-1-a-garg7@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE36:EE_|BLAPR10MB5089:EE_ X-MS-Office365-Filtering-Correlation-Id: 83a213de-8640-4fe5-e2b0-08de5d814150 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700013|376014|1800799024|7416014|921020; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?2iDipaa5aTBaesCpEWrtZewONbl55+uTSD35EMQHiufEXlRdw6iNLCwVNSAL?= =?us-ascii?Q?MO0vOE8NEqUPQ0KcEHXfghZ7VsKqAzC1EjeknHL3/JuPW3l/hVeDyPp4v0uL?= =?us-ascii?Q?9l6zfy2N5D1swWWsKpmbkp3z1PJPldQsom4Js5jCY6gYB0K39Nne9UoXRi9C?= =?us-ascii?Q?mIgO+s8yJZUtAyS2BnG6aJ5FfGeQ5o7DlGB7gCU93anitxbwRZBBhbZeh8v1?= =?us-ascii?Q?uGZtHaOymRQwPWuVU1Ua3hLyvnffLamPJs9IB/apInqcekYPFmp9/BpnAcmD?= =?us-ascii?Q?8PVaDxSPIv52D55Z3O8tGDrD203B0hgGnPir04r9Z2DhFjrfSnfya7pbcIvo?= =?us-ascii?Q?qzTTlewv3VY0DbI8yKMxJXiY0+dmdCFzX+I4XOhm50ylBENsJLTQpvfF69TS?= =?us-ascii?Q?28xu/HQF47LGFCdOQbdH343TCcxp9iRAexQiOmABtBZ5HT/PpXVWdvhR7SvR?= =?us-ascii?Q?R64BccELiK96qPaPCfgMx0IxvJEP4LBHobg36opRxVRIg2/dJYj+7IcWnVzt?= =?us-ascii?Q?ICqg9vjtPvPfGllekbgxN11+P+OmP0Jm77P9YaEPQ52QPRUujMfPUIuPGTTj?= =?us-ascii?Q?a40F+evWngupNOTzWYQh2QJ2c+piFpeBaxxuMQ5acLSYss838zrr7XpfuhNV?= =?us-ascii?Q?JGOp3PUDcok/R0h+6xJ6T3TwxXhEIii1XDoq2XRa6DAqDo8GQu1TTGaqNKLc?= =?us-ascii?Q?d/YsfRVINZ92YxQMjR4xaG5BFq29dmpr9oR1k/oq3bhVcBTJT36FR9Z0NMB8?= =?us-ascii?Q?OR6BYIS4NFE/x0BccGqdr77aM1gQ+k7m+rDA469ACtOmlIN+Gae8JWasLht2?= =?us-ascii?Q?i+hIlo30tyL/wxGG3Gent7QaWAQmpqO3si+315MFopjVrBvTcVudDK6EKkDV?= =?us-ascii?Q?oy8cCM1ICWSs6jydRZcuh8vDdNs3sf6by2xh5dsrg+Xrq2b5bSRURL2Updui?= =?us-ascii?Q?g+CtRmhS53ht+LsHPAxjRb0DFXvRwl3YrdKyMpaEzMmHohV5UsMqwSvhD4dW?= =?us-ascii?Q?VBncOvXwuNz7IsHUS0wPqI8ShpVtTUmA2jUgFDP7ymYpg7SS0UAw1OROMwAI?= =?us-ascii?Q?W+5QjIANqHD6U/eZaPY1oSaeaCunPhNZu/ZT2ZkzyjEN+QFNTbSEDQ09dw72?= =?us-ascii?Q?5bSW3SaGDf2LUVcL/pr/bKsS0Zqk1d+xf2p/NOTfUKXKlRWVUwM46qKugPdW?= =?us-ascii?Q?bczuTRtqaGle4nPiAPB0HFl+t7POc9KoLMvQwroW084OC2LtOS20lu8Gm5bZ?= =?us-ascii?Q?tNDivuxua5UTph21EaQ0aYcT6pSzTZfgM2YZOS6u9phGHvcgvVOXdxW7YI30?= =?us-ascii?Q?ovt9qvj8y2mpG66t565YYmZ3MBLhvaeLuD8aXb7d1fTz/Jpd5sVMvfWPpu+5?= =?us-ascii?Q?gMkO1V4K1S3RxrGY8MblrG3aVMpjdT7LkZ4wiZY4Vj7j5RhQBVUECNFm8zKu?= =?us-ascii?Q?GpBWQnb6w27e8n0gSpyxjWMewtVAuIuAYnSa2xab8YJxpGLpSpO60Mb0QQVO?= =?us-ascii?Q?mXkGjerjm5VZf/W6cPMdRHlNrpumuIVAngs0BUxawJR1rSek2Elua6ow4qpi?= =?us-ascii?Q?kC0fUFIRlUdb7R/9+jaBrTTozpbygVAUDUd10BA6cs9X/PTXX6KZPPDNQa5R?= =?us-ascii?Q?BitGz+93Uv3/t+PEROpnYLD7Y2Y7Y7cUXbC5nwxaPTRzgx84aHU4NACV1p/x?= =?us-ascii?Q?KpyPA3Lvoq1xmX/Wfg/zAQt+Up8=3D?= X-Forefront-Antispam-Report: CIP:198.47.21.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet200.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(82310400026)(36860700013)(376014)(1800799024)(7416014)(921020);DIR:OUT;SFP:1101; X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2026 08:51:26.0347 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 83a213de-8640-4fe5-e2b0-08de5d814150 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.194];Helo=[flwvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE36.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5089 Content-Type: text/plain; charset="utf-8" PCIe r6.0, section 7.9.15 requires PTM capability in exactly one function to control all PTM-capable functions. This makes PTM registers controller-level rather than per-function. Add a comment explaining why PTM capability registers are accessed using the standard DBI accessors instead of func_no indexed per-function accessors. Suggested-by: Niklas Cassel Signed-off-by: Aksh Garg Reviewed-by: Niklas Cassel --- Changes from v2 to v3: - Fixed the suggested nits v2: https://lore.kernel.org/all/20260122082538.309122-4-a-garg7@ti.com/ drivers/pci/controller/dwc/pcie-designware-ep.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/= controller/dwc/pcie-designware-ep.c index 095362143363..2488690f509b 100644 --- a/drivers/pci/controller/dwc/pcie-designware-ep.c +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c @@ -995,6 +995,16 @@ int dw_pcie_ep_init_registers(struct dw_pcie_ep *ep) if (ep->ops->init) ep->ops->init(ep); =20 + /* + * PCIe r6.0, section 7.9.15 states that for endpoints that support PTM, + * this capability structure is required in exactly one function, which + * controls the PTM behavior of all PTM capable functions. This indicates + * the PTM capability structure represents controller-level registers + * rather than per-function registers. + * + * Therefore, PTM capability registers are configured using the standard = DBI + * accessors, instead of func_no indexed per-function accessors. + */ ptm_cap_base =3D dw_pcie_find_ext_capability(pci, PCI_EXT_CAP_ID_PTM); =20 /* --=20 2.34.1