From nobody Mon Feb 9 04:22:32 2026 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63AB4253F11; Tue, 27 Jan 2026 08:22:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.3 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769502138; cv=none; b=YLOKw9StG5NsIKVwmgyP6DUBq6/3G/lMz+mOUHi78qpe3p13eZgmUzJMDK3ZolMsGJ/XPi5WAaz3XoGg2ZCcrnQb/GYDi24ZiBTg0jTE11fBjcns5CPekNENThwf0UHQbqBQxe5yjCZ2yYqtglJyUBssGREZSYj3BYFzMu9xKCk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769502138; c=relaxed/simple; bh=ii7k+yFRQA5XVmrgDWli8t0vbgib669xUbv2uR82EU4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Dv3dn/Y2DjY4FGIVvvdwMyebMYMvGpgLghyKkPv/6szZPDsDYVa3G6QfxtxOGL+ugBMP0fGtZevygwYa5XFNzhIUE7BbqZWYISS1DxVEZ/FRPru4PhAzU6UkBzSkT+BIHfatbDswE+ffTPYdcV5KeUgyBqEviLOZ+urxENq07Cw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=YUYtDZKX; arc=none smtp.client-ip=220.197.31.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="YUYtDZKX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=Ta DxY4ABIuPT9P92qKp0GFjidC5G/11g07EqR2xd3ao=; b=YUYtDZKXiWtp2HMXWV RC1wSSOv6oRFi8fCQsX3fKeP2dR9fOp+gTFFj7WUlXaWPy+rzOncvR8lqqkZqHqa w9jN3bORQ8nFdcF4WhvfnfIAshve522TPHu0ZEucNA3irT4KjNx8SU9i4qKgTcHu sNI2wmBXpnsVZwwTfqROWJPU8= Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g1-2 (Coremail) with SMTP id _____wDXP3iHdXhpOByCHw--.7542S3; Tue, 27 Jan 2026 16:21:35 +0800 (CST) From: zhangshida2026@163.com To: colyli@fnnas.com, kent.overstreet@linux.dev, hch@infradead.org, axboe@kernel.dk Cc: linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, zhangshida@kylinos.cn, starzhangzsd@gmail.com Subject: [PATCH v3 1/2] bcache: remove dead code in detached_dev_do_request Date: Tue, 27 Jan 2026 16:21:11 +0800 Message-Id: <20260127082112.1114158-2-zhangshida2026@163.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260127082112.1114158-1-zhangshida2026@163.com> References: <20260127082112.1114158-1-zhangshida2026@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wDXP3iHdXhpOByCHw--.7542S3 X-Coremail-Antispam: 1Uf129KBjvdXoW7JFW3Aw1rtFWkGF4DWrWUtwb_yoWfuwb_ua 1rZFn7W398Gw1ruFsFyr18ArWj93WqgF90qr4DtFyft343uwn7WryFvr15t3yrur4xCF4x Jw15Gw15CryvkjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUYYzutUUUUU== X-CM-SenderInfo: x2kd0wxvklvtasqslqqrwthudrp/xtbCvw-4BWl4dY9ClgAA3y Content-Type: text/plain; charset="utf-8" From: Shida Zhang bio_alloc_clone() with GFP_NOIO and a mempool will not return NULL. Remove the unnecessary NULL check. Suggested-by: Christoph Hellwig Signed-off-by: Shida Zhang Reviewed-by: Christoph Hellwig --- drivers/md/bcache/request.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c index a02aecac05c..c2f38907a2a 100644 --- a/drivers/md/bcache/request.c +++ b/drivers/md/bcache/request.c @@ -1113,11 +1113,6 @@ static void detached_dev_do_request(struct bcache_de= vice *d, =20 clone_bio =3D bio_alloc_clone(dc->bdev, orig_bio, GFP_NOIO, &d->bio_detached); - if (!clone_bio) { - orig_bio->bi_status =3D BLK_STS_RESOURCE; - bio_endio(orig_bio); - return; - } =20 ddip =3D container_of(clone_bio, struct detached_dev_io_private, bio); /* Count on the bcache device */ --=20 2.34.1 From nobody Mon Feb 9 04:22:32 2026 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02F5525A2A4; Tue, 27 Jan 2026 08:22:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.2 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769502139; cv=none; b=lGBW20tGYDKqJsCp2oTyMi+SHG0ETgwVhmYgO04zgp3G9mdibB7E7mro7Xi4Bej6aVQN0dlPuktBH+nHJ+M1YmXls9/4DMbZd0n9dYjVaLMgYLVD2NlptT9NCqKYxKM17FQ0lr1HaNDHE/mQXIh/zxrgaYzwiOP95XC2+pfD830= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769502139; c=relaxed/simple; bh=57FZHE6FXv3qPQV9Kd9KgcwxBZWdSS6+PiWfE6PR3s4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=gNwlqV17adkZXIucH7Ym/a4MiyVlp2TYFsKIaxmCHIz59WYrUhcj4tfHwTtJG8BcGFYESJRpm6XF3pCMpTemQgKhv+8sZEMLJIBr0ubeZYlreJobjucNF5jDFeTrD//fPwdGI9fWSjTru3e2kjyocQ0EL7DgRAVv2Ognzb2wBaU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=WS8SqQNX; arc=none smtp.client-ip=220.197.31.2 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="WS8SqQNX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=bl kronDHXEpGjIL9Br1BlfqkPGldSBTPUEtaG3YoxMQ=; b=WS8SqQNXLOP2ntlwbt pssiVorXoHfomqAC/RREPxhWJAfo9L2Lu1kbyt0/Etq5193PVFRTnygKhMFtv2q2 o/YtgcHR/39SA5/IrNfVQEDe9WOSHVl+LG/Blv3NUlTHAwRChxqUWn+DtNpWzlZn 5/lpMS+yZeSti9FfVhcAZM640= Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g1-2 (Coremail) with SMTP id _____wDXP3iHdXhpOByCHw--.7542S4; Tue, 27 Jan 2026 16:21:37 +0800 (CST) From: zhangshida2026@163.com To: colyli@fnnas.com, kent.overstreet@linux.dev, hch@infradead.org, axboe@kernel.dk Cc: linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, zhangshida@kylinos.cn, starzhangzsd@gmail.com Subject: [PATCH v3 2/2] bcache: fix I/O accounting leak in detached_dev_do_request Date: Tue, 27 Jan 2026 16:21:12 +0800 Message-Id: <20260127082112.1114158-3-zhangshida2026@163.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260127082112.1114158-1-zhangshida2026@163.com> References: <20260127082112.1114158-1-zhangshida2026@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wDXP3iHdXhpOByCHw--.7542S4 X-Coremail-Antispam: 1Uf129KBjvdXoW7GFyUXr47WFy3GFW5Gw1UAwb_yoWDXFc_G3 WfuF92grZ8Cr1v9F4ayr1fZr4jga1DZFyrKF4vgr1fJw43uwnFgFWFvryDKFyxua18uF4x Aws3Ww1rAwnYkjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUYowZ7UUUUU== X-CM-SenderInfo: x2kd0wxvklvtasqslqqrwthudrp/xtbC6BH5Bml4dZGH2AAA3s Content-Type: text/plain; charset="utf-8" From: Shida Zhang When a bcache device is detached, discard requests are completed immediately. However, the I/O accounting started in cached_dev_make_request() is not ended, leading to 100% disk utilization reports in iostat. Add the missing bio_end_io_acct() call. Fixes: cafe56359144 ("bcache: A block layer cache") Signed-off-by: Shida Zhang Acked-by: Coly Li Reviewed-by: Christoph Hellwig --- drivers/md/bcache/request.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c index c2f38907a2a..3fa3b13a410 100644 --- a/drivers/md/bcache/request.c +++ b/drivers/md/bcache/request.c @@ -1107,6 +1107,7 @@ static void detached_dev_do_request(struct bcache_dev= ice *d, =20 if (bio_op(orig_bio) =3D=3D REQ_OP_DISCARD && !bdev_max_discard_sectors(dc->bdev)) { + bio_end_io_acct(orig_bio, start_time); bio_endio(orig_bio); return; } --=20 2.34.1