From nobody Sat Feb 7 06:55:16 2026 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6257E26D4DF for ; Tue, 27 Jan 2026 07:34:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769499255; cv=none; b=oVNeFtJG518MSudTXF9MI4KDPL6zOPd6gq/1gJgbM2JIlW+SVf1wGL2MdKeksIy7arMuPbXbMbsHEHOWMZuqwNj+dGzWT1toS06sY4QDBZMSQGImO+XYKFPYegtfK6n7WjQfIXDPvJyyDN4fD0jsi1oGySniH44i1huvyij+qX4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769499255; c=relaxed/simple; bh=9NLZRgwcvV7vzeoUJvZKI0Z59eH2ErVcfn9JkfFxGdo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=BL5Ng3tZG0G4Epw9BFo/le8VtGnqUZhc98BRKvqDNAsZntG0gtzS26l039MwJNw4mNf6f7Ine22ExNvgq5ZWNQNs4HcRZ3cGTJmcTkArKwfSmoSkVGl1TYE6OMIuRDDKgGQotM+cKirCjQ9gkCr6iEmWc9xw2gWD7lndx6xvLnQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=CY5OXmSd; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="CY5OXmSd" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-8231061d234so4451404b3a.1 for ; Mon, 26 Jan 2026 23:34:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1769499253; x=1770104053; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=MO/xBk1Z9Sg2T5LDtUgXSRnpiqznRJUad1HNlKnWIEg=; b=CY5OXmSdEiEPf5/upIrSH9qbp2SqkcRlTA9gMLnirnyW/cgSTTqRkx6uuY9SUOiZ38 YMiKU8kBUc5bh+C+CYG/JkKRm+Yds8Ns+zYRpLexGljOr+caKaa1gzh5mYAoCr8nYU5G jzwNtdCsq1TYCow1zTItWoS5KnC+gRJ04EIg0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769499253; x=1770104053; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MO/xBk1Z9Sg2T5LDtUgXSRnpiqznRJUad1HNlKnWIEg=; b=a4B1K673VF/fMB8nXReF5PFZUFhF+nYVMY8eq3JTBDk4Nq5q2AQyN59Dsy65f87b5E VRDZr4hMlNYCZGf8ecSZc0ChvFnD79kKt/x73i1bNlj7XIJMM0kERLDv3ZUMv2qZbv8z f2IUYx3SRWsg1qQfZf2ejPl8Mmd8cjEyyYjfUdoAFNLuU6/u9j/sWWAXfalrHBDhRG7n bCFMSryM9GnEoybgPV7bs7764FL7A46TUGsfyzl+6/hd97KhJjdyQU7VZgqwqx7w1lzH xZFz/KudTG3uvQWPpi6zRsbanuOaZZxGcleoBAB+gtVJBcwT3zlIDJp1CQv+L18xLecr Sxkw== X-Forwarded-Encrypted: i=1; AJvYcCX/i/pRbsIUj7ZwUPPLKIynb9nfO7oVDCg9D9TsB/dM7Q2nAGqp6mdI0YagE7gcCPCE65L1SKl/GUVV+HE=@vger.kernel.org X-Gm-Message-State: AOJu0YzNau89sz5k7u1IZAkq21qNv3RswcVrt8yDassr2FOs/YtpHzrL I21TKmxQiLHDum/oqsVoDFsHD/qfVREpKJP9R0jE6OtQOjz/gA/jLv5oxHldxGG4Lg== X-Gm-Gg: AZuq6aItgenD3ycXF8KZqtDEXMMBEHBQScqD0puyJN2EYeiAA0kjCEI/R1jt5fKMacP X1oURBJhuOOh70bVQ2suk7n3gaWXTF0HWqOzcxtFgg7rA2aPStpopDyUvxmyL4evh/WmY5GO24r Mukedn1oL2RcwLXK1OH1nwF1eGdBDtomUNG6NwFXoy6DgI/sHpoJadZMvyGS39uMAoiZ1cYPOvv HMaVin+V5QEejWoI+qAVpwxJVideR6HINC4/MJ8311RsIoCohPWfgiLtuhqqWfX0tGAoQpX1OLX FikQMrjbIuVusOZZxZz0HtFmTi4gCMj1ha6RPVZ9Gqny1U1uE3C0jjfsuPtRyGZYYSf2zXlhCEV BO6nnBaYDLaQqHb1/aDI+zPXHb6Q5C/v9tT04wB0QMoATqyBRkw7CG3jA7IU62OE7kUeYR4gi2/ un5IXphPNFLl8lUk+aFqOJ8GhnrFbMIl8OxMHWdAQIj+Xt1jd/mmuddKbIbG2cC7BfsMraEFo5K Q== X-Received: by 2002:a05:6a00:1c99:b0:81f:521c:b640 with SMTP id d2e1a72fcca58-823692e6deamr973608b3a.55.1769499251997; Mon, 26 Jan 2026 23:34:11 -0800 (PST) Received: from tigerii.tok.corp.google.com ([2a00:79e0:2031:6:d089:781c:105e:9178]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8231876e718sm11232295b3a.62.2026.01.26.23.34.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jan 2026 23:34:11 -0800 (PST) From: Sergey Senozhatsky To: Rob Clark Cc: Sean Paul , Konrad Dybcio , Akhil P Oommen , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky , Tomasz Figa Subject: [RFC PATCH] drm: gpu: msm: forbid mem reclaim from reset Date: Tue, 27 Jan 2026 16:33:34 +0900 Message-ID: <20260127073341.2862078-1-senozhatsky@chromium.org> X-Mailer: git-send-email 2.53.0.rc1.217.geba53bf80e-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" We sometimes get into a situtation where GPU hangcheck fails to recover GPU: [..] msm_dpu ae01000.display-controller: [drm:hangcheck_handler] *ERROR* (IPv4: = 1): hangcheck detected gpu lockup rb 0! msm_dpu ae01000.display-controller: [drm:hangcheck_handler] *ERROR* (IPv4: = 1): completed fence: 7840161 msm_dpu ae01000.display-controller: [drm:hangcheck_handler] *ERROR* (IPv4: = 1): submitted fence: 7840162 msm_dpu ae01000.display-controller: [drm:hangcheck_handler] *ERROR* (IPv4: = 1): hangcheck detected gpu lockup rb 0! msm_dpu ae01000.display-controller: [drm:hangcheck_handler] *ERROR* (IPv4: = 1): completed fence: 7840162 msm_dpu ae01000.display-controller: [drm:hangcheck_handler] *ERROR* (IPv4: = 1): submitted fence: 7840163 [..] The problem is that msm_job worker is blocked on gpu->lock INFO: task ring0:155 blocked for more than 122 seconds. Not tainted 6.6.99-08727-gaac38b365d2c #1 task:ring0 state:D stack:0 pid:155 ppid:2 flags:0x00000008 Call trace: __switch_to+0x108/0x208 schedule+0x544/0x11f0 schedule_preempt_disabled+0x30/0x50 __mutex_lock_common+0x410/0x850 __mutex_lock_slowpath+0x28/0x40 mutex_lock+0x5c/0x90 msm_job_run+0x9c/0x140 drm_sched_main+0x514/0x938 kthread+0x114/0x138 ret_from_fork+0x10/0x20 which is owned by recover worker, which is waiting for DMA fences from a memory reclaim path, under the very same gpu->lock INFO: task ring0:155 is blocked on a mutex likely owned by task gpu-worker:= 154. task:gpu-worker state:D stack:0 pid:154 ppid:2 flags:0x00000008 Call trace: __switch_to+0x108/0x208 schedule+0x544/0x11f0 schedule_timeout+0x1f8/0x770 dma_fence_default_wait+0x108/0x218 dma_fence_wait_timeout+0x6c/0x1c0 dma_resv_wait_timeout+0xe4/0x118 active_purge+0x34/0x98 drm_gem_lru_scan+0x1d0/0x388 msm_gem_shrinker_scan+0x1cc/0x2e8 shrink_slab+0x228/0x478 shrink_node+0x380/0x730 try_to_free_pages+0x204/0x510 __alloc_pages_direct_reclaim+0x90/0x158 __alloc_pages_slowpath+0x1d4/0x4a0 __alloc_pages+0x9f0/0xc88 vm_area_alloc_pages+0x17c/0x260 __vmalloc_node_range+0x1c0/0x420 kvmalloc_node+0xe8/0x108 msm_gpu_crashstate_capture+0x1e4/0x280 recover_worker+0x1c0/0x638 kthread_worker_fn+0x150/0x2d8 kthread+0x114/0x138 So no one can make any further progress. Forbid recover/fault worker to enter memory reclaim (under gpu->lock) to address this deadlock scenario. Cc: Tomasz Figa Signed-off-by: Sergey Senozhatsky --- drivers/gpu/drm/msm/msm_gpu.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c index 995549d0bbbc..ddcd9e1c217a 100644 --- a/drivers/gpu/drm/msm/msm_gpu.c +++ b/drivers/gpu/drm/msm/msm_gpu.c @@ -17,6 +17,7 @@ #include #include #include +#include =20 /* * Power Management: @@ -469,6 +470,7 @@ static void recover_worker(struct kthread_work *work) struct msm_gem_submit *submit; struct msm_ringbuffer *cur_ring =3D gpu->funcs->active_ring(gpu); char *comm =3D NULL, *cmd =3D NULL; + unsigned int noreclaim_flag; struct task_struct *task; int i; =20 @@ -506,6 +508,8 @@ static void recover_worker(struct kthread_work *work) msm_gem_vm_unusable(submit->vm); } =20 + noreclaim_flag =3D memalloc_noreclaim_save(); + get_comm_cmdline(submit, &comm, &cmd); =20 if (comm && cmd) { @@ -524,6 +528,8 @@ static void recover_worker(struct kthread_work *work) pm_runtime_get_sync(&gpu->pdev->dev); msm_gpu_crashstate_capture(gpu, submit, NULL, comm, cmd); =20 + memalloc_noreclaim_restore(noreclaim_flag); + kfree(cmd); kfree(comm); =20 @@ -588,6 +594,7 @@ void msm_gpu_fault_crashstate_capture(struct msm_gpu *g= pu, struct msm_gpu_fault_ struct msm_gem_submit *submit; struct msm_ringbuffer *cur_ring =3D gpu->funcs->active_ring(gpu); char *comm =3D NULL, *cmd =3D NULL; + unsigned int noreclaim_flag; =20 mutex_lock(&gpu->lock); =20 @@ -595,6 +602,8 @@ void msm_gpu_fault_crashstate_capture(struct msm_gpu *g= pu, struct msm_gpu_fault_ if (submit && submit->fault_dumped) goto resume_smmu; =20 + noreclaim_flag =3D memalloc_noreclaim_save(); + if (submit) { get_comm_cmdline(submit, &comm, &cmd); =20 @@ -610,6 +619,8 @@ void msm_gpu_fault_crashstate_capture(struct msm_gpu *g= pu, struct msm_gpu_fault_ msm_gpu_crashstate_capture(gpu, submit, fault_info, comm, cmd); pm_runtime_put_sync(&gpu->pdev->dev); =20 + memalloc_noreclaim_restore(noreclaim_flag); + kfree(cmd); kfree(comm); =20 --=20 2.53.0.rc1.217.geba53bf80e-goog