From nobody Sat Feb 7 22:55:10 2026 Received: from mail-yx1-f46.google.com (mail-yx1-f46.google.com [74.125.224.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F314723E346 for ; Tue, 27 Jan 2026 01:21:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769476900; cv=none; b=GPofAvANiswImHxgNHYHNSM+4vHKT/dB6ihXo3bV/6IHAABZmDrL4rZ+LovN7kBzJ/YqdwPK1noAam5y5azDRBN+TkSConpFGSBEhc1cB8I6NRo4S8MJcUo5PaBPLfVXiQtX65A/O2h9/u3SxdpaS6lljMVaYxoRieUVHkcJ64o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769476900; c=relaxed/simple; bh=UsjQ9ltqiiWqDx26LPu62eiYc2Na0nMJXEbawZWT7Qo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=k0i8ANULpUs4pGPyCOfB9Pn+o7jlBwkUeqJF/YzemZ6MzLt85XQMsWBdXXOxq9RzhOcThJ+z6LrEkUU8uvIos7asNLH94eA+mMjjg26NimJzrC+k/0areiibj5SkihXOZMPyuYhXXlZRjwQDoFocunD8L5vG9KX8Zz9Rn3kGZqU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ig7pNfen; arc=none smtp.client-ip=74.125.224.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ig7pNfen" Received: by mail-yx1-f46.google.com with SMTP id 956f58d0204a3-64455a2a096so3996306d50.3 for ; Mon, 26 Jan 2026 17:21:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769476898; x=1770081698; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+/vN9tI+Ty1fNJHJDsZSICBWCE32xAULAqNRkTr4Q8M=; b=ig7pNfen4rljYORaZwX3McegfP8Luf3eYIZMkKG5dqlKsaJt/4xwOe515c0Mfl1gt8 YQuGP/WnsCNQB70Tw+JSRWXl92VZD+3Epj/gtbNakRWVSHP0icc2MJXsCIjQlxQYDLZc Q/ihXR/gjOyEJCdKvZuTYybFhAhJXvxqOqV862yh8fF82fFeNOT0Bre8D6al8VoI/QtH 8VeFlrYTQWgAkG+ExZbYgUt7hD0rnPVNXKThFSAmMSUEW/wCHq0Q3leX4/9AQCsZKS/0 PenR79tBh44fGikZpFb3HH/8k9xVBv61DaUv1xuRKj1LQonvF6l143CQnYfeJVX+Kzt5 rUKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769476898; x=1770081698; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+/vN9tI+Ty1fNJHJDsZSICBWCE32xAULAqNRkTr4Q8M=; b=p9LnUWxfuQyjfGilcz2Ain9cftHotXu9v+U2xyXigdE2Lzmvrx2QRMjk3tnhuk00A0 aZ3C07B/agtk0aIw3hzFMjy3pEN/Mjh4DTxxNtWfI0kKhXcBtJul3X8wJmqtsDz//iN3 urRNyXed/9aGOW4wHLdCFZ/0snoRC/3dJ1W18ItQO/SOXpP0BO9JjZXro7sieBs4Qzlz NJvsXuu2NcfCo3dbWhIe6Sbjg9ZnHvl2+FQhbsA8b52WMi3aId9a8/s+hyWe69Is9uba GuGmomFzLvddVERj0lNRVrCzQQ7Pymbt3P9Ms0ryY2tFfy83Ovfl3c1TW/jvmMbrgRAF e3PQ== X-Forwarded-Encrypted: i=1; AJvYcCWNDZBtDRHyTUF/qfQSh/y8Rsk7McUfq9rryY+o+NQ09ttYUr7wbo0nGGahzvOIECl/wCqmtXcN74mAowM=@vger.kernel.org X-Gm-Message-State: AOJu0YzYM1rRFUErA5g9LID4UXZPEQenjSgwtBzDyoY3BlChqtZdnDpJ gJyUaOrb7WBdXPKycQE7G+IRDLmrCj88mYMzWfNEn/aE2Off9sTty52K X-Gm-Gg: AZuq6aJH1uCNXVQYRPl82dCENyi0/6ysZyjM1/PZPb4XJ3n6SzkqsbTz54jYu1RUqHk X+LPvrwAQ4YB3U5DzpOYDcUzBpn91kkM5g5++K+AXcFstAMyjr4VPFU8q2/DHd0YeiOp029+hPC FUekPKLosVA5GEqBk3QvP0/qzZwNGkq0OA9GPZiCyYgb1UMgOFOawTFRV+g3sz2Zi9r4Tg7lviL cLcVyQh9iUYT6mTbHBEZZ9ihmi0Zh4nrQpcY3wNEltcg6wBNxJr5ujp9KzO6WyIDn6yTuzQKSDI TZf7I9kOXYGpgpeDfCPvmQ1tRpD4UAzaIKa7+V5B8b1fzgpZQY009hMgA1XGzL4pPIwnCHH0k3H NuGOxbqLKH2L5Ue5BTtztXWyg7LOhy5JD/A1ncIzIimSYLtgVN/Ho6F0kzYqDF/ormidiBYlkVg jSxg== X-Received: by 2002:a05:690c:c38f:b0:794:6fa2:a037 with SMTP id 00721157ae682-7946fa2aa29mr39518767b3.8.1769476897891; Mon, 26 Jan 2026 17:21:37 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::89f2]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7944c5c9b0bsm40189657b3.57.2026.01.26.17.21.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jan 2026 17:21:37 -0800 (PST) From: Ethan Tidmore To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, straube.linux@gmail.com, hansg@kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH v2 1/8] staging: rtl8723bs: rename RegEnableTxPowerLimit to reg_enable_tx_power_limit Date: Mon, 26 Jan 2026 19:21:11 -0600 Message-ID: <20260127012118.43037-2-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260127012118.43037-1-ethantidmore06@gmail.com> References: <20260127012118.43037-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename RegEnableTxPowerLimit to reg_enable_tx_power_limit to avoid CamelCase. Signed-off-by: Ethan Tidmore --- drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 4 ++-- .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 18 +++++++----------- drivers/staging/rtl8723bs/include/drv_types.h | 2 +- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 2 +- 4 files changed, 11 insertions(+), 15 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/stagi= ng/rtl8723bs/hal/hal_com_phycfg.c index cd76e26e868f..403fb485b6b4 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c +++ b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c @@ -690,9 +690,9 @@ s8 phy_get_tx_pwr_lmt(struct adapter *adapter, u32 reg_= pwr_tbl_sel, struct hal_com_data *hal_data =3D GET_HAL_DATA(adapter); s8 limits[10] =3D {0}; u8 i =3D 0; =20 - if (((adapter->registrypriv.RegEnableTxPowerLimit =3D=3D 2) && + if (((adapter->registrypriv.reg_enable_tx_power_limit =3D=3D 2) && (hal_data->EEPROMRegulatory !=3D 1)) || - (adapter->registrypriv.RegEnableTxPowerLimit =3D=3D 0)) + (adapter->registrypriv.reg_enable_tx_power_limit =3D=3D 0)) return MAX_POWER_INDEX; =20 switch (adapter->registrypriv.RegPwrTblSel) { diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/stag= ing/rtl8723bs/hal/rtl8723b_phycfg.c index d8709d40cb33..e89e34a6ad8c 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c @@ -338,13 +338,10 @@ static int phy_BB8723b_Config_ParaFile(struct adapter= *Adapter) =20 /* Read Tx Power Limit File */ PHY_InitTxPowerLimit(Adapter); - if ( - Adapter->registrypriv.RegEnableTxPowerLimit =3D=3D 1 || - (Adapter->registrypriv.RegEnableTxPowerLimit =3D=3D 2 && pHalData->EEPRO= MRegulatory =3D=3D 1) - ) { - ODM_ConfigRFWithHeaderFile(&pHalData->odmpriv, - CONFIG_RF_TXPWR_LMT, 0); - } + if (Adapter->registrypriv.reg_enable_tx_power_limit =3D=3D 1 || + (Adapter->registrypriv.reg_enable_tx_power_limit =3D=3D 2 && + pHalData->EEPROMRegulatory =3D=3D 1)) + ODM_ConfigRFWithHeaderFile(&pHalData->odmpriv, CONFIG_RF_TXPWR_LMT, 0); =20 /* */ /* 1. Read PHY_REG.TXT BB INIT!! */ @@ -363,10 +360,9 @@ static int phy_BB8723b_Config_ParaFile(struct adapter = *Adapter) if (pHalData->odmpriv.PhyRegPgValueType =3D=3D PHY_REG_PG_EXACT_VALUE) PHY_TxPowerByRateConfiguration(Adapter); =20 - if ( - Adapter->registrypriv.RegEnableTxPowerLimit =3D=3D 1 || - (Adapter->registrypriv.RegEnableTxPowerLimit =3D=3D 2 && pHalData->EEPR= OMRegulatory =3D=3D 1) - ) + if (Adapter->registrypriv.reg_enable_tx_power_limit =3D=3D 1 || + (Adapter->registrypriv.reg_enable_tx_power_limit =3D=3D 2 && + pHalData->EEPROMRegulatory =3D=3D 1)) PHY_ConvertTxPowerLimitToPowerIndex(Adapter); } =20 diff --git a/drivers/staging/rtl8723bs/include/drv_types.h b/drivers/stagin= g/rtl8723bs/include/drv_types.h index f86180dc350c..4e164bec6f4d 100644 --- a/drivers/staging/rtl8723bs/include/drv_types.h +++ b/drivers/staging/rtl8723bs/include/drv_types.h @@ -156,7 +156,7 @@ struct registry_priv { u8 notch_filter; =20 /* define for tx power adjust */ - u8 RegEnableTxPowerLimit; + u8 reg_enable_tx_power_limit; u8 RegEnableTxPowerByRate; u8 RegPowerBase; u8 RegPwrTblSel; diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/= rtl8723bs/os_dep/os_intfs.c index bc02db13781c..725f1da80d32 100644 --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c @@ -259,7 +259,7 @@ static void loadparam(struct adapter *padapter, struct = net_device *pnetdev) =20 registry_par->notch_filter =3D (u8)rtw_notch_filter; =20 - registry_par->RegEnableTxPowerLimit =3D (u8)rtw_tx_pwr_lmt_enable; + registry_par->reg_enable_tx_power_limit =3D (u8)rtw_tx_pwr_lmt_enable; registry_par->RegEnableTxPowerByRate =3D (u8)rtw_tx_pwr_by_rate; =20 registry_par->RegPowerBase =3D 14; --=20 2.52.0 From nobody Sat Feb 7 22:55:10 2026 Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E345243951 for ; Tue, 27 Jan 2026 01:21:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769476902; cv=none; b=ST8jGmUjzB5TUF5MumgxgNbIrcQk9/MuUXNVWBZO9qhhDBP6MAdXPpTEYBbQ8NbxlpHxSZvbL8RDid79tKCah/S+LX/IrKHbQMPBUEF2AkV7HPVuMDehVXHjzDwirXX/dQzNCR11+x1fdNa6dZ1DiTT4iU+Ey3EbhFYiLRGTBbU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769476902; c=relaxed/simple; bh=fgE2tpaaBWO71UpxBuDOuX9k2P1qze0TvGiBr8JrSA0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Za0u4sodg9Fj+3nSmd18TGKbpurC3pYiatCGz2QYZ14NTVtm73PYU+jTwzBsiMLtphzSVndQ+o5TpwTEUYg3m7OmEr9i/tCKF0405s+45TYwtEG8xGUdvU520y5SYQj2B7R9L4YoA6jtkvSVTZOaTCpxDx2inCx+6Lnl+Sa2Ghw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cJIXXuQz; arc=none smtp.client-ip=209.85.128.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cJIXXuQz" Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-7927b1620ddso76398247b3.0 for ; Mon, 26 Jan 2026 17:21:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769476900; x=1770081700; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ljjT7O7ItlrDAqEbKHC9+zTCVSY/1bncKmBNPDCi23I=; b=cJIXXuQzLgZywIYrUTKQepg+B7Yv+T7SvFzKqdVPJtyc3n690qq3sX5pBSr6aCpqFc S+/+2gJzsA+IZkY/yS7gdDEQS9NmNNMwlZiLuLaXD/KTtsfNiGbfyIQVxATlvG/FeoQX I7V5N5d+G/UmRj88WEFG8SWjopetOWGBvY9FHyl4h4rm3nKKcq9SfKIT2Qfi7Ds65bQd G1J3rBVGQjsnhm1POjkwc2IbkCnumLagOu3KpTAVZgT9KdEz/aZbztKsjelOLkPHhgDJ hfvk9SLxw35PCaX83s03GqE2t72oqmqIdL+CQaSd6iXcY5LvRv93q8SvVccs0DVHCoGU A0pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769476900; x=1770081700; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ljjT7O7ItlrDAqEbKHC9+zTCVSY/1bncKmBNPDCi23I=; b=G/IlIWkytdypa++JHQ4zcQN3NtmDI47DPKgpJ6+M065A4yd7JfeGrwKkYOPPPLQB7n qEo9GkHQdxHnlurFI1NhApGMjpGJm0Bw0BQgZGFAj633M3DO/AUZN4jOgIF7fqOXCL0Y 8hkZfyn6GtxANWRRHX0NLYI/xt9CPC/jF42pTIjAGUVKNiS35rUyySbkS0r0KotLDZfn 0YsgBVI1SEa4KymLM/y3KwoKzlb+Sw6amtsKa7QrN4tXNg5a8hZZUmDQP04/2XJM58g3 h21zCloSum5/vkioNVzW5tTd0l+6q9U1h8vI2m4/573aYAHAV1zoWBY0KN8i4kmxXhKW PSUg== X-Forwarded-Encrypted: i=1; AJvYcCXufWqC8JR9jZUylB6LlrbhLnSfOrKcfCQ6n/li4BccSEkH4CaL/CQnPdbTLBXIz6ZnnDeci/CQ8k+n3Bo=@vger.kernel.org X-Gm-Message-State: AOJu0YxiUlPUXv3FogI7umV79KtjUBCNKU/QR8DyET4iWvU9ULCSah/g EuRfmAbwFu+VPd/qDhXALjdqAP0WI24o/CqW7yu6qGkBOVjfSse5NcFz X-Gm-Gg: AZuq6aIJ7J4w8MSdO+mBmFt2bKrCe8ZU3pHgT/NbNHw127n17rWuhoJOqIoKzwx3egc LzGOqtnWwtUia5BUDlgrCOnRNGc735DSWFGM8/1mAFQGmaIcTzQXOVXt+3nr05LVIQyRS1spxMn paTQ33Z6z+bslRetXEpah0Vtg9aCSbjkcH9XTfMWYa8jGRt3l/bIzNvKmZ6/XFzxkGXwrc+wiLB jZzohPqHlKK2jIgMhHFFZNhsJwWIUDlV7RC7gzj0D3pg+lp4ZgLhooWk0q/Yq6KcYMdouxR0HoD 1SgOmaTO3B81E5t6NpVwBDffC3Rsd6PUc3Qyzzdj6iZPQ+4cO+8Gvf4kOGErV18xr3uprJ7tw+o 1prlmDGsJGhxsU+5dBGay5gnh3nBdk2tpyKYsLur5QltMr/Ynniz7vzQb+39VCcdiYzo= X-Received: by 2002:a05:690c:101:b0:731:817b:4d73 with SMTP id 00721157ae682-7945ac580b1mr44945707b3.14.1769476899622; Mon, 26 Jan 2026 17:21:39 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::89f2]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7944c5c9b0bsm40189657b3.57.2026.01.26.17.21.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jan 2026 17:21:39 -0800 (PST) From: Ethan Tidmore To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, straube.linux@gmail.com, hansg@kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH v2 2/8] staging: rtl8723bs: rename RegEnableTxPowerByRate to reg_enable_tx_power_by_rate Date: Mon, 26 Jan 2026 19:21:12 -0600 Message-ID: <20260127012118.43037-3-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260127012118.43037-1-ethantidmore06@gmail.com> References: <20260127012118.43037-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename RegEnableTxPowerByRate to reg_enable_tx_power_by_rate to=20 avoid CamelCase. Signed-off-by: Ethan Tidmore --- drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 5 +++-- drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 11 +++++------ drivers/staging/rtl8723bs/include/drv_types.h | 2 +- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 2 +- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/stagi= ng/rtl8723bs/hal/hal_com_phycfg.c index 403fb485b6b4..e7e355b41747 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c +++ b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c @@ -573,8 +573,9 @@ s8 PHY_GetTxPowerByRate(struct adapter *padapter, u8 RF= Path, u8 Rate) s8 value =3D 0; u8 rateIndex =3D PHY_GetRateIndexOfTxPowerByRate(Rate); =20 - if ((padapter->registrypriv.RegEnableTxPowerByRate =3D=3D 2 && pHalData->= EEPROMRegulatory =3D=3D 2) || - padapter->registrypriv.RegEnableTxPowerByRate =3D=3D 0) + if ((padapter->registrypriv.reg_enable_tx_power_by_rate =3D=3D 2 && + pHalData->EEPROMRegulatory =3D=3D 2) || + padapter->registrypriv.reg_enable_tx_power_by_rate =3D=3D 0) return 0; =20 if (RFPath >=3D RF_PATH_MAX) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/stag= ing/rtl8723bs/hal/rtl8723b_phycfg.c index e89e34a6ad8c..95ddb34850bc 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c @@ -350,12 +350,11 @@ static int phy_BB8723b_Config_ParaFile(struct adapter= *Adapter) =20 /* If EEPROM or EFUSE autoload OK, We must config by PHY_REG_PG.txt */ PHY_InitTxPowerByRate(Adapter); - if ( - Adapter->registrypriv.RegEnableTxPowerByRate =3D=3D 1 || - (Adapter->registrypriv.RegEnableTxPowerByRate =3D=3D 2 && pHalData->EEPR= OMRegulatory !=3D 2) - ) { - ODM_ConfigBBWithHeaderFile(&pHalData->odmpriv, - CONFIG_BB_PHY_REG_PG); + + if (Adapter->registrypriv.reg_enable_tx_power_by_rate =3D=3D 1 || + (Adapter->registrypriv.reg_enable_tx_power_by_rate =3D=3D 2 && + pHalData->EEPROMRegulatory !=3D 2)) { + ODM_ConfigBBWithHeaderFile(&pHalData->odmpriv, CONFIG_BB_PHY_REG_PG); =20 if (pHalData->odmpriv.PhyRegPgValueType =3D=3D PHY_REG_PG_EXACT_VALUE) PHY_TxPowerByRateConfiguration(Adapter); diff --git a/drivers/staging/rtl8723bs/include/drv_types.h b/drivers/stagin= g/rtl8723bs/include/drv_types.h index 4e164bec6f4d..847f29c7f3be 100644 --- a/drivers/staging/rtl8723bs/include/drv_types.h +++ b/drivers/staging/rtl8723bs/include/drv_types.h @@ -157,7 +157,7 @@ struct registry_priv { =20 /* define for tx power adjust */ u8 reg_enable_tx_power_limit; - u8 RegEnableTxPowerByRate; + u8 reg_enable_tx_power_by_rate; u8 RegPowerBase; u8 RegPwrTblSel; s8 TxBBSwing_2G; diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/= rtl8723bs/os_dep/os_intfs.c index 725f1da80d32..1558045f9366 100644 --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c @@ -260,7 +260,7 @@ static void loadparam(struct adapter *padapter, struct = net_device *pnetdev) registry_par->notch_filter =3D (u8)rtw_notch_filter; =20 registry_par->reg_enable_tx_power_limit =3D (u8)rtw_tx_pwr_lmt_enable; - registry_par->RegEnableTxPowerByRate =3D (u8)rtw_tx_pwr_by_rate; + registry_par->reg_enable_tx_power_by_rate =3D (u8)rtw_tx_pwr_by_rate; =20 registry_par->RegPowerBase =3D 14; registry_par->TxBBSwing_2G =3D 0xFF; --=20 2.52.0 From nobody Sat Feb 7 22:55:10 2026 Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C73F23C512 for ; Tue, 27 Jan 2026 01:21:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769476903; cv=none; b=iHI4d/ca8Xr6yZ8ciEgVmIsqA8uKI0w2IpeUnr93YTyOfzWN8Q8FM2q10ka85nQUndr+kS4PAU+pCYc/J93h/ZGKegY5Wa1y6pcQ4mE3AZ2lzdh7Ma/1CjBfHAYGLVjwCApSzbxPda4Fqd8Xhc8lqHLLTkcsDVv0KaV+VbB7NrA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769476903; c=relaxed/simple; bh=80FjncwGZuJ9Nro7Dr7mfYeXwQJ9ergg/exMx3Y6LlQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kQ4TSj1E4/xJo/81ZNVI9RDLC9bSWMyjpFOqPiuwM5K/GnIZu2hKW5VrC3Yfq6N1x2l86ZVLgA0nzYFx3LHldJFolTEqAmqeP/4CNxwLeU4VQviCD1dDFHD+3IispqPAyw9eP/TXX3wHSW7a8X7poxanQ+fhaxBLCj3LWFrkqIQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Y97nsLli; arc=none smtp.client-ip=209.85.128.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y97nsLli" Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-7927b1620ddso76398927b3.0 for ; Mon, 26 Jan 2026 17:21:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769476901; x=1770081701; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=G1gHCfTEYsbIh6B+hXKqc7pg35lzBRzrciYDcVDzMoA=; b=Y97nsLlinxm5Cs2ObI+g+k5CaWMTv/4p9UAUMw6monclCopCOTxJnjkNZh1+C/ZEJz bMrMklvEepS3f1xYVmoK/hqOPXQcyvS7yFRDls6R3nBAz4MGmb1nh0kiyTik09RBGLwI bMPrwbs956QtGw2Z6IM+5QUxVx4lfKWxP7RSTlIyBCzilKX/pFCPOXXPhZtmyDNTqADu 64Qyyv971jwcyn9jKAXSlqN5qjuXda4b8fIySWZjNgd3iBI367CnHDPYTKgxFCXe5lxa qnqJtL3kIbPeU0KrYH586p7QivB213KcmskAzXNPI0CfEwEHYQoiD8oX5rJfUybbbG9I Bzfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769476901; x=1770081701; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=G1gHCfTEYsbIh6B+hXKqc7pg35lzBRzrciYDcVDzMoA=; b=srHUF0UbkZ30uod4K5seslkd7g+C7U02CV0quEI/31v5xkzrwUZyrF9niNy+DIaTdF CyObKChrG3XFG9Yu/edfnitWG70OP4oM2OP00UqERN4n9edqrmjtFh5ScKVfcxmb5xap zZjBPS92rnTKjEdtDLRkZ7gaphIbCihpRNtLfD2qZjGeXSDikscItw07CcTtrxxR2Zpj qx9avMleNQ99SHBCP+jVqpHjUwlQqyHgGH88JVxgZhdKiFXCpsIXLLt0KlDrmc8n42H/ 0wyJCtY5iz7LUHS548oop50Wt6tz0L8UqmsFLNVYSN5lxmThazPB90wkNhEX6r/lmGXa Jgqg== X-Forwarded-Encrypted: i=1; AJvYcCXvX5nSgW0UB0/OXx76/eRy/XWxaDVkmQDT+Fx8ujE78zrZr+Smj02jRYsivzAoGaomLoTCC9J7RgTeeEA=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+Yk4QoRpWS4Jeo6c8yYVR7BRuf/bDRd91G3Hi5WObfVULmKuK HtCGm7agqbNu039uDiPb8r9rFcp6BLYMsvYcoMot4GuxT5yLvJ75wGg2 X-Gm-Gg: AZuq6aJSXo7Tnlvi/hLKcnVc3zDzYT1CX2b9P5BJrTaYHeq3Wxpp6H/QZxxVuGnxJ7l hK0a/WM+AwpfgOZDejEw4G6L+uDIeuHaf943VDH3TgN8vyi341qeB59a8yVX9vACcZ/nqn5nSp6 X1dHYRrdekGORig28XbPvdlxR4TE29td6ICK/CrO8h3yW42KF261okvq+SxlbIxRzirq2FWBZoc x5moPXqITALR+89IV/ofFbcOkZqYCArBN7jUYbLvLi5gevN3vlp0Qq6AhWnckmme5+/+dW/j9iM /nJYQPU6Kz0YMy0KE6R4k7noULQk55KjyKSL+X62SLdW4vdwXI3OsusIYEus2NkL8iGrruiBbzZ LOz7m516BFpIBae8EvIg+8mCcwxIv8g+6lwV3Yca4LeqYhj6MtXQWXmKaI+WFm9Yh8kE= X-Received: by 2002:a05:690c:e3eb:b0:78f:86cd:5626 with SMTP id 00721157ae682-7945ad8d8admr42857867b3.26.1769476901347; Mon, 26 Jan 2026 17:21:41 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::89f2]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7944c5c9b0bsm40189657b3.57.2026.01.26.17.21.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jan 2026 17:21:41 -0800 (PST) From: Ethan Tidmore To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, straube.linux@gmail.com, hansg@kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH v2 3/8] staging: rtl8723bs: rename RegPowerBase to reg_power_base Date: Mon, 26 Jan 2026 19:21:13 -0600 Message-ID: <20260127012118.43037-4-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260127012118.43037-1-ethantidmore06@gmail.com> References: <20260127012118.43037-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename RegPowerBase to reg_power_base to avoid CamelCase. Signed-off-by: Ethan Tidmore --- drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 3 ++- drivers/staging/rtl8723bs/include/drv_types.h | 2 +- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/stagi= ng/rtl8723bs/hal/hal_com_phycfg.c index e7e355b41747..1a9a4bb15bd8 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c +++ b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c @@ -752,6 +752,7 @@ s8 phy_get_tx_pwr_lmt(struct adapter *adapter, u32 reg_= pwr_tbl_sel, void PHY_ConvertTxPowerLimitToPowerIndex(struct adapter *Adapter) { struct hal_com_data *pHalData =3D GET_HAL_DATA(Adapter); + struct registry_priv *r =3D &Adapter->registrypriv; u8 BW40PwrBasedBm2_4G =3D 0x2E; u8 regulation, bw, channel, rateSection; s8 tempValue =3D 0, tempPwrLmt =3D 0; @@ -772,7 +773,7 @@ void PHY_ConvertTxPowerLimitToPowerIndex(struct adapter= *Adapter) else if (rateSection =3D=3D 0) /* CCK */ BW40PwrBasedBm2_4G =3D PHY_GetTxPowerByRateBase(Adapter, rfPath, C= CK); } else - BW40PwrBasedBm2_4G =3D Adapter->registrypriv.RegPowerBase * 2; + BW40PwrBasedBm2_4G =3D r->reg_power_base * 2; =20 if (tempPwrLmt !=3D MAX_POWER_INDEX) { tempValue =3D tempPwrLmt - BW40PwrBasedBm2_4G; diff --git a/drivers/staging/rtl8723bs/include/drv_types.h b/drivers/stagin= g/rtl8723bs/include/drv_types.h index 847f29c7f3be..e1efc14e86af 100644 --- a/drivers/staging/rtl8723bs/include/drv_types.h +++ b/drivers/staging/rtl8723bs/include/drv_types.h @@ -158,7 +158,7 @@ struct registry_priv { /* define for tx power adjust */ u8 reg_enable_tx_power_limit; u8 reg_enable_tx_power_by_rate; - u8 RegPowerBase; + u8 reg_power_base; u8 RegPwrTblSel; s8 TxBBSwing_2G; u8 AmplifierType_2G; diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/= rtl8723bs/os_dep/os_intfs.c index 1558045f9366..02e01f0f0bf4 100644 --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c @@ -262,7 +262,7 @@ static void loadparam(struct adapter *padapter, struct = net_device *pnetdev) registry_par->reg_enable_tx_power_limit =3D (u8)rtw_tx_pwr_lmt_enable; registry_par->reg_enable_tx_power_by_rate =3D (u8)rtw_tx_pwr_by_rate; =20 - registry_par->RegPowerBase =3D 14; + registry_par->reg_power_base =3D 14; registry_par->TxBBSwing_2G =3D 0xFF; registry_par->bEn_RFE =3D 1; registry_par->RFE_Type =3D 64; --=20 2.52.0 From nobody Sat Feb 7 22:55:10 2026 Received: from mail-yx1-f45.google.com (mail-yx1-f45.google.com [74.125.224.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 941BB25F7A4 for ; Tue, 27 Jan 2026 01:21:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769476904; cv=none; b=mYS/F9k3d+WR7gm9BRBMUZE/aNOlI7+Taa7BwKy/qyLV2hVZ12cYUjqSwX1+V4EyKeRf0GUrW8z1+Oq100c7ATF4JBBbmzalEQlTe31VUYHX6q978SQg3FPF6I60dwe4m63o6KdUri8OGyli5ZfnsiigLrrakydaw0j2M17OscM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769476904; c=relaxed/simple; bh=x6OGEEPZObwhemIh6rI/KuoqEUB6UqPzxOiBV1d7xyU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Zd/i/RovQb75Nisgerz13YCHmfRMmPiD736/cd4pf9LZWqTkRgME0qMcl1FUSKHCMHs/tU3TPZoU8Gp//EqEDahaVCsueJK+CQGjemo9TFDIq+65nV30yjAjbo+mwb49pYQShRtfaH91qgTMBhnZ4YZf2nzwVqoiW35IpjJmvqE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=V5YzxNep; arc=none smtp.client-ip=74.125.224.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V5YzxNep" Received: by mail-yx1-f45.google.com with SMTP id 956f58d0204a3-64959e30705so3833908d50.1 for ; Mon, 26 Jan 2026 17:21:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769476903; x=1770081703; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zFbj0Vj04CxifpaIIawJYRMpCdzoB9mlcxTLOX7l6dI=; b=V5YzxNepIsOuTQnlProMm+STRsV1Gi+vH+3rG+an0zv44MaVxezNDctZLSWpqossap sSnCHykNLZasHsVOiN9I8lDBiR2RlR3tGqmrGDB6dQbTUw5KuSiF8F2lUmfUlOp6yrv4 2gLOmMkclol0vDTdFwa2kP16FITKyd2sJpN6BzNUGd/jwPHMi5IBZkh3FVN9pzNAKiMW 7d3Kom4TSWqYI3dIhrQXJhJeG0pIJxhGQLYtG8S2OBuH2n1nVNuYJVVPUWnHWR2NsD1v cDBvJr/eKLbxUt62oyHx6pXCHaMZeIwI048cMEmAwerg0TVSrj0r42bgPzfIucW+7oTm QHcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769476903; x=1770081703; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zFbj0Vj04CxifpaIIawJYRMpCdzoB9mlcxTLOX7l6dI=; b=Wa1zVZzE9lvsbim4ufT1tLASxiSg0s9xpDfWikNjPovfFCpvXEfciEA58efLmiYh+7 kjWNzJa9ckx8n4eQBuylHVCVwQH+X+eVyGChZ3MdB/FgoDyh6sI8VXVtCapQuA+3+let 4VufXOHGNj8jx9BoqJxvGpAP5cK/AEejn59tdkrfcEZdLQCynZb3AboOjDw7p8zxSrEG lBuBQEvZDiL37/lN01hjodzdCg0ckiKrmCj2K4UchajPPxd5wHTF51ekTANwcGk/WMee 5QErbX3Lq6rnCZnFMAstiEE9GrXCKDDqrd5mMjwsSlsNgWf7SDaUN6+fwbMWy3FqDtk9 HXNA== X-Forwarded-Encrypted: i=1; AJvYcCUUafVSFK0DHa8jWKUclEUB4Um0gtdlcP+DNk8onlcIaiOuE++4vasylSoUAeetpZjSlEm2T4hmTGZQwY4=@vger.kernel.org X-Gm-Message-State: AOJu0YwINXxrUau1SNzTR7YWgO7HGjkWYDtJ2u88qLitZL3zFMTyEkAF 1i3ksrTy4ZKtajBf4/BuTZW2BOE2IpgaE+RzwfRVBw/wZPWe25pcfvW5 X-Gm-Gg: AZuq6aIpPtM3ZEt97gdqscEGMe57W9Nz+kUe5xfH11rXHwlShHlb8O3OsUegW4ZLTx6 5uNGZKu3uAARw+4lVFW8HuscT8ieU/rU8lxlgkKp2BCvWBuHyuw+VSp/X84iAO+nFnZ/cXb23V/ GZz5yJN+4fWMHMlIaqtpEw2wW28dua1RypAtz8IKy3vnRGws40GRQJT9lZBuoFUKZjEeM383m1W WXsZTnTIxWBMbxnbyEHNeAzUtDEVlypRihna9BpfJ6vMOeZZsOi7WrEezJTlAnZchSJ4XCzVRpS K2yG2GketrZ7lzf/6L243E28eC86iHF0YIy8/TAJq9MXJ58hznB2Xq/qnTmjVDwajDU5XLnluUr Ww98S7ZpJzDYTa2RUyvf6uspkCQr8/c5LALz5NHZpKycKu4AW364KFPFRkcjvlxf5mbs= X-Received: by 2002:a05:690c:102:b0:792:768a:897 with SMTP id 00721157ae682-7945a9b5389mr108589817b3.45.1769476902673; Mon, 26 Jan 2026 17:21:42 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::89f2]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7944c5c9b0bsm40189657b3.57.2026.01.26.17.21.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jan 2026 17:21:42 -0800 (PST) From: Ethan Tidmore To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, straube.linux@gmail.com, hansg@kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH v2 4/8] staging: rtl8723bs: rename RegPwrTblSel to reg_pwr_tbl_sel Date: Mon, 26 Jan 2026 19:21:14 -0600 Message-ID: <20260127012118.43037-5-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260127012118.43037-1-ethantidmore06@gmail.com> References: <20260127012118.43037-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename RegPwrTblSel to reg_pwr_tbl_sel to avoid CamelCase. Signed-off-by: Ethan Tidmore --- drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 2 +- drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 2 +- drivers/staging/rtl8723bs/include/drv_types.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/stagi= ng/rtl8723bs/hal/hal_com_phycfg.c index 1a9a4bb15bd8..dc2da49e6738 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c +++ b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c @@ -696,7 +696,7 @@ s8 phy_get_tx_pwr_lmt(struct adapter *adapter, u32 reg_= pwr_tbl_sel, (adapter->registrypriv.reg_enable_tx_power_limit =3D=3D 0)) return MAX_POWER_INDEX; =20 - switch (adapter->registrypriv.RegPwrTblSel) { + switch (adapter->registrypriv.reg_pwr_tbl_sel) { case 1: idx_regulation =3D TXPWR_LMT_ETSI; break; diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/stag= ing/rtl8723bs/hal/rtl8723b_phycfg.c index 95ddb34850bc..6d5e531505f9 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c @@ -536,7 +536,7 @@ u8 PHY_GetTxPowerIndex( =20 limit =3D phy_get_tx_pwr_lmt( padapter, - padapter->registrypriv.RegPwrTblSel, + padapter->registrypriv.reg_pwr_tbl_sel, pHalData->CurrentChannelBW, RFPath, Rate, diff --git a/drivers/staging/rtl8723bs/include/drv_types.h b/drivers/stagin= g/rtl8723bs/include/drv_types.h index e1efc14e86af..3557d7365585 100644 --- a/drivers/staging/rtl8723bs/include/drv_types.h +++ b/drivers/staging/rtl8723bs/include/drv_types.h @@ -159,7 +159,7 @@ struct registry_priv { u8 reg_enable_tx_power_limit; u8 reg_enable_tx_power_by_rate; u8 reg_power_base; - u8 RegPwrTblSel; + u8 reg_pwr_tbl_sel; s8 TxBBSwing_2G; u8 AmplifierType_2G; u8 bEn_RFE; --=20 2.52.0 From nobody Sat Feb 7 22:55:10 2026 Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEE59265CD9 for ; Tue, 27 Jan 2026 01:21:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769476906; cv=none; b=RTMiZvAjdWDP6x6p3cRUFFdnZ1Rg2ADb761mRPEXokhRcyF2luA4kWG9CkXiF/Uqb8tXXfddKjH2CU7/30fj8mwZVdXKXtLhW/KIRIBDxYWFIj7YMx/FJpQ4+7OFqwuQW1yyh3Y22CB7ZRzevo+t/acQX+6m+g57SaNjYkzut5Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769476906; c=relaxed/simple; bh=CZh1oms4tg823p3NL4KsoOiSLw0+DBB0AA+QBlYpKA4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hM/BbvTtkb6WoqTtB42sjuHS/xhic55+Roy0R/u1K/uZxhsF7dV4bqUGBd6ZQv/oslvVb2HjkvmOVOdZU4AibaJ/IxkHjawJ41e321dDCsZdvo4t9O4uNdap4eYgbZRj8pfLthNV5bRFzcbuCHQOJsUTzrm5eQcMoLhFJDW142U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mvkmaQFe; arc=none smtp.client-ip=209.85.128.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mvkmaQFe" Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-79273a294edso49475867b3.3 for ; Mon, 26 Jan 2026 17:21:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769476904; x=1770081704; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1Ax/DtX3U52L5ilLrJLGZXgOPJbqXoiOd58E0Q9dODg=; b=mvkmaQFeQKb6LjKeWcVD5T3y/2bZLpr5s8LC6vO++T9zlbeLZFrYpZU/IQpjGfROGV odWpf1Mcv8n3v+dt0TVjaCSxs2iO4qJ0ZrcHsJ86bMaRUR/GJfR2AVDmvnJGu57W/uhs ISl9HQActPoB743+exgvJdOHUFUspZzf1kYXfcpxVlwUxr0OX8x+irBGuOlFB/bwaTW7 ssivKtYizo1KfMK6KoKP+CPHZEnugs34U9PBJ4F35TQrmAANj6+LeB0QYpIoWslTUK3m CnQGMFcp5BtsEAi0uZrDaabP1Cxh/gpdf/SRQWIdBZLwlJMPWUzBfnBT9zmUs4Hx2g1A vdPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769476904; x=1770081704; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1Ax/DtX3U52L5ilLrJLGZXgOPJbqXoiOd58E0Q9dODg=; b=jhHL+lrbCybMExludyi7gUvKgfVbp4dcq8CO0be3G07cjuPqrUu/ogE+L79R8252nL gYifI6QPZ0jcbgfurjWhMb5aK2utdQZ3j0cM2hEKdhmssKh28NbQBzOzVLNUhv5EJeC/ RjeKLxcmsEFs6tTGirFHkIm49BemwY/Xpd8nLK3HfmZ7ACL5dhjpgIQe80YS5qGEXnlo xi1ezBAY5H9KGoDn1smN2HcO1hjUgqU5yVn8yMajAZN0LV/uOKZAn7YkWLIR341+W+XA 7AH0QXvN65BhvmWuv07+yXgRTrotcyBAljtl6Zv2WHBzfHssghXv6JpiFVktg+UVWty7 MosQ== X-Forwarded-Encrypted: i=1; AJvYcCUErvSqg14jNLKuQu0nrONzMh7qcEUfrTlzv5WP4ol4s1Bx8suPvtVp2NKb+ZGHZ3nowTTC6hUCH9D4S24=@vger.kernel.org X-Gm-Message-State: AOJu0YzQM8GG6DuoDxWpGv6q1Eg/R11zdZPC6bSc//1Y9z1laEDcsWGY hxml0Tn/tqGKkqfjsCpZQwfg7K7cY87glSkhLt2fQOirfvMl9YGskf+sn2fdfw== X-Gm-Gg: AZuq6aIVF6Z5HEuUH4isCD4n9akcanWa096HwLGmptndIOzkYzPHDG2DuzBCkqahgA3 mW0M/JnOINwLSHnbyawW5PRSAmrRPTwNRLFpyf7qK++ouAXT4EkEheOwl9JiTmPl2+hldRDPiYQ Xz97/Rtqo8HhUsndDo+5EIdVgeYwQJZDoTttW3jcePjKmKC3sCvOJQY4w1hEJYogJgYBnwmKE15 jWbqSeBkg1irFQx0H0QD/oq+KmDtcwH/nKsjw/El+YPkHfelM9bgllJfpeox3fS1+ulNU1XkbH+ PiJtEulNDM7dkM3DZKrOchHQ2BDhpBWfEhEQBKRNzcxbyQf9AvhgEKXzE+yYrm6N7aB108mawaD jPTfEHkZtYUKhchTpcYffGylrRYZ7DXKj9CzUe/mzf14UlI2kzdurRNOVfuT7ldKJT7o= X-Received: by 2002:a05:690c:30e:b0:794:6fa2:a00e with SMTP id 00721157ae682-7946fa2a97fmr21541537b3.60.1769476903921; Mon, 26 Jan 2026 17:21:43 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::89f2]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7944c5c9b0bsm40189657b3.57.2026.01.26.17.21.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jan 2026 17:21:43 -0800 (PST) From: Ethan Tidmore To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, straube.linux@gmail.com, hansg@kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH v2 5/8] staging: rtl8723bs: remove unused variable TxBBSwing_2G Date: Mon, 26 Jan 2026 19:21:15 -0600 Message-ID: <20260127012118.43037-6-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260127012118.43037-1-ethantidmore06@gmail.com> References: <20260127012118.43037-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The variable TxBBSwing_2G is initialized but never read or used anywhere in the driver. Remove it to clean up dead code and fix a CamelCase warning. Signed-off-by: Ethan Tidmore --- drivers/staging/rtl8723bs/include/drv_types.h | 1 - drivers/staging/rtl8723bs/os_dep/os_intfs.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/drv_types.h b/drivers/stagin= g/rtl8723bs/include/drv_types.h index 3557d7365585..cbbdf45012c4 100644 --- a/drivers/staging/rtl8723bs/include/drv_types.h +++ b/drivers/staging/rtl8723bs/include/drv_types.h @@ -160,7 +160,6 @@ struct registry_priv { u8 reg_enable_tx_power_by_rate; u8 reg_power_base; u8 reg_pwr_tbl_sel; - s8 TxBBSwing_2G; u8 AmplifierType_2G; u8 bEn_RFE; u8 RFE_Type; diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/= rtl8723bs/os_dep/os_intfs.c index 02e01f0f0bf4..f4b2be4296c9 100644 --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c @@ -263,7 +263,6 @@ static void loadparam(struct adapter *padapter, struct = net_device *pnetdev) registry_par->reg_enable_tx_power_by_rate =3D (u8)rtw_tx_pwr_by_rate; =20 registry_par->reg_power_base =3D 14; - registry_par->TxBBSwing_2G =3D 0xFF; registry_par->bEn_RFE =3D 1; registry_par->RFE_Type =3D 64; =20 --=20 2.52.0 From nobody Sat Feb 7 22:55:10 2026 Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36D89273D6D for ; Tue, 27 Jan 2026 01:21:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769476907; cv=none; b=lVJO+bwhDbSUyL2egdxENBhl7jID6hFR4FTfQtNocbJbmdBoVdBDmlyp38vEd2UQh819SK0n+PEeH7PeDzV+lF44Ir6BYtiJvxBI5fX1KAc7yJYyNYziTm/eLL01wD+lB4nmsD9V3oiW48navgpa3OlZGsw0fJGppyCq6gVuP1E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769476907; c=relaxed/simple; bh=bWXSX2Z2iObBnmWXf3385WaPD0EcXLv/mgJ7rblnwLI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YEi5amTxbRIAGxfYhyz9/g+xS+F6gb4HeOxav5I8pJNIvm+JHYzSV+rst+F4GAbiSdT32T1U1QFs/MCMs+bWoej4YYBGiUFE0DA4sFC094WuKtpM7Zl0ANNeSn7G41r7j/Nqm066klPZEBGTPZx6k1J+3QAl5F9Kb2nozccDrWI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TKdaLrll; arc=none smtp.client-ip=209.85.128.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TKdaLrll" Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-7942fca0da6so35168897b3.3 for ; Mon, 26 Jan 2026 17:21:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769476905; x=1770081705; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4G9x9taUAv5JzYdnkyHFAF8EphpOgK4vinweKZ7n8k8=; b=TKdaLrlllZlWYyHhSN3ERulZFj0N1/SmmcOg3ejAk+QNY0xXM8+enuHagOWef++nOW v9/HSFlZo0r6aHDXlveAacO0C6RBHAqbeZ+kIoy8CqarxLQbzh50eGSlXfez3m+o2hpo WupiWFoSaiJu95cKLvUkaJLJgo4CDQM8nTsFVamPXDhGy+29O+b+rOo9F0vQPVkVUnpV pa0m6CaG8ET5Vm/QDr/pz8nTPd7nRi1OOm6HY9lM7cRdWvB+sS3JSO6lN7XXcGusc18a 39v+LbyhQ39n6guW8VHm7EQajZvkt0OZ2tQHb7c3F1FoOQKNqcA9HJQnhmYkChGc1+r1 uKoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769476905; x=1770081705; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4G9x9taUAv5JzYdnkyHFAF8EphpOgK4vinweKZ7n8k8=; b=P0nO5oMe9TLoYT16oc8LNPIx5As19dABOtQ0yPe25jmoKgm+VYp2riQXqSzdtnC2Zv +5kO/W+JzI2G3x9XC1dS1oIs5pXTa9W0cHu6yWUSuRS7ER7Jx38w/5mv3WB3oCT/ckAb FRBySb8hZslay7/hktXj8D+TcnvubQxcRYa9Jx1uog5oqR2+G9gZd87p//sPESs+iOKm 7s77wwT0ihnhlLB73f5abR+QyFZwT2R3qmO06R+4b54/NoItdqbEtX/cqo/5yPWe2try mK9t3k0WaqWolMG3T/zkj3yUf9Nhf8fef74eTgnMw1Ukjb/GWLpwSR4oCUoxfO3BPsBi YO3g== X-Forwarded-Encrypted: i=1; AJvYcCWscFnmG/V4vwO+rA900SnpX4jU3yhz9mCxuNrXcRKWSzB5wpDzXr57iBbEvOEF6WKN7fbE4/5UbQLMsjA=@vger.kernel.org X-Gm-Message-State: AOJu0YyOYKCil6KfFtqbQNMXNFv0MxTI5pqkvacvqYwUWIGh/KyY07S5 gSZTV+Fkl8nz0AwBsh8YvKR9b5PqcXufQuitZ7Fai0lvKE+ywZK20f5a X-Gm-Gg: AZuq6aKmYcBLlf49LQ14m5JbsFf4/vSaatDeE+lprCZ7bz9Xn/fRnbbKFOnmG8nxc61 ei1annKPlxws+vJ0YNrrw8saHbCaZ866ldED6+FZezUBL9Hsg8F3gp6lWKzVZbV/nxo8sIIjZ8K 0tMPLJAYtaxyLESBcqobCLVA3QmxQPFh12S0aAHrI1OvdfujpEsH7dPeFoskAf7W5qa5OZPLOOV t+hPlzlaiEnhvOctO4zQhKOCbTDZxGqdOrQTcypfTsvSMgmTUhGxWXRzp5xS9KQ6JuXrZZZCUVL 2osCe79RHsxIyQTzrwqRznMSG1j9E2KdhWldDGNLuC1p7kc3mIONGBpGUwXTX6GVkCDP6pe5y4w v9cEXmxrde2cBVf5ZkFZVyEjniWzKBriqYIaLjY9MRAsUgnEJjpLuHZP4sjVNFDCRlfc= X-Received: by 2002:a05:690c:d82:b0:793:cf09:cbb6 with SMTP id 00721157ae682-7945a96337bmr48886287b3.45.1769476905176; Mon, 26 Jan 2026 17:21:45 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::89f2]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7944c5c9b0bsm40189657b3.57.2026.01.26.17.21.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jan 2026 17:21:45 -0800 (PST) From: Ethan Tidmore To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, straube.linux@gmail.com, hansg@kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH v2 6/8] staging: rtl8723bs: remove unused variable AmplifierType_2G Date: Mon, 26 Jan 2026 19:21:16 -0600 Message-ID: <20260127012118.43037-7-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260127012118.43037-1-ethantidmore06@gmail.com> References: <20260127012118.43037-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The variable AmplifierType_2G is declared in struct registry_priv but is never initialized or used within the driver. Remove it to clean up the code and fix a CamelCase warning. Signed-off-by: Ethan Tidmore --- drivers/staging/rtl8723bs/include/drv_types.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/include/drv_types.h b/drivers/stagin= g/rtl8723bs/include/drv_types.h index cbbdf45012c4..64a2ffd45563 100644 --- a/drivers/staging/rtl8723bs/include/drv_types.h +++ b/drivers/staging/rtl8723bs/include/drv_types.h @@ -160,7 +160,6 @@ struct registry_priv { u8 reg_enable_tx_power_by_rate; u8 reg_power_base; u8 reg_pwr_tbl_sel; - u8 AmplifierType_2G; u8 bEn_RFE; u8 RFE_Type; u8 check_fw_ps; --=20 2.52.0 From nobody Sat Feb 7 22:55:10 2026 Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C7CF27EFE9 for ; Tue, 27 Jan 2026 01:21:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769476908; cv=none; b=eSnmG7uz92MEzIMXilA7F1kntISkK9V2XhymykdfUypI52XI5wH+QTaG0oiTmOhwhtfX1VmR/t2iImWRBnTW+qYkogTO+xQy1mPg9Wp00K7gAyOTAwEj24IbDguJsF3UqbT40MqWOAq1A9cwKlTZA3aioUL8EzpyWKdJu2a0SnM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769476908; c=relaxed/simple; bh=iNhp70QVLeN2CU8FSe1fhxRzlw3yzlgZ7VIpBSCc55Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LRwpTzrFqgkj9bmDUsQJXEFOUDY8WlFRwNP7wNTIi+r/2Hg77AwTaQzOkGiFEiUn1MjFEA4zF7ExX6tZNO3mDsxD5ABa4YSagw9pB3vO9q/wM8/PoD1dzfjiuD1rjpgHgvRqEkL85fahnMwFq+axj1my3Md+M1F7uaaXyityYBM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=R+IsejOz; arc=none smtp.client-ip=209.85.128.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R+IsejOz" Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-7946a1f2430so11484647b3.1 for ; Mon, 26 Jan 2026 17:21:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769476906; x=1770081706; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZBOBEvNcFzDBoSP/z1izj924i11bgg/3MAKJ/n0N4a0=; b=R+IsejOzC0jt7Z5b6Z54Sw/seWYAFg10kJ138xR9/n326/wHjdiuaqvPGCalj1cN3Q gp0xfpgzPoep7X/pkBez/Mm2yPgLuWJnBMABGGO+m4v2MMmvFNCIW87kHBTLqqVy4RjO sQ8vZq5X68cFbcF0mc6PJtwFRbgvjiNf++Pz9a98R/VzXAu9hIrP6II/vMV/GW+yhFGq zW0KibUDRrdADTmwmoCxcHbU17bWsFL+aqQwIYghaV+fF28luuoUQtpvSiXwd5oM1ZAH YkFIDXdfmiQcGSXraoDFEewW5GoYtqdXne5/8gs457vEilgxGA/FT5E8N+0v2SFwM6dR bFIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769476906; x=1770081706; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ZBOBEvNcFzDBoSP/z1izj924i11bgg/3MAKJ/n0N4a0=; b=KwbUpPOau44D6gH1RvqR/RdTRTrIc7Slv/PcObWyIg1sON2QQww/4OmsvNNMU7kx9y i2Lwwnlk9Bm/z8GXvMHtSO+3DU/WPbHmHxCANh3ZS1FcnM99oAjNzMLbf++S1aPJ41To 5fEjvajrgRjAwTYvnt/VOw+/rcchMoU1Y6ViLC04JYi6MZRvsVRrXFU62gOoI0/qFeZL 970ypvR5Xn5pon6DJTrApiC/ZtORdAbZV5IgoIyUSiJIMdZNoxpkfvzFr/wpMkqxyfSw 98PRUpCkqnoJLmtFpqL5wiGpgfG9UxePZ76XWK2bSjUQMxMSGlnOHn0TEtBZuNvFjyCv DuEQ== X-Forwarded-Encrypted: i=1; AJvYcCX1FJQT665laO26INxmioyqmhj48lsR1EpTrQ31nBtcs0lMgFO6JfWzpfpmC9YEVS8RFdHJacYNR5OMP3c=@vger.kernel.org X-Gm-Message-State: AOJu0YzV6jBK38Jpq/Gc0WjLyPZpxnYr+CGuH+h/yEmon/TugmcSNSxF Wt39JPaJtxrHGuxY4DQFDx3K+gDqk7KNb6KqJyyVvxCuR/9h2WRa1OvowZpE4Q== X-Gm-Gg: AZuq6aKZLRPx3KYWSRpjvQcf8ZNKa9Ixf7T7TVFxI4oN28dmJRJurYdV47RYId01LqJ wYmYgVbhcTkhTsEFegOYHBJTUoAoh3kh/FhfGK58grf1WMbXQ6Xykpx5+dwldzHIlWj+iLiJb7/ SccORnSp4nbxIZwMLIbhPiOGIUu8I/x5Fz5l8JTf4OD037tfNxLpqcZpFIk3GBzVEIWez5yZ4KT ONqytEoo9Jn/Gy/HH0TY0xhJCwyWouDGPpLRJa4NfJ+E5rce2gvUmKfMczoB7hZj/59P438eQpb Fdy75ODVuDZGkvVWp9ltEAALcYcnAtk/VRY5DBxqevlTz8I4JvJMQYY9tk7niGfokla3wabQGn+ HDhb3T3wHDYoNxIbrXNXme0MrXmqQZM7loXTXnzOivYsNYf8tTh3Z6RkTj3OkEjkbEjo= X-Received: by 2002:a05:690c:680f:b0:794:7072:b31d with SMTP id 00721157ae682-7947072d3f7mr21238417b3.46.1769476906388; Mon, 26 Jan 2026 17:21:46 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::89f2]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7944c5c9b0bsm40189657b3.57.2026.01.26.17.21.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jan 2026 17:21:46 -0800 (PST) From: Ethan Tidmore To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, straube.linux@gmail.com, hansg@kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH v2 7/8] staging: rtl8723bs: remove unused variable bEn_RFE Date: Mon, 26 Jan 2026 19:21:17 -0600 Message-ID: <20260127012118.43037-8-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260127012118.43037-1-ethantidmore06@gmail.com> References: <20260127012118.43037-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The variable bEn_RFE is initialized but never read or used anywhere in the=20 driver. Remove it to clean up dead code and fix a CamelCase warning. Signed-off-by: Ethan Tidmore --- drivers/staging/rtl8723bs/include/drv_types.h | 1 - drivers/staging/rtl8723bs/os_dep/os_intfs.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/drv_types.h b/drivers/stagin= g/rtl8723bs/include/drv_types.h index 64a2ffd45563..00da21774c4d 100644 --- a/drivers/staging/rtl8723bs/include/drv_types.h +++ b/drivers/staging/rtl8723bs/include/drv_types.h @@ -160,7 +160,6 @@ struct registry_priv { u8 reg_enable_tx_power_by_rate; u8 reg_power_base; u8 reg_pwr_tbl_sel; - u8 bEn_RFE; u8 RFE_Type; u8 check_fw_ps; =20 diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/= rtl8723bs/os_dep/os_intfs.c index f4b2be4296c9..c163e2eeea26 100644 --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c @@ -263,7 +263,6 @@ static void loadparam(struct adapter *padapter, struct = net_device *pnetdev) registry_par->reg_enable_tx_power_by_rate =3D (u8)rtw_tx_pwr_by_rate; =20 registry_par->reg_power_base =3D 14; - registry_par->bEn_RFE =3D 1; registry_par->RFE_Type =3D 64; =20 registry_par->qos_opt_enable =3D (u8)rtw_qos_opt_enable; --=20 2.52.0 From nobody Sat Feb 7 22:55:10 2026 Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com [209.85.128.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9C61284665 for ; Tue, 27 Jan 2026 01:21:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769476910; cv=none; b=aDN3Dva5gYx8d6Ssf6+l6/bP2ML2BCq08+XeBLqSly8X4339sUbt9fz1DnkXy7Zh/QVCGvCaIKl7QO0a7VQ1PjgSUC6etTGjizTjJjCqjONdG5Ahe7hEbH0i5q4WDnV9sC3zCstOnwNQOe3BOKkbT5PkLJaJ1x9cnNNCbSTYkpo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769476910; c=relaxed/simple; bh=FOkv29nEYucBdaK0TCDNtrtaCOt5iq4tQh3P2LSPZUc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Naowql4mH+BRXbfary7unycF6x7W8prT2XfEjwE0skqiqzkH1RtNT6czenHFWfnSoLbGDtHGm+580hQZghxZnu5qXgmA5qlGEcbbSGyyon0lZo2lpX+42bgwcwn9aEqhNJHQw7KHbMl2j93kx0hqyczxnrdnKy4KqaOCJF/vvdg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PljIV9He; arc=none smtp.client-ip=209.85.128.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PljIV9He" Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-794719afcd4so8408387b3.1 for ; Mon, 26 Jan 2026 17:21:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769476908; x=1770081708; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dn9HCRUTLSb0WGFaKFz+y1mSDDwRePumGtcU4XsiQz0=; b=PljIV9HemROArshgDPfsrj51RzJTqLHoNiD/tThM6J4rdv+vM1kaRKbg//lEgPiwUW rciNAg3DFCZhM02RxOP1jf4hkAOlSlY/x9tlQw7hhJZtmmCQ8YSgNafCaV/8biVCMqzA Bj3ZtdRCHKxyplXE06Hz6HQ8rKb8JX0suEYc1b3EvjyUigq779D9RMI8qzNENrZzeQO/ w8yEGk6nUw05X0Bz5G0SsZ9O64jNgpJ75HFUdochr1lhen+DP+rUEGouAR8CmiAIVWOt g1zViLO+V5m+oQDE6vn91PsN0eJr5MJmPV1kAlJVQFRpxbTkLmd6vpI51/IEZqgXFQYB LjGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769476908; x=1770081708; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=dn9HCRUTLSb0WGFaKFz+y1mSDDwRePumGtcU4XsiQz0=; b=sGZJq1YayTtxdaHqQzruBjTte6xCFdIvDHGJC1FwbEp7gkZ5UgPQljeVBYGKtTpow0 dUtScRGkpEN8WUxUaJ1V2bPae2o+s3VOMxQFbYCoXA4eUp/qj3AWLCY8jxduZLPhOj2m ZUdjx+JauyLmnLU/VSTrxVlLe7/2ox1lg9oShCQ4Yh3xJYA3XUVs9EeUvk9NMqo0N6ZE ym4s45gnhrYlaPGvnv3S8NLudqNRvfIiAFFSH5h/zWExlDGeMepR03aEfDs0cFdkHlNW Sgc35Tcc89Ha6dojp2D1at51biX1vn9fL1kLgHhi7jRdt85vp8hmKqqQjTJtpIUHXtrs 7C/w== X-Forwarded-Encrypted: i=1; AJvYcCXhiiQVrKD2HIj+Z6hjjpapReEGExRjen43x88rCHdmDSkCGtPZ8eQCyQqrjwfBUjWMQEWoigTNxv0TDsY=@vger.kernel.org X-Gm-Message-State: AOJu0YzqGkTEwfbxPb82vf5dHw/1BZqkkhtg6nWP4iN+byc6sUYfSnNA NZJVQJkklydUoEFdVNF10SaKigBxoNZILml3OCuAGjW6pg8EcXOIgZua X-Gm-Gg: AZuq6aIKRueImwFjMjxagXXpcgekplkKpjQOQAXQpQW4pV4y2NC2hZWhEiyh9Ow4rTX ASxwTKxLpZeEFBtkILsR5fsi31HZ1kNgiR0RtlqzoM8pk4UWBDsihsrgsA5xH23SexelvH7TTTR vwRlQlTQPPOLSbqTT/IN7FwI883h4vveIN7P6BFprCueNEo19rFxf0TUH0BdA/qOT3LKeZmQV30 qFwyR8CWZhc58XI+GP7MGWistOo2SUzokqvAN+YBtbwQPO8H9Tf+Ghya/eX/BOvMnTURXw10xUh EIdvxDMrZpnEud3nte4VdxeTPVsV7qW4go2WY6YgSYqvQWw+yNpRIg1DOrMLZYnCs1KNwb0LBXl euaeJ20+nG04qy1HtT9i3v6hbHESpNhJMpMW7GF3yLPywY+tkF+kgRXMyZmGJLkaTRmQ= X-Received: by 2002:a05:690c:670d:b0:793:aa11:d9fd with SMTP id 00721157ae682-7945a8b046bmr43939917b3.25.1769476908098; Mon, 26 Jan 2026 17:21:48 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::89f2]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7944c5c9b0bsm40189657b3.57.2026.01.26.17.21.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jan 2026 17:21:47 -0800 (PST) From: Ethan Tidmore To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, straube.linux@gmail.com, hansg@kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH v2 8/8] staging: rtl8723bs: remove unused variable RFE_Type Date: Mon, 26 Jan 2026 19:21:18 -0600 Message-ID: <20260127012118.43037-9-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260127012118.43037-1-ethantidmore06@gmail.com> References: <20260127012118.43037-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The variable RFE_Type is initialized but never read or used anywhere in the driver. Remove it to clean up dead code and fix a CamelCase warning. Signed-off-by: Ethan Tidmore --- drivers/staging/rtl8723bs/include/drv_types.h | 1 - drivers/staging/rtl8723bs/os_dep/os_intfs.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/drv_types.h b/drivers/stagin= g/rtl8723bs/include/drv_types.h index 00da21774c4d..11e1feade4e4 100644 --- a/drivers/staging/rtl8723bs/include/drv_types.h +++ b/drivers/staging/rtl8723bs/include/drv_types.h @@ -160,7 +160,6 @@ struct registry_priv { u8 reg_enable_tx_power_by_rate; u8 reg_power_base; u8 reg_pwr_tbl_sel; - u8 RFE_Type; u8 check_fw_ps; =20 u8 qos_opt_enable; diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/= rtl8723bs/os_dep/os_intfs.c index c163e2eeea26..f7f23d1b1709 100644 --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c @@ -263,7 +263,6 @@ static void loadparam(struct adapter *padapter, struct = net_device *pnetdev) registry_par->reg_enable_tx_power_by_rate =3D (u8)rtw_tx_pwr_by_rate; =20 registry_par->reg_power_base =3D 14; - registry_par->RFE_Type =3D 64; =20 registry_par->qos_opt_enable =3D (u8)rtw_qos_opt_enable; =20 --=20 2.52.0