From nobody Sat Feb 7 11:38:19 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 107EB35B653; Tue, 27 Jan 2026 13:55:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769522159; cv=none; b=Ea189r3ieEsBoU5/Yr5e3tHQ+rXUzWirvRV7gV2HnK31rXkTCe0obdXHq6cDFDNPEf4+8O9+JRTdjs96snTpOURASnOvb/6C4ZcLLkpNPfDU5FNzB8m13dDzstpyfD2aXb+YLKVOc4NBPJ8nl5MVpYbHmesOecCScVDujqDITgU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769522159; c=relaxed/simple; bh=8TzTu9mmFQ4jg+51JjtdxRMXvVNt8G/iW3LP00dYge0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=L2Gw7rIAzxxjpLeDhqKPLAU9M2mXxPgH8Cl1IDTLo/BB8pA+Mwe1sipfoF8ZyFXqE7Lo4nlqlXfIiSGjuUV/iDu1uJVn/BPakXXy63iMQR1WDA/qV++p2ZjBhnfVFYH1GVWfixCjCcszYh/rVWKViGQZtJ0+7HaUZsIS8vMUA6A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ir1msOoy; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ir1msOoy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D36E7C19422; Tue, 27 Jan 2026 13:55:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769522158; bh=8TzTu9mmFQ4jg+51JjtdxRMXvVNt8G/iW3LP00dYge0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=ir1msOoyXL1PuoC6L3u+zkM0JYzup3vqj75SN8giwg8ti93RRQcEx/FYtPaA3qUvg YDupIun6aVb606/CpWijril3jBDkjimxeFY/q10BWBk9XrXhvV51fB6HahcmmwUvYR FnxdxCNRgNYSmNF+wY90JgoessyJvaiFk+Uf3v+j8LR3R4ob/ZZ8nzFJpYLKH55bd1 3VmGEZ5mAxkZmR3utuUOliEq2RwXfefpSzQBnCMHJpOtLJLoVHT23ewZ/36NFprP9c bvjEP+ZnfKZ5VrA7pDgEuXvuev3tOk0Ni6wRB+jazZzUp+jZk8OEKKoTXQVNBzy4Gj G1+x7j3t66Omw== From: Tamir Duberstein Date: Tue, 27 Jan 2026 08:55:50 -0500 Subject: [PATCH v3 1/2] rust: kbuild: extract configs for reuse Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260127-rust-analyzer-pin-init-duplication-v3-1-118c48c35e88@kernel.org> References: <20260127-rust-analyzer-pin-init-duplication-v3-0-118c48c35e88@kernel.org> In-Reply-To: <20260127-rust-analyzer-pin-init-duplication-v3-0-118c48c35e88@kernel.org> To: Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Jesung Yang Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Nathan Chancellor , Nicolas Schier , Linux Kbuild mailing list , Tamir Duberstein X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openssh-sha256; t=1769522154; l=3718; i=tamird@kernel.org; h=from:subject:message-id; bh=8TzTu9mmFQ4jg+51JjtdxRMXvVNt8G/iW3LP00dYge0=; b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgtYz36g7iDMSkY5K7Ab51ksGX7hJgs MRt+XVZTrIzMVIAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA QEttgRf9ZbPuQOM1mzP0CanmFa0tQltsDX0TUgyy0WKFrTLHCtqkUi6kHs1LiGIKmZCkZiXjbOz 4j+0rpmSBqAg= X-Developer-Key: i=tamird@kernel.org; a=openssh; fpr=SHA256:264rPmnnrb+ERkS7DDS3tuwqcJss/zevJRzoylqMsbc Extract `pin_init{,_internal}-{cfgs,flags}` to reduce duplication. Acked-by: Benno Lossin Signed-off-by: Tamir Duberstein --- rust/Makefile | 30 +++++++++++++++++++++--------- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/rust/Makefile b/rust/Makefile index 5d357dce1704..280a18617627 100644 --- a/rust/Makefile +++ b/rust/Makefile @@ -210,16 +210,30 @@ rustdoc-ffi: private is-kernel-object :=3D y rustdoc-ffi: $(src)/ffi.rs rustdoc-core FORCE +$(call if_changed,rustdoc) =20 +pin_init_internal-cfgs :=3D \ + kernel + +pin_init_internal-flags :=3D \ + $(call cfgs-to-flags,$(pin_init_internal-cfgs)) + rustdoc-pin_init_internal: private rustdoc_host =3D yes -rustdoc-pin_init_internal: private rustc_target_flags =3D --cfg kernel \ +rustdoc-pin_init_internal: private rustc_target_flags =3D $(pin_init_inter= nal-flags) \ --extern proc_macro --crate-type proc-macro rustdoc-pin_init_internal: $(src)/pin-init/internal/src/lib.rs \ rustdoc-clean FORCE +$(call if_changed,rustdoc) =20 +pin_init-cfgs :=3D \ + kernel + +pin_init-flags :=3D \ + --extern pin_init_internal \ + --extern macros \ + $(call cfgs-to-flags,$(pin_init-cfgs)) + rustdoc-pin_init: private rustdoc_host =3D yes -rustdoc-pin_init: private rustc_target_flags =3D --extern pin_init_interna= l \ - --extern macros --extern alloc --cfg kernel --cfg feature=3D\"alloc\" +rustdoc-pin_init: private rustc_target_flags =3D $(pin_init-flags) \ + --extern alloc --cfg feature=3D\"alloc\" rustdoc-pin_init: $(src)/pin-init/src/lib.rs rustdoc-pin_init_internal \ rustdoc-macros FORCE +$(call if_changed,rustdoc) @@ -272,14 +286,13 @@ rusttestlib-macros: $(src)/macros/lib.rs \ rusttestlib-proc_macro2 rusttestlib-quote rusttestlib-syn FORCE +$(call if_changed,rustc_test_library) =20 -rusttestlib-pin_init_internal: private rustc_target_flags =3D --cfg kernel= \ +rusttestlib-pin_init_internal: private rustc_target_flags =3D $(pin_init_i= nternal-flags) \ --extern proc_macro rusttestlib-pin_init_internal: private rustc_test_library_proc =3D yes rusttestlib-pin_init_internal: $(src)/pin-init/internal/src/lib.rs FORCE +$(call if_changed,rustc_test_library) =20 -rusttestlib-pin_init: private rustc_target_flags =3D --extern pin_init_int= ernal \ - --extern macros --cfg kernel +rusttestlib-pin_init: private rustc_target_flags =3D $(pin_init-flags) rusttestlib-pin_init: $(src)/pin-init/src/lib.rs rusttestlib-macros \ rusttestlib-pin_init_internal $(obj)/$(libpin_init_internal_name) FORCE +$(call if_changed,rustc_test_library) @@ -547,7 +560,7 @@ $(obj)/$(libmacros_name): $(src)/macros/lib.rs $(obj)/l= ibproc_macro2.rlib \ $(obj)/libquote.rlib $(obj)/libsyn.rlib FORCE +$(call if_changed_dep,rustc_procmacro) =20 -$(obj)/$(libpin_init_internal_name): private rustc_target_flags =3D --cfg = kernel +$(obj)/$(libpin_init_internal_name): private rustc_target_flags =3D $(pin_= init_internal-flags) $(obj)/$(libpin_init_internal_name): $(src)/pin-init/internal/src/lib.rs F= ORCE +$(call if_changed_dep,rustc_procmacro) =20 @@ -642,8 +655,7 @@ $(obj)/compiler_builtins.o: $(src)/compiler_builtins.rs= $(obj)/core.o FORCE +$(call if_changed_rule,rustc_library) =20 $(obj)/pin_init.o: private skip_gendwarfksyms =3D 1 -$(obj)/pin_init.o: private rustc_target_flags =3D --extern pin_init_intern= al \ - --extern macros --cfg kernel +$(obj)/pin_init.o: private rustc_target_flags =3D $(pin_init-flags) $(obj)/pin_init.o: $(src)/pin-init/src/lib.rs $(obj)/compiler_builtins.o \ $(obj)/$(libpin_init_internal_name) $(obj)/$(libmacros_name) FORCE +$(call if_changed_rule,rustc_library) --=20 2.52.0 From nobody Sat Feb 7 11:38:19 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEEFE35B631; Tue, 27 Jan 2026 13:56:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769522161; cv=none; b=SYQ9BLW89cN5eDV4z4ldTM3yo4ZBfXIycbWttMsS2sxdIzhYeTummpcnj+REsUKdFMMjl0DnnfsJZ21+zg1MDVgn0rLS8PQeMkCBDfxTQCTvs1TYfxHiXlPjP6Vos+aeQ7YlE8RO/DxWHtVojoJ2RYJM2eehfc5cL+6rZhqQsWY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769522161; c=relaxed/simple; bh=J9h3BctZhtdKmb7cEw6+613P+IgYkCI1Ng1aDGOU9BE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NA0akFJSCfis1F3Ib27q1Snb1Wvo1b0JVa4OVmQZ1CktTOUp5h9aZLXQNHP9TbYnt5+7ohiWmrhkZuSQaFdcIf+VUf/NU0SIvEk5MAHKz9NkvXoLz0RwVzxnfzpL36iIsplebq8Gqhv0xmfLiyHX2bOlX/fVjWgT9KjuPemgBn8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cLGp59SL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cLGp59SL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06FCAC116C6; Tue, 27 Jan 2026 13:55:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769522161; bh=J9h3BctZhtdKmb7cEw6+613P+IgYkCI1Ng1aDGOU9BE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=cLGp59SLBETGrLCr8IhrFVBMRpxpWZ0YgVhxDDIJo8XiYF6+dGgQZJmIDr7oxjyw+ pcrT5IFEJjElXEVbf1fbAIeC3zVNm/4eBwZR5zPFK/Pehs1Hhx48OmTuEbaBRC0Ki8 zrf3uJgWINYmPFOajC10ORnKTXuQsD+W1OFCDIsYLjGTE/nItPyr3Sm2EI+Lx6GF6o ZACA81I099sCQV6eYKWPbSJlc+q/mHb2HCB1XLm42p7zd2mb+OHxZBY4B/+fGd3WvL XYwLYKZbJo9ilGEyDNTPG30Y24DUdBjaO7fE6+LWDXzf4WFDjZ/fz+6zF5O81I7eqH kswLWS6Fbd54Q== From: Tamir Duberstein Date: Tue, 27 Jan 2026 08:55:51 -0500 Subject: [PATCH v3 2/2] scripts: generate_rust_analyzer.py: reduce cfg plumbing Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260127-rust-analyzer-pin-init-duplication-v3-2-118c48c35e88@kernel.org> References: <20260127-rust-analyzer-pin-init-duplication-v3-0-118c48c35e88@kernel.org> In-Reply-To: <20260127-rust-analyzer-pin-init-duplication-v3-0-118c48c35e88@kernel.org> To: Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Jesung Yang Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Nathan Chancellor , Nicolas Schier , Linux Kbuild mailing list , Tamir Duberstein X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openssh-sha256; t=1769522154; l=4239; i=tamird@kernel.org; h=from:subject:message-id; bh=J9h3BctZhtdKmb7cEw6+613P+IgYkCI1Ng1aDGOU9BE=; b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgtYz36g7iDMSkY5K7Ab51ksGX7hJgs MRt+XVZTrIzMVIAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA QPemx9I9p0FL8tYmnhHr/FuvsMLBa4PzD0WMq4+BxhjiGn0JSqE02nwJc7QJsBXrtN4BWJ+MPIh 8RbI7Hoq9/ww= X-Developer-Key: i=tamird@kernel.org; a=openssh; fpr=SHA256:264rPmnnrb+ERkS7DDS3tuwqcJss/zevJRzoylqMsbc - rust/Makefile: pass `pin_init{,_internal}-cfgs` from rust/Makefile to scripts/generate_rust_analyzer.py. - scripts/generate_rust_analyzer.py: centralize `cfg` lookup in `append_crate` to avoid having to do so for each crate. Remove hardcoded `cfg`s for `pin-init{,-internal}` now that these are passed from `rust/Makefile`. Reviewed-by: Jesung Yang Acked-by: Benno Lossin Signed-off-by: Tamir Duberstein Acked-by: Miguel Ojeda --- rust/Makefile | 2 ++ scripts/generate_rust_analyzer.py | 13 +++++-------- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/rust/Makefile b/rust/Makefile index 280a18617627..2461c5835a7e 100644 --- a/rust/Makefile +++ b/rust/Makefile @@ -583,6 +583,8 @@ rust-analyzer: --cfgs=3D'proc_macro2=3D$(proc_macro2-cfgs)' \ --cfgs=3D'quote=3D$(quote-cfgs)' \ --cfgs=3D'syn=3D$(syn-cfgs)' \ + --cfgs=3D'pin_init_internal=3D$(pin_init_internal-cfgs)' \ + --cfgs=3D'pin_init=3D$(pin_init-cfgs)' \ $(realpath $(srctree)) $(realpath $(objtree)) \ $(rustc_sysroot) $(RUST_LIB_SRC) $(if $(KBUILD_EXTMOD),$(srcroot)) \ > rust-project.json diff --git a/scripts/generate_rust_analyzer.py b/scripts/generate_rust_anal= yzer.py index 147d0cc94068..b96d3cbe3df1 100755 --- a/scripts/generate_rust_analyzer.py +++ b/scripts/generate_rust_analyzer.py @@ -35,7 +35,9 @@ def generate_crates(srctree, objtree, sysroot_src, extern= al_src, cfgs, core_edit crates_indexes =3D {} crates_cfgs =3D args_crates_cfgs(cfgs) =20 - def append_crate(display_name, root_module, deps, cfg=3D[], is_workspa= ce_member=3DTrue, is_proc_macro=3DFalse, edition=3D"2021"): + def append_crate(display_name, root_module, deps, cfg=3DNone, is_works= pace_member=3DTrue, is_proc_macro=3DFalse, edition=3D"2021"): + if cfg is None: + cfg =3D crates_cfgs.get(display_name, []) crate =3D { "display_name": display_name, "root_module": str(root_module), @@ -60,7 +62,7 @@ def generate_crates(srctree, objtree, sysroot_src, extern= al_src, cfgs, core_edit def append_sysroot_crate( display_name, deps, - cfg=3D[], + cfg=3DNone, edition=3D"2021", ): append_crate( @@ -75,7 +77,7 @@ def generate_crates(srctree, objtree, sysroot_src, extern= al_src, cfgs, core_edit # NB: sysroot crates reexport items from one another so setting up our= transitive dependencies # here is important for ensuring that rust-analyzer can resolve symbol= s. The sources of truth # for this dependency graph are `(sysroot_src / crate / "Cargo.toml" f= or crate in crates)`. - append_sysroot_crate("core", [], cfg=3Dcrates_cfgs.get("core", []), ed= ition=3Dcore_edition) + append_sysroot_crate("core", [], edition=3Dcore_edition) append_sysroot_crate("alloc", ["core"]) append_sysroot_crate("std", ["alloc", "core"]) append_sysroot_crate("proc_macro", ["core", "std"]) @@ -90,21 +92,18 @@ def generate_crates(srctree, objtree, sysroot_src, exte= rnal_src, cfgs, core_edit "proc_macro2", srctree / "rust" / "proc-macro2" / "lib.rs", ["core", "alloc", "std", "proc_macro"], - cfg=3Dcrates_cfgs["proc_macro2"], ) =20 append_crate( "quote", srctree / "rust" / "quote" / "lib.rs", ["alloc", "proc_macro", "proc_macro2"], - cfg=3Dcrates_cfgs["quote"], ) =20 append_crate( "syn", srctree / "rust" / "syn" / "lib.rs", ["proc_macro", "proc_macro2", "quote"], - cfg=3Dcrates_cfgs["syn"], ) =20 append_crate( @@ -124,7 +123,6 @@ def generate_crates(srctree, objtree, sysroot_src, exte= rnal_src, cfgs, core_edit "pin_init_internal", srctree / "rust" / "pin-init" / "internal" / "src" / "lib.rs", [], - cfg=3D["kernel"], is_proc_macro=3DTrue, ) =20 @@ -132,7 +130,6 @@ def generate_crates(srctree, objtree, sysroot_src, exte= rnal_src, cfgs, core_edit "pin_init", srctree / "rust" / "pin-init" / "src" / "lib.rs", ["core", "pin_init_internal", "macros"], - cfg=3D["kernel"], ) =20 append_crate( --=20 2.52.0