From nobody Mon Jan 26 22:46:13 2026 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22B9934C98C for ; Mon, 26 Jan 2026 17:30:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769448614; cv=none; b=jeVcTTz6Njt7AvQDWni2kcuRVw4woXButA57cxel6BILjUMCQioVBrQp6fhpEGjtYD8B5z1NH6fgK8zOILfeHG+XRV0qwxWwyQvPkXZy1DGji/dhPhydzJdJHb4Qq3Cj8ZJV3oVfdTt21M93nDrb+TvJMJrppDNwYm45lzjiqL4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769448614; c=relaxed/simple; bh=uTwubkwE+ivwWxf7Ez9DcEqsmyCTQKSKG9A94OtkCSA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=FN28c36VQjaEvzcdhaROt1DzQTH9jEot85MsNC7VfjpVyFeFqTVYaaJk2y1l3KRWwKiLdryrs5ERZ4cY9yjOZNiAUufx932PYGzbinT6YtlTA7v80eQKIGbPou3SFBsQGKGFRS5o/+smKZeaDOM+ZIOSP4UGzOX63jzQnX5ERh0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KQlVSl9h; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KQlVSl9h" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-81ecbdfdcebso2391078b3a.1 for ; Mon, 26 Jan 2026 09:30:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769448612; x=1770053412; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=m1VymzyEZQ1GW8HUdY4DzBAeVbamE/3XvlGQUQ5dl2I=; b=KQlVSl9h7FKyUptiGUe3auuM9XFSFeDQxol3O1rFeW1E7z3hbeRZ0kew1iGIhyVYdC 109L0yNYBejYoSsOFHNCaTYYTcSaCh6LL2ZyYhR7KHX7mTrYZ8biB97JXnpPXVyy3XBS w8mqEfSdwOKfRjBG7lol4N51HFUPfNfC304K4KFpQgevICvfMLrO54uIfZf+J4NZbCNw I0Fyw0KK24LYPnLAvNgthBlLBHN2ROJoYUnrLer1f/X23Xx87uMD8ru14gm0wqsJCJTv fX/B0O9AkmWbNEqmUVnh5n5M0e7KRQUDauxhd5AWOKMjWZz6fPMP1lAYaRL/sncEvQe4 HYng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769448612; x=1770053412; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=m1VymzyEZQ1GW8HUdY4DzBAeVbamE/3XvlGQUQ5dl2I=; b=UG75Q49VqgqFb52BuKJZmOTE7UbYIQdb6DPFOqJ4/hyEWJPLcL7R5DWjIKSeRrOy5m PDe+tgU20G/QDxw0Y//ILqDd7YS7cc6IAfJmLOM7nxaFrsr3gbbEQ5USWbG6m0t/ZkyX /2wHONusOnJZU0J1Doh6viOrrNARmNha5jwuia+/znSJ3DoNUyOzR1cYG4hMuHQSD9T4 IUs3M5wIqGnrznel/zExYU+EUy3hrGPqhChP4riqrOC4uR+jHTONNm9TJJKevOuAAfgD YodvPCL7Ywt3MF0bafcgE7yCxUb0IOZjKyGYyEG8NAHIcBLjsSTkkyfBAprYwGf5TSXa Blog== X-Forwarded-Encrypted: i=1; AJvYcCXMeew54j/hWXrAb50999OpfFtQ5IO9M5Slr4m2bfZqF5/tZnj6hcASGefC9UhF7YuVSY9o79DP+/505Bk=@vger.kernel.org X-Gm-Message-State: AOJu0YwWb0v/5uN/CSn6dPTOGbCg1zkFVjOS1s4+7GqAHPj1v7gDB5mR EvCY/WruXhd/UnzP3XfwRNJCcQyoDAow8n4CCBGfQhRbuB5c7RNZCjrpyvH6Lbd5U/I= X-Gm-Gg: AZuq6aLpfnRB/wQaxJ2zgHTYzbOF6+LuOaHdbjObJIRAg6gkm/0Ex4QEESDdzATnucJ j2hnbGaLylfcuX+pwex4zHdqBJtAViZaDZLSJqJpuFAr1lrauCLB3lUiCWg0X/xOulNkDw81et9 YNFhykYwbyU/dY2kib81pJrqkLDekNqiTiwojYzTki5xwEJSmw1LlQWm/Y4VX/o9Juov+69YvfT 9oeLlu6DdNwLhviN1EXeUwivzXabGZ4cEJiE0U5DPXW5JkZ+4K95P8gZk/TiA1SOJb7Zzoje4Hy afEvZx4b0+yIslERy/PgZDtg4kQJui+1KbLGEDpHAGNrUtcybqbe48yXfJ7Zl4g1nVeK4ccmzM0 /yn5kjoqSm/Bw+HuoAM/ULdpxmCnDV61iIDpa1xQHyOkFOMCeeVTHLXDYAEWtYECwZEHgh67oOe w2hxPigJdQLTxdLXTAag4/P5I= X-Received: by 2002:a05:6a21:6813:b0:35e:e604:f787 with SMTP id adf61e73a8af0-38e9f1cbf1dmr3757936637.39.1769448611979; Mon, 26 Jan 2026 09:30:11 -0800 (PST) Received: from junjungu-PC.localdomain ([223.166.246.160]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c635a4135e6sm8685127a12.25.2026.01.26.09.30.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jan 2026 09:30:11 -0800 (PST) From: Felix Gu Date: Tue, 27 Jan 2026 01:30:07 +0800 Subject: [PATCH] pinctrl: equilibrium: Fix device node reference leak in pinbank_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260127-pinctrl-equilibrium-v1-1-6ae094ac3bf8@gmail.com> X-B4-Tracking: v=1; b=H4sIAJ6kd2kC/x3MSw5AMBRG4a3IHWtCB15bEQOtW/6E4haRiL1rD L/BOQ8FFnCgJnlI+ELA6iPyNCE79X5khSGadKaLLNel2uDtIbPi/cQMIzgXVdre2Lo2VeEcxXI Tdrj/a9u97wehCKNMZQAAAA== X-Change-ID: 20260127-pinctrl-equilibrium-7cabc99b86ff To: Linus Walleij , Rahul Tanwar , Andy Shevchenko Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1769448609; l=1193; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=uTwubkwE+ivwWxf7Ez9DcEqsmyCTQKSKG9A94OtkCSA=; b=h/WPJw5HexHjsJTnfCwregEkHKWcRvmJTltUG1dPrA8WbKXXaSBELNRf2lk08I0YoIj81hAm+ Qd2t05p18OZAMd+hwqNDti68Be1v5vVQ2gMKDaMUNwNsNXITpT6gYPb X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= When calling of_parse_phandle_with_fixed_args(), the caller is responsible to call of_node_put() to release the reference of device node. In pinbank_init(), the reference of the node obtained from the "gpio-ranges" property is never released, resulting in a reference count leak. Add the missing of_node_put() call to fix the leak. Fixes: 1948d5c51dba ("pinctrl: Add pinmux & GPIO controller driver for a ne= w SoC") Signed-off-by: Felix Gu --- drivers/pinctrl/pinctrl-equilibrium.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/pinctrl-equilibrium.c b/drivers/pinctrl/pinctr= l-equilibrium.c index 2d04829b29c9..48b55c5bf8d4 100644 --- a/drivers/pinctrl/pinctrl-equilibrium.c +++ b/drivers/pinctrl/pinctrl-equilibrium.c @@ -846,6 +846,7 @@ static int pinbank_init(struct device_node *np, =20 bank->pin_base =3D spec.args[1]; bank->nr_pins =3D spec.args[2]; + of_node_put(spec.np); =20 bank->aval_pinmap =3D readl(bank->membase + REG_AVAIL); bank->id =3D id; --- base-commit: ca3a02fda4da8e2c1cb6baee5d72352e9e2cfaea change-id: 20260127-pinctrl-equilibrium-7cabc99b86ff Best regards, --=20 Felix Gu