From nobody Sun Feb 8 19:55:54 2026 Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51ECF2D7D2F for ; Tue, 27 Jan 2026 14:23:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769523810; cv=none; b=oIM3sNTG8flOZxQuLh6r7ZwZutcyKs/IU2zxPpYwS1YgbOdkwxSTMw34XqcFMLTpov2NXe52bCnRUx0dhVCmHAs8CqVcl/sP+9Vb9BOoUTL8eg77S3rJ0N+wf2XKN4UfUR6M73VR0GUspsEqAxcj46SfDj+woGKWh7FnXdgFOOQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769523810; c=relaxed/simple; bh=/43NTVER+1X1uTWs1qLJMdDkJzK7k1BHZT5ZPLTsXsg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=NJNwu/8ip7/gXgQRh/gfoXRJ3WKM0MmyhNYKm9gxG5/Ji/UACkBEel2uCPO66ONurQAcrWRhaAD7zYKpBjtlHd2SMdwr8mTLfcmV6mexS5PJrTHnNS+bVY6JXvMVMJfbvwdpYbBw4HZXujVynancRAmM/IUe5jFrBeRI1IknVns= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fa2/4dNb; arc=none smtp.client-ip=209.85.214.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fa2/4dNb" Received: by mail-pl1-f194.google.com with SMTP id d9443c01a7336-2a09d981507so39265135ad.1 for ; Tue, 27 Jan 2026 06:23:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769523809; x=1770128609; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=wxBsL8rjioxCsA14jZXgtyRCy4Ul5M3AG/gOUFcFYso=; b=fa2/4dNbRvq40HuxRGLeZRPjbsQ5LPcn1MAv6GO21TrHbwogzsTLVtXCg7Srs9txW4 os9NWinhy5oykwVYwTyn8BI/9u+Dk5L8Omx5fBEu/S+VPy39OR3jfkLBTadcH96r1nDi DV11wDgraMBTuw8Mux0rsFjPI/fuGz4w4VpoWEfYCAUJOIfn+FAZhpLDfHK01CI4h8AJ nJnLI5O4nW5gQcOeRZPnSoXfUmEv84qstim/CJXFTQQVK6d24HlalMH3PkUkEIWlr8LG ijeNVvgXp00rYTk3xNbEmFjSG67vC84IwbMUAR4jUSVWCHXndjJA5Namp+YlxpyfcICM jEsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769523809; x=1770128609; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wxBsL8rjioxCsA14jZXgtyRCy4Ul5M3AG/gOUFcFYso=; b=QNHo/uOXBHtz6SEx07Mm2MnDRZjhJB6P4kKJV5IF1cfZUntWtlfTcn97RsF7NGkqda wrcb9zsurQLp/y/pKNrQcw3/OAbowYRXiUra0+zbWrf5+yA93YPrTiZrXiCYH9UE+mQo q/Q3Q9/Y/dpzEcjg0v+e1FqU+OJ3sjvmqnad+tDaj3jRwM88g+5ldBcTFpwk2mJNA4jj OIzVoLVKzjVuQ+FC0pWONaObt/pUimxip+bYcpYp8Nd5lzxCBN3XbKG61rRYw99cJJbn BqxEYSUxG2aekEwflYeuJO2Uo1TRtbt9hWMbqMRV1iJwT2EYJkgOK8xdw4wxfElF06yC Ab6g== X-Forwarded-Encrypted: i=1; AJvYcCXc+jCMMlatDcvjPUKkHrHdDwpw0e0LqGJjlIog4CRzRyxKj/BAnbGFR8MVEgbRJNfoc1FQn+qP6kyKPXM=@vger.kernel.org X-Gm-Message-State: AOJu0YwruJ3WXhGczRytri28fMCLxsoTRyi4ivY1wIY51zXSKNcOKAt0 B1gdUCuX/41FKB2FiWUYyUrsOi+Qv9gBRou3XKkUQ8c1LIVquxt4nN0lU+BrTNYzAy8= X-Gm-Gg: AZuq6aKmMAnVCpxR0Frn+NV/jXCZpDoJT6Hs/ZKdd7Br3PP2GlGVzRh0iW8M9uRvvN8 NGpknEY7XCmAIJyacgeCaLFAIB36HmKxYuKjz3ZqheM1zD0jkaJlKLhD+YdWQNioeO1oONNkZdR 1kkZQFYCPSPPKi2tenojWRVzgjDD8A2OhULUKNNPi3Myas8kEQgJNaAmJsNvW6AjVzJ+YqsaDBH nE4MGdz+HnOFVMlgccyYX53/Nt1/owBQS+13W4qIt/nvldxDngXbFDghgf//R69HJQ10UOAfXIE iHomI5eZxdx8lnqNROVnqQ0I7K9ROND4kyJEznQzdJbjr7+HHZFMS3V5ea/x8mUl9rzWH3OBr4e mAbw2sBCKWrxD2YHwIMLM/Aw50u1w+r61H7YdSGoo5grMgNLoo20kiNxe21zi5ARxnYPTz3NEPw CvW1IfD7MgIwqwuBUXCvk= X-Received: by 2002:a17:902:f54f:b0:2a7:b412:6cc8 with SMTP id d9443c01a7336-2a87122683emr15530315ad.1.1769523808569; Tue, 27 Jan 2026 06:23:28 -0800 (PST) Received: from [172.16.80.107] ([210.228.119.9]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a802ede6fesm118812305ad.45.2026.01.27.06.23.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jan 2026 06:23:27 -0800 (PST) From: Ryota Sakamoto Date: Tue, 27 Jan 2026 23:23:23 +0900 Subject: [PATCH] ext4: Replace KUnit tests for memcmp() with KUNIT_ASSERT_MEMEQ() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260127-fix-fs_ext4-memcmp-v1-1-5c269ae906b6@gmail.com> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/x2MQQqAIBAAvyJ7bkFNMvpKRISttQdLNEKI/p50H JiZBzIlpgyDeCDRzZnPo4JqBLh9OTZCXiuDlrqTSlv0XNDnmcplMFBwISL1Uhlre+dtCzWMiar 1T8fpfT9+yhNIZAAAAA== X-Change-ID: 20260127-fix-fs_ext4-memcmp-e8014778cf73 To: Theodore Ts'o , Andreas Dilger Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Ryota Sakamoto X-Mailer: b4 0.14.2 Replace KUnit tests for memcmp() with KUNIT_ASSERT_MEMEQ() to improve debugging that prints the hex dump of the buffers when the assertion fails, whereas memcmp() only returns an integer difference. Signed-off-by: Ryota Sakamoto --- fs/ext4/mballoc-test.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/fs/ext4/mballoc-test.c b/fs/ext4/mballoc-test.c index a9416b20ff64c930d90fc177d01cd6a4639d8333..85613b1811cd7c7b7410acff602= 8f0eabf28ef2c 100644 --- a/fs/ext4/mballoc-test.c +++ b/fs/ext4/mballoc-test.c @@ -710,8 +710,7 @@ do_test_generate_buddy(struct kunit *test, struct super= _block *sb, void *bitmap, ext4_mb_generate_buddy(sb, ext4_buddy, bitmap, TEST_GOAL_GROUP, ext4_grp); =20 - KUNIT_ASSERT_EQ(test, memcmp(mbt_buddy, ext4_buddy, sb->s_blocksize), - 0); + KUNIT_ASSERT_MEMEQ(test, mbt_buddy, ext4_buddy, sb->s_blocksize); mbt_validate_group_info(test, mbt_grp, ext4_grp); } =20 @@ -772,8 +771,7 @@ test_mb_mark_used_range(struct kunit *test, struct ext4= _buddy *e4b, grp->bb_counters[i] =3D 0; ext4_mb_generate_buddy(sb, buddy, bitmap, 0, grp); =20 - KUNIT_ASSERT_EQ(test, memcmp(buddy, e4b->bd_buddy, sb->s_blocksize), - 0); + KUNIT_ASSERT_MEMEQ(test, buddy, e4b->bd_buddy, sb->s_blocksize); mbt_validate_group_info(test, grp, e4b->bd_info); } =20 @@ -837,8 +835,7 @@ test_mb_free_blocks_range(struct kunit *test, struct ex= t4_buddy *e4b, grp->bb_counters[i] =3D 0; ext4_mb_generate_buddy(sb, buddy, bitmap, 0, grp); =20 - KUNIT_ASSERT_EQ(test, memcmp(buddy, e4b->bd_buddy, sb->s_blocksize), - 0); + KUNIT_ASSERT_MEMEQ(test, buddy, e4b->bd_buddy, sb->s_blocksize); mbt_validate_group_info(test, grp, e4b->bd_info); =20 } --- base-commit: fcb70a56f4d81450114034b2c61f48ce7444a0e2 change-id: 20260127-fix-fs_ext4-memcmp-e8014778cf73 Best regards, --=20 Ryota Sakamoto