From nobody Sat Feb 7 06:14:50 2026 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F09762F8BCA for ; Mon, 26 Jan 2026 21:56:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769464566; cv=none; b=s4BMzYREq8IcnGnSx70jqi3McUlM1eI+E3o2iHu+nPwXnjnoaJ3l1bCc0mPFLyt8D/zrBGPIdciag7X5DDQCURG/UsPkw+15/1BgIxwttIcPeNtWpj4EP4R0opWuiCh1lp4ToWEp6x3eNXDtLqR+gQvMHo5Y1wELkzd1IelCBQM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769464566; c=relaxed/simple; bh=fJ3znz89OgJOjd50tWt/s9ggvgZ7jvDqWLqyjMa6VU8=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=Ulws6vc6ls1IOhhbuCojiGlF1zn7RVxaqC/hc6tgQ5XXf5N4F4BJLXqyjjASWRr+qq6YvFMuCEy1S19m0/M5QKzI50UONapjz671jENKfptOPKDSgU/GP2VeFRt0+QNuv/JIzbwbB69F0N2EKAhxJDkpt/Iej8zHMJAc8p8BQwc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--brianvv.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=j9mBZ7UF; arc=none smtp.client-ip=209.85.214.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--brianvv.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="j9mBZ7UF" Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-2a13be531b2so49066125ad.2 for ; Mon, 26 Jan 2026 13:56:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1769464564; x=1770069364; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=ehmTA1o3oHWV2JS6XnM6t9zEYMHCZAFgQr8k6VR/OCY=; b=j9mBZ7UFJ5wW6HuLZFDIYEHAqLMwhwrL3rYS11av2t7H7UY9Ju+myLgLSUaH7J90Tz PeD1uonGxOnZY/0880OQAXsGC68WAwX6lcJ4JNRIH1NQYV31Nkjy9kpo+9ukVLNaIdxE C2BLS3S4bebv1mkUx4nfXkGhHvt62AGDcCw3rU0h8/wUoiZ1ceydowOnKjbCdVoDnhhA cJJzry+cmIovQEBDU+t1wDNJAbjct9DooQAbtBjsUm6xqAb6mDr+/88XDNNdFjKEmAqf shUFS621iBhGrOYVs7XbiM35eFMiM1TMJtvo9xLz2iEHepu/aqS4ASoAhUERRMzHAuog FTZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769464564; x=1770069364; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ehmTA1o3oHWV2JS6XnM6t9zEYMHCZAFgQr8k6VR/OCY=; b=Qnc4BzTTjeltIhmrWfxTx4fnuPFw8RDb7qk4FTx8CfjUo1J763h/I70TZSN0MMUL3q xKhHzwz0WTsNuKHPa42gX1x+YKtE8JIWqqMoOP7V5LKV5quBdIBi2Ts3JqFt/VBnGwhs zax7/x4Vzh6S2TT5z7s7XH3CHTGnQz5G2VCJBV4KrB70Y80RPPKOtCUgTBrfJnLu91gY eUObkqJB3ILbXqi7X+XWjOl1yBBBurHZMqg/+qNRllfuW2E28kapF/fvXjXZ+NRQI1sT iSWw+SJFJOx2iEMollXlne84Gvd7ns3aZe90l/KbXLPjugb4+pRLW+FsnZNltGFTKVtu 2uIQ== X-Forwarded-Encrypted: i=1; AJvYcCUaoHR5aVTkG9Cr4YIeKCWJ+Puj1OubmKI4FvKrtF02frsczckGP5wMx/5NIIVVYJO/3eClffQoRvgOu40=@vger.kernel.org X-Gm-Message-State: AOJu0YwWWUySIMYC5X/KysTchcvLxHeB30OOH7kxDPMxDSiaofF0HrC+ s/7MJyass0i8Y0NbepLAwNASjLPqd7T4ACJVT/zPUGHPqwQx4GS1ofB0iiZ66CiJHmKqgtCBxql X0U2p0vBQIQ== X-Received: from plbbb9.prod.google.com ([2002:a17:902:bc89:b0:2a7:d253:e3bf]) (user=brianvv job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:2f4c:b0:2a1:3ee7:cc75 with SMTP id d9443c01a7336-2a84525785bmr53056755ad.19.1769464564175; Mon, 26 Jan 2026 13:56:04 -0800 (PST) Date: Mon, 26 Jan 2026 21:55:59 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.52.0.457.g6b5491de43-goog Message-ID: <20260126215600.3387171-1-brianvv@google.com> Subject: [iwl-net PATCH v3] idpf: change IRQ naming to match netdev and ethtool queue numbering From: Brian Vazquez To: Brian Vazquez , Tony Nguyen , Przemek Kitszel , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , intel-wired-lan@lists.osuosl.org Cc: David Decotigny , Li Li , Anjali Singhai , Sridhar Samudrala , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, emil.s.tantilov@intel.com, Brian Vazquez , Brett Creeley , Aleksandr Loktionov Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The code uses the vidx for the IRQ name but that doesn't match ethtool reporting nor netdev naming, this makes it hard to tune the device and associate queues with IRQs. Sequentially requesting irqs starting from '0' makes the output consistent. This commit changes the interrupt numbering but preserves the name format, maintaining ABI compatibility. Existing tools relying on the old numbering are already non-functional, as they lack a useful correlation to the interrupts. Before: ethtool -L eth1 tx 1 combined 3 grep . /proc/irq/*/*idpf*/../smp_affinity_list /proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167 /proc/irq/68/idpf-eth1-TxRx-1/../smp_affinity_list:0 /proc/irq/70/idpf-eth1-TxRx-3/../smp_affinity_list:1 /proc/irq/71/idpf-eth1-TxRx-4/../smp_affinity_list:2 /proc/irq/72/idpf-eth1-Tx-5/../smp_affinity_list:3 ethtool -S eth1 | grep -v ': 0' NIC statistics: tx_q-0_pkts: 1002 tx_q-1_pkts: 2679 tx_q-2_pkts: 1113 tx_q-3_pkts: 1192 <----- tx_q-3 vs idpf-eth1-Tx-5 rx_q-0_pkts: 1143 rx_q-1_pkts: 3172 rx_q-2_pkts: 1074 After: ethtool -L eth1 tx 1 combined 3 grep . /proc/irq/*/*idpf*/../smp_affinity_list /proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167 /proc/irq/68/idpf-eth1-TxRx-0/../smp_affinity_list:0 /proc/irq/70/idpf-eth1-TxRx-1/../smp_affinity_list:1 /proc/irq/71/idpf-eth1-TxRx-2/../smp_affinity_list:2 /proc/irq/72/idpf-eth1-Tx-3/../smp_affinity_list:3 ethtool -S eth1 | grep -v ': 0' NIC statistics: tx_q-0_pkts: 118 tx_q-1_pkts: 134 tx_q-2_pkts: 228 tx_q-3_pkts: 138 <--- tx_q-3 matches idpf-eth1-Tx-3 rx_q-0_pkts: 111 rx_q-1_pkts: 366 rx_q-2_pkts: 120 Fixes: d4d558718266 ("idpf: initialize interrupts and enable vport") Signed-off-by: Brian Vazquez Reviewed-by: Brett Creeley Reviewed-by: Aleksandr Loktionov Reviewed-by: Eric Dumazet Reviewed-by: Paul Menzel Tested-by: Samuel Salin --- V3: Add more context to the commit message V2: Add mising Fixes tag drivers/net/ethernet/intel/idpf/idpf_txrx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/idpf/idpf_txrx.c b/drivers/net/ethe= rnet/intel/idpf/idpf_txrx.c index c2a1fe3c79ec..c1f8dfc570ce 100644 --- a/drivers/net/ethernet/intel/idpf/idpf_txrx.c +++ b/drivers/net/ethernet/intel/idpf/idpf_txrx.c @@ -4093,7 +4093,7 @@ static int idpf_vport_intr_req_irq(struct idpf_vport = *vport, continue; =20 name =3D kasprintf(GFP_KERNEL, "%s-%s-%s-%d", drv_name, if_name, - vec_name, vidx); + vec_name, vector); =20 err =3D request_irq(irq_num, idpf_vport_intr_clean_queues, 0, name, q_vector); --=20 2.52.0.457.g6b5491de43-goog