From nobody Tue Jan 27 00:10:01 2026 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 530EF336EF8 for ; Mon, 26 Jan 2026 16:22:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769444534; cv=none; b=Mm8neVna9IeQYT1cvLE6Ew+sTj5K8j7D1OoCB73O1glaQelGDM3RCDxPa4SETcTVWZtx+SdlM6R4zEiOWg1z+l2ZbjdEHvirFFm/5WabOk5rLMP4eX70yc6roDceVunlBdS847NWtbqagS9Yk0025muKAsmCgRrrZYryvbEDObk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769444534; c=relaxed/simple; bh=x0VpZkifpmsZOeiUeKRVj5l01SHfLNEX+dBjXy+hSXo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uf2jj5rlpuZ7fQCbVKdSWcB5rFJY4gCpYxVhdodZj0wPQjXX0KSdwUR4OexMsbtDVECgEVZBE3HsqnO3fVN6rbOVBA8MgLpyDvo4ucqZ3wxWDLQg8sjNd0i74JpvfEuAFJ8dvuyHXoEowesTn2izEgztTuLyOa8Q6sHhJzk0dFw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MDD5Mgtc; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MDD5Mgtc" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-47ee76e8656so69059365e9.0 for ; Mon, 26 Jan 2026 08:22:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769444532; x=1770049332; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=URd/ONh2/S9cNJVZREq3Fly7rFEXScu5qM+CsEx4Im0=; b=MDD5MgtctpRRjYz+uxJcfZUdSpxd17M7hI+fod1yAbk1+UWrBwnbhTg6yEtQqbXHpp wbbaNlnpaAh1bq8ErLe53dDajcr7T8sXWllfkdulpbb6fr1Cu+ppmm9oxnQT/QBOLRch MTPoFrwzsrFawQj27BweCwKV2CeEDGANt/FqswD9RLr+2pMhkl7l7szdIxI5ci65ehS4 QpLC3zstdrbyCowq9Kl6hS0+vnJDkqTfn9AqKU7efSEjebUisrYoWIrVgvlrbNtL8VE7 UP/mi0KmuzeQl7oaZdk1g8b3b/lAVC9aJSfUgV7PrlWkF1WIlsdDct5SgJLffMIMPfPo MH8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769444532; x=1770049332; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=URd/ONh2/S9cNJVZREq3Fly7rFEXScu5qM+CsEx4Im0=; b=b+GpkZ1bjzn52YLSb4l4nT3ir+r/MeruyQQhS5J+9o78QpPNRqVNZE9de5hViAcVgh NUFsWEyTD1847cof96BoL9MhqdgC8x4gqEGrqOEs2M/3Ub33CohENYCLE7SOfwDetlcw 0loyTD1lPZaS4oCu2uyjmoim4rVWfAHUqzClhv127qaDhK8w8apFoXlS8sS6NfQRL+hX kRvVyLB5juP0BZHmQuQN4YzDqSWVL/eg8MJoRAWBit72F7/xvgFnyu7JVJxLPw1xt1EA Gp03fb77MUoafMX0iLhwl8SZYdffaWOO2PCZ70mvrDMA9GYp+9g2KcK4xc36IUg08FHV w6OQ== X-Forwarded-Encrypted: i=1; AJvYcCVUMJTh8aNI0tbQvRmXvAFwNNCXpFfNUnRUTwaR/IQysieihaLmWeiW7L7Q7/hIVM908CWuDN6JO8IPgtc=@vger.kernel.org X-Gm-Message-State: AOJu0YySwBOsgSUG5V7T/6+1bDmyHaom4rXlkDTvhvIYAXsbDL4RPZde eV2BBkbnd7ZRcnopUL6JKrGSJG8tlq0EGQAqVOHy/knG5tD8SbUy/tJ0 X-Gm-Gg: AZuq6aLOUayKrjAe8dK14Zdx92gruYYOu/vkrYv+MXje9oNAA/YS2xo2i9x9+T0bwR5 TUeKJTLZlcJPz4/fBeRVsQabbpKrJXRvIP5pwXH/nwngKl4yaIOqINR0LsqsYezf1ETRwze0bwD 2zb4nuYhgxXLH16LNDN2ARbb5FVFDmwt+v2Kk1IEiqAbP+Z0xSSD/IPGPWj8r/Owb24uIAmBfov LNKfIWtpkJUSij1Szt3/dXzK4ala++RK/BV0aS8aO4YzwSt86OP2gqkJIdiqbTI0gCSPdXzAGZm l9A6yUKSSnKD8112c+qvtvybTXea77lctzs92Mn/auEL2RW3sTNL2FrHuDnyzvPHwakvKbDYwRK y7gq2u2qOiQ5P4bAJKPZlSF0wD3bQiPAbIg8bYk/dSUNV1MvrkHenE0ephWLjGSh5bGu+GOIRhC 9S45oMhdTAPGWmBiIv+M9IrzA2QpX4sRc/Ybtd8w== X-Received: by 2002:a05:600c:35c2:b0:47f:b737:5ce0 with SMTP id 5b1f17b1804b1-4805cf66771mr88446235e9.23.1769444531205; Mon, 26 Jan 2026 08:22:11 -0800 (PST) Received: from SMW024614.wbi.nxp.com ([128.77.115.158]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-480470cf1acsm370371035e9.14.2026.01.26.08.22.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jan 2026 08:22:10 -0800 (PST) From: Laurentiu Mihalcea To: Philipp Zabel , Shawn Guo , Fabio Estevam , Daniel Baluta , Frank Li Cc: imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Pengutronix Kernel Team Subject: [PATCH v7 1/4] reset: imx8mp-audiomix: Drop unneeded macros Date: Mon, 26 Jan 2026 08:22:00 -0800 Message-ID: <20260126162203.708-2-laurentiumihalcea111@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260126162203.708-1-laurentiumihalcea111@gmail.com> References: <20260126162203.708-1-laurentiumihalcea111@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Laurentiu Mihalcea The macros defining the mask values for the EARC, EARC PHY resets, and the DSP RUN_STALL signal can be dropped as they are not and will not be used anywhere else except to set the value of the "mask" field from "struct imx8mp_reset_map". In this particular case, based on the name of the "mask" field, you can already deduce what these values are for, which is why defining macros for them doesn't offer any new information, nor does it help with the code readability. Reviewed-by: Daniel Baluta Reviewed-by: Frank Li Reviewed-by: Philipp Zabel Signed-off-by: Laurentiu Mihalcea --- drivers/reset/reset-imx8mp-audiomix.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/reset/reset-imx8mp-audiomix.c b/drivers/reset/reset-im= x8mp-audiomix.c index eceb37ff5dc5..acfa92b15329 100644 --- a/drivers/reset/reset-imx8mp-audiomix.c +++ b/drivers/reset/reset-imx8mp-audiomix.c @@ -6,6 +6,7 @@ #include =20 #include +#include #include #include #include @@ -14,11 +15,7 @@ #include =20 #define IMX8MP_AUDIOMIX_EARC_RESET_OFFSET 0x200 -#define IMX8MP_AUDIOMIX_EARC_RESET_MASK BIT(0) -#define IMX8MP_AUDIOMIX_EARC_PHY_RESET_MASK BIT(1) - #define IMX8MP_AUDIOMIX_DSP_RUNSTALL_OFFSET 0x108 -#define IMX8MP_AUDIOMIX_DSP_RUNSTALL_MASK BIT(5) =20 struct imx8mp_reset_map { unsigned int offset; @@ -29,17 +26,17 @@ struct imx8mp_reset_map { static const struct imx8mp_reset_map reset_map[] =3D { [IMX8MP_AUDIOMIX_EARC_RESET] =3D { .offset =3D IMX8MP_AUDIOMIX_EARC_RESET_OFFSET, - .mask =3D IMX8MP_AUDIOMIX_EARC_RESET_MASK, + .mask =3D BIT(0), .active_low =3D true, }, [IMX8MP_AUDIOMIX_EARC_PHY_RESET] =3D { .offset =3D IMX8MP_AUDIOMIX_EARC_RESET_OFFSET, - .mask =3D IMX8MP_AUDIOMIX_EARC_PHY_RESET_MASK, + .mask =3D BIT(1), .active_low =3D true, }, [IMX8MP_AUDIOMIX_DSP_RUNSTALL] =3D { .offset =3D IMX8MP_AUDIOMIX_DSP_RUNSTALL_OFFSET, - .mask =3D IMX8MP_AUDIOMIX_DSP_RUNSTALL_MASK, + .mask =3D BIT(5), .active_low =3D false, }, }; --=20 2.43.0