From nobody Mon Jan 26 22:56:03 2026 Received: from mail-m155101.qiye.163.com (mail-m155101.qiye.163.com [101.71.155.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D225F13A244 for ; Mon, 26 Jan 2026 15:27:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=101.71.155.101 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769441250; cv=none; b=ptGZPNs5aW36v8R/nWhQsWtYJXcIToLgZ4UhHYrs6R+0JgyCVLqeZ9qrMfM7hh0SAUhd59cwPxq61S8yXtsJdAn353H7cmNJ93AEwyKIaOPTTAMIdH/CgjHEYB5YOFYsoofU5rrJDuTteU36DFXR50+jvPL9DqA8/gVIoFJxLzQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769441250; c=relaxed/simple; bh=tfsRHXT3Avx+0QKxUOxMIHpRqp71Edg/sPsLlQMGt6w=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=UJe39Xuyx8YrkRnQaSz2D7og4psjap5WRNNWnBaIOFF8RntMfIXsphWLsQfBpadT0twT+RGsRYcqohIajEjbilCxHdnku0C/S52m1MlrhvbQ/fjIH+fWZC7a7ZGlmLpoekmDmoDNJLoSe+4kFwCZfGgZkdbMmr+weumIQZusM6w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=seu.edu.cn; spf=pass smtp.mailfrom=seu.edu.cn; dkim=pass (1024-bit key) header.d=seu.edu.cn header.i=@seu.edu.cn header.b=VjvO9Upn; arc=none smtp.client-ip=101.71.155.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=seu.edu.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=seu.edu.cn Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=seu.edu.cn header.i=@seu.edu.cn header.b="VjvO9Upn" Received: from LAPTOP-N070L597.localdomain (unknown [58.215.202.202]) by smtp.qiye.163.com (Hmail) with ESMTP id 3203f8b2c; Mon, 26 Jan 2026 23:27:22 +0800 (GMT+08:00) From: Zilin Guan To: jani.nikula@linux.intel.com Cc: joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tursulin@ursulin.net, airlied@gmail.com, simona@ffwll.ch, chris@chris-wilson.co.uk, lionel.g.landwerlin@intel.com, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, jianhao.xu@seu.edu.cn, Zilin Guan Subject: [PATCH] drm/i915/gem: Fix memory leak in i915_gem_do_execbuffer() Date: Mon, 26 Jan 2026 15:27:18 +0000 Message-Id: <20260126152718.276013-1-zilin@seu.edu.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-HM-Tid: 0a9bfaeaacc103a1kunmbbba5180fa35 X-HM-MType: 10 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFITzdXWS1ZQUlXWQ8JGhUIEh9ZQVlCTxlJVkxPSRhLGEIdGE1KHlYeHw5VEwETFhoSFy QUDg9ZV1kYEgtZQVlOQ1VJSk5VSUtJVUlLSVlXWRYaDxIVHRRZQVlPS0hVSktJSE5DQ1VKS0tVS1 kG DKIM-Signature: a=rsa-sha256; b=VjvO9UpnjEKAnCi4MyUbu63T9qyX6Nt5SxWZLvLwzZfFxsn11EHqJru50P62/3zLuTmhMPgHBXy3+qQgv9nmGvjKcRDih5CHcY9v0CrWtx7VGibbwkx0tiW9AdTHh4SKWif4VpwV62I3F1oNA7sKYBVw3D1slr8zWasKv64kdHs=; s=default; c=relaxed/relaxed; d=seu.edu.cn; v=1; bh=gNpAAdRUMg/ZRAkntu9Cwk86cxeJUQGqQwcMGXeBiNk=; h=date:mime-version:subject:message-id:from; Content-Type: text/plain; charset="utf-8" In i915_gem_do_execbuffer(), add_fence_array() allocates and populates eb.fences. Immediately after this, if both IN_FENCES flags are set, the function returns -EINVAL directly without calling put_fence_array(), resulting in a memory leak of the allocated fence array. Fix this by jumping to err_ext in the error path, ensuring that put_fence_array() is properly called to release the fence array. Compile tested only. Issue found using a prototype static analysis tool and code review. Fixes: 13149e8bafc4 ("drm/i915: add syncobj timeline support") Signed-off-by: Zilin Guan --- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/d= rm/i915/gem/i915_gem_execbuffer.c index d49e96f9be51..43f267f98ba0 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c @@ -3407,8 +3407,10 @@ i915_gem_do_execbuffer(struct drm_device *dev, =20 #define IN_FENCES (I915_EXEC_FENCE_IN | I915_EXEC_FENCE_SUBMIT) if (args->flags & IN_FENCES) { - if ((args->flags & IN_FENCES) =3D=3D IN_FENCES) - return -EINVAL; + if ((args->flags & IN_FENCES) =3D=3D IN_FENCES) { + err =3D -EINVAL; + goto err_ext; + } =20 in_fence =3D sync_file_get_fence(lower_32_bits(args->rsvd2)); if (!in_fence) { --=20 2.34.1