From nobody Sat Feb 7 17:42:07 2026 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5E00334C1A for ; Mon, 26 Jan 2026 12:10:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769429417; cv=none; b=L5O2MRcaiLjKuatLjEabb3UDfLhmj5oAe74gvmWoMchq2fpw1V1WpNffin7ZCJXTGh2iBO/fqFeQwF1d35xr4tdKkcGoRsUjij0xBZWbvSM0dRMMqTkt0es0ejeO58qezYMuZIIWTXfKsR/6jz+xfXzekSKFkv98wpvgCdPjHIs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769429417; c=relaxed/simple; bh=7/gNhqWazny3OyL0y4jesOeRtItr1Lf5eqPoiLHFWbA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=BiFfGgBOSxQlb0g0vp3XJ24arNhEawAVgUeBU818gOTsnMtpg8ubv8zW11TAveAnn5UnfOCpMmbCuyT1dI2dXFygeJc7vPm1EOyNehH6pBmaVpNvUn+7bgbDc8VWtEXsj9bXMaOSvLTc7DdREmUQU2pJN6U7VTiB6Cu0azPJyfc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bEXw2oaw; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bEXw2oaw" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-8230c33f477so1818030b3a.2 for ; Mon, 26 Jan 2026 04:10:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769429415; x=1770034215; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=NqZGJGsBG2P7D4vFR0AdHyYXZpLRsBLzqt7Wa5rjGTU=; b=bEXw2oawVMsRl1ZcH0v1icQf3UjKuW33M/90PrlxSAemNcF+tePHX4xZNjXx4eF9x+ Arp4OICcckx/3ZEIO0uXFcimDnCucYp/g+c/pgJYv+nPQ4uv/N3n+wCm7Ibr55Tj1Ppt yZ6Wpaxd0TJxPSf9InVrGhi6Mpa1+2FQNnFLXLMEH1s12jetDugeAxPPkaitrv/zQwNb ddblEdCoGV7DMjd7YsZOTvMZunFZZ+zwvxAlNivQ7rI25wMxO1+Jxt/6bE3KsNFa7YAe iggH2Joo7DvuKC9g1yFQ/Dj6rz+qNLx+BSsNfmDS91Sey3QjI2OOosDTo02T4EnCEHBz IIjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769429415; x=1770034215; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NqZGJGsBG2P7D4vFR0AdHyYXZpLRsBLzqt7Wa5rjGTU=; b=OIhQrPlmcuvLqgCOhu7A7fJnf1bBUyeN89NqgQO3LGo/dmVwv7IaJOM7soMTYMZSLm YK2S2q084S7U947mwfNLaKYOweh45uvVGeT8TuGfnpqNQx4PLPQhx9qaD0cDjtlQRSUV z4RG+Mgd058Lcxp1UW8ZcZthoYQCkIF7sYbD0ejVSaO664DkfHZ23PEf0wQfS08kTnqp c3EbNHBosMZ62bQdorsW8jgdXCXOr5ZhbfHDkEXrbMK96YulsQNWbbzXQJYT2jsZQU/0 d5ToVWEoWYKRPbLTKkIcGzqNBmnOc9lZstUE5gHPDhLb/i9zEWX47seba02SNuiaKLLe gr6g== X-Forwarded-Encrypted: i=1; AJvYcCXZ90TVR++xl1unO8lmmYSq2r4RADiMC56VPPtMnRRRiKohLcGSKYuv4hGv8wK8nTYQnK37S7Xac11TLyA=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+25SxOvre0pOVq08uavVvaMGJJ4e+Xl79ugztr3Wf7C8XjXxT L2fpDuMZS2mTCwXrKQ8JSIRwIDeaJn18av/q/pVho6ItqCrpnbwjVJKy X-Gm-Gg: AZuq6aJWFYhrZrinhkZuIH4izeYg+EbrzBJAhnqUje51JsEoMPgAuq9YG9YiLTWZgmF unQHOxsyGq3wjYjXA5FP+GMN0dfk42euABxxw+1om8bf43p0zbp0ddmfQiUWETiPHdIFhVRcYjb NAbZMdhidyAqHe5DYQiB0fDVLhtj3zjtd9pXV3ASxi4HkPVEuHYThF1TfNPG1idqQmoXYBwcShp Mr0TvnayWbfCXwLbFAMxT9ziGxJ/WbXaXsiYPZPbMpPkRKQzzU2V6KaxW2HRtbgPoHUxICMWU84 l60PdGEhsReGCfYOE+sSg1QOKDNDWCsNEjQT+sEr53gCFJjgmFo0MoJfG0Ta2ykClZ+xxGo+4pR 0Kz/B4V1J6P3KWg8Sj5HdXweZv6Qw6O9oqdea5T7F6IZg0bOpqhllxwg44PADtVHSolXtm2OAxk /AieC63b8lvOMAue2IbJz+MnUQUw/sLb8L X-Received: by 2002:a05:6a00:2355:b0:81f:5ec1:8bcd with SMTP id d2e1a72fcca58-8234122bd0emr3573059b3a.20.1769429414956; Mon, 26 Jan 2026 04:10:14 -0800 (PST) Received: from tehuang-Alienware-m16-R2.. ([50.47.240.160]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8231871d512sm9319854b3a.33.2026.01.26.04.10.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jan 2026 04:10:14 -0800 (PST) From: Michael Huang To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Huang Subject: [PATCH v3] staging: rtl8723bs: remove unnecessary boolean comparisons Date: Mon, 26 Jan 2026 04:09:07 -0800 Message-ID: <20260126120908.19563-1-tehsiu.huang@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove explicit comparisons to true/false in boolean expressions to improve code readability and follow standard Linux kernel coding style. Signed-off-by: Michael Huang --- v3: - Reduced the series to a single patch. - Dropped the redundant "else" statement cleanup as it was already=20 merged into staging-next (commit 09a9c4bde41c). - Rebased on top of the latest staging-next branch. - Fixed minor alignment and line length issues in modified lines to comply with checkpatch.pl. v2: - Split the cleanup into two patches (boolean comparisons and=20 redundant else statements). - Improved indentation and added proper sign-offs. v1: - Initial version with combined cleanups. drivers/staging/rtl8723bs/core/rtw_mlme.c | 42 +++++++++++------------ 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index f81a29cd6a78..8e1e1c97f0c4 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -179,8 +179,8 @@ void _rtw_free_network(struct mlme_priv *pmlmepriv, str= uct wlan_network *pnetwor if (pnetwork->fixed) return; =20 - if ((check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true) || - (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) =3D=3D true)) + if (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) || + check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) lifetime =3D 1; =20 if (!isfreeall) { @@ -267,7 +267,7 @@ signed int rtw_if_up(struct adapter *padapter) signed int res; =20 if (padapter->bDriverStopped || padapter->bSurpriseRemoved || - (check_fwstate(&padapter->mlmepriv, _FW_LINKED) =3D=3D false)) + !check_fwstate(&padapter->mlmepriv, _FW_LINKED)) res =3D false; else res =3D true; @@ -469,7 +469,7 @@ static void update_current_network(struct adapter *adap= ter, struct wlan_bssid_ex &pmlmepriv->cur_network.network, &pmlmepriv->cur_network.network); =20 - if ((check_fwstate(pmlmepriv, _FW_LINKED) =3D=3D true) && (is_same_networ= k(&pmlmepriv->cur_network.network, pnetwork, 0))) { + if (check_fwstate(pmlmepriv, _FW_LINKED) && (is_same_network(&pmlmepriv->= cur_network.network, pnetwork, 0))) { update_network(&pmlmepriv->cur_network.network, pnetwork, adapter, true); rtw_update_protection(adapter, (pmlmepriv->cur_network.network.ies) + si= zeof(struct ndis_802_11_fix_ie), pmlmepriv->cur_network.network.ie_length); @@ -633,7 +633,7 @@ int rtw_is_desired_network(struct adapter *adapter, str= uct wlan_network *pnetwor if ((desired_encmode !=3D Ndis802_11EncryptionDisabled) && (privacy =3D= =3D 0)) bselected =3D false; =20 - if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) =3D=3D true) { + if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) { if (pnetwork->network.infrastructure_mode !=3D pmlmepriv->cur_network.ne= twork.infrastructure_mode) bselected =3D false; } @@ -661,7 +661,7 @@ void rtw_survey_event_callback(struct adapter *adapter,= u8 *pbuf) spin_lock_bh(&pmlmepriv->lock); =20 /* update IBSS_network 's timestamp */ - if ((check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE)) =3D=3D true) { + if (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE)) { if (!memcmp(&pmlmepriv->cur_network.network.mac_address, pnetwork->mac_a= ddress, ETH_ALEN)) { struct wlan_network *ibss_wlan =3D NULL; =20 @@ -678,7 +678,7 @@ void rtw_survey_event_callback(struct adapter *adapter,= u8 *pbuf) } =20 /* lock pmlmepriv->lock when you accessing network_q */ - if ((check_fwstate(pmlmepriv, _FW_UNDER_LINKING)) =3D=3D false) { + if (!check_fwstate(pmlmepriv, _FW_UNDER_LINKING)) { if (pnetwork->ssid.ssid[0] =3D=3D 0) pnetwork->ssid.ssid_length =3D 0; rtw_add_network(adapter, pnetwork); @@ -710,8 +710,8 @@ void rtw_surveydone_event_callback(struct adapter *adap= ter, u8 *pbuf) rtw_set_signal_stat_timer(&adapter->recvpriv); =20 if (pmlmepriv->to_join) { - if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) =3D=3D true)) { - if (check_fwstate(pmlmepriv, _FW_LINKED) =3D=3D false) { + if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) { + if (!check_fwstate(pmlmepriv, _FW_LINKED)) { set_fwstate(pmlmepriv, _FW_UNDER_LINKING); =20 if (rtw_select_and_join_from_scanned_queue(pmlmepriv) =3D=3D _SUCCESS)= { @@ -1206,7 +1206,7 @@ void rtw_joinbss_event_prehandle(struct adapter *adap= ter, u8 *pbuf) rtw_free_stainfo(adapter, pcur_sta); =20 ptarget_wlan =3D rtw_find_network(&pmlmepriv->scanned_queue, pnetwork= ->network.mac_address); - if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) =3D=3D true) { + if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) { if (ptarget_wlan) ptarget_wlan->fixed =3D true; } @@ -1214,7 +1214,7 @@ void rtw_joinbss_event_prehandle(struct adapter *adap= ter, u8 *pbuf) =20 } else { ptarget_wlan =3D _rtw_find_same_network(&pmlmepriv->scanned_queue, pne= twork); - if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) =3D=3D true) { + if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) { if (ptarget_wlan) ptarget_wlan->fixed =3D true; } @@ -1231,7 +1231,7 @@ void rtw_joinbss_event_prehandle(struct adapter *adap= ter, u8 *pbuf) } =20 /* s3. find ptarget_sta & update ptarget_sta after update cur_network o= nly for station mode */ - if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) =3D=3D true) { + if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) { ptarget_sta =3D rtw_joinbss_update_stainfo(adapter, pnetwork); if (!ptarget_sta) { spin_unlock_bh(&pmlmepriv->scanned_queue.lock); @@ -1240,7 +1240,7 @@ void rtw_joinbss_event_prehandle(struct adapter *adap= ter, u8 *pbuf) } =20 /* s4. indicate connect */ - if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) =3D=3D true) { + if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) { pmlmepriv->cur_network_scanned =3D ptarget_wlan; rtw_indicate_connect(adapter); } @@ -1258,7 +1258,7 @@ void rtw_joinbss_event_prehandle(struct adapter *adap= ter, u8 *pbuf) rtw_reset_securitypriv(adapter); _set_timer(&pmlmepriv->assoc_timer, 1); =20 - if ((check_fwstate(pmlmepriv, _FW_UNDER_LINKING)) =3D=3D true) + if (check_fwstate(pmlmepriv, _FW_UNDER_LINKING)) _clr_fwstate_(pmlmepriv, _FW_UNDER_LINKING); =20 } else {/* if join_res < 0 (join fails), then try again */ @@ -1386,8 +1386,8 @@ void rtw_stassoc_event_callback(struct adapter *adapt= er, u8 *pbuf) =20 spin_lock_bh(&pmlmepriv->lock); =20 - if ((check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true) || - (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) =3D=3D true)) { + if (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) || + check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) { if (adapter->stapriv.asoc_sta_count =3D=3D 2) { spin_lock_bh(&pmlmepriv->scanned_queue.lock); ptarget_wlan =3D rtw_find_network(&pmlmepriv->scanned_queue, cur_networ= k->network.mac_address); @@ -1624,7 +1624,7 @@ static void rtw_auto_scan_handler(struct adapter *pad= apter) if (pmlmepriv->auto_scan_int_ms !=3D 0 && jiffies_to_msecs(jiffies - pmlmepriv->scan_start_time) > pmlmepriv->a= uto_scan_int_ms) { if (!padapter->registrypriv.wifi_spec) { - if (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY | _FW_UNDER_LINKING) =3D= =3D true) + if (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY | _FW_UNDER_LINKING)) goto exit; =20 if (pmlmepriv->LinkDetectInfo.bBusyTraffic) @@ -1866,7 +1866,7 @@ int rtw_select_and_join_from_scanned_queue(struct mlm= e_priv *pmlmepriv) candidate_exist: =20 /* check for situation of _FW_LINKED */ - if (check_fwstate(pmlmepriv, _FW_LINKED) =3D=3D true) { + if (check_fwstate(pmlmepriv, _FW_LINKED)) { rtw_disassoc_cmd(adapter, 0, true); rtw_indicate_disconnect(adapter); rtw_free_assoc_resources(adapter, 0); @@ -2607,12 +2607,12 @@ void _rtw_roaming(struct adapter *padapter, struct = wlan_network *tgt_network) =20 signed int rtw_linked_check(struct adapter *padapter) { - if ((check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE) =3D=3D true) || - (check_fwstate(&padapter->mlmepriv, WIFI_ADHOC_STATE | WIFI_ADHOC_MASTE= R_STATE) =3D=3D true)) { + if (check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE) || + check_fwstate(&padapter->mlmepriv, WIFI_ADHOC_STATE | WIFI_ADHOC_MAST= ER_STATE)) { if (padapter->stapriv.asoc_sta_count > 2) return true; } else { /* Station mode */ - if (check_fwstate(&padapter->mlmepriv, _FW_LINKED) =3D=3D true) + if (check_fwstate(&padapter->mlmepriv, _FW_LINKED)) return true; } return false; --=20 2.43.0