From nobody Mon Feb 9 05:20:35 2026 Received: from mail-m49197.qiye.163.com (mail-m49197.qiye.163.com [45.254.49.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6630D332915 for ; Mon, 26 Jan 2026 11:20:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.254.49.197 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769426424; cv=none; b=A8hTt7UNp9nIUIduyRDlepMN2nwPH56FAGSLaLbNHcQHGfdQLt3LtvIL9xS2X21h6LJRHY2EzUSVsaYDpPIus/0hDiH9mvVXysxxETw4HHnok0ia7kzQSYHjrSQVR0BZKBy5hnxLucw/+uf5ZKt+ppZIC7fYpDDRO0kfmHGlA9M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769426424; c=relaxed/simple; bh=4oj5fWyEr6zOmNxNFaiR6daacu0ovm+rjCqbil3LQSg=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=WD9tBDN33RqVy2l0iOJ3KJNsMzQ/nq3WDdBtS7AZG5jgveQMKHhOQ9nCwbsfOAaKa3edsWI1p5FKUB6h9JPjMNmpnwZKukyvRQBZ2H7i/vB8QaQ+Y/VhWHZYKK/Fhc1xebLL8cDlErNqzB9Z6+yUZk+Fr5tqlF6qp+fXfiupXnM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=seu.edu.cn; spf=pass smtp.mailfrom=seu.edu.cn; dkim=pass (1024-bit key) header.d=seu.edu.cn header.i=@seu.edu.cn header.b=ketQ06f4; arc=none smtp.client-ip=45.254.49.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=seu.edu.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=seu.edu.cn Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=seu.edu.cn header.i=@seu.edu.cn header.b="ketQ06f4" Received: from LAPTOP-N070L597.localdomain (unknown [58.241.16.34]) by smtp.qiye.163.com (Hmail) with ESMTP id 31fec9550; Mon, 26 Jan 2026 19:20:16 +0800 (GMT+08:00) From: Zilin Guan To: lyude@redhat.com Cc: dakr@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, skeggs@nvidia.com, gsamaiya@nvidia.com, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, jianhao.xu@seu.edu.cn, Zilin Guan Subject: [PATCH] drm/nouveau/gr/ga102: Fix memory leak in ga102_gr_load() Date: Mon, 26 Jan 2026 11:20:13 +0000 Message-Id: <20260126112013.117318-1-zilin@seu.edu.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-HM-Tid: 0a9bfa0871e803a1kunm1619dd9d13e54e X-HM-MType: 10 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFITzdXWS1ZQUlXWQ8JGhUIEh9ZQVlCSktJVh9LHUpNTx9NHkhLSFYeHw5VEwETFhoSFy QUDg9ZV1kYEgtZQVlOQ1VJT0pVSk1VSE9ZV1kWGg8SFR0UWUFZT0tIVUpLSUhOQ0NVSktLVUtZBg ++ DKIM-Signature: a=rsa-sha256; b=ketQ06f4ZFwp0wiwUerGA/o7XMZZOtH5kOiv0tbYwK9+PeZWsMwEbRrp3Fwzfel93OTw5QhwtXW1LwsIip4wjwIc7Cvu+4a3nKaLstBHwmGUC6df31NnYtlzl1ADQAjUMRpWyLZ6obo178jUbgwgCtHlrK9u4IjhPXF6YFPJGYI=; c=relaxed/relaxed; s=default; d=seu.edu.cn; v=1; bh=m13OkK6Tk+ugEWhQFvMZVd/ciBO6ic38A0S2OJKhlIE=; h=date:mime-version:subject:message-id:from; Content-Type: text/plain; charset="utf-8" The ga102_gr_load() function loads firmware using nvkm_firmware_get(). If nvkm_acr_lsfw_load_bl_sig_net() fails for either FECS or GPCCS, the function returns without releasing the firmware, resulting in a memory leak. Change the error paths to goto out_free to ensure nvkm_firmware_put() is called to release the firmware. Compile tested only. Issue found using a prototype static analysis tool and code review. Fixes: c4bdac754ca0 ("drm/nouveau/gr/ga102: initial support") Signed-off-by: Zilin Guan --- drivers/gpu/drm/nouveau/nvkm/engine/gr/ga102.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ga102.c b/drivers/gpu/d= rm/nouveau/nvkm/engine/gr/ga102.c index 2b51f1d0c281..4338777506db 100644 --- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ga102.c +++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ga102.c @@ -324,7 +324,7 @@ ga102_gr_load(struct gf100_gr *gr, int ver, const struc= t gf100_gr_fwif *fwif) fw->data + fecs_data->data_offset, fecs_data->data_size); if (ret) - return ret; + goto out_free; =20 ret =3D nvkm_acr_lsfw_load_bl_sig_net(subdev, &gr->gpccs.falcon, NVKM_ACR= _LSF_GPCCS, "gr/gpccs_", ver, fwif->gpccs, @@ -333,12 +333,13 @@ ga102_gr_load(struct gf100_gr *gr, int ver, const str= uct gf100_gr_fwif *fwif) fw->data + gpccs_data->data_offset, gpccs_data->data_size); if (ret) - return ret; + goto out_free; =20 gr->firmware =3D true; =20 +out_free: nvkm_firmware_put(fw); - return 0; + return ret; } =20 static const struct gf100_gr_fwif --=20 2.34.1