From nobody Tue Feb 10 10:55:08 2026 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AE26331223 for ; Mon, 26 Jan 2026 10:32:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769423531; cv=none; b=nWG1srvT0o3r4PzZGiWeE0Fv66krYph6TkB2c05yl0fVCeRRBNMjW9d8Z94Der6n2L0+W9czP6vHg8jw/Kf1+hC8LvghE0Ue8KNfsDVhVaI7WN0DF6FdXu3UE6ZuQM9wmQ4tb17eNt1QE6g+WXeopBGZ//8ygLnh54v2uQ64yks= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769423531; c=relaxed/simple; bh=r/SU5oimCuoe+JcHi0XUqVFDCGGG+2pEiPjSeS+Fvhw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lFyPIB9yR6bI3vet9SmnuBydkvrU4O/6c8j+NPufxqZMItzH1ert/Ng9DnCI6Kt0RGPx17c7NAQ1fzkuYchVqV2NCt870hNEGlswI2A4YHucHoeuhPe4VMeIIr3xs2Ry9D5UtQniRV3Xa3dWwzA33VflmwY6ECbvkP6kb4SMZhg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=HwlYUNH3; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="HwlYUNH3" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-42fbc544b09so3061526f8f.1 for ; Mon, 26 Jan 2026 02:32:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1769423527; x=1770028327; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nWa0aGJtSMtx7LCzliIPZcMgkE6x5phxxbaj/EtOLPo=; b=HwlYUNH3Wn+odahPefogz6BXJ3wnDaNVajiYnyDjhjToqMIKq4UMP51TmP05SWISDf 0dWNHkB1yrQijuTSmDsAWPZOZZb5L7d2AuO6Z95fvVF9b8TBUuO0Uit5S68YNrWroLyD iLvqdxs41ehk/os9QuSVIZ1PBPn8DI5PYOJrWc7zG3XBwR+l8g7Awnwi5pRv3sV3hoTb 8O2TK0XrfFT1TqPR85Z4mEXslHKomILN/B7O0q6DQpfwG52iXJ4HL1xtn5wtbrbMFUo0 BxwlR0zm3X1YIDJHhBramH49UGC53nKLXsw99J4EH/8EmoLbKvJKrkV9JAG9Q53I+tqj DU5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769423527; x=1770028327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=nWa0aGJtSMtx7LCzliIPZcMgkE6x5phxxbaj/EtOLPo=; b=LIUEJQGBPkm4grSHsxcLUdPS4Q7lrx9OL+OfHxSwdYYSYUeFevZRxKtu9xzegrbO6Z iklI7ta4htvjKRZVwz9JSSIqmSqVJx4HzNv+tcVvQlPP0Ow3NYZ1XJhmascNqivjYMgV uZym8dyNMde586RBZXakqWhQyGjn65F7TcDXhJYwoJaRf6IUQlHjBcjh7ZlwMaJ0oiMX vLaV8YeR3bi3KXsrBLfFO90hkrLIfBYAfJ/MOXA1n1mYiWrfll2yx8vURHYA3laMD11A zG8geH/edqV4s6f7dv7CFjjFsYGELnRm1JmG1mGq5XmsAUXhLDRqFykivKr/twSb0+Sj ShrA== X-Forwarded-Encrypted: i=1; AJvYcCVnAJX01WyyXC1v2CNi7sj1Rn7tm8AOHcAEocsQIhV99kQ+W3ve1iR/4T2aexmACqkuHjuRaMID25Ej/9I=@vger.kernel.org X-Gm-Message-State: AOJu0Yyw8UmIlixDSlks6Wh2KKfc9kCWsr+Y0mA9AG8n9IZ5LGH5OgID MhPPCAxt7M+2kpaU1DODiWeh46BAAW8qFnXH0bTLHhixTEQeBFTmyg4Hxio3Qp8wTwM= X-Gm-Gg: AZuq6aK2XvEP2B66tkrkt0oXn6BoE5sEbHwJt5BNoLQelVMZWe3ipc5MVdnt2LPV4VJ IVZECDjCDObb4O+CTnVD0abqDi1ijaOV5vG7VwRbV+jtBdAxRpbhTnmm4CRnexiUJoKTan0SUwL /wbuUmDh0VTkCOxE6Z7PC3RBmqM3NlnsZsemd5nj7WO+qD+9bfiGnoiWI34P16XuQU3kRyU2hDG UXWuN5E8Qh2f2X36y6dBGgQi8V67KZyNPIrQHztGaR0MglL02lXWZ0B2S2UgZk/ovC0qBDA2mnt hxtLLto2c7z05Vgnw9L36cZC1Bak2NERyEwyCvWlKEkRCBDLwn+QNu2dBKsK3t2JQwwpWwIqaqq HVFuX091f3YfQ8Npi/Ve9XswUagba9oN0hxNGSNpEXfMrORYgY4ag3JfcUWJdiXc3BtLguEsDn5 LwxQtX4lQAvNfjN4pha3wlK0+mtCMqjtsIsg/pw6c= X-Received: by 2002:a05:6000:24c1:b0:433:1d30:44c with SMTP id ffacd0b85a97d-435ca138ae8mr6980335f8f.43.1769423526727; Mon, 26 Jan 2026 02:32:06 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.31]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435b1c246ecsm29715049f8f.10.2026.01.26.02.32.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jan 2026 02:32:06 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: vkoul@kernel.org, biju.das.jz@bp.renesas.com, prabhakar.mahadev-lad.rj@bp.renesas.com, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, p.zabel@pengutronix.de, geert+renesas@glider.be, fabrizio.castro.jz@renesas.com Cc: claudiu.beznea@tuxon.dev, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Claudiu Beznea Subject: [PATCH 3/7] dmaengine: sh: rz-dmac: Drop the update of CHCTRL_SETEN in channel->chctrl APIs Date: Mon, 26 Jan 2026 12:31:51 +0200 Message-ID: <20260126103155.2644586-4-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260126103155.2644586-1-claudiu.beznea.uj@bp.renesas.com> References: <20260126103155.2644586-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea The CHCTRL_SETEN bit is explicitly set in rz_dmac_enable_hw(). Updating struct rz_dmac_chan::chctrl with this bit is unnecessary in the current code base. Moreover, it conflicts with the configuration sequence used for cyclic DMA channels during suspend to RAM, which will be introduced in subsequent commits. This is a preparatory commit for cyclic DMA suspend to RAM support. Signed-off-by: Claudiu Beznea --- drivers/dma/sh/rz-dmac.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/dma/sh/rz-dmac.c b/drivers/dma/sh/rz-dmac.c index 8d8391a5b3a7..4bc7ea9566fd 100644 --- a/drivers/dma/sh/rz-dmac.c +++ b/drivers/dma/sh/rz-dmac.c @@ -375,7 +375,7 @@ static void rz_dmac_prepare_desc_for_memcpy(struct rz_d= mac_chan *channel) rz_dmac_set_dma_req_no(dmac, channel->index, dmac->info->default_dma_req_= no); =20 channel->chcfg =3D chcfg; - channel->chctrl =3D CHCTRL_STG | CHCTRL_SETEN; + channel->chctrl =3D CHCTRL_STG; } =20 static void rz_dmac_prepare_descs_for_slave_sg(struct rz_dmac_chan *channe= l) @@ -424,8 +424,6 @@ static void rz_dmac_prepare_descs_for_slave_sg(struct r= z_dmac_chan *channel) channel->lmdesc.tail =3D lmdesc; =20 rz_dmac_set_dma_req_no(dmac, channel->index, channel->mid_rid); - - channel->chctrl =3D CHCTRL_SETEN; } =20 static int rz_dmac_xfer_desc(struct rz_dmac_chan *chan) --=20 2.43.0