From nobody Mon Feb 9 15:26:22 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DAE232D42A for ; Mon, 26 Jan 2026 09:49:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769420957; cv=none; b=S3fh3zqIMlylIGA8E5fu4PgrI7TZz34Haou3UhnUSGqv2tDX5rZcLd7Cck3RijJ+GnuUp1iddxyPAEolAm4Q6Xa5J6oUnEGIdiQavbtDBwwiUnDtjkW0ATJpN5Np9Wz4f0Uf2knUPYXOlVxFImX9u4dg2z2cA3ghvLfPeVyPuGs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769420957; c=relaxed/simple; bh=sQG0ulPjyoMU2mXqCzKt0fj8BMgAfnG4+oOFmOhKhfo=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QcSiGH1TbF0Rhd6sCBlMZO8lCZrO1sfuijBNEcsWbe+vF7u+nfD0v7EQU/aXJfupE2wubkw1cwo8+l+aKb7JHHMgGjF65wXqpgkUmot5DGd4n7NDhPOKDfAokrWSHw9+UY6uvrrrRpq5pji0EX60r+gGdBz6NBmxP58fcTBAD0M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=FKNikyjY; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="FKNikyjY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769420954; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ItKIv+h2/RtsA3PNwbq9GoAOv0lsdKDp+oWdKyES3kM=; b=FKNikyjYo15qN+Pi/5JAjedAX+4KBWzVbut6bX2XMhTNEICOTVhwm/b7UscfQm6qS9FJ3i i4dDuWkhqVds9D+o8WbVmYYGTD2IW2NvMG06NhibBPc85GmGMdRkQRDCAY+Tz5K/07anBN /AqaoUezM1V4KxGYQ0dnEMSSA1Y368Q= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-695-XxBIQ1eWMfSKmDIbSAM0Sg-1; Mon, 26 Jan 2026 04:49:12 -0500 X-MC-Unique: XxBIQ1eWMfSKmDIbSAM0Sg-1 X-Mimecast-MFC-AGG-ID: XxBIQ1eWMfSKmDIbSAM0Sg_1769420951 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8E9811956094; Mon, 26 Jan 2026 09:49:11 +0000 (UTC) Received: from S2.redhat.com (unknown [10.72.112.82]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D7E71180066A; Mon, 26 Jan 2026 09:49:07 +0000 (UTC) From: Cindy Lu To: lulu@redhat.com, dtatulea@nvidia.com, mst@redhat.com, jasowang@redhat.com, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: [PATCH v4 3/3] vdpa/mlx5: update MAC address handling in mlx5_vdpa_set_attr() Date: Mon, 26 Jan 2026 17:45:38 +0800 Message-ID: <20260126094848.9601-4-lulu@redhat.com> In-Reply-To: <20260126094848.9601-1-lulu@redhat.com> References: <20260126094848.9601-1-lulu@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Content-Type: text/plain; charset="utf-8" Improve MAC address handling in mlx5_vdpa_set_attr() to ensure that old MAC entries are properly removed from the MPFS table before adding a new one. The new MAC address is then added to both the MPFS and VLAN tables. This change fixes an issue where the updated MAC address would not take effect until QEMU was rebooted. Signed-off-by: Cindy Lu Reviewed-by: Dragos Tatulea --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5= _vnet.c index 78a4b80d1ce2..517edd7da019 100644 --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c @@ -4055,17 +4055,15 @@ static void mlx5_vdpa_dev_del(struct vdpa_mgmt_dev = *v_mdev, struct vdpa_device * static int mlx5_vdpa_set_attr(struct vdpa_mgmt_dev *v_mdev, struct vdpa_de= vice *dev, const struct vdpa_dev_set_config *add_config) { - struct virtio_net_config *config; struct mlx5_core_dev *pfmdev; struct mlx5_vdpa_dev *mvdev; struct mlx5_vdpa_net *ndev; struct mlx5_core_dev *mdev; - int err =3D 0; + int err =3D -EOPNOTSUPP; =20 mvdev =3D to_mvdev(dev); ndev =3D to_mlx5_vdpa_ndev(mvdev); mdev =3D mvdev->mdev; - config =3D &ndev->config; =20 down_write(&ndev->reslock); =20 @@ -4078,9 +4076,8 @@ static int mlx5_vdpa_set_attr(struct vdpa_mgmt_dev *v= _mdev, struct vdpa_device * goto out; } pfmdev =3D pci_get_drvdata(pci_physfn(mdev->pdev)); - err =3D mlx5_mpfs_add_mac(pfmdev, config->mac); - if (!err) - ether_addr_copy(config->mac, add_config->net.mac); + err =3D mlx5_vdpa_change_mac(ndev, pfmdev, + (u8 *)add_config->net.mac); } =20 out: --=20 2.51.0