From nobody Mon Feb 9 15:26:56 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9985A3064AF for ; Mon, 26 Jan 2026 09:49:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769420948; cv=none; b=R7JKRTYIK3AhUVLcbOXbApfT2L6j6t4bM/uRiTAL9Qtn3pIy/b0UCoyLszL337Ks3YtIx58tpGDUTOJHM+gJRRIijmIKCedmP5uw8PJCUvv3tfRj8VamKSWO0/nyQO08H9X8KfmjhQWdvq4951RVcjIZyisQz2UGDB8xWBKgon4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769420948; c=relaxed/simple; bh=tu5SYZ4sBijOnmwN3BXLwTM84gyNVhByLrMaj3fLiQs=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=t1rFxY3VMgXKiCPYLk1MSldvuZgSkKH7DGTzCZhZEazj0VndEjWFbmQ5J4kYLt6i+LXdO3hpOHqvssNlxPCBn7PVhtXHj/moVqk226twm+/qZYMW8FHE6pUFBpl6ScVR+yrExipLzTl3DN++o9BryZ+7mlzab5pqxGL2LaCbKQA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=BMMhNc75; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BMMhNc75" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769420946; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=34z1K+d6LyulR8yKYD3uyl4l7F9JoQvdVoW4oBdiuc0=; b=BMMhNc75NC+gjUolp6SjLetcnxYyOAzdxOw2VyH06vEuYsI2uJRCUgsuMjlqxhkLBn7MZ/ mbt2MIk4tw35ggVxYHyJP5LX/fKi1hvqZz0lCFcbVv8GfTCOivihGqJvgRFPvcV0RktUON H4jKNTx1juYdf4+KJIkd3wimP9ernx8= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-120-QIZ-x6qHNwOV-9qF82R1qQ-1; Mon, 26 Jan 2026 04:49:03 -0500 X-MC-Unique: QIZ-x6qHNwOV-9qF82R1qQ-1 X-Mimecast-MFC-AGG-ID: QIZ-x6qHNwOV-9qF82R1qQ_1769420941 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8DE691977642; Mon, 26 Jan 2026 09:49:01 +0000 (UTC) Received: from S2.redhat.com (unknown [10.72.112.82]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D7374180066A; Mon, 26 Jan 2026 09:48:57 +0000 (UTC) From: Cindy Lu To: lulu@redhat.com, dtatulea@nvidia.com, mst@redhat.com, jasowang@redhat.com, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: [PATCH v4 1/3] vdpa/mlx5: update mlx_features with driver state check Date: Mon, 26 Jan 2026 17:45:36 +0800 Message-ID: <20260126094848.9601-2-lulu@redhat.com> In-Reply-To: <20260126094848.9601-1-lulu@redhat.com> References: <20260126094848.9601-1-lulu@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Content-Type: text/plain; charset="utf-8" Add logic in mlx5_vdpa_set_attr() to ensure the VIRTIO_NET_F_MAC feature bit is properly set only when the device is not yet in the DRIVER_OK (running) state. This makes the MAC address visible in the output of: vdpa dev config show -jp when the device is created without an initial MAC address. Signed-off-by: Cindy Lu Reviewed-by: Dragos Tatulea --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5= _vnet.c index ddaa1366704b..6e42bae7c9a1 100644 --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c @@ -4049,7 +4049,7 @@ static int mlx5_vdpa_set_attr(struct vdpa_mgmt_dev *v= _mdev, struct vdpa_device * struct mlx5_vdpa_dev *mvdev; struct mlx5_vdpa_net *ndev; struct mlx5_core_dev *mdev; - int err =3D -EOPNOTSUPP; + int err =3D 0; =20 mvdev =3D to_mvdev(dev); ndev =3D to_mlx5_vdpa_ndev(mvdev); @@ -4057,13 +4057,22 @@ static int mlx5_vdpa_set_attr(struct vdpa_mgmt_dev = *v_mdev, struct vdpa_device * config =3D &ndev->config; =20 down_write(&ndev->reslock); - if (add_config->mask & (1 << VDPA_ATTR_DEV_NET_CFG_MACADDR)) { + + if (add_config->mask & BIT_ULL(VDPA_ATTR_DEV_NET_CFG_MACADDR)) { + if (!(ndev->mvdev.status & VIRTIO_CONFIG_S_DRIVER_OK)) { + ndev->mvdev.mlx_features |=3D BIT_ULL(VIRTIO_NET_F_MAC); + } else { + mlx5_vdpa_warn(mvdev, "device running, skip updating MAC\n"); + err =3D -EBUSY; + goto out; + } pfmdev =3D pci_get_drvdata(pci_physfn(mdev->pdev)); err =3D mlx5_mpfs_add_mac(pfmdev, config->mac); if (!err) ether_addr_copy(config->mac, add_config->net.mac); } =20 +out: up_write(&ndev->reslock); return err; } --=20 2.51.0