From nobody Sat Feb 7 17:20:46 2026 Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4826261B9B for ; Mon, 26 Jan 2026 06:15:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.193 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769408119; cv=none; b=eJxw8K9OJIlmIH9cPn8+LsPaHU8ZptRwRUjGuZqn8/XZJTfOwUyOl1Wgt1NAdDYF3ef/bKuT8O7MprVSa296oEBL7i8W1wn0E+opFEEAkVH73RG5hp4/II5ATmndn8rsIrorb5sk6C/d1rMu8lFpf3H/rAkpbXGbdCO8H8QQwoo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769408119; c=relaxed/simple; bh=eK9IEQxX6bPuQTZmqf3fBzqSi3lRKs7tjHBkjQMOx5I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=b+hXuXZEd4cWXRjdFQgss3mYJMzJUGu4AZS6SIfgHgU4xfcSkguXKDf6shFInwh1QIq+U3iyWiZPC6h3o6O9gToLyIN1fU8rlR0+H0GpW6gLj/q3H68afZeGDA10Rsqv7vSsOqMSjgQgsHza10YsmS2xn6Q3VfM0jwkvfRZOlto= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QqZdU/DI; arc=none smtp.client-ip=209.85.214.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QqZdU/DI" Received: by mail-pl1-f193.google.com with SMTP id d9443c01a7336-2a0a95200e8so26624415ad.0 for ; Sun, 25 Jan 2026 22:15:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769408117; x=1770012917; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=p1BtHozxghZJqgMzo9JEMTRARSx5nNU/9Ls9XrihPew=; b=QqZdU/DIoAP32fY2NRBhsdfz0TayJ1RcDDiy4CmVKklVPK9M78lCRZcp82GNyzym2M 2zwCuwr5PSst3QfKHcjXGNZ+YjGSwnmEww5Ha+snvGV3j4tO0noncCrS1HtrkHh6S/Gu tNwWb5t57VU2O0cEzW8uxUVR8MbbbUbxJBH8IhIGYcu4vWf+VnaOg2H6BaAkxLcDchP+ Puc2KWBZmz1uLU3KC7QQODZ/4CEfnHP0wgiW34bwofI/ktVoqAaVzauLBdlwcD97eNoz UG4hSQoCnFDaMY8cp6CV4MuWMA0oliqOExme/Qv7WUvAawHl6kTlvrLnJqFX2P/mapN8 Cb1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769408117; x=1770012917; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=p1BtHozxghZJqgMzo9JEMTRARSx5nNU/9Ls9XrihPew=; b=R4p4ZQlXM30Ze2DTdWO+oPo8ui2e6kGJ9t1+TP5JRdz8DyoivaRNjqY3DXSwAIsto3 JztSCHRPV7Ltt0+u4uXpWfnE4FYhX2lKzX4u4ZpfJfs+NPrbsOYsjjXyl+KumY9bCGCm DsY+mmjVQjE20qvFYfwnYwFs1w0yJea1H1QCDAmh1dD8KJQSTjZj/Qilk+VX4tc/Oo2w S+hm4AlbKEpk/4lzctJbwfRgjgH6gFo5KKOWzzZS9xlE/qO9h95qTzXj4VDGrjE6SPEk 8Vbo+h6K6nYIO9PUY8GpufmSsObgyU3d7DITpxc+NxBd+D/xrgsQqW2E98v19L9AiTzc lSOA== X-Forwarded-Encrypted: i=1; AJvYcCVOTRGUwtk5t7Ki0FeFuDs/rhPGwxmKKAihLLX/0NNpE849KZb5tI0sq2RMLDbqwsZ+Ono/07G1ehiRCS8=@vger.kernel.org X-Gm-Message-State: AOJu0YwjC0YQSNqSt6y4/eOkJuZwGq4bQie1ngJmTmA3gWtfimzmb9+G YJC0qupns9VyAJrCz4YUn5UrImjkGbcfzDtkFFPuqfLa0EDOJZSAY5+Y X-Gm-Gg: AZuq6aJGEyCvDE9NTIopk0q4cxbYwBqslvtW98ITl//8sFmv+ygMvEnRueMLDE8R4Yv 5522l9WWDgJM8ihZJ4iQh1N4AEjYug8OlESxe+3X4wqRMcgE+GdFmyAlyL456J7ZjDkIFlSQgCs FXJne73Siesu+co9rfzFqni191+zL4jOxNbf5pk1mpNamAIwo15eS1JpOHggplXMKfPXSXtBUFJ dpYosWXRhyPr4zs/J2dSOzaHekscnZnmAkgjIeGfzlC6q1f89RqMZFp9sYjGuCiJSfr6Ip8tJwB gXSaIjbakslyxAjMv9OTYqwTs2u76R2dIpjn75A+Du2yu1rFi45RndNu64noqnDynkMbitnUY2j sixiIozHCrDyPlPezJQd/kOUNOG7gIlQonrjLPE7cNz54foqSK9n9K+8EcKLTYf33niYI5UTRxl O52i+B00eP61BDD2artTFbSGfRWOus5YUInGMrUKQ0ZHNsNdMvgYyWRgTwWkQRZ/rm X-Received: by 2002:a17:902:d58b:b0:2a1:e19:ff0 with SMTP id d9443c01a7336-2a8452b2031mr32575335ad.39.1769408117209; Sun, 25 Jan 2026 22:15:17 -0800 (PST) Received: from d.home.mmyangfl.tk ([2001:19f0:8001:1644:5400:5ff:fe3e:12b1]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a802ede745sm79477325ad.44.2026.01.25.22.15.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Jan 2026 22:15:16 -0800 (PST) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , Vladimir Oltean , Claudiu Manoil , Alexandre Belloni , UNGLinuxDriver@microchip.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Russell King , linux-kernel@vger.kernel.org Subject: [PATCH net-next 1/3] net: dsa: sync dsa_mall_policer_tc_entry with FLOW_ACTION_POLICE Date: Mon, 26 Jan 2026 14:13:29 +0800 Message-ID: <20260126061340.757543-2-mmyangfl@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260126061340.757543-1-mmyangfl@gmail.com> References: <20260126061340.757543-1-mmyangfl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" New options were introduced to FLOW_ACTION_POLICE after struct dsa_mall_policer_tc_entry was added. The following commands will succeed on DSA ports: tc qdisc add dev lan1 handle ffff: ingress tc filter add dev lan1 ingress matchall skip_sw action police \ pkts_rate 80000 pkts_burst 100 mtu 1000 conform-exceed ok resulting 1. burst_pkt, rate_pkt_ps, etc. being ignored; 2. burst and rate_bytes_per_sec set to 0 without any error. Instead of making decisions for drivers, extend struct dsa_mall_policer_tc_entry to all options for FLOW_ACTION_POLICE in favor of full functionalities, such as packet rate mode. Drivers must reject unsupported combinations. Signed-off-by: David Yang --- include/net/dsa.h | 11 +++++++++++ net/dsa/user.c | 7 +++++-- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/include/net/dsa.h b/include/net/dsa.h index 6b2b5ed64ea4..4c177b168ec8 100644 --- a/include/net/dsa.h +++ b/include/net/dsa.h @@ -21,6 +21,7 @@ #include #include #include +#include =20 struct dsa_8021q_context; struct tc_action; @@ -220,6 +221,16 @@ struct dsa_mall_mirror_tc_entry { struct dsa_mall_policer_tc_entry { u32 burst; u64 rate_bytes_per_sec; + u64 peakrate_bytes_ps; + u32 avrate; + u16 overhead; + u64 burst_pkt; + u64 rate_pkt_ps; + u32 mtu; + struct { + enum flow_action_id act_id; + u32 extval; + } exceed, notexceed; }; =20 /* TC matchall entry */ diff --git a/net/dsa/user.c b/net/dsa/user.c index f59d66f0975d..4c9cff629d5c 100644 --- a/net/dsa/user.c +++ b/net/dsa/user.c @@ -1497,8 +1497,11 @@ dsa_user_add_cls_matchall_police(struct net_device *= dev, mall_tc_entry->cookie =3D cls->cookie; mall_tc_entry->type =3D DSA_PORT_MALL_POLICER; policer =3D &mall_tc_entry->policer; - policer->rate_bytes_per_sec =3D act->police.rate_bytes_ps; - policer->burst =3D act->police.burst; + /* so sad, flow_offload.h did not export the type of act->police, and + * it's a nightmare to copy it field by field + */ + static_assert(sizeof(act->police) =3D=3D sizeof(*policer)); + memcpy(policer, &act->police, sizeof(*policer)); =20 err =3D ds->ops->port_policer_add(ds, dp->index, policer); if (err) { --=20 2.51.0 From nobody Sat Feb 7 17:20:46 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA8AD261B9B for ; Mon, 26 Jan 2026 06:15:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769408124; cv=none; b=CpDq8H04JyUDhI1WirrqNfW6A2EGtWORvJTw6b6Vaoc81TdMTaueziF+jg6OKMmp9ir3yTn3R8bIReiktllEez4WaP+Lxf2iqpFFmtHB4xlauGP7ujxy0G5Zpy1O2xtRaajsjeoX+jG7evFXv1R1+6QDB7ZvJfIf06nHe4LxiAg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769408124; c=relaxed/simple; bh=2wpssjHxjFftU46L2ct0nhACoK/GI1O4qsjjvjba/KM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XM2eTKQolkEuzOwIOmGi3Tas7ejjnbATO30j0NvnxzC5pOptxSmTQz6SP4w82inhIiBzLThR2MRUizVq9RRDhu1vCD0aoibkg/g53gggqkY8mLIPnagwnRJfxiK4pxyBVpOdGrWkxSzN6ZWFWQl72lBLy4NXC82PHTi3Agb9Cxk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IgNkYHeC; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IgNkYHeC" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2a7786d7895so26745515ad.1 for ; Sun, 25 Jan 2026 22:15:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769408122; x=1770012922; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8JJjobB6PNdLChVyacJVt2J6BgkT8/TCPgnTIdLgQN0=; b=IgNkYHeC7XSUQptfx+B5q/3ant5jB30Mx8nJKeX8vtoytk0ThFLADBTRGj2eJJzIMk aonVtzLX0x0kurRn4T+POU5WmWvhcQL350TyOmlDYRY871NboXfVQSaDOZneoS50ItXz Kt9qtUqi4dmBXsPA5j/pCK5+jlXNyVNgtJdXDJ7IHoqm0AwDDtXdQ6DHnujICzc9Vaba AUE2RrkUGyiQb2FHfVFEsV5+mV7OPfQ1oqV/gyyIJUZwLAqekzWE1sL64tKs+qgwHviX E1jsxCs4dJgJrEAfVG2Sd5B+4NaSdSSiH1sNwyPJzBeTW53IPzmiwTcD8b87cEe5SU81 Vyyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769408122; x=1770012922; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8JJjobB6PNdLChVyacJVt2J6BgkT8/TCPgnTIdLgQN0=; b=t8t5IML+y2x6PvW4EtFTbGvQ4p4YHtciFPYtQENPKYWK1dE8xtXm7EAWWVActMHmPn 9DOldCYUfrmx11sIfN9TKEJ55C3Jdm4e6ah48NMsuJOUi0MVN02pd/MHl5dB2nkVpuSj rPO4rFuW1m+Q0IJBzjRnV24lAhfDR+63OYtRe29sm4OZxIk6RItO9vLs9eWfp4UL2e6Y /gP469RHYjZP4BoUlnjLIU9C+jJXnNG4b+5UTeu5nY7kmOe31elYMpZk54gvEpaIU//e y1aaKj9xkqIh679PoG3JU7FL0tyKamLAD6kOx8VlLB3VvT0mI3WWFsjIvVGiK/j4m2u6 UhjA== X-Forwarded-Encrypted: i=1; AJvYcCWATNvSpHBW3A83vMwEwNIssVhLAyObu4TjrJ79+S5EqMGwOzpov4Rg+g66JXizNxPlKRfk/n5fLBLRhbo=@vger.kernel.org X-Gm-Message-State: AOJu0YzqygvJitMSS2OjAgGQYle5Z+DPEnWvEkESPb99MDCIeUpzTrsz JhALxH4SlQlbRYFXBeQmXXnfY5qqIQWJd9Ov7WGLoYiNtZ6M9yJj7+Zo X-Gm-Gg: AZuq6aLVNTdLTcoP0Jg9tOWrUbvvnqkXgYeIA1oIdLdbFDyHPuBa7ciT5v+vBXggMSR nxqUgyvVsdupKhZb6wOUcQfJCbZxnTN//3e2UlVVr1xONXQjKeRCv9xYtPAk1+OJltPYFLVogbr jFlylncvipse1RkNLu6z/gjeIAtYYGtpCDWZ4lzOqGv8HTBxeJyNh5CJzvYydNhm/8KKhhjo4gM +WK5RRO9y3cym1wjJ8OZN5cN7xNGgs1V9h650mIFXVl96NcLNpJWssOYym3QGS1bZhvtm9o1HhQ /lvfgAonX4rqW0ocKAzzC6irWS0c/YGUVhN64i6BEl/0slO6cKnaS/oeXO2QfCAosgloABWjBvW q0+2sBua6JqLpjUinbCtQMGlcB4idvF9soMnttg82HZEo9bunt4FQU4qMbGBUKG1dPXkECdHswL iITcqw3yGWjNc0aNw8AAqH3qY7N5ar+Xi1mkAEQXGfkEwUS7vq7gg1xg== X-Received: by 2002:a17:902:daca:b0:2a7:d7b8:7661 with SMTP id d9443c01a7336-2a84520a932mr27459565ad.4.1769408122098; Sun, 25 Jan 2026 22:15:22 -0800 (PST) Received: from d.home.mmyangfl.tk ([2001:19f0:8001:1644:5400:5ff:fe3e:12b1]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a802ede745sm79477325ad.44.2026.01.25.22.15.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Jan 2026 22:15:21 -0800 (PST) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , Vladimir Oltean , Claudiu Manoil , Alexandre Belloni , UNGLinuxDriver@microchip.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Russell King , linux-kernel@vger.kernel.org Subject: [PATCH net-next 2/3] net: dsa: add dsa_mall_policer_tc_entry_type() helper Date: Mon, 26 Jan 2026 14:13:30 +0800 Message-ID: <20260126061340.757543-3-mmyangfl@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260126061340.757543-1-mmyangfl@gmail.com> References: <20260126061340.757543-1-mmyangfl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" It has shown FLOW_ACTION_POLICE is not stable, and it's very likely that options were added at drivers' request. However, that also means .port_policer_add() would have to check the parameters themselves. Giving that struct dsa_mall_policer_tc_entry is not stable, adjusting the interface between the framework and drivers would be a pain. Introduce a helper to maximize forward compatibility. Drivers may use it to recognize the pattern of tc entry reliably, and ensure all newly-added options are set to 0 / their default values and do not break the semantics. Signed-off-by: David Yang --- include/net/dsa.h | 14 ++++++++++++++ net/dsa/dsa.c | 33 +++++++++++++++++++++++++++++++++ 2 files changed, 47 insertions(+) diff --git a/include/net/dsa.h b/include/net/dsa.h index 4c177b168ec8..957439846fe5 100644 --- a/include/net/dsa.h +++ b/include/net/dsa.h @@ -1410,4 +1410,18 @@ netdev_tx_t dsa_enqueue_skb(struct sk_buff *skb, str= uct net_device *dev); void dsa_port_phylink_mac_change(struct dsa_switch *ds, int port, bool up); bool dsa_supports_eee(struct dsa_switch *ds, int port); =20 +enum dsa_mall_policer_tc_type { + /* Pattern recognized, no surprising fields exist */ + DSA_MALL_POLICER_TC_KNOWN =3D BIT(0), + /* Unset: .burst and .rate_bytes_per_sec valid + * Set: .burst_pkt and .rate_pkt_ps valid + */ + DSA_MALL_POLICER_TC_PKT_MODE =3D BIT(1), + /* .mtu valid */ + DSA_MALL_POLICER_TC_MTU =3D BIT(2), +}; + +unsigned long +dsa_mall_policer_tc_entry_type(struct dsa_mall_policer_tc_entry *entry); + #endif diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c index 35ce3941fae3..c8102cea5ab3 100644 --- a/net/dsa/dsa.c +++ b/net/dsa/dsa.c @@ -1834,6 +1834,39 @@ int dsa_port_simple_hsr_leave(struct dsa_switch *ds,= int port, } EXPORT_SYMBOL_GPL(dsa_port_simple_hsr_leave); =20 +/* dsa_mall_policer_tc_entry_type - map tc_entry to some "known" types + * @entry: the tc entry + * + * A helper to check dsa_mall_policer_tc_entry against some known patterns, + * without having to know the exact struct layout. + * + * Returns: ORs of enum dsa_mall_policer_tc_type with DSA_MALL_POLICER_TC_= KNOWN + * set if recognized, otherwise 0 + */ +unsigned long +dsa_mall_policer_tc_entry_type(struct dsa_mall_policer_tc_entry *entry) +{ + bool byte_mode =3D (entry->burst || entry->rate_bytes_per_sec); + bool pkt_mode =3D (entry->burst_pkt || entry->rate_pkt_ps); + unsigned long flags =3D DSA_MALL_POLICER_TC_KNOWN; + + if (byte_mode =3D=3D pkt_mode) + return 0; + if (entry->peakrate_bytes_ps || entry->avrate || entry->overhead) + return 0; + if (entry->exceed.act_id !=3D FLOW_ACTION_DROP || + entry->notexceed.act_id !=3D FLOW_ACTION_ACCEPT) + return 0; + + if (pkt_mode) + flags |=3D DSA_MALL_POLICER_TC_PKT_MODE; + if (entry->mtu) + flags |=3D DSA_MALL_POLICER_TC_MTU; + + return flags; +} +EXPORT_SYMBOL_GPL(dsa_mall_policer_tc_entry_type); + static const struct dsa_stubs __dsa_stubs =3D { .conduit_hwtstamp_validate =3D __dsa_conduit_hwtstamp_validate, }; --=20 2.51.0 From nobody Sat Feb 7 17:20:46 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 868C127055D for ; Mon, 26 Jan 2026 06:15:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769408128; cv=none; b=Y3DLeWcivUiayvxS/Ilbzb5NpqYRXJ/GZCfkn5n47uwcP/8WwNndFMN63dKqGkYUNDgh41mvJgJg7kURTinDOen+Al8cMCIfGYSWl6AkGTV/Yxkxii/YvbXBxd6tQYY0qKMtMsNzxJqWSoLJFx5ZUpbLDJNvWbIyptvSzVsGYoc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769408128; c=relaxed/simple; bh=ObrmwWLHEgXJXhqfzUvxApLqh7ht8xYEb8z0erge2J4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=c+qSY5xMWNDos8uJG74vkEN4NC41vnQC2ozKZdOth8/semwPZJLO1BzWVM1RJnXo8W8Aeld/q1RE9WKF2HT/vohK9zdvfxfPSACev1Z42v5Kb887chQ4fv2fZ+PXrIiPxqUPrWwHS3q9MtygmMBKHrT+amS2cFAvKIrXlYqHenQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FqcSrQ3o; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FqcSrQ3o" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-29f2676bb21so42690855ad.0 for ; Sun, 25 Jan 2026 22:15:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769408127; x=1770012927; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qwzqgsYbRQv2GZw6RztdTtcB5Hu8Wd4ivWKt/DZh6kM=; b=FqcSrQ3o3MJj22UG0TX8lIOfuhT3mhfbvCWQQZNgYHD/I2DV9n5BI7G6C0bNIw89xm yJNE418LOxHzoFKkL0GJICNHxP/OXzt30BBY+RU+sm2Lb6HJkpvxwKgfEv2Ck/UYFlZt 3mcvA6QvGtAuxjJBnE09/GV3v2VXPKfNU2dq8ng4PPXd4EWs0fdEuVGVVZaj5iAjWM/i 4b/dMoMKhAW3U+ESyNs1QV8SRrpGWiH0aawVqnBRVMO2N5TzvDcDJVdFGUfW+6Pcbpzd z32nxWt+MEWjiptesdOyc3OX9bhW9qhzlehLGruYwx6+cqWtbvH+PyooDlHPSnv/0jZ7 I/JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769408127; x=1770012927; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qwzqgsYbRQv2GZw6RztdTtcB5Hu8Wd4ivWKt/DZh6kM=; b=da4WxeITQbM2Ds8M7brL2fH7nYjZFs5cyKRVMMpN+MlbRHfDGJ9bhJjKD1JKf1pMzt 2YMIhFMGxi6XtYunwAWrTjINj6ASFO+EuCsa7HvYKWt5IQhfkjiVYIPErEgbr5F0OwQe ERwoR/tQOBz7AtKBD01HVfN9Xdt0q31cXe1nMdwXrkmYgsRPI7o+CnWO0YzYYPqCt57B dfSNwWWyKPC0bscxMz3TeLg5r0SuAWYDCs8Vj1Y8OvPk0acL/cjfx5nGVb9xCsakTuiQ yh/7mGKb2eojJ30uhGthCvdUmFyeM98gZN2hNfH9QR0jBZTaQo7eVWWW0gDfWtNOAZWU y3Xg== X-Forwarded-Encrypted: i=1; AJvYcCVLCiXiXZfvdnWpj6UzEBvRjJa7JUTbSeuscKwt4LlGERtgVyc8Gr2FAnIBSnDltrMI1XiXwrjPbaRYpP0=@vger.kernel.org X-Gm-Message-State: AOJu0YzTfw9vx0cmkg/ShgwxOoxa770d9ErSTW6HyFx7llwqpthsAvkc Kxrm3dfgkFbepi1Sx1YVMMFgeeQpxePlCgfjgjBN+3H0UvR8/9M7JFPX X-Gm-Gg: AZuq6aIeJvuQbCv6fCBwsnJge+YHYAnRAK5aDQiVbTy6XZtJRaSibnbceP+uzfMfsGh Lr6PrWqWHM/FhlOv7V3aEoMukFCa5tD24izMyATfKNGLGfAf8bAVBrMcZ/JK4yOrF34ETeTD1k0 BfkDR0gC9U8dHwrL3qdq9+1gc5njo+hKX+9oa9pgTSFole5yATbsVawYJT7+JfwUj+aq0corI1o qBahnv90exgCeMwY9gbhFIad7oEBbftQBOo2UZPujxqQIcLl/TFqXxuLGmfqIHZBtmrPzkKYYU1 lf/b+Roxz8CEOFqdlPDVbysUvp0lokS72r844u5C/HoZ0SH4ZAOASRgDQZNgqRxujYEJxspu6Pj M1nNdKc92NU5eB0x6Rq1xC4oqmx6In377DPZvF4EZ/zMWycp08M17ugyff18McTZqBbWcH5q76J Qhi8rHikQYq2JNa00Kqz6Z+76EI7hG/3+ozPYtDsabrjZyNC1l7DfBkQ== X-Received: by 2002:a17:902:cecb:b0:2a0:9755:2e97 with SMTP id d9443c01a7336-2a845257e5amr35235865ad.15.1769408126789; Sun, 25 Jan 2026 22:15:26 -0800 (PST) Received: from d.home.mmyangfl.tk ([2001:19f0:8001:1644:5400:5ff:fe3e:12b1]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a802ede745sm79477325ad.44.2026.01.25.22.15.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Jan 2026 22:15:26 -0800 (PST) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , Vladimir Oltean , Claudiu Manoil , Alexandre Belloni , UNGLinuxDriver@microchip.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Russell King , linux-kernel@vger.kernel.org Subject: [PATCH net-next 3/3] net: dsa: ocelot: check policer entry Date: Mon, 26 Jan 2026 14:13:31 +0800 Message-ID: <20260126061340.757543-4-mmyangfl@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260126061340.757543-1-mmyangfl@gmail.com> References: <20260126061340.757543-1-mmyangfl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" rate_bytes_per_sec might be 0, check for it. Signed-off-by: David Yang --- drivers/net/dsa/ocelot/felix.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/dsa/ocelot/felix.c b/drivers/net/dsa/ocelot/felix.c index 9e5ede932b42..fb2d02ff0fe7 100644 --- a/drivers/net/dsa/ocelot/felix.c +++ b/drivers/net/dsa/ocelot/felix.c @@ -2011,6 +2011,10 @@ static int felix_port_policer_add(struct dsa_switch = *ds, int port, .burst =3D policer->burst, }; =20 + if (dsa_mall_policer_tc_entry_type(policer) !=3D + DSA_MALL_POLICER_TC_KNOWN) + return -EOPNOTSUPP; + return ocelot_port_policer_add(ocelot, port, &pol); } =20 --=20 2.51.0