From nobody Sun Feb 8 14:12:53 2026 Received: from mail-dy1-f227.google.com (mail-dy1-f227.google.com [74.125.82.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6E2D237713 for ; Mon, 26 Jan 2026 05:44:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.227 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769406267; cv=none; b=AfUX9lYy/PDX2gW1ueRMtfkytwwmyq974m49JVmnifHB5kiF5qnW0BVBVGjfrKEojXjlAPZDqraEgX7alo5bLgzRpXj0Qlx62Sr/cIayVWgV35PvMqdRwXgPloO9aSGvt5SSrQ89nVxD3LROw521qB/CNW+uELUnjlsgQRiSUSM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769406267; c=relaxed/simple; bh=4ryh+Y/RSJnV3e6qju9S9g0fVgzNNnpeBWUn7Xn4sQE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=fAbHYdZC688ny2OidMnUEONxFXGFMNCZyLo85LugZPfY0DHkDFiwF05a6HNWE0Ey8laWJMfMbnRTl9mDp3SDmhjoy9J4EuIGdBAbbYgmCWhceO37vnRxtvPYUqkEpkChHJdbwxbfYqi1tahGovr9HASXwvPPOYvon1KhH/z2UMU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=FEAUqf7c; arc=none smtp.client-ip=74.125.82.227 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="FEAUqf7c" Received: by mail-dy1-f227.google.com with SMTP id 5a478bee46e88-2b6fd5bec41so9781664eec.1 for ; Sun, 25 Jan 2026 21:44:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769406265; x=1770011065; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DX/9D3u5qbIyWsXWQiMiNsL7jWON8Kwc3aIk95oDeQA=; b=In3KHca0R4PVAnjDEF5ouxRPdeQBHyLagji0IV1O3cpPRWwb8h5I0EjGELus6692M0 HdF6lIdMIYbgfUfDnq1OnDaU3chosMlhDsHnKeLDvLPKatbuNXLr5c5Ii2qNN4Sp2iFn vyNxRYV51ZdXDT2I+IAdwecn/qX/RH3n8aV2pXU4MlX1CPkI7A+god5UmD5tFWq1o+wQ VWByuIcwzy9D6kcxpvxjnDrMpSVo6my2n3QKEDbnwKjxMPD0yENYjntMzqcxGOWtWDd/ lYO9U3kPUOxx4fJJNXWPw8vTPrp2Gd3O177AXcf+gJBdhK+8qizFO3qv0hFG2dTk+j90 shjw== X-Gm-Message-State: AOJu0YzeBXp/hBRfAE7Hm77NGxmcwFOQgEn2eMtws2w/wgrnn6KyuL41 /Zwgt0dJJIm3iSuPf6G4QkOlJzJe9v5m1PBsgzbuWkIALUQtOl0aDYkkFN27IGbCLKMUFvxuK5l PYFPyIu+qjrRsb3n7uvoUaieSQDnMGZZpPIbUfMROIX7u4AzcW6KPZIwcBXx/5fqvA0Lxc7zTN9 zQACkFPHeeEz/WvnIxqXQfU8L07xoef4DzmrVgu4kf1cEKxfHEfWKr+Z/5lsDaEH8lAn32lRl1m pMqXQyTCZNhYl9CPrk= X-Gm-Gg: AZuq6aK/LRLPkbl4TwzV+ugn8FNpboGMiEc9RkVKr75WLCdyGnMJyLJg+NMdVzu6g2B wcFSLx6rTe9ouVYuEQlPJTTY6ZWGfIQ+W58UwX//XBrzjy1ZBMDfp/HjhvvNhMnsL3RS+g8Q6UU H1qMoeeds2YxckbOz5+b77rJtXtKqSvU9U4cApCtdRWZZvCOKkxmUktinYmyxJwQhaUlrSmRsd/ dgBShWQGihCx2E/iwqgCzvsdnqHlJKIiAznZ7h69toi6cu6OMjicQ9y9Nq2aosY+f43oTBRfA/L A7dASGkqYjcJ859gaI5kydP4WBg5le4UBMuvACIkBgAcAKG8FYt3dTX/EoEa1fWWhwkhjyUtLOQ FUxKJHrKwvoWnXovIC02KB7zoyWBnxBNLkiWpsCPX5Z491BCgFVVEVxkRiM1tPktnfLn34bEeYp ZhxS129hKHXOQZ/kpxtOu0ylRAZjG18UD7Aul1sEo4YgWe X-Received: by 2002:a05:7300:bc86:b0:2b7:1dbc:c243 with SMTP id 5a478bee46e88-2b76432bf45mr1322452eec.8.1769406264487; Sun, 25 Jan 2026 21:44:24 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-77.dlp.protect.broadcom.com. [144.49.247.77]) by smtp-relay.gmail.com with ESMTPS id 5a478bee46e88-2b73a71b216sm1280497eec.7.2026.01.25.21.44.24 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 25 Jan 2026 21:44:24 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-34c38781efcso3945785a91.2 for ; Sun, 25 Jan 2026 21:44:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1769406263; x=1770011063; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DX/9D3u5qbIyWsXWQiMiNsL7jWON8Kwc3aIk95oDeQA=; b=FEAUqf7cVd7KUYXgyuuGs3kw677vInQ5JvReSZxI+cbTQwziN+pH8osID8XoRu5ycs Un+KHCLrwA0Zyv450UEZQyr91TSVMdPOwUmnZ5ZZE/hjGo/F42A7pvfSe297hM8fnF/R E7ftx/RbM986FoC09/pRKpf6FDOI47RU169GY= X-Received: by 2002:a17:90b:3851:b0:353:3f04:1b78 with SMTP id 98e67ed59e1d1-353c40ba152mr3201429a91.4.1769406262843; Sun, 25 Jan 2026 21:44:22 -0800 (PST) X-Received: by 2002:a17:90b:3851:b0:353:3f04:1b78 with SMTP id 98e67ed59e1d1-353c40ba152mr3201407a91.4.1769406262433; Sun, 25 Jan 2026 21:44:22 -0800 (PST) Received: from PC-MID-R740.dhcp.broadcom.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c635a3f2ddcsm7427213a12.17.2026.01.25.21.44.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Jan 2026 21:44:21 -0800 (PST) From: Pavan Chebbi To: jgg@ziepe.ca, michael.chan@broadcom.com Cc: linux-kernel@vger.kernel.org, dave.jiang@intel.com, saeedm@nvidia.com, Jonathan.Cameron@huawei.com, gospo@broadcom.com, selvin.xavier@broadcom.com, leon@kernel.org, kalesh-anakkur.purayil@broadcom.com, Pavan Chebbi Subject: [PATCH v2 fwctl 3/5] fwctl/bnxt_en: Create an aux device for fwctl Date: Sun, 25 Jan 2026 21:37:08 -0800 Message-Id: <20260126053710.3474483-4-pavan.chebbi@broadcom.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20260126053710.3474483-1-pavan.chebbi@broadcom.com> References: <20260126053710.3474483-1-pavan.chebbi@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Create an additional auxiliary device to support fwctl. The next patch will create bnxt_fwctl and bind to this device. Reviewed-by: Andy Gospodarek Signed-off-by: Pavan Chebbi --- drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 12 ++++++++++-- include/linux/bnxt/ulp.h | 1 + 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c b/drivers/net/et= hernet/broadcom/bnxt/bnxt_ulp.c index 4cdfc9641639..13159c0515bb 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c @@ -62,6 +62,8 @@ static bool bnxt_auxdev_is_active(struct bnxt *bp, int id= x) =20 static struct bnxt_aux_device bnxt_aux_devices[__BNXT_AUXDEV_MAX] =3D {{ .name =3D "rdma", +}, { + .name =3D "fwctl", }}; =20 static void bnxt_fill_msix_vecs(struct bnxt *bp, struct bnxt_msix_entry *e= nt) @@ -289,6 +291,11 @@ void bnxt_ulp_stop(struct bnxt *bp) aux_priv =3D bp->aux_priv[i]; edev =3D bp->edev[i]; mutex_lock(&edev->en_dev_lock); + if (i =3D=3D BNXT_AUXDEV_FWCTL) { + edev->flags |=3D BNXT_EN_FLAG_ULP_STOPPED; + mutex_unlock(&edev->en_dev_lock); + continue; + } if (!bnxt_ulp_registered(edev) || (edev->flags & BNXT_EN_FLAG_ULP_STOPPED)) { mutex_unlock(&edev->en_dev_lock); @@ -325,7 +332,7 @@ void bnxt_ulp_start(struct bnxt *bp) aux_priv =3D bp->aux_priv[i]; edev =3D bp->edev[i]; mutex_lock(&edev->en_dev_lock); - if (!bnxt_ulp_registered(edev) || + if (i =3D=3D BNXT_AUXDEV_FWCTL || !bnxt_ulp_registered(edev) || !(edev->flags & BNXT_EN_FLAG_ULP_STOPPED)) { goto clear_flag_continue; } @@ -525,7 +532,8 @@ void bnxt_aux_devices_add(struct bnxt *bp) aux_dev =3D &bp->aux_priv[idx]->aux_dev; rc =3D auxiliary_device_add(aux_dev); if (rc) { - netdev_warn(bp->dev, "Failed to add auxiliary device for ROCE\n"); + netdev_warn(bp->dev, "Failed to add auxiliary device for auxdev type %= d\n", + idx); auxiliary_device_uninit(aux_dev); if (idx =3D=3D BNXT_AUXDEV_RDMA) bp->flags &=3D ~BNXT_FLAG_ROCE_CAP; diff --git a/include/linux/bnxt/ulp.h b/include/linux/bnxt/ulp.h index 1a4643c46f86..0851ad3394b0 100644 --- a/include/linux/bnxt/ulp.h +++ b/include/linux/bnxt/ulp.h @@ -24,6 +24,7 @@ struct bnxt; =20 enum bnxt_auxdev_type { BNXT_AUXDEV_RDMA =3D 0, + BNXT_AUXDEV_FWCTL, __BNXT_AUXDEV_MAX }; =20 --=20 2.39.1