From nobody Mon Jan 26 23:02:11 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A119C3375DD for ; Mon, 26 Jan 2026 16:59:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769446743; cv=none; b=TmlolbgU/uJN+5d65flE5XycDX8PI1/+kEZ1+xjI0CQKK1tA6N5hHaeS9vxQDLDMafEk1oUlzdj71oBNLKr2YOjinWeK177kLfrkefCCA0BXwUohJIQMTSjOyRfBhHdPMFhFt2Jg2Yna1WApYkMpbjd7Bt1r+hjNUD3BSDwYuwQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769446743; c=relaxed/simple; bh=UUE836v8cvihk8IfosjMQaRYSGydDbQU3XprtYIeQiA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=itqhlq5Z/ZVw6Vlhb542yPOq8f86BEhOaVG3Oqgvckqp2Gl4LWG3CMjFqz0hozJ9Dn9Av2KWE9RuJag9r1gsZ3ifiCeux4lV5ywkXWDHhwx+D4PpmOehbdOuQFWMfnXfUDvEmHOiZV/fb/+wdxuKZlNoXklz+s4HKMdLnjZi4Yc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tCs9IqaZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tCs9IqaZ" Received: by smtp.kernel.org (Postfix) with ESMTPS id 5AD16C16AAE; Mon, 26 Jan 2026 16:59:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769446743; bh=UUE836v8cvihk8IfosjMQaRYSGydDbQU3XprtYIeQiA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=tCs9IqaZltdmyzLN4gEjLO+OJ7vXG7AurFGq2U0/Mskflrt6M91NXg+NmJ9a/P/cw f2rBcv8WlsG/V6oXGbeGJ/kBPu9ffJLXaZnK2C5Fyt9/ngE2sSZ+W8dhcOifgjr0Rv 4zAhzwEwRah33v3nDlVyPEzQhz4Rq4KSewPzVk7Yf6U1IubDvauzJ3DNd9n9VIEKoh kWN1OutHJJsE3uBzO6Q/qlC+LHRunUCLMTbGKbG7t3uzdZRYEFdm5tZlRR8B8RUYtD AMkaZ7nAHIr/dOZJ95c2HKD6HcQbIPewicW6cDMZMvTUS8uCUAB0bogp6se5XzU/JC zWTqD1tavnJRQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 512C4D19501; Mon, 26 Jan 2026 16:59:03 +0000 (UTC) From: Andrea Scian via B4 Relay Date: Mon, 26 Jan 2026 17:58:55 +0100 Subject: [PATCH v2 1/2] mtd: rawnand: pl353: Fix software ECC support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260126-pl353-soft-ecc-support-v2-1-fcd74b6e955f@dave.eu> References: <20260126-pl353-soft-ecc-support-v2-0-fcd74b6e955f@dave.eu> In-Reply-To: <20260126-pl353-soft-ecc-support-v2-0-fcd74b6e955f@dave.eu> To: Miquel Raynal , Michal Simek , Richard Weinberger , Vignesh Raghavendra Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Amit Kumar , Andrea Scian X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1769446742; l=930; i=andrea.scian@dave.eu; s=20260121; h=from:subject:message-id; bh=pjp7e5XqvjwdI+0l+aByZIcrYrWvIGxc1jaHj+aNu4Q=; b=XqkcYEu2zoXUaDXq30sYtPT/NnekjpeCT3cOKfKNN1+YiL3zej8d3DiZpVfT9Nx5rwkAb/U0/ +74MntHAS0kDFwCdVVtOXNPlXeXK0I9a+KuigMg+5RjWATmN6WcPJxW X-Developer-Key: i=andrea.scian@dave.eu; a=ed25519; pk=PMQL72nEsyoiJCobnq0uEXwUFpVmkwoWIx317WvaQOU= X-Endpoint-Received: by B4 Relay for andrea.scian@dave.eu/20260121 with auth_id=613 X-Original-From: Andrea Scian Reply-To: andrea.scian@dave.eu From: Andrea Scian We need to set another couple of fields in ecc structure to allow choosing SW ECC instead of HW one, otherwise write operation fail. Signed-off-by: Andrea Scian --- drivers/mtd/nand/raw/pl35x-nand-controller.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mtd/nand/raw/pl35x-nand-controller.c b/drivers/mtd/nan= d/raw/pl35x-nand-controller.c index 11bd90e3f18cb..fcb62b9ec947b 100644 --- a/drivers/mtd/nand/raw/pl35x-nand-controller.c +++ b/drivers/mtd/nand/raw/pl35x-nand-controller.c @@ -976,6 +976,8 @@ static int pl35x_nand_attach_chip(struct nand_chip *chi= p) fallthrough; case NAND_ECC_ENGINE_TYPE_NONE: case NAND_ECC_ENGINE_TYPE_SOFT: + chip->ecc.algo =3D NAND_ECC_ALGO_HAMMING; + chip->ecc.write_page_raw =3D nand_monolithic_write_page_raw; break; case NAND_ECC_ENGINE_TYPE_ON_HOST: ret =3D pl35x_nand_init_hw_ecc_controller(nfc, chip); --=20 2.43.0 From nobody Mon Jan 26 23:02:11 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A12283385A0 for ; Mon, 26 Jan 2026 16:59:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769446743; cv=none; b=jlPTyE2dt9PC5EoU/SW/3ydY7XGHTbZDBu4PhfH3T4T6HB7J7WyBTbT1P+KOs5kaxuNTo8+O9FUA+OG5WmzLiDeuVPX6r4c0hQ27OrV2Rqr4gl8Q8wl0rJ2QIV/iKbu8vAdLs5oOcnXwLam5GcdjzZViNJLqzF7lxFWs5SlwNKM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769446743; c=relaxed/simple; bh=bsIoLFQq9aC2kNh8ij3SZOmwGTyMS6ISf2ZCS9RxiIg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CoabMuj2aTaoWj6CA5/WMeKO63ZLI4ooRtyp0SLCAyp2zBFGmkDkz6Dv/+vYd1c8xDUkY5Ggsowlt0HP5DYUH0h68+HQhdrCf2MlllpZ+BNY5WG3gny9dbezoX7gIb1nmHJ2pyXj7C2Eb31liFrqN4qZbW+lNWn95Q0kjhSwzOk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mlvZYsl+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mlvZYsl+" Received: by smtp.kernel.org (Postfix) with ESMTPS id 68A67C2BC86; Mon, 26 Jan 2026 16:59:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769446743; bh=bsIoLFQq9aC2kNh8ij3SZOmwGTyMS6ISf2ZCS9RxiIg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=mlvZYsl+M3z5TyMiFIMbaEVLSwM6iLhhd7/3/zE2QRORY/oFW7roqyHPuIvX+J08e ybV3TwINJluRYi/69nEhG851eKcLYopemSLYxGcoMJTmQBKKUPRdt5y5ABs/JPTBAO 07+K8UAWosTm3Mre7F4if5yBzZtvaKQtJ+g5QSQBrwfNc2VAOaa+5syzEV05ewr447 B3Q5XSb7u6p0gG2aHenKr1UvcX1sz/D2DB1Z8lJA+ZBlUxOyKtAaigWPfGJWzJKdIQ rtt2gmQu27zd2P45W+B2NczsrPym0pcsH1GpIyWwg5ed3X+bHG3kf93/zFR+X3gPsA 2DDk96IB6Rcng== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6213DD19506; Mon, 26 Jan 2026 16:59:03 +0000 (UTC) From: Andrea Scian via B4 Relay Date: Mon, 26 Jan 2026 17:58:56 +0100 Subject: [PATCH v2 2/2] mtd: rawnand: pl353: Add message about ECC mode Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260126-pl353-soft-ecc-support-v2-2-fcd74b6e955f@dave.eu> References: <20260126-pl353-soft-ecc-support-v2-0-fcd74b6e955f@dave.eu> In-Reply-To: <20260126-pl353-soft-ecc-support-v2-0-fcd74b6e955f@dave.eu> To: Miquel Raynal , Michal Simek , Richard Weinberger , Vignesh Raghavendra Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Amit Kumar , Andrea Scian X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1769446742; l=1273; i=andrea.scian@dave.eu; s=20260121; h=from:subject:message-id; bh=W54VDp3ZuMb3O2+EOIc9KMGJG7f9MGc6xwP0ApOENno=; b=0PXv3vemO7XV8diJRAX7vegCXBaskah1elabJYQNWe3Q7S3LuwMXE2yPJAjFxFnL/EORJsiRQ mVMyImAcEanBHy3xPkySpIIDoajRo7IENyT8qSfWnm+vriOqqLGvOTr X-Developer-Key: i=andrea.scian@dave.eu; a=ed25519; pk=PMQL72nEsyoiJCobnq0uEXwUFpVmkwoWIx317WvaQOU= X-Endpoint-Received: by B4 Relay for andrea.scian@dave.eu/20260121 with auth_id=613 X-Original-From: Andrea Scian Reply-To: andrea.scian@dave.eu From: Andrea Scian This just add some information on kernel log about the selected ECC Signed-off-by: Andrea Scian --- drivers/mtd/nand/raw/pl35x-nand-controller.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mtd/nand/raw/pl35x-nand-controller.c b/drivers/mtd/nan= d/raw/pl35x-nand-controller.c index fcb62b9ec947b..cbef4f0084844 100644 --- a/drivers/mtd/nand/raw/pl35x-nand-controller.c +++ b/drivers/mtd/nand/raw/pl35x-nand-controller.c @@ -970,16 +970,19 @@ static int pl35x_nand_attach_chip(struct nand_chip *c= hip) =20 switch (chip->ecc.engine_type) { case NAND_ECC_ENGINE_TYPE_ON_DIE: + dev_dbg(nfc->dev, "Using on-die ECC\n"); /* Keep these legacy BBT descriptors for ON_DIE situations */ chip->bbt_td =3D &bbt_main_descr; chip->bbt_md =3D &bbt_mirror_descr; fallthrough; case NAND_ECC_ENGINE_TYPE_NONE: case NAND_ECC_ENGINE_TYPE_SOFT: + dev_dbg(nfc->dev, "Using software ECC (Hamming 1-bit/512B)\n"); chip->ecc.algo =3D NAND_ECC_ALGO_HAMMING; chip->ecc.write_page_raw =3D nand_monolithic_write_page_raw; break; case NAND_ECC_ENGINE_TYPE_ON_HOST: + dev_dbg(nfc->dev, "Using hardware ECC\n"); ret =3D pl35x_nand_init_hw_ecc_controller(nfc, chip); if (ret) return ret; --=20 2.43.0