From nobody Mon Feb 9 15:11:26 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3E9F33BBC4; Mon, 26 Jan 2026 14:01:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769436113; cv=none; b=m/ylF9PXbTyytoFZZCxnA6IqONt7K4Wnx7ISDmMcce65GkrKCAljGw2ObYwx+hI9BTikuta9VCWtQ4Nnr0ktk+cls1tIf9HfbvnfL/YZmez/76xhRhscvmBGnCCd5MQnf4Oosr2FZ0TP2YN9o9tvlIowFslNFj3KUFzYgAAXrlM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769436113; c=relaxed/simple; bh=NIUoV8JQngN+NzuxFM8eg0SbnCws9nM7RSFj26CxTrM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Rgo2BX8ThlXThnjtm1fOqn2SdjhbODlNH9Evk7fJPAgv3O1vHdKUT2LKdJDwoJadbz9zDiVQ6KMpvr2QDlZn5kc81YyjCT5fx5lcSwoAe1xW3mD7ZRZsDQotCHZ5fBi085xJRpqwL9rmIsFSe0EZTq04PvMN4adPxQGQga9VcF8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kn1Nm7SX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kn1Nm7SX" Received: by smtp.kernel.org (Postfix) with ESMTPS id 87B1FC2BCB3; Mon, 26 Jan 2026 14:01:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769436113; bh=NIUoV8JQngN+NzuxFM8eg0SbnCws9nM7RSFj26CxTrM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=kn1Nm7SXQRL2tl0Fno9UgeAJ/sphzAOj0FrZFrn+4pt77jhYPsP/6wm91d+zdEPbK KGj+O/FDtCgcaW8EhLjnfQ0Hfr4RQ9HcnyK7XcIn/gX7yiOlgZiudTvfxGLHmabesy dW5fNU67QDhmzf/Q9VgaZwEn3kQxeSYnsiAV3JwKUtr+RvGaZ1EDGU76ZW5iqLh/Zp uG+Mf4jDhCmDgOOKXB6Kx6qTz0IGpLnpuzouIgzy7E2yJbtp8VRNWc/+pPsbIWuZme 795pTARBXgNiMaFRCAyac9f5etFkT39AXUDDhgqKwyB71VkVZN3j9cfJtSYPUxllwS yePuOw2ZQ9Tew== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78B44D13C1A; Mon, 26 Jan 2026 14:01:53 +0000 (UTC) From: Rodrigo Alencar via B4 Relay Date: Mon, 26 Jan 2026 13:51:04 +0000 Subject: [PATCH v2 3/6] iio: amplifiers: ad8366: refactor device resource management Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260126-iio-ad8366-update-v2-3-c9a4d31aeb01@analog.com> References: <20260126-iio-ad8366-update-v2-0-c9a4d31aeb01@analog.com> In-Reply-To: <20260126-iio-ad8366-update-v2-0-c9a4d31aeb01@analog.com> To: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org Cc: Michael Hennerich , Lars-Peter Clausen , Jonathan Cameron , David Lechner , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Rodrigo Alencar X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1769436111; l=3912; i=rodrigo.alencar@analog.com; s=default; h=from:subject:message-id; bh=MSyQPvX4zNZ9Tempwgh6myGBaPDft1zW3aPPK5Ky45k=; b=iRrnsTBOCGHBh+cGIhPDTQxDnpG8Q7e5JRwKzVbTLfKy/FyOA9//ebZnMa/kSc9WypPuMuqm8 HLUaGeXuUF1DmpKrnJ1qMgxo6F1Z7PHxsf0zA6puwETxvAtN5LbAhVl X-Developer-Key: i=rodrigo.alencar@analog.com; a=ed25519; pk=ULeHbgU/OYh/PG/4anHDfLgldFItQHAhOktYRVLMFRo= X-Endpoint-Received: by B4 Relay for rodrigo.alencar@analog.com/default with auth_id=561 X-Original-From: Rodrigo Alencar Reply-To: rodrigo.alencar@analog.com From: Rodrigo Alencar Adhere modern device resource management with the following: - Voltage regulator managed and enabled internally; - Proper mutex lifecycle with devm_mutex_init(), replacing mutex_init(); - IIO device registration handled with devm_iio_device_register(); - removal of goto's from the probe function; - ad8366_remove() removed as it is not needed anymore; Also, dev_err_probe() is used to report probe errors with created local device pointer. Signed-off-by: Rodrigo Alencar --- drivers/iio/amplifiers/ad8366.c | 60 ++++++++++++-------------------------= ---- 1 file changed, 17 insertions(+), 43 deletions(-) diff --git a/drivers/iio/amplifiers/ad8366.c b/drivers/iio/amplifiers/ad836= 6.c index d06ac786501c..0f3fc79ebbf3 100644 --- a/drivers/iio/amplifiers/ad8366.c +++ b/drivers/iio/amplifiers/ad8366.c @@ -40,7 +40,6 @@ struct ad8366_info { =20 struct ad8366_state { struct spi_device *spi; - struct regulator *reg; struct mutex lock; /* protect sensor state */ struct gpio_desc *reset_gpio; unsigned char ch[2]; @@ -245,25 +244,25 @@ static const struct iio_chan_spec ada4961_channels[] = =3D { =20 static int ad8366_probe(struct spi_device *spi) { + struct device *dev =3D &spi->dev; struct iio_dev *indio_dev; struct ad8366_state *st; int ret; =20 - indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); if (indio_dev =3D=3D NULL) return -ENOMEM; =20 st =3D iio_priv(indio_dev); =20 - st->reg =3D devm_regulator_get(&spi->dev, "vcc"); - if (!IS_ERR(st->reg)) { - ret =3D regulator_enable(st->reg); - if (ret) - return ret; - } + ret =3D devm_regulator_get_enable(dev, "vcc"); + if (ret) + return dev_err_probe(dev, ret, "Failed to get regulator\n"); + + ret =3D devm_mutex_init(dev, &st->lock); + if (ret) + return ret; =20 - spi_set_drvdata(spi, indio_dev); - mutex_init(&st->lock); st->spi =3D spi; st->type =3D spi_get_device_id(spi)->driver_data; =20 @@ -276,18 +275,16 @@ static int ad8366_probe(struct spi_device *spi) case ID_ADL5240: case ID_HMC792: case ID_HMC1119: - st->reset_gpio =3D devm_gpiod_get_optional(&spi->dev, "reset", GPIOD_OUT= _HIGH); - if (IS_ERR(st->reset_gpio)) { - ret =3D PTR_ERR(st->reset_gpio); - goto error_disable_reg; - } + st->reset_gpio =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); + if (IS_ERR(st->reset_gpio)) + return dev_err_probe(dev, PTR_ERR(st->reset_gpio), + "Failed to get reset GPIO\n"); + indio_dev->channels =3D ada4961_channels; indio_dev->num_channels =3D ARRAY_SIZE(ada4961_channels); break; default: - dev_err(&spi->dev, "Invalid device ID\n"); - ret =3D -EINVAL; - goto error_disable_reg; + return dev_err_probe(dev, -EINVAL, "Invalid device ID\n"); } =20 st->info =3D &ad8366_infos[st->type]; @@ -297,31 +294,9 @@ static int ad8366_probe(struct spi_device *spi) =20 ret =3D ad8366_write(indio_dev, 0, 0); if (ret < 0) - goto error_disable_reg; + return dev_err_probe(dev, ret, "failed to write initial gain\n"); =20 - ret =3D iio_device_register(indio_dev); - if (ret) - goto error_disable_reg; - - return 0; - -error_disable_reg: - if (!IS_ERR(st->reg)) - regulator_disable(st->reg); - - return ret; -} - -static void ad8366_remove(struct spi_device *spi) -{ - struct iio_dev *indio_dev =3D spi_get_drvdata(spi); - struct ad8366_state *st =3D iio_priv(indio_dev); - struct regulator *reg =3D st->reg; - - iio_device_unregister(indio_dev); - - if (!IS_ERR(reg)) - regulator_disable(reg); + return devm_iio_device_register(dev, indio_dev); } =20 static const struct spi_device_id ad8366_id[] =3D { @@ -339,7 +314,6 @@ static struct spi_driver ad8366_driver =3D { .name =3D KBUILD_MODNAME, }, .probe =3D ad8366_probe, - .remove =3D ad8366_remove, .id_table =3D ad8366_id, }; =20 --=20 2.43.0