From nobody Tue Jan 27 00:30:47 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B732334A786; Mon, 26 Jan 2026 17:08:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769447301; cv=none; b=b4DDubHwKqp31pGn79dMykPO/s4H1QMAiPd6vj+5UDByvvCO4UP6F5SFuRjbbDwS9smx+9aZjn7PzOZfk9wC3mDdyUY30W/cYxFG+eWezN8t+JKAE3stmwHP70Us+sG+zWFcwaODl1Be10jTwSub5hrWOxrTrPfTEVw6qKFywaY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769447301; c=relaxed/simple; bh=xfIGFZcaZsuJbvTqczzDf/90UO6uj2TJb2Q5cU8ZhTo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ajuUoTORzlUStjJ7aOIMN54EK5AZO05/sBMymFRv3I4pwqH4BQz/0YlNZOKocHl9uatAQHKuhilYRaLQVkP54LwSuIHlpwbbILBtSe5zNq04e8GezvIIs3PJi6A+bDDSnA+FTRPvxYU847r2mBwcHIkN0DcKiytxWEYH4Rpouuk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QxqJndli; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QxqJndli" Received: by smtp.kernel.org (Postfix) with ESMTPS id 76E90C19425; Mon, 26 Jan 2026 17:08:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769447301; bh=xfIGFZcaZsuJbvTqczzDf/90UO6uj2TJb2Q5cU8ZhTo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=QxqJndlicgqS+EvFUdfN+VTMx1sJuIaNcBPmxgcpWYFGl4XQ3v3dADMlpG2U8xYQi 3Pr8MDxRdx24h8ugsXt1WyAv5KczqjWpDTboPQWP86BzroskvvmNKTA6w8fwUrY2Dh 5bBpET5pDh4vYJ9IT9GpZBX6IhgldW3MtdVKdGTzATjuBjEv66hV2KQuej1dbyunls ASgYWzVyYs2rJ01yMie5AvQHcsrlofjsv6z0bxXMJ1HnvnAbDZpG/Q28PPNtvwlF4l uuTs+W2qPjIY73AWqEjnLDFyII872eoalAcJpWclAoE7xj/uGi4PmIiMX9WKBKx3ro DSz5VNJwK05PA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7028AD19503; Mon, 26 Jan 2026 17:08:21 +0000 (UTC) From: Abdurrahman Hussain via B4 Relay Date: Mon, 26 Jan 2026 17:08:21 +0000 Subject: [PATCH v5 6/6] i2c: xiic: cosmetic cleanup Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260126-i2c-xiic-v5-6-88a16a28721c@nexthop.ai> References: <20260126-i2c-xiic-v5-0-88a16a28721c@nexthop.ai> In-Reply-To: <20260126-i2c-xiic-v5-0-88a16a28721c@nexthop.ai> To: Michal Simek , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , info@mocean-labs.com Cc: Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Abdurrahman Hussain X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1769447300; l=2981; i=abdurrahman@nexthop.ai; s=20260119; h=from:subject:message-id; bh=dRi5LhqiOa6vw9BCoKD9I00IfjaOT2QPsZveER4YMII=; b=dFoUopq67JPlGmSSOsHt0HEVWqQZOYbBppg3u2gGPIqyDN571SYelyF1jpp9eE/h0GAEx9pXm gJ7sl9WDorZDvUqUm2+G5nJuIpb60pZsuAuDf9xcBMb1DYQ/77605Yz X-Developer-Key: i=abdurrahman@nexthop.ai; a=ed25519; pk=S+ysnf+NwMcBdHBlyKIUEAtaFGSIhQwcJcgcXhq0osg= X-Endpoint-Received: by B4 Relay for abdurrahman@nexthop.ai/20260119 with auth_id=608 X-Original-From: Abdurrahman Hussain Reply-To: abdurrahman@nexthop.ai From: Abdurrahman Hussain Re-use dev pointer instead of referencing &pdev->dev everywhere. Signed-off-by: Abdurrahman Hussain --- drivers/i2c/busses/i2c-xiic.c | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index 09a4b532d55d..3537c97e307a 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -1429,7 +1429,7 @@ static int xiic_i2c_probe(struct platform_device *pde= v) u8 i; u32 sr; =20 - i2c =3D devm_kzalloc(&pdev->dev, sizeof(*i2c), GFP_KERNEL); + i2c =3D devm_kzalloc(dev, sizeof(*i2c), GFP_KERNEL); if (!i2c) return -ENOMEM; =20 @@ -1445,13 +1445,13 @@ static int xiic_i2c_probe(struct platform_device *p= dev) if (irq < 0) return irq; =20 - pdata =3D dev_get_platdata(&pdev->dev); + pdata =3D dev_get_platdata(dev); =20 /* hook up driver to tree */ platform_set_drvdata(pdev, i2c); i2c->adap =3D xiic_adapter; i2c_set_adapdata(&i2c->adap, i2c); - i2c->adap.dev.parent =3D &pdev->dev; + i2c->adap.dev.parent =3D dev; device_set_node(&i2c->adap.dev, dev_fwnode(dev)); snprintf(i2c->adap.name, sizeof(i2c->adap.name), DRIVER_NAME " %s", pdev->name); @@ -1464,12 +1464,12 @@ static int xiic_i2c_probe(struct platform_device *p= dev) =20 i2c->clk =3D devm_clk_get_optional_enabled(dev, NULL); if (IS_ERR(i2c->clk)) - return dev_err_probe(&pdev->dev, PTR_ERR(i2c->clk), + return dev_err_probe(dev, PTR_ERR(i2c->clk), "failed to enable input clock.\n"); =20 - i2c->dev =3D &pdev->dev; - pm_runtime_set_autosuspend_delay(i2c->dev, XIIC_PM_TIMEOUT); - pm_runtime_use_autosuspend(i2c->dev); + i2c->dev =3D dev; + pm_runtime_set_autosuspend_delay(dev, XIIC_PM_TIMEOUT); + pm_runtime_use_autosuspend(dev); ret =3D devm_pm_runtime_set_active_enabled(dev); if (ret < 0) return ret; @@ -1503,7 +1503,7 @@ static int xiic_i2c_probe(struct platform_device *pde= v) =20 ret =3D xiic_reinit(i2c); if (ret < 0) { - dev_err_probe(&pdev->dev, ret, "Cannot xiic_reinit\n"); + dev_err_probe(dev, ret, "Cannot xiic_reinit\n"); return ret; } =20 @@ -1528,22 +1528,23 @@ static int xiic_i2c_probe(struct platform_device *p= dev) =20 static void xiic_i2c_remove(struct platform_device *pdev) { + struct device *dev =3D &pdev->dev; struct xiic_i2c *i2c =3D platform_get_drvdata(pdev); int ret; =20 /* remove adapter & data */ i2c_del_adapter(&i2c->adap); =20 - ret =3D pm_runtime_get_sync(i2c->dev); + ret =3D pm_runtime_get_sync(dev); =20 if (ret < 0) - dev_warn(&pdev->dev, "Failed to activate device for removal (%pe)\n", + dev_warn(dev, "Failed to activate device for removal (%pe)\n", ERR_PTR(ret)); else xiic_deinit(i2c); =20 - pm_runtime_put_sync(i2c->dev); - pm_runtime_dont_use_autosuspend(&pdev->dev); + pm_runtime_put_sync(dev); + pm_runtime_dont_use_autosuspend(dev); } =20 static const struct dev_pm_ops xiic_dev_pm_ops =3D { --=20 2.52.0