From nobody Tue Jan 27 00:30:01 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7973934846A; Mon, 26 Jan 2026 17:08:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769447301; cv=none; b=DXS7bCNXWrvby28YDlrIJZ9brO4cQMpv7jn1Rw4xq7tByqDbZXnuYosbsW61pZuVtY26oq6RYTDu0ywiKwvbOb7fpaGYlReD3CFrq5kc99/WpBpzHDiDAcw9VwUvvO2g8plv9NoXIPl7MKBWTUtexaT8KUFPsXDgeJYOBhk4P28= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769447301; c=relaxed/simple; bh=jvF5qeYw9OFf0xTRtcK9799ZYgCLXgUjt2dmGVjzq24=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dfBVkT1R/Na5rLnd2HV3apnaeSvjJBP/CT9Vem0vXkLz/hpp/IWP3UA8K/pc+aqZYRoKINqUi/kILFAOz0gn7wTH09g514Jl6f56foNls8OmxmcjWC2FKW0GgmNhCRZM83mnqhwNPjpGw2Fzy2uutYMw6S0gNm5ezAm/3wV74yE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TXOhV9FO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TXOhV9FO" Received: by smtp.kernel.org (Postfix) with ESMTPS id 4F6C1C2BC86; Mon, 26 Jan 2026 17:08:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769447301; bh=jvF5qeYw9OFf0xTRtcK9799ZYgCLXgUjt2dmGVjzq24=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=TXOhV9FO6hSpWSicbKfiaIwIizJXBKDoijOgSn9BAnwhea+Umo8UwAXi/8uXFRCue myufuXm8px7SZzN5Vjh2kHtq0QUXFgytRkzisruecf0sDvxGU6OovuQe9O3bXNvnfl ktmjdXdF76vubwmBhQSdfNQmvb7CZY8YHR8G6tQd8R5nY0Qpa+vh9gppKNEy5bIktN AZS1SfKf7//f2oyIQMLPr6Abc3+r9kJcsUyh3YLUqfJTRrOhezaHsAPuxsHsu9MMJQ 7Q5rnmG2GtYrPOzOkbBUGx2Dad5H3EuQlmUUUfz6UalHhbssNp1lLvohcdyJZ/Gt8o Lr3kVxS8lMtZw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44907D19507; Mon, 26 Jan 2026 17:08:21 +0000 (UTC) From: Abdurrahman Hussain via B4 Relay Date: Mon, 26 Jan 2026 17:08:18 +0000 Subject: [PATCH v5 3/6] i2c: xiic: switch to devres managed APIs Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260126-i2c-xiic-v5-3-88a16a28721c@nexthop.ai> References: <20260126-i2c-xiic-v5-0-88a16a28721c@nexthop.ai> In-Reply-To: <20260126-i2c-xiic-v5-0-88a16a28721c@nexthop.ai> To: Michal Simek , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , info@mocean-labs.com Cc: Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Abdurrahman Hussain X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1769447300; l=2539; i=abdurrahman@nexthop.ai; s=20260119; h=from:subject:message-id; bh=bfIH49iCAyAlFD23YdabFfBWUt0uWz1DwhgQrI4yMbc=; b=n1SMe1SPbm69jcfaZUcirZWtvrvPY/A6SV+/oJh7eIVDhEolY942jd4n8uJ5ldPItgzJnqqMD 2CK7IUGgSK1B7Og5eDoy2lZO0bQXeUWVQq3VTkE9Tkr/mLwTGUilgTp X-Developer-Key: i=abdurrahman@nexthop.ai; a=ed25519; pk=S+ysnf+NwMcBdHBlyKIUEAtaFGSIhQwcJcgcXhq0osg= X-Endpoint-Received: by B4 Relay for abdurrahman@nexthop.ai/20260119 with auth_id=608 X-Original-From: Abdurrahman Hussain Reply-To: abdurrahman@nexthop.ai From: Abdurrahman Hussain Simplify the error code paths by switching to devres managed helper functions. Signed-off-by: Abdurrahman Hussain --- drivers/i2c/busses/i2c-xiic.c | 24 ++++++++++-------------- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index 16202fb89271..a4a8087c1407 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -1462,7 +1462,10 @@ static int xiic_i2c_probe(struct platform_device *pd= ev) snprintf(i2c->adap.name, sizeof(i2c->adap.name), DRIVER_NAME " %s", pdev->name); =20 - mutex_init(&i2c->lock); + ret =3D devm_mutex_init(dev, &i2c->lock); + if (ret < 0) + return ret; + spin_lock_init(&i2c->atomic_lock); =20 i2c->clk =3D devm_clk_get_optional_enabled(dev, NULL); @@ -1473,8 +1476,9 @@ static int xiic_i2c_probe(struct platform_device *pde= v) i2c->dev =3D &pdev->dev; pm_runtime_set_autosuspend_delay(i2c->dev, XIIC_PM_TIMEOUT); pm_runtime_use_autosuspend(i2c->dev); - pm_runtime_set_active(i2c->dev); - pm_runtime_enable(i2c->dev); + ret =3D devm_pm_runtime_set_active_enabled(dev); + if (ret < 0) + return ret; =20 /* SCL frequency configuration */ i2c->input_clk =3D clk_get_rate(i2c->clk); @@ -1490,7 +1494,7 @@ static int xiic_i2c_probe(struct platform_device *pde= v) =20 if (ret < 0) { dev_err_probe(&pdev->dev, ret, "Cannot claim IRQ\n"); - goto err_pm_disable; + return ret; } =20 i2c->singlemaster =3D @@ -1511,14 +1515,14 @@ static int xiic_i2c_probe(struct platform_device *p= dev) ret =3D xiic_reinit(i2c); if (ret < 0) { dev_err_probe(&pdev->dev, ret, "Cannot xiic_reinit\n"); - goto err_pm_disable; + return ret; } =20 /* add i2c adapter to i2c tree */ ret =3D i2c_add_adapter(&i2c->adap); if (ret) { xiic_deinit(i2c); - goto err_pm_disable; + return ret; } =20 if (pdata) { @@ -1530,12 +1534,6 @@ static int xiic_i2c_probe(struct platform_device *pd= ev) dev_dbg(&pdev->dev, "mmio %08lx irq %d scl clock frequency %d\n", (unsigned long)res->start, irq, i2c->i2c_clk); =20 - return 0; - -err_pm_disable: - pm_runtime_disable(&pdev->dev); - pm_runtime_set_suspended(&pdev->dev); - return ret; } =20 @@ -1556,8 +1554,6 @@ static void xiic_i2c_remove(struct platform_device *p= dev) xiic_deinit(i2c); =20 pm_runtime_put_sync(i2c->dev); - pm_runtime_disable(&pdev->dev); - pm_runtime_set_suspended(&pdev->dev); pm_runtime_dont_use_autosuspend(&pdev->dev); } =20 --=20 2.52.0