From nobody Mon Feb 9 23:01:27 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57AB5313E2E for ; Mon, 26 Jan 2026 07:48:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769413738; cv=none; b=jo4QAPwlLDSNF5IlF4SxHGf/+h/R3sc7JXzHZyrk/a8xHa+33U6SwfINuUz8r6hR3yRc7/JilRPHncPAMALWjXvVleI1AnrbK0m7CYT9G/wwXYbiIWBsXxS88ce4KBMyyy2ELtc2GUaqQ3bFwIl53r9hSLhZJIASmSEcmditwNM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769413738; c=relaxed/simple; bh=fYWi6it3rCCr65Id+LeC8mkX1SDe4sDJPpCZSTfEuGI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dZmcEG9VSjmiXV18/N9dO/Jk8uFgiyDel6fr64pJ70pNuW3d4V9bA8X63zfEVwpWhiQPwrhgejwur2hhCNmWgFxFI3U+U+hbTBlc66qTstI/Br8V3ahlvFhInxpBJYECpcSRytfA7lRASbI8zbRUPwyMBWShOARmDvOXWrGBQhY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GrO8H3fh; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Q7TzqVdy; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GrO8H3fh"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Q7TzqVdy" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60PIr3PE3858096 for ; Mon, 26 Jan 2026 07:48:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4gIye7UQNPbdPhV/Q1vWHhs/KIv3bebvvJhc2HVhooY=; b=GrO8H3fht2IipknQ sSKyAl4IYQHxY1pMQQDatJPvob3JTF3HImBr4ENW1yC2sXQvP6lzZsC2Gx9aaMQP pkHVjwQg0iBU6Q7Gl8KVU+VfDXn3nMF/GZ4ZiW+rjhKMhkC5ZSindFIf0dpiF9M5 jzBDt18AejB1L6MkudfIr9Ky+IaR/Ze+aMumJfIMGdtV4mLkgrG8FcJGA9ohIlUY WHscgldAL7WDUmyTY1WvnnL2/w4GZ3tVRCyx+eI55O/ZOsjzeInNsu+g363lbIAd UwoYhcec6B9tR7/QzKoPql/WC6tmi905gd66h7BoF15wnvNrdAhiV4NO9u+OJvfM owMHUQ== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bvq6xus1j-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 26 Jan 2026 07:48:56 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-82323cc7594so1002441b3a.2 for ; Sun, 25 Jan 2026 23:48:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769413734; x=1770018534; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=4gIye7UQNPbdPhV/Q1vWHhs/KIv3bebvvJhc2HVhooY=; b=Q7TzqVdyydfy9M0h8XrRNWPfU1I2GTBLamtXs1zWMMid4qDvDd5chMMA6fDKZKy9QT 9rzN9PncmgNQnlf26lmQsEZcjHIK83vS7yk/Jplmu7yTP7ZxPy2r0SB8JbAlR9kqJzIm Z4/nmCr0UQ4F8Ze5gFIO32VX1pGBrvoVSVgRgs0B0xWqpIqTvo5mIDHuuSLGEqIZKa20 tA1tSayFVK5VupMFYCQEgvETCgmg6dk8FEZ4CZSSD5x14YsILoBTAZipHCTUbdcml/1H 06c+VFIgGkTV1SdLmnMZwLlZTJJfxyS0plV+LHAHbEidaGFQxjEwNBrDoABGCeFIHU3A exlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769413734; x=1770018534; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=4gIye7UQNPbdPhV/Q1vWHhs/KIv3bebvvJhc2HVhooY=; b=UxZbkyfpQxgLKOWhmOgDnmQGdURTdswAvVso9g134zX3OfAI8F4+k+p++ysmCZN23W F35qDW6mjiKTOtHsyLRcBa/CjNYIRMWnrCoL31YLI3YCqF51W6To6Hd1MHCi78urKhCW GFFoFiaE9YAma0T6j3SMXoWZyhP0t0hhWV2CmIGQSEqeoGtjZ9NsZ1cNF9lRvBZA9q2y Xr68GMIZBvgm8FVtFTANds8xztvM7MOEwHuW4fJjgq5pVeq3/j4zJTZoxdVulrsVhQ8C TiwTA5ix0+D/SJOJdeffy0jn9nwvEV5AUI7VcDxZ+M3/0JZTD7Y8KftKPj12NIpY8PE3 XdSQ== X-Forwarded-Encrypted: i=1; AJvYcCV+JDf3lLruVCtRYVc3Xye6fRFk2Rc72AYkb2CgNT5bC+T1qBfTdqOrQVFmwiUMs0vqCRKqZu9UQjKegM8=@vger.kernel.org X-Gm-Message-State: AOJu0YwfnG0oZjVg01rgka7xBvyXrDidPD2o7qC8QSZ66Wl1lEVhnWPn 8mi64lJNnqAVS3XiMRoAW0nQ/gdgwCtwimOKMUsokegQZglv9MHMz0dT9oJYRp5J5Lp+76o0EFb Uy+I5ZLv5phxsCWRTtw1u+7UyZJ8WrDoIkYsiJLCPGJSlOW8wl6yrN4zCG7Asw7qx+hU= X-Gm-Gg: AZuq6aJAgudaj4WEok8fqKah4EAprqLVirUD1G6Relo2Ody/icQ0N/CsqjUVsYAq9bQ hItGSkk4O9kc118GrJjX4MnoDDABz6zo2g64Ll5fMNlJoEAQ6K4VObCCCmEyVZn5GFOmP/UuFKC uP6mgKo3F+N3f3KGj76E2QM7OwkeYsX3iU3n0kmiEhy3HqAYkuTruKUY9G8gtz0cE2TcxUmntPf OsYK7MKj/qHtKO47OLifWCLs3ZLfOJ22U5Q82+wjNgOFYNBulnot0IvytktBRHOHKo4XreaHxek OjEpPf6dynXuhiSd6lURcZleO2g7hJCZWFpFA4cm357I1naAflyFkNMdyteN0HuYQ9GtFt/o91M Yxm0sCAjb6fwVJy2qy9pH7xLn601psreFZtHq7mTvwBPazxrHfmtlDzYhapMpOf5btTtFVbXUdE 1G X-Received: by 2002:a05:6a00:8d94:b0:81f:995d:6cb with SMTP id d2e1a72fcca58-823412d9289mr3296083b3a.36.1769413733965; Sun, 25 Jan 2026 23:48:53 -0800 (PST) X-Received: by 2002:a05:6a00:8d94:b0:81f:995d:6cb with SMTP id d2e1a72fcca58-823412d9289mr3296055b3a.36.1769413733496; Sun, 25 Jan 2026 23:48:53 -0800 (PST) Received: from jiegan-gv.ap.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8234fd9a5a7sm1223418b3a.63.2026.01.25.23.48.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Jan 2026 23:48:53 -0800 (PST) From: Jie Gan Date: Mon, 26 Jan 2026 15:47:56 +0800 Subject: [PATCH v11 4/8] coresight: etr: refactor the tmc_etr_get_catu_device function Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260126-enable-byte-cntr-for-ctcu-v11-4-c0af66ba15cf@oss.qualcomm.com> References: <20260126-enable-byte-cntr-for-ctcu-v11-0-c0af66ba15cf@oss.qualcomm.com> In-Reply-To: <20260126-enable-byte-cntr-for-ctcu-v11-0-c0af66ba15cf@oss.qualcomm.com> To: Suzuki K Poulose , Mike Leach , James Clark , Alexander Shishkin , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tingwei Zhang , Mao Jinlong , Bjorn Andersson , Konrad Dybcio Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Jie Gan X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1769413705; l=4412; i=jie.gan@oss.qualcomm.com; s=20250909; h=from:subject:message-id; bh=fYWi6it3rCCr65Id+LeC8mkX1SDe4sDJPpCZSTfEuGI=; b=UJnXSFL79huFwDQeeINc5HmqIQvIG4Wua9f5RXCBnj2KI8WFg7dFFU3bzJbZunIagSjnxh6Bo WobJdmWoxbXDUSqzioewnFE2oO4k9VVDYNQElrobh6S6ekOCGvUzSVu X-Developer-Key: i=jie.gan@oss.qualcomm.com; a=ed25519; pk=3LxxUZRPCNkvPDlWOvXfJNqNO4SfGdy3eghMb8puHuk= X-Proofpoint-GUID: MVWb4z7KDqXvh9fZk5UivUZxjovAvG-I X-Proofpoint-ORIG-GUID: MVWb4z7KDqXvh9fZk5UivUZxjovAvG-I X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI2MDA2NiBTYWx0ZWRfX7o9RHLLj5jWA qjXLuUdW2FKElzApXuaW3BhjcHKSuq9lM8Fiwb9EqbuVAOYE8O/aOBZpAk3e2QC4zlhh/CuU7G7 mgcqXuW2KWk8fBb2aIogW8niHMO+uwsMCTsWeoZkP9wN1K20+NANLVQdTf4uPFOcZrv9Uow0I4X pBjrFiw8rJup8OxXKJamReEfZcGbKQgTVL8f+w4P3IH7NGdcT4mDPf0bXEO/MEyKbOsNqYqef/f a5lkW95D9lMLTC11kmQvkdlrkvAEXOq6iEtK30AcRrHrH7WDrFyRiQz8jHNiWao25NVR9ZZiTt4 0AFqXYMcSAJgnUnAePACZA/H2aCDVw68kw4jaj/JGV9Da6EXT9snPEiHTJEe68/Ms6sUL50Ybx/ uAXX7kLKDGjddtYbzgmaFKO1Dl0cXrPyiSErSiqPMOmJXItMochB448dvGheLvuP7+uNgywDhya u2JZPqpJ9D+5jS3uJhw== X-Authority-Analysis: v=2.4 cv=Htd72kTS c=1 sm=1 tr=0 ts=69771c68 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=-ozbsww5GKt6_lkPIaMA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-26_02,2026-01-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 suspectscore=0 priorityscore=1501 spamscore=0 phishscore=0 clxscore=1015 adultscore=0 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601260066 Refactor tmc_etr_get_catu_device to retrieve the helper device connected to the TMC ETR based on helper_subtype. Signed-off-by: Jie Gan --- drivers/hwtracing/coresight/coresight-catu.c | 3 ++- drivers/hwtracing/coresight/coresight-tmc-etr.c | 32 ++++++++++++++++-----= ---- drivers/hwtracing/coresight/coresight-tmc.h | 3 ++- 3 files changed, 25 insertions(+), 13 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-catu.c b/drivers/hwtraci= ng/coresight/coresight-catu.c index 69b36bae97ab..d3972619cc96 100644 --- a/drivers/hwtracing/coresight/coresight-catu.c +++ b/drivers/hwtracing/coresight/coresight-catu.c @@ -334,7 +334,8 @@ static int catu_alloc_etr_buf(struct tmc_drvdata *tmc_d= rvdata, struct tmc_sg_table *catu_table; struct catu_etr_buf *catu_buf; =20 - csdev =3D tmc_etr_get_catu_device(tmc_drvdata); + csdev =3D tmc_etr_get_helper_device(tmc_drvdata, + CORESIGHT_DEV_SUBTYPE_HELPER_CATU); if (!csdev) return -ENODEV; catu_buf =3D kzalloc(sizeof(*catu_buf), GFP_KERNEL); diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtr= acing/coresight/coresight-tmc-etr.c index cbbb15648fb7..16a4562533d5 100644 --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c @@ -844,28 +844,37 @@ static const struct etr_buf_operations etr_sg_buf_ops= =3D { }; =20 /* - * TMC ETR could be connected to a CATU device, which can provide address - * translation service. This is represented by the Output port of the TMC - * (ETR) connected to the input port of the CATU. + * TMC ETR could be connected to the helper device, which can provide addr= ess + * translation service(CATU) or data filter function(CTCU). This is repres= ented + * by the Output port of the TMC (ETR) connected to the input port of the = helper. * - * Returns : coresight_device ptr for the CATU device if a CATU is found. + * @drvdata : drvdata of the TMC device + * @subtype : helper_subtype of the helper device + * + * Returns : coresight_device ptr for the helper device if a helper is fou= nd. * : NULL otherwise. */ struct coresight_device * -tmc_etr_get_catu_device(struct tmc_drvdata *drvdata) +tmc_etr_get_helper_device(struct tmc_drvdata *drvdata, + enum coresight_dev_subtype_helper subtype) { struct coresight_device *etr =3D drvdata->csdev; - union coresight_dev_subtype catu_subtype =3D { - .helper_subtype =3D CORESIGHT_DEV_SUBTYPE_HELPER_CATU + union coresight_dev_subtype helper_subtype =3D { + .helper_subtype =3D subtype }; =20 - if (!IS_ENABLED(CONFIG_CORESIGHT_CATU)) + + if (subtype =3D=3D CORESIGHT_DEV_SUBTYPE_HELPER_CATU && + !IS_ENABLED(CONFIG_CORESIGHT_CATU)) + return NULL; + else if (subtype =3D=3D CORESIGHT_DEV_SUBTYPE_HELPER_CTCU && + !IS_ENABLED(CONFIG_CORESIGHT_CTCU)) return NULL; =20 return coresight_find_output_type(etr->pdata, CORESIGHT_DEV_TYPE_HELPER, - catu_subtype); + helper_subtype); } -EXPORT_SYMBOL_GPL(tmc_etr_get_catu_device); +EXPORT_SYMBOL_GPL(tmc_etr_get_helper_device); =20 static const struct etr_buf_operations *etr_buf_ops[] =3D { [ETR_MODE_FLAT] =3D &etr_flat_buf_ops, @@ -913,7 +922,8 @@ static void get_etr_buf_hw(struct device *dev, struct e= tr_buf_hw *buf_hw) =20 buf_hw->has_iommu =3D iommu_get_domain_for_dev(dev->parent); buf_hw->has_etr_sg =3D tmc_etr_has_cap(drvdata, TMC_ETR_SG); - buf_hw->has_catu =3D !!tmc_etr_get_catu_device(drvdata); + buf_hw->has_catu =3D !!tmc_etr_get_helper_device(drvdata, + CORESIGHT_DEV_SUBTYPE_HELPER_CATU); buf_hw->has_resrv =3D tmc_has_reserved_buffer(drvdata); } =20 diff --git a/drivers/hwtracing/coresight/coresight-tmc.h b/drivers/hwtracin= g/coresight/coresight-tmc.h index c780f6d5dede..e573503f2edf 100644 --- a/drivers/hwtracing/coresight/coresight-tmc.h +++ b/drivers/hwtracing/coresight/coresight-tmc.h @@ -469,7 +469,8 @@ static inline uint32_t find_crash_tracedata_crc(struct = tmc_drvdata *drvdata, return crc32_le(0, (void *)drvdata->resrv_buf.vaddr, crc_size); } =20 -struct coresight_device *tmc_etr_get_catu_device(struct tmc_drvdata *drvda= ta); +struct coresight_device *tmc_etr_get_helper_device(struct tmc_drvdata *drv= data, + enum coresight_dev_subtype_helper subtype); =20 void tmc_etr_set_catu_ops(const struct etr_buf_operations *catu); void tmc_etr_remove_catu_ops(void); --=20 2.34.1