From nobody Tue Feb 10 04:15:37 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FC07313E19 for ; Mon, 26 Jan 2026 07:48:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769413732; cv=none; b=IeiQdxlp90q+2rnzOvpOwNXkMjcOjn1Cvod+/JvFlqt0MiaUpNBfrjnSUB1Df3jEv570y9msVfNjjd1k0bXnQ9KQIZh1QNycl3eBwH/Swe5iUdhQicnA75lOiPaOLEnTIhhsz/D+LBb/e0spzZXZIKWru9WPSKjccpk0FhIA4Hk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769413732; c=relaxed/simple; bh=CwCT5/x9boKhb1Ajkz+foUdUOzmm0/q81QDotkFpGzA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=n8uRfFe+an3SCZ43+Z7w03FLTqcNUE1XuPLYg35QqQaaE/buccWlUCp8a1S7OPksLoRcAzgMdVh9x/c+OsY1dYbqWQ+Tocvtc1LSv4yEnnFINlBZ0lrODvA2/LN5PlptpQlztFqeZnNbdCTeshSzvEEKnY7QMy+9f+hDuAjiyPk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=n9e7xKdy; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IJdaXQF2; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="n9e7xKdy"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IJdaXQF2" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60PKNtZT354539 for ; Mon, 26 Jan 2026 07:48:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 51VyzH5MVWt5pCU+WtqPfgt9gr9jXVE/0KTTZNnKYmU=; b=n9e7xKdyqtsIO5rG F4lPB2ij4lSriSmuqoaPJzSerq7syILRisxT3UKxfXDEzC5afCP789G/fSDqFNNp gTdJBgXF1wRI9Pnr+UTUEPka+sceJqVShAzl3JzdAswghULQuH//3hdIkI2E0Nf7 5w2wVqhdWYKwcStLfTLtjEQQPNA22H0fnYcUelOmYq8s8e5M465hYafXbdA1/Vh1 m8x8f1mtRs1Ecna9+wv/dCLmNQOX8+uSI8Z8gXwY+PvC7BbDoLsr3YQcTnVIg36x piUO+cBvP+gcOewQ5EeDYg1QLkoicKhsQF50NK00TT3RSG254QsjXsojsZ0jMhn3 iERnmA== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bvq9qksmm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 26 Jan 2026 07:48:50 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-8234ea73bdeso625688b3a.0 for ; Sun, 25 Jan 2026 23:48:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769413729; x=1770018529; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=51VyzH5MVWt5pCU+WtqPfgt9gr9jXVE/0KTTZNnKYmU=; b=IJdaXQF2CRE9nQKDdTYJ+dsGny5avJ2lOrD5B2UJptsthQQqWT7IwXUEh8fCqorqRy mmqddQVaIyHHgzyhHUxJe4yZ5IJya9VH6i9Lf5S0tspphxDbxiXAIpcl+s0m9OmhPOyz lAei1QoZ+n6o2hkSp5Hjl/FghmFpdTAa5PcxQqxeODljQLYvw7DhPXayyI8vG3Si2fto cSxEVBw1yW+TknH8RoBpRv7UA2pk/EWmZH6HeL5lAHyH5kMZoeR0ssmkIWTdczcyNOMQ luvsec1SysYX2QV+QxQao6FshLS+C7E11dlokeGepSOaiX8UDyVoaYezzMisWQLamfhx /prQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769413729; x=1770018529; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=51VyzH5MVWt5pCU+WtqPfgt9gr9jXVE/0KTTZNnKYmU=; b=SSvd/hSfWMf+VZK0SEVhA4fNX2NPR6yvUZ+I91jNPxA3Wua3pCH63Ucl/X/6O1LmmH AeIV9VQ1MpOHiQXu7RLJOAm4triT9B+f8fSS6n43I4dLB3MRmMRhm3/UpeHTrPBuhF2V lIapGKU0iZqkii3fyMTpeuPJqAC+Ds3m6MEBCPslzS6hon/g+C72aOpNnvmIHU9UqJG3 /Q5LuXJyNw8NqFvgGNXoFgDxKvCeCQbhp7hZF6xBvLeMBgijihfjTgviQKYKTyMKAnqO CQSzh2f6rc4+9QnjY82thCg1506ROBQQoN/fcK3BAahnHGYfYpDo3BpEQfB2O6QXt6Fd Q6dA== X-Forwarded-Encrypted: i=1; AJvYcCW/HWKK/lB1DDrA5kUugxiERw4mA4ABHQPnMM7oYQ2wSOU7ieXBe9Y625yrBjEYP4qSE81qVn9c9R+DLLc=@vger.kernel.org X-Gm-Message-State: AOJu0YyKal8kRBFhN7GJRXJBE2LYyaoUaX0QEceM/FbLBR9cKfEaTkCG mQIEF20DL8qXaNlIY9hxHFUa4JMfzEgS1Mm9sauRfOrsrAnOebPPz4qwMGq3xwjxLJB9WUrhs2z ojtjZ6ixvcUklR8ArpIy9PocWS/mtYTPomI/MkgfqIGPc4LYRZBsOyg/HkzU4nlpOwCk= X-Gm-Gg: AZuq6aLgTV874xOTdvSaSI2JEfdReWSFo1uuBHHeuW+7HNDHYq9kBOJ6qGoDNcHQNfV UgUIWNr6ZiILysXJop1vzQcrsaeh3W3ubf9d6h8oGMg1NIFOPZA3b16xIcblbaS32Rurh5uHBmE xvEgr7yb5aUaDuZ6lEKGXPO+TGetZYA2xFVXb3+09K3mPqYFU+ALHtVuFjvnGL0nFLg/Df03Vrc 5MnU55ADV+ER6i91ePtEHgHmqGaAMPP2Z4IDNYUDodzf5+acnZWMx0VAeaQxKFQb+DI/vvZeTZz xhHS2EK+Z5hC2G/BdKTPAgUS0ju6Qg9Vgr5lemS49peTJZ9ume9gdqnRNGNLjHezDzc4Q5RwmJ9 0JAf2RSoWBiA0XoRKgn0i0lexpU5WBQwtPYoHgsA56Nru30rmqZn/xgRy9c1FzLezdMAlRJT29O tJ X-Received: by 2002:a05:6a00:9284:b0:81f:de60:39b0 with SMTP id d2e1a72fcca58-823411da07dmr2830788b3a.13.1769413729084; Sun, 25 Jan 2026 23:48:49 -0800 (PST) X-Received: by 2002:a05:6a00:9284:b0:81f:de60:39b0 with SMTP id d2e1a72fcca58-823411da07dmr2830765b3a.13.1769413728607; Sun, 25 Jan 2026 23:48:48 -0800 (PST) Received: from jiegan-gv.ap.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8234fd9a5a7sm1223418b3a.63.2026.01.25.23.48.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Jan 2026 23:48:48 -0800 (PST) From: Jie Gan Date: Mon, 26 Jan 2026 15:47:55 +0800 Subject: [PATCH v11 3/8] coresight: tmc: Introduce tmc_sysfs_ops to wrap sysfs read operations Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260126-enable-byte-cntr-for-ctcu-v11-3-c0af66ba15cf@oss.qualcomm.com> References: <20260126-enable-byte-cntr-for-ctcu-v11-0-c0af66ba15cf@oss.qualcomm.com> In-Reply-To: <20260126-enable-byte-cntr-for-ctcu-v11-0-c0af66ba15cf@oss.qualcomm.com> To: Suzuki K Poulose , Mike Leach , James Clark , Alexander Shishkin , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tingwei Zhang , Mao Jinlong , Bjorn Andersson , Konrad Dybcio Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Jie Gan , Mike Leach X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1769413705; l=5212; i=jie.gan@oss.qualcomm.com; s=20250909; h=from:subject:message-id; bh=CwCT5/x9boKhb1Ajkz+foUdUOzmm0/q81QDotkFpGzA=; b=Cl4fdo7nxRQLBIImPb2gA1ya8QZK0sZl7WyCD5lomXVdSWJdGJRffVnzjr6VcolRhx6x5UUn2 FRFHQSMSYPKBcaC84Macjr8SUm23SdXP0xXOEqDLRd0hp/VoYoJ9J3W X-Developer-Key: i=jie.gan@oss.qualcomm.com; a=ed25519; pk=3LxxUZRPCNkvPDlWOvXfJNqNO4SfGdy3eghMb8puHuk= X-Proofpoint-ORIG-GUID: SjnO4uFdP4EHng7XureeE3vYrpuRdN3K X-Proofpoint-GUID: SjnO4uFdP4EHng7XureeE3vYrpuRdN3K X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI2MDA2NiBTYWx0ZWRfX6xFXuBttfjpU he+KBUA8d6s7u7UDRhZrrSm5dcrBUzz4BUTdBUST7ETBaAOjAUM9DAhJdOgRpBs9bafNhnFzCrq 2H4UYfHJdbj6+mB+0CoAteU0lBxVpwjTBRsvD6Coqm0Osfkk2O+S8g2yJocEDDFRY1LyN0+wnTl F5C/EnlAgrfrAMgLs63QTRuIHD4uyXZKXRU/XNNDRG74FNiqqIR83h5Z0rKUmVUWhFNdgSpfZDc RQtcWF5Cuq5vy1+rJHe/HMxudcWYKZERiUY923rKPTnxAaazPsMHdIM9y6Ti3RadqEfPVBQmYNT oQX69CLu5W10MeReEYCtfrSS1WtWRBxAkHS6QQRM1uaTgwu42QjvUczXWKPvqZ7ZIMNlnv+5qHH QD3cuTgEoTXO6TWm11TGNWcz3uzgFZ+z8PZrNJhN764hk8K2hwjkOMKQTkZqOAeIvTJiPFkqUZA gM5Ai0Ivm4H3i8HoaNw== X-Authority-Analysis: v=2.4 cv=TsTrRTXh c=1 sm=1 tr=0 ts=69771c62 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=ia3uihG--C1vaqsH_ucA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-26_02,2026-01-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 phishscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601260066 Introduce tmc_sysfs_ops as a wrapper, wrap sysfs read operations, for readi= ng trace data from the TMC buffer. Reviewed-by: Mike Leach Signed-off-by: Jie Gan --- drivers/hwtracing/coresight/coresight-tmc-core.c | 51 ++++++++++----------= ---- drivers/hwtracing/coresight/coresight-tmc.h | 15 +++++++ 2 files changed, 37 insertions(+), 29 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-tmc-core.c b/drivers/hwt= racing/coresight/coresight-tmc-core.c index 1ea255ffa67c..32ca2ec994de 100644 --- a/drivers/hwtracing/coresight/coresight-tmc-core.c +++ b/drivers/hwtracing/coresight/coresight-tmc-core.c @@ -232,17 +232,10 @@ static int tmc_read_prepare(struct tmc_drvdata *drvda= ta) { int ret =3D 0; =20 - switch (drvdata->config_type) { - case TMC_CONFIG_TYPE_ETB: - case TMC_CONFIG_TYPE_ETF: - ret =3D tmc_read_prepare_etb(drvdata); - break; - case TMC_CONFIG_TYPE_ETR: - ret =3D tmc_read_prepare_etr(drvdata); - break; - default: + if (drvdata->sysfs_ops) + ret =3D drvdata->sysfs_ops->read_prepare(drvdata); + else ret =3D -EINVAL; - } =20 if (!ret) dev_dbg(&drvdata->csdev->dev, "TMC read start\n"); @@ -254,17 +247,10 @@ static int tmc_read_unprepare(struct tmc_drvdata *drv= data) { int ret =3D 0; =20 - switch (drvdata->config_type) { - case TMC_CONFIG_TYPE_ETB: - case TMC_CONFIG_TYPE_ETF: - ret =3D tmc_read_unprepare_etb(drvdata); - break; - case TMC_CONFIG_TYPE_ETR: - ret =3D tmc_read_unprepare_etr(drvdata); - break; - default: + if (drvdata->sysfs_ops) + ret =3D drvdata->sysfs_ops->read_unprepare(drvdata); + else ret =3D -EINVAL; - } =20 if (!ret) dev_dbg(&drvdata->csdev->dev, "TMC read end\n"); @@ -291,15 +277,7 @@ static int tmc_open(struct inode *inode, struct file *= file) static ssize_t tmc_get_sysfs_trace(struct tmc_drvdata *drvdata, loff_t pos= , size_t len, char **bufpp) { - switch (drvdata->config_type) { - case TMC_CONFIG_TYPE_ETB: - case TMC_CONFIG_TYPE_ETF: - return tmc_etb_get_sysfs_trace(drvdata, pos, len, bufpp); - case TMC_CONFIG_TYPE_ETR: - return tmc_etr_get_sysfs_trace(drvdata, pos, len, bufpp); - } - - return -EINVAL; + return drvdata->sysfs_ops->get_trace_data(drvdata, pos, len, bufpp); } =20 static ssize_t tmc_read(struct file *file, char __user *data, size_t len, @@ -769,6 +747,18 @@ static void register_crash_dev_interface(struct tmc_dr= vdata *drvdata, "Valid crash tracedata found\n"); } =20 +static const struct tmc_sysfs_ops etb_sysfs_ops =3D { + .read_prepare =3D tmc_read_prepare_etb, + .read_unprepare =3D tmc_read_unprepare_etb, + .get_trace_data =3D tmc_etb_get_sysfs_trace, +}; + +static const struct tmc_sysfs_ops etr_sysfs_ops =3D { + .read_prepare =3D tmc_read_prepare_etr, + .read_unprepare =3D tmc_read_unprepare_etr, + .get_trace_data =3D tmc_etr_get_sysfs_trace, +}; + static int __tmc_probe(struct device *dev, struct resource *res) { int ret =3D 0; @@ -828,6 +818,7 @@ static int __tmc_probe(struct device *dev, struct resou= rce *res) desc.subtype.sink_subtype =3D CORESIGHT_DEV_SUBTYPE_SINK_BUFFER; desc.ops =3D &tmc_etb_cs_ops; dev_list =3D &etb_devs; + drvdata->sysfs_ops =3D &etb_sysfs_ops; break; case TMC_CONFIG_TYPE_ETR: desc.groups =3D coresight_etr_groups; @@ -841,6 +832,7 @@ static int __tmc_probe(struct device *dev, struct resou= rce *res) mutex_init(&drvdata->idr_mutex); dev_list =3D &etr_devs; INIT_LIST_HEAD(&drvdata->etr_buf_list); + drvdata->sysfs_ops =3D &etr_sysfs_ops; break; case TMC_CONFIG_TYPE_ETF: desc.groups =3D coresight_etf_groups; @@ -849,6 +841,7 @@ static int __tmc_probe(struct device *dev, struct resou= rce *res) desc.subtype.link_subtype =3D CORESIGHT_DEV_SUBTYPE_LINK_FIFO; desc.ops =3D &tmc_etf_cs_ops; dev_list =3D &etf_devs; + drvdata->sysfs_ops =3D &etb_sysfs_ops; break; default: pr_err("%s: Unsupported TMC config\n", desc.name); diff --git a/drivers/hwtracing/coresight/coresight-tmc.h b/drivers/hwtracin= g/coresight/coresight-tmc.h index 9b3c4e6f0a5e..c780f6d5dede 100644 --- a/drivers/hwtracing/coresight/coresight-tmc.h +++ b/drivers/hwtracing/coresight/coresight-tmc.h @@ -258,6 +258,7 @@ struct etr_buf_node { * Used by ETR/ETF. * @etr_buf_list: List that is used to manage allocated etr_buf. * @reading_node: Available buffer_node for byte-cntr reading. + * @sysfs_ops: Read operations for sysfs mode. */ struct tmc_drvdata { struct clk *atclk; @@ -290,6 +291,20 @@ struct tmc_drvdata { struct tmc_resrv_buf crash_mdata; struct list_head etr_buf_list; struct etr_buf_node *reading_node; + const struct tmc_sysfs_ops *sysfs_ops; +}; + +/** + * struct tmc_sysfs_ops - read operations for TMC and its helper devices + * @read_prepare: prepare operation. + * @read_unprepare: unprepare operation. + * @get_trace_data: read operation. + */ +struct tmc_sysfs_ops { + int (*read_prepare)(struct tmc_drvdata *drvdata); + int (*read_unprepare)(struct tmc_drvdata *drvdata); + ssize_t (*get_trace_data)(struct tmc_drvdata *drvdata, loff_t pos, + size_t len, char **bufpp); }; =20 struct etr_buf_operations { --=20 2.34.1