From nobody Mon Feb 9 19:29:54 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8130430EF96 for ; Mon, 26 Jan 2026 07:48:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769413726; cv=none; b=nPlW51Rchmteu9596uWPdcPZZm+/QHDfl8cAHp8tR90kvBCmJFLr0lgmX4BILRxFLFV5f+8OxR4xfSshRC7sXZwBniHNG2D3J1jQR/eTIFXyNWUEjx4iKlReAado3coF+rShUzx/AUDzirAqwTpHvx+t5am/Z1UuRM7fF5XmtFg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769413726; c=relaxed/simple; bh=iOBlKE7wcNNqdQg697EHs/307n7EmzHjJxd5G5rMLIU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NLboEs6gzrErgJIn2j1L2DDdYlYtmxf6j2QNqnmgc+8kXHObXYCRkuc6iJTCPV+5JQmvofnvREC8Dn+KuBv546TFN+34A8ozrxR81wCrmkGW2L6KD0CHPxlSK47SXR3wZmGcdDw4htloBmXDGvnSV849NPtMo/ZlwuXcvikwMXU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bhd012yn; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hFOi9W05; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bhd012yn"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hFOi9W05" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60Q7Rofi193629 for ; Mon, 26 Jan 2026 07:48:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4Jay9EfBX3UpMTwsvQnGvQgNS5FLBeKOwQWuoZ1I2KI=; b=bhd012ynFFUsIiZ7 hUldVPgyTc9JXLZcVbVAJjrszmwTXRySM/0XxmeDq1hxIEpcQb8zuWjCXul9Gxkp 8k6m1m1H796IzkBN0VVgCiclhxz5gV4p5fTci9bBDg18haTMJGruyByGC08aSJDj YOxB4pxwMn/+9E6/hH3y+RNbJJnaPV7bNcB/fMkHMlQqpg4l9bxJAQTPzl/IIEPJ 1BoMpUfgL6nzY57mCYL51xK+4FRoY3wsg8uAAaOPW8ZY2pHpU8JaxKBRAFjCi+4h tVmTNsGl86F8TQWmKhDSsGlut9Pc0ROCmgZuh5ItiSYS8KjUOl3tvDfpTNRokTKo BacvJg== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bvq9f3s2m-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 26 Jan 2026 07:48:44 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c6136af8e06so2388706a12.1 for ; Sun, 25 Jan 2026 23:48:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769413724; x=1770018524; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=4Jay9EfBX3UpMTwsvQnGvQgNS5FLBeKOwQWuoZ1I2KI=; b=hFOi9W05m1B21wJzUN0raufFmyd5vBxUl+oem8BmDGn2WDGlCxMNECp0SNi7rHCYpX P6VcfX6F2zf9l+iB/LkqbOBoUIKmPVchlT1HdL0+wXECyRfv/KxQzJuQbQPQjgRhmRZP c2HYCzyjF4FqtL63lMXqtWGtplUyqNtnkUaYLTgsVQ3UPNLQ+fd6Dmchmvf0vyDY6oA0 9u+4jpFB7F2TZpL+60YmifKkhbChAqiuKK5vxwjzCGIm1lxFBeUuJyqa+eeypPsMHyXe PThLpGIRqPhqCDuvQOCsvvdvmL61QyO+WquLgANhB7Yq3w+LXycQch2bSaQksVbYG+sN VPLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769413724; x=1770018524; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=4Jay9EfBX3UpMTwsvQnGvQgNS5FLBeKOwQWuoZ1I2KI=; b=OrzVrLcaixzVQHrJ5YtdMWhRSMqSOjTo3rT3ixcIjYeiMAZXE1fSRrSIzYL+Mwwwni aBcBBJ1hA1Yk+0nV1pJXiyze17GxvhHcqnN88BMbUw5bq8zzN8I9HDzBW6/3oswDfua3 6UYGRNveaByymPv6B/qkwBfK4IRYySwSPN+qoVZRwDWi2qlng+cOtITL6MGQ3HPiztuX kObVuZgt9lI7kBp2ORPrMxpV2ecG12Ns4kIPEIVvRlCWZWmXkdU4ydcz+1XOPt84+2ML 7PAY0CTZZgt3ojrLuxnxm6Y1bCKK20TV0gn7aug8mzb/W4fOAUtGbfBa+EvQWFX7vuCf 5RPA== X-Forwarded-Encrypted: i=1; AJvYcCVo/ZO/6FYQqLJlk8Dg/T6SnfHNv8OjcwleSi6wZ30dhfvLEc426XDsQcVQppxRodTbMNKhQbF0UmF0t3c=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8674WwNDlgiaS/VCHd9kM2PDHIkmE29jlc71XPwg80qOYLqmh qVD8Di7t2jsSF+z+tLvpXxPdwJUHh11qoUZZPljYuKXU10I+KKvsM/xm5FsrG9bU7FtjM/AXtnl NuoPQ3BxoOIob5lJjZ8WiMv6qgAl05T/sB3aB5j7/F/H7XIW7SQ8maczNgCw+vLqwOCw= X-Gm-Gg: AZuq6aIjAxtUDaQDzgECMDPHQfc9KS66vg+IMDj44PzjQXDoOEvTNfGMlX9JqZntph7 Krw+wJSl/oK6STwR8DD5uhyNSIAZUPT7zxjbt9n44uR5LK9ezn5kOMOX3decG+WioA0EGJ04jH0 OfoeUySN4lCsY4URigDojALbPUO1STjp+siOhZKkhQCoPlTnzCG81GMKUYRooweggOaWh3KH0Mv Wt7pjUCmfk/ryW92I9BRjfrUgw5BcK0kpHIYW2eL8herQQlXKxbKSF/4X/YmA7Jkna/A0dsFxuo XhCaGoZ6F6THCNM6a6L5BFyiiGNnRT5t0oELP9DcROGovOB2nMXaBeX7oicG3iU9fuCZLM0nUou ndKRr6MeDMXqnZZflbM/U5TB9VZiqhICM9eGSkh9+lZaI2LhSnj6Mv56i/RcMvK+F7yKD2exRsV nb X-Received: by 2002:a05:6a00:3e02:b0:81f:4999:ae46 with SMTP id d2e1a72fcca58-823412be9afmr3126541b3a.48.1769413724053; Sun, 25 Jan 2026 23:48:44 -0800 (PST) X-Received: by 2002:a05:6a00:3e02:b0:81f:4999:ae46 with SMTP id d2e1a72fcca58-823412be9afmr3126506b3a.48.1769413723357; Sun, 25 Jan 2026 23:48:43 -0800 (PST) Received: from jiegan-gv.ap.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8234fd9a5a7sm1223418b3a.63.2026.01.25.23.48.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Jan 2026 23:48:42 -0800 (PST) From: Jie Gan Date: Mon, 26 Jan 2026 15:47:54 +0800 Subject: [PATCH v11 2/8] coresight: tmc: add create/clean functions for etr_buf_list Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260126-enable-byte-cntr-for-ctcu-v11-2-c0af66ba15cf@oss.qualcomm.com> References: <20260126-enable-byte-cntr-for-ctcu-v11-0-c0af66ba15cf@oss.qualcomm.com> In-Reply-To: <20260126-enable-byte-cntr-for-ctcu-v11-0-c0af66ba15cf@oss.qualcomm.com> To: Suzuki K Poulose , Mike Leach , James Clark , Alexander Shishkin , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tingwei Zhang , Mao Jinlong , Bjorn Andersson , Konrad Dybcio Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Jie Gan , Mike Leach X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1769413705; l=6192; i=jie.gan@oss.qualcomm.com; s=20250909; h=from:subject:message-id; bh=iOBlKE7wcNNqdQg697EHs/307n7EmzHjJxd5G5rMLIU=; b=ru4rBEls9TKgFexG6YSC8o9GwR+E4SQnSYPxvf6VcG/iS6eyoEXXLZhgwyRXMkXb125QZPGn9 aHQY+jERHp8BxfLZ/nFr4OGARDp8ZygOuKu0thZkz2N8lCOlOxxrhqy X-Developer-Key: i=jie.gan@oss.qualcomm.com; a=ed25519; pk=3LxxUZRPCNkvPDlWOvXfJNqNO4SfGdy3eghMb8puHuk= X-Authority-Analysis: v=2.4 cv=YLGSCBGx c=1 sm=1 tr=0 ts=69771c5c cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=AScg1gZdVb1XvqdcXssA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: wRuCN_CWoeOTAAusqiPOxLfIFjkK8E3f X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI2MDA2NiBTYWx0ZWRfX7/SkuLXQ8TEu q2f2Q2F23uDfqDhC5ArGtJLfTBiohG7Ro4LhVL4vqSs24S9UsHJ3A7EOFCk63j+zCIQDrqf1gth RezRNpksVwTi8qGDklGu+QkWUrRfQ+rSs4lHHcMvgZxZm6xOpby6SjmcYr56liMJTv8adi54eCW ASLaPpFPD6CzMHm2d9EhMmZSUTnAckIy8LK4dU1RvQ3pw42/7PL8VodrU8/fV22WbXMl4Cd23AJ DAgTKmclaoYa+kTmCSV1dnsyPAIwaYopAONEYoCfTRMN0DE7WjKPxZYsZ5XneMBEjKaK/VF3kxR YpkSYKTtUPz2oAqkrRT/RUmy0cu4ic96jrgonG1iVrBMxtI+YcIetMv2RtAH8H4bRXwhfiCWKDB NjbGQgflJp94QFDaN0i021FmHIKK5CGN9eruSFiwW55XeAXu5vKeyR5StaarKCTnGboug4sOTqd 2b59TFiKDI8LMYZEYGQ== X-Proofpoint-ORIG-GUID: wRuCN_CWoeOTAAusqiPOxLfIFjkK8E3f X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-26_02,2026-01-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 phishscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601260066 Introduce functions for creating and inserting or removing the etr_buf_node to/from the etr_buf_list. The byte-cntr functionality requires two etr_buf to receive trace data. The active etr_buf collects the trace data from source device, while the byte-cntr reading function accesses the deactivated etr_buf after is has been filled and synced, transferring data to the userspace. Reviewed-by: Mike Leach Signed-off-by: Jie Gan --- drivers/hwtracing/coresight/coresight-tmc-core.c | 1 + drivers/hwtracing/coresight/coresight-tmc-etr.c | 94 ++++++++++++++++++++= ++++ drivers/hwtracing/coresight/coresight-tmc.h | 19 +++++ 3 files changed, 114 insertions(+) diff --git a/drivers/hwtracing/coresight/coresight-tmc-core.c b/drivers/hwt= racing/coresight/coresight-tmc-core.c index 36599c431be6..1ea255ffa67c 100644 --- a/drivers/hwtracing/coresight/coresight-tmc-core.c +++ b/drivers/hwtracing/coresight/coresight-tmc-core.c @@ -840,6 +840,7 @@ static int __tmc_probe(struct device *dev, struct resou= rce *res) idr_init(&drvdata->idr); mutex_init(&drvdata->idr_mutex); dev_list =3D &etr_devs; + INIT_LIST_HEAD(&drvdata->etr_buf_list); break; case TMC_CONFIG_TYPE_ETF: desc.groups =3D coresight_etf_groups; diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtr= acing/coresight/coresight-tmc-etr.c index e0d83ee01b77..cbbb15648fb7 100644 --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c @@ -1919,6 +1919,100 @@ const struct coresight_ops tmc_etr_cs_ops =3D { .panic_ops =3D &tmc_etr_sync_ops, }; =20 +/** + * tmc_clean_etr_buf_list - clean the etr_buf_list. + * @drvdata: driver data of the TMC device. + * + * Remove the allocated node from the list and free the extra buffer. + */ +void tmc_clean_etr_buf_list(struct tmc_drvdata *drvdata) +{ + struct etr_buf_node *nd, *next; + + list_for_each_entry_safe(nd, next, &drvdata->etr_buf_list, node) { + if (nd->sysfs_buf =3D=3D drvdata->sysfs_buf) { + if (coresight_get_mode(drvdata->csdev) =3D=3D CS_MODE_DISABLED) { + drvdata->sysfs_buf =3D NULL; + tmc_free_etr_buf(nd->sysfs_buf); + nd->sysfs_buf =3D NULL; + } + list_del(&nd->node); + kfree(nd); + } else { + /* Free allocated buffers which are not utilized by ETR */ + list_del(&nd->node); + tmc_free_etr_buf(nd->sysfs_buf); + nd->sysfs_buf =3D NULL; + kfree(nd); + } + } +} +EXPORT_SYMBOL_GPL(tmc_clean_etr_buf_list); + +/** + * tmc_create_etr_buf_list - create a list to manage the etr_buf_node. + * @drvdata: driver data of the TMC device. + * @num_nodes: number of nodes want to create with the list. + * + * Return 0 upon success and return the error number if fail. + */ +int tmc_create_etr_buf_list(struct tmc_drvdata *drvdata, int num_nodes) +{ + struct etr_buf_node *new_node; + struct etr_buf *sysfs_buf; + int i =3D 0, ret =3D 0; + + /* We dont need a list if there is only one node */ + if (num_nodes < 2) + return -EINVAL; + + /* We expect that sysfs_buf in drvdata has already been allocated. */ + if (drvdata->sysfs_buf) { + /* Directly insert the allocated sysfs_buf into the list first */ + new_node =3D kzalloc(sizeof(struct etr_buf_node), GFP_KERNEL); + if (IS_ERR(new_node)) + return PTR_ERR(new_node); + + new_node->sysfs_buf =3D drvdata->sysfs_buf; + new_node->is_free =3D false; + list_add(&new_node->node, &drvdata->etr_buf_list); + i++; + } + + while (i < num_nodes) { + new_node =3D kzalloc(sizeof(struct etr_buf_node), GFP_KERNEL); + if (IS_ERR(new_node)) { + ret =3D PTR_ERR(new_node); + break; + } + + sysfs_buf =3D tmc_alloc_etr_buf(drvdata, drvdata->size, 0, cpu_to_node(0= ), NULL); + if (IS_ERR(sysfs_buf)) { + kfree(new_node); + ret =3D PTR_ERR(sysfs_buf); + break; + } + + /* We dont have a available sysfs_buf in drvdata, setup one */ + if (!drvdata->sysfs_buf) { + drvdata->sysfs_buf =3D sysfs_buf; + new_node->is_free =3D false; + } else + new_node->is_free =3D true; + + new_node->sysfs_buf =3D sysfs_buf; + list_add(&new_node->node, &drvdata->etr_buf_list); + i++; + } + + /* Clean the list if there is an error */ + if (ret) + tmc_clean_etr_buf_list(drvdata); + + return ret; +} +EXPORT_SYMBOL_GPL(tmc_create_etr_buf_list); + int tmc_read_prepare_etr(struct tmc_drvdata *drvdata) { int ret =3D 0; diff --git a/drivers/hwtracing/coresight/coresight-tmc.h b/drivers/hwtracin= g/coresight/coresight-tmc.h index 95473d131032..9b3c4e6f0a5e 100644 --- a/drivers/hwtracing/coresight/coresight-tmc.h +++ b/drivers/hwtracing/coresight/coresight-tmc.h @@ -208,6 +208,19 @@ struct tmc_resrv_buf { s64 len; }; =20 +/** + * @sysfs_buf: Allocated sysfs_buf. + * @is_free: Indicates whether the buffer is free to choose. + * @pos: Position of the buffer. + * @node: Node in etr_buf_list. + */ +struct etr_buf_node { + struct etr_buf *sysfs_buf; + bool is_free; + loff_t pos; + struct list_head node; +}; + /** * struct tmc_drvdata - specifics associated to an TMC component * @atclk: optional clock for the core parts of the TMC. @@ -243,6 +256,8 @@ struct tmc_resrv_buf { * (after crash) by default. * @crash_mdata: Reserved memory for storing tmc crash metadata. * Used by ETR/ETF. + * @etr_buf_list: List that is used to manage allocated etr_buf. + * @reading_node: Available buffer_node for byte-cntr reading. */ struct tmc_drvdata { struct clk *atclk; @@ -273,6 +288,8 @@ struct tmc_drvdata { struct etr_buf *perf_buf; struct tmc_resrv_buf resrv_buf; struct tmc_resrv_buf crash_mdata; + struct list_head etr_buf_list; + struct etr_buf_node *reading_node; }; =20 struct etr_buf_operations { @@ -445,5 +462,7 @@ struct etr_buf *tmc_etr_get_buffer(struct coresight_dev= ice *csdev, enum cs_mode mode, struct coresight_path *path); extern const struct attribute_group coresight_etr_group; +void tmc_clean_etr_buf_list(struct tmc_drvdata *drvdata); +int tmc_create_etr_buf_list(struct tmc_drvdata *drvdata, int num_nodes); =20 #endif --=20 2.34.1