From nobody Sun Feb 8 02:26:43 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D30677081A for ; Sun, 25 Jan 2026 22:13:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769379206; cv=none; b=WUeEgPXNfPjXUtS95wKuINgL6cz+NLbxfSR/EAbKuEFKbvEL2TndFwZDFmZaVraJ1e/Z1E4r9eh+onPo8JWR/U0YY6Dne4o6caoWskJbx1quZ5dZg4BljOs/EKP4Iis51bsELsoT1UUvV68S7YJU7KqOW6zkbut4wYUP+bv2fok= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769379206; c=relaxed/simple; bh=u+k23Z2isiZkAg51kRMJSGnp7gUH0oYPti07l903XhA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=MY9eq2emwTLGtG00fAtGthrBs7sZWHY7klZpqicEWFk5qW6EZtbr2tUkyswukwGiwhSyqHY5Ge0SzewkkEWAQ7gvaBhbappe5WSEg+J5eWAhZkwe0j0abzGSufi/7ibjGxaf7cYSMZFubT4gt8CzlUga2UFNQHTg/1krmJDstTk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eS7WMfbd; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eS7WMfbd" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4801c1ad878so43125485e9.1 for ; Sun, 25 Jan 2026 14:13:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769379203; x=1769984003; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=IOtSDPAj9LHP/EGtr99y23OjP09FJ55hWknUkCivpC0=; b=eS7WMfbduXT6ET6kuyEV1P4ubdznpr8pxAOiGG9y/kY7VN8Y6SpFtPDmNgmdTk7aDM jA95O5NMcuR0kL8n5/m8lpqf/JTSR7aMErbNlBsrbT2iVocA+OQc4U2cu24sug2yNeWU XYC0qtE9Bl4/S0n7sGCrrd+kQ4bXJ/tEIZSUcq781e5TNpDUkXeLX0dD3FFwe74UCDw2 OY8EZEU0sBMjZMwgl2AvZHuX/UyAvhmrq5Ra2coBuWnuwZ9VoEbp4InIDpMZ8RfCpgTn JlCWCbBL/b7wZNCda4xTIehvJuAM731Q+lN+K4ZncNU6wX51RswHagXbVAK1vtMvdHPR W6PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769379203; x=1769984003; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IOtSDPAj9LHP/EGtr99y23OjP09FJ55hWknUkCivpC0=; b=u1jBRRzDOut6CzL9FzA4kdlfoIVtdOeg68XiU6rnTpLvjK4z/JfNBer1v4ccW2YWCl uNH+EriUKBPvYDfH3xAIFGqFCR3SdAOsbno7R51/kMZ5DqUhh5Q8o11vqME7PJRXxdjN OHPscOsdgPPRdtvS6qqPS5ZNic9dkWBLgVTS+gethJgl0bOASOqwd6izzsMiRXkiGfG8 jOjeXP3DK0pqATe3yEiRLWgTrPH52eNLRDHmOh9Q6bDAT0X8N4vskKhjf4Dvn3L99ung SIiy9nSxaznp58pD9GuUU3amKj07Nr9WzFdtOvPYtrBxlybF8foFIyKYZvh5OGi4aXdS ghVA== X-Forwarded-Encrypted: i=1; AJvYcCVBue0WPLlX3lr+myG0e9vOpeOmtUW+lRBMxvDB0rjewVJ7vXHAsvlel00HMR3E3pBGUUApWNgqifQXKbw=@vger.kernel.org X-Gm-Message-State: AOJu0YymGuSpOYcmS5TllbwZU8gR9kn2XUFVfTR4Z+1NrAo7kqXVAwQI AJ2Tg9vO5H+YDIBbouUuVupX46JgoqbNRS0YK5Sxe3P95qgyKwu0lZ3E X-Gm-Gg: AZuq6aK83VF7UEttnhkRiMjBsJzaef2ALRBfxtp19qCGwrQxIUalaL2fJwMTJmiUsKe PRySA40ysjxCpUMPspUby9RTNP0ru7gwRA7zvdNjeAmiMjpR6+ZZSu8TWYZNKywmb81sJoppgJi nk1Unz94+iYjGT/S2WuesXynpsTMKIpjVPAeQ0OJvzNE7sPLjFsmXfpLyOyFW8FR56bDbjsaKT8 oj13z3/sXQ5SQMAAFn6xqIjnsXxmemcvMSwl5NDWRBcUImTaqfCZc6N7TAbg0r5euC1SLyuNtnk iwOdjtXCss+iLgVpMgnVedPzjztNCj7axFW3hkz2rAt30j2eTnDa4+jeG7J/iwgf4jnd5Z6Z4j3 zl7jZ7JogtEAL9Dl8aXKxjL9dwgzDDH6pS7Y2viCqwGfDxdZ3EbpuJG62LunJbMlX8ghk1/7SXl unHPuL9fI= X-Received: by 2002:a05:600c:530e:b0:47a:935f:61a0 with SMTP id 5b1f17b1804b1-4805ccddb9bmr47802695e9.0.1769379203056; Sun, 25 Jan 2026 14:13:23 -0800 (PST) Received: from TTPP ([31.176.181.94]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4804d8a5b67sm229304495e9.10.2026.01.25.14.13.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Jan 2026 14:13:22 -0800 (PST) From: Omer El Idrissi To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Omer El Idrissi Subject: [PATCH] staging: rtl8723bs: replace magic -2 error codes with proper errno Date: Sun, 25 Jan 2026 23:12:18 +0100 Message-ID: <20260125221219.26151-1-omer.e.idrissi@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In xmit_xmitframes function: - Hardware busy condition previously returned -2; changed to -EBUSY - Transmit buffer allocation failure previously returned -2; changed to ENOBUFS The caller checks both errors and handles retry logic.This improves readability and conforms to kernel error-handling conventions. Signed-off-by: Omer El Idrissi --- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/stagi= ng/rtl8723bs/hal/rtl8723bs_xmit.c index abb6fdfe7e1f..d1a427b2ef7f 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c @@ -205,7 +205,7 @@ static s32 xmit_xmitframes(struct adapter *padapter, st= ruct xmit_priv *pxmitpriv (padapter->mlmepriv.LinkDetectInfo.bHigherBusyTxTraffic) ) { if ((phwxmit->accnt > 0) && (phwxmit->accnt < 5)) { - err =3D -2; + err =3D -EBUSY; // supposed to return -EBUSY for these conditions??? break; } } @@ -260,7 +260,7 @@ static s32 xmit_xmitframes(struct adapter *padapter, st= ruct xmit_priv *pxmitpriv "%s: xmit_buf is not enough!\n", __func__); #endif - err =3D -2; + err =3D -ENOBUFS; complete(&(pxmitpriv->xmit_comp)); break; } @@ -380,7 +380,7 @@ static s32 rtl8723bs_xmit_handler(struct adapter *padap= ter) /* dequeue frame and write to hardware */ =20 ret =3D xmit_xmitframes(padapter, pxmitpriv); - if (ret =3D=3D -2) { + if (ret =3D=3D -EBUSY || ret =3D=3D -ENOBUFS) { /* here sleep 1ms will cause big TP loss of TX */ /* from 50+ to 40+ */ if (padapter->registrypriv.wifi_spec) --=20 2.51.0