From nobody Mon Feb 9 01:46:15 2026 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0F8F30E0C0 for ; Sun, 25 Jan 2026 22:08:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769378905; cv=none; b=Bd8yPDEqAOL+seg3NbbIA/AZDitCJZaDXMVw2JyNzuBzakW0Scsz1rEkKvFtwpxas3Wk54nDn8SJA6KClySLSgfJDM9Br/UdnW5UgZcObJg0duJuxA4f71umt2lKI/A0tQm/FqITjjq3BdrN+CxvCE7k9O9PtI6RiNUELA2t8uo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769378905; c=relaxed/simple; bh=WR5uq6D5CL2+zYPX3ErQbINKVuF54ruQFnm911fVzGM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=b+wm8QLZSoVfD0pqQJnyU7IN529acR6d0R91l3eVf7Smxj2v3/aUHH0pH9k4pNBc3SybX6CBxIr9Wi7z/JUu0316LnlfGkkrTRd7eFNXkLMLxIHM6OQEf7PhM078wtOVumUxXTLbOM4plbm1bcBsW2f+FIEadfNhhJH/LJpo1fI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WYppz4s/; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WYppz4s/" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-352e2c59264so2778407a91.0 for ; Sun, 25 Jan 2026 14:08:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769378904; x=1769983704; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=g3EJ6TxN7ZDz04YTrVqZvmwk994KH4aI44usL/+rv9E=; b=WYppz4s/OEmLIljPruiSeSOS9n2nTRmwCCaRnLHjPfZlXgYrUBdZesbMFOZS0nQFrP 6ugnkOVCrIiyvR8cCRB/bR2Eql5aFhT/qQfPZTVOM15QtbboslPGr/kEe8oFU0ao/aV8 8g1rNmODb4FFNl6yEPbC7WSvfpErrWjO6jqfNrLfkkOuYgKA4ZmNj/Atyvtzwe4Bk7gN kwXa93l4Og0yNPBY32IXyBvWeAmUFXkseAcNySmy7LE1awGL6UsS2B4urHKMZBgdT8Qt y3tYe4S1QXWANvzQN71by1kg1/y529rRuklvhfiSN2jlj7ic4Xsh+I1YukGN5ZEcm2RB aAfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769378904; x=1769983704; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=g3EJ6TxN7ZDz04YTrVqZvmwk994KH4aI44usL/+rv9E=; b=b1n0Ck1VlHGZ4g7Y0RT9/oadCbi3VNaecDtIK5yuF1ynj9lgKKnkVjk5vykzHgSlgy P7N2mU1McFMFyDCgEhu+OMXWV9Fb3WfG/70vfyqpyAu/mp4gOnxz3T8YAzzcjnbhFHoq I/CIljvzTdco6b8I1r2gqAgojPhx4s33t9KGQmQtPHadzNmkd9rrtFyhh5Q1rjUcLhGG ieRjCfYNfWneUDSj4ZVa+AfBECdsfTRe+5NtDHzfhtWMfWlL4Lzjmd15VKWRm68wZyUs hHnFRneBt/EAKNkic1DKrBC6dgzDliLA/EhNDO1iZoSGJxUdhjAs4JVe7dv7J4X7kRlk nHMA== X-Forwarded-Encrypted: i=1; AJvYcCX+KM3JPz5jUGkk2t+IFYkI/QpwTcZDG7Ub3V5HrsFJFTHQ+RZVvQeaY1WKYfGcJvIgsxHOLQpVu2OUw8s=@vger.kernel.org X-Gm-Message-State: AOJu0YwcCQNnxHSWfbqBiMEzXofrr7FHjYqZMF6uf079lFs3fc3t5GHZ b2y0pvf7guWAgi5zKe7Wb0jpc8S/CunQv69Le++5YE1yO9TBUnI2lZV6 X-Gm-Gg: AZuq6aK0tEZurZr7fJcGXH9UgkMCR1guu0IRaCD/zxM6dnf6g9CgY2RIQSxgvg+y4RG 6q8tvrlwO5hbaUzoT1ni8prY+mNtgrwXXLu7FFcrHlYj0yA7pA/0wx0y93rsdZ45e32aY4klmpo huQW6lSQR/jEXJg0AfRu/wSga3r2C8OIs+xVR43Mi6EWPC/VIpLWe9P22sxHmQo+h6cBIBLOkvJ lLnNXugoHxNRbir73srnF5h0snc+DQTUywBUW8e/ZXAOiDv1TEHjakmMNwP4emSkX7EdXS48qG6 pqb44ewVqZdWddkvP0iP5IZjYY7LJNxjLyzo+xOGqNX4Su2Qwwsn0CYQG2AM7Jv2Io69goIwdfb ln1qm/PGy3KMZvX6IF4erhMAaq3L7Wbr2uLUslz3bRmOb4UUAcU1eHb0hvxvSb7D7NdDaZ1YlEZ yQnEafsQS5+Bcr48XjmJLxw1HaJP7CC1XxJTQG9orlIgO+eBXBsKvkCqq0jbtA X-Received: by 2002:a17:90b:45:b0:349:3fe8:e7df with SMTP id 98e67ed59e1d1-353c4167b7bmr2107663a91.22.1769378903982; Sun, 25 Jan 2026 14:08:23 -0800 (PST) Received: from d.home.mmyangfl.tk ([45.32.227.231]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8231873e60fsm7651286b3a.48.2026.01.25.14.08.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Jan 2026 14:08:23 -0800 (PST) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , Lorenzo Bianconi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 1/2] u64_stats: Allow u64_stats_add() to accept s64 Date: Mon, 26 Jan 2026 06:07:49 +0800 Message-ID: <20260125220753.3984326-2-mmyangfl@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260125220753.3984326-1-mmyangfl@gmail.com> References: <20260125220753.3984326-1-mmyangfl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The current u64_stats_add() accepts only unsigned long, which makes no sense as u64_stats_set() accepts u64 already, and causes unnecessary narrowing on 32-bit architectures. Moreover, since there's no u64_stats_sub(), users may be tempted to reuse it for decrements, which already happened on nft_counter_reset() in net/netfilter/nft_counter.c . Change to s64 to allow both positive and negative values. Signed-off-by: David Yang --- include/linux/u64_stats_sync.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/u64_stats_sync.h b/include/linux/u64_stats_sync.h index 457879938fc1..e77f2b30bac7 100644 --- a/include/linux/u64_stats_sync.h +++ b/include/linux/u64_stats_sync.h @@ -84,7 +84,7 @@ static inline void u64_stats_set(u64_stats_t *p, u64 val) local64_set(&p->v, val); } =20 -static inline void u64_stats_add(u64_stats_t *p, unsigned long val) +static inline void u64_stats_add(u64_stats_t *p, s64 val) { local64_add(val, &p->v); } @@ -125,7 +125,7 @@ static inline void u64_stats_set(u64_stats_t *p, u64 va= l) p->v =3D val; } =20 -static inline void u64_stats_add(u64_stats_t *p, unsigned long val) +static inline void u64_stats_add(u64_stats_t *p, s64 val) { p->v +=3D val; } --=20 2.51.0