From nobody Mon Feb 9 08:50:40 2026 Received: from cstnet.cn (smtp21.cstnet.cn [159.226.251.21]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FD4822D4DD for ; Sun, 25 Jan 2026 16:24:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769358254; cv=none; b=ZY1G//1fHNdyFKTf+LFNGySLhegMvblXrupjJmR9tSNbC5CSrCQ3LAX1aBRE2f7exAcXPj42rnyY+HkIFmk3hbsIdkQHChLA3YvRJ54Ko3bhRTB5bMvW97pYSQYcxKHIWEOIG6QsKdDEBnnC1RwetT33jkhUmOwC00pCwH0MJj0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769358254; c=relaxed/simple; bh=KMgPZoY1+lvBsZ2D/G/Si9frKmMwXonwUd7c+CFY4ls=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Wm+NTrwvbZ5Hhz++2QAhNsJmcpq/+SGpemETLFAD8AiYk075InR2OBm5ytxLDlKBy7ZWZnjtXGJBhVrojEEIFw4ynixyAKXApvWTcy5aTWU8aDp3ZkG/i5UJ9xLfLNFry2Z/kEBgU+2UnpBr8RRINfSgWNvvf6fp3HGMA3pb2TI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=isrc.iscas.ac.cn; spf=pass smtp.mailfrom=isrc.iscas.ac.cn; arc=none smtp.client-ip=159.226.251.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=isrc.iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=isrc.iscas.ac.cn Received: from localhost.localdomain (unknown [36.112.3.223]) by APP-01 (Coremail) with SMTP id qwCowACH826eQ3Zp6JcxBg--.20553S2; Mon, 26 Jan 2026 00:23:58 +0800 (CST) From: Haoxiang Li To: zack.rusin@broadcom.com, bcm-kernel-feedback-list@broadcom.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Haoxiang Li Subject: [PATCH] drm/vmwgfx: fix a potential memory leak in vmw_ttm_bind() Date: Mon, 26 Jan 2026 00:23:57 +0800 Message-Id: <20260125162357.2164209-1-lihaoxiang@isrc.iscas.ac.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: qwCowACH826eQ3Zp6JcxBg--.20553S2 X-Coremail-Antispam: 1UD129KBjvdXoWrur4DAr1fAF4DtFW3GF17ZFb_yoWftrg_ur WUZrnrtayDKFn5Z3ZF9343A3429a93Zan7ur1Sya4UJ3Zrtas8KrWUWrn8X3WfWF1jkrs8 Wr48KF4xArnxujkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb3xFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_ Cr1l84ACjcxK6I8E87Iv67AKxVWUJVW8JwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gr0_Gr 1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xII jxv20xvE14v26r106r15McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr 1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7M4IIrI8v6xkF7I0E8cxa n2IY04v7MxkF7I0En4kS14v26r1q6r43MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4 AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE 17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMI IF0xvE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4l IxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvf C2KfnxnUUI43ZEXa7VU13ku3UUUUU== X-CM-SenderInfo: 5olkt0x0ld0ww6lv2u4olvutnvoduhdfq/1tbiBwsSE2l2MU8TpQAAsa Content-Type: text/plain; charset="utf-8" In vmw_ttm_bind(), if vmw_mob_create() fails, call vmw_ttm_unmap_dma() to release the memory allocated by vmw_ttm_map_dma(). Signed-off-by: Haoxiang Li --- drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c b/drivers/gpu/drm/v= mwgfx/vmwgfx_ttm_buffer.c index 5553892d7c3e..6f6a73a7c857 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c @@ -299,8 +299,10 @@ static int vmw_ttm_bind(struct ttm_device *bdev, if (unlikely(vmw_be->mob =3D=3D NULL)) { vmw_be->mob =3D vmw_mob_create(ttm->num_pages); - if (unlikely(vmw_be->mob =3D=3D NULL)) + if (unlikely(vmw_be->mob =3D=3D NULL)) { + vmw_ttm_unmap_dma(vmw_be); return -ENOMEM; + } } =20 ret =3D vmw_mob_bind(vmw_be->dev_priv, vmw_be->mob, --=20 2.25.1