From nobody Sat Feb 7 05:30:00 2026 Received: from cstnet.cn (smtp21.cstnet.cn [159.226.251.21]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEA963EBF21; Sun, 25 Jan 2026 12:23:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769343830; cv=none; b=Lf586zXMnicuLgkTbVEeYbxdKPljmp4UcMRrDy1mww9qRWZU6ML3nbiVTSDJ6JTDMPO8kstCaY45BWipryJIcFuZHsQrS9xx2iAqJy4u8B4Xd6R0VhYeatfhjzJ5q2/spa/DmZnu6vcl+q+Ur1NwSOLBvHGRVxWAm5kiyaUSPuc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769343830; c=relaxed/simple; bh=A7ZNenREdKva72mcfILf0vXj6lo8W9TsdkB+zsI1spg=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=nhNOgtaOMgMGBajjgna10Enu0SUnCWyyu+K9RUI351abI1UA6L1Os95IzCT9N2BLxCzl8VRh1RalRIpi8Vzb1t5lNB9Y2R3Ow7z1HgqVq24AzTNd/n2qDLxMdYt1iygkwySV1zVL/tSyWJ1ptjsO1A7fcaSeTS8aw3CS/MMJI44= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=isrc.iscas.ac.cn; spf=pass smtp.mailfrom=isrc.iscas.ac.cn; arc=none smtp.client-ip=159.226.251.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=isrc.iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=isrc.iscas.ac.cn Received: from localhost.localdomain (unknown [36.112.3.223]) by APP-01 (Coremail) with SMTP id qwCowABnEW1NC3ZpK0orBg--.10392S2; Sun, 25 Jan 2026 20:23:41 +0800 (CST) From: Haoxiang Li To: airlied@redhat.com, chris@chris-wilson.co.uk, simona.vetter@ffwll.ch Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Haoxiang Li , stable@vger.kernel.org Subject: [PATCH] intel-gtt: fix an error handle in i810_setup() Date: Sun, 25 Jan 2026 20:23:39 +0800 Message-Id: <20260125122339.2008087-1-lihaoxiang@isrc.iscas.ac.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: qwCowABnEW1NC3ZpK0orBg--.10392S2 X-Coremail-Antispam: 1UD129KBjvdXoW7Xw1ruw4xuF48Cry7Xr13Jwb_yoWkJFc_WF yFg34kG3yFkF1rCr1UAr17ZFy2kw1FqrZaqF17Kryaya4SqFs3KFy5urn3u3WkXrs8ur9F qa47Xr1Fyry2kjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb48FF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_ Cr1l84ACjcxK6I8E87Iv67AKxVWUJVW8JwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gr0_Gr 1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xII jxv20xvE14v26r106r15McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr 1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxkF7I0En4kS14v26r12 6r1DMxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI 0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y 0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxV W8JVWxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1l IxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7VU18sqtUUUU U== X-CM-SenderInfo: 5olkt0x0ld0ww6lv2u4olvutnvoduhdfq/1tbiBwkSE2l1q+x0JgAAsG Content-Type: text/plain; charset="utf-8" In i810_setup(), if ioremap() fails, the memory allocated by alloc_gatt_pages() should be freed. Add free_gatt_pages() to do so. Fixes: 820647b97a9c ("intel-gtt: switch i81x to the common initialization h= elpers") Cc: stable@vger.kernel.org Signed-off-by: Haoxiang Li --- drivers/char/agp/intel-gtt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/char/agp/intel-gtt.c b/drivers/char/agp/intel-gtt.c index bcc26785175d..dfb6282ce401 100644 --- a/drivers/char/agp/intel-gtt.c +++ b/drivers/char/agp/intel-gtt.c @@ -186,8 +186,10 @@ static int i810_setup(void) reg_addr =3D pci_resource_start(intel_private.pcidev, I810_MMADR_BAR); =20 intel_private.registers =3D ioremap(reg_addr, KB(64)); - if (!intel_private.registers) + if (!intel_private.registers) { + free_gatt_pages(intel_private.i81x_gtt_table, I810_GTT_ORDER); return -ENOMEM; + } =20 writel(virt_to_phys(gtt_table) | I810_PGETBL_ENABLED, intel_private.registers+I810_PGETBL_CTL); --=20 2.25.1