From nobody Mon Feb 9 16:27:57 2026 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F18B14207A for ; Sun, 25 Jan 2026 08:52:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769331127; cv=none; b=OW8o0rgDTqWQacqeA/cER1/Z8zhOrFUuHTCQpoLfG6+YccDur+kmoncC8GAjDGE1lLQ5INwjOfzgQTFVHs+Ism+nIz31rSZuyfZmCD36yQ93S9WsxtTnh5CTObQAFqDmbrl2wwZVo8dIeh10gP013SlRofiFemLjir6b1V6lhlA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769331127; c=relaxed/simple; bh=7GIpaZcPG0qpaUGgCkh2hKi4S2JRE+KitID/fdVMKPk=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=IZmVqnEbL9GPiTUHJ7bqt6FwjkPcd6/8L3j9BFmVzd6Z8f95sitDPUUOvBmbijIdYuwmyVKe9ovcoqupe0ThjpeplwnMz7p9GWm0LSZbrMVO5ZMmQaI7TqUL9V+3JxqT7+jSAalG2ceJ7SGTyGYewSNlDkY7yatTZnoKF9tvHR0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Q6Lxv7+7; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q6Lxv7+7" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-81f4c0e2b42so1790336b3a.1 for ; Sun, 25 Jan 2026 00:52:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769331125; x=1769935925; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=iT5OFvQeF8zMVf/PxrofZtaIbAS6SSbifWcBi3L0Yu0=; b=Q6Lxv7+7hfziCoiGwRhPiBLnRO4D24jmkTkQR2+PPOIOaxyWOD8UOucH6ERbhMzTM7 mb4GDfSHXULp1lqS3lA+Cksi+1pdc462c+zGxF1mSEJoo5fLDJjV4jINQVf34/HUYiww perjxQPMtmCexFuGHgo6eAoa6WwsrGHFl6oOt2ka6rBUoF+reibKo0Ir3R3EVEg+fg4P CfaGzKHlwPGfPdgNe9oWqR510g75OIF17IjNUSTM+RZ9zi1T+sxtctvuRZtSEBs/IzYH j5/tBKu6z5b1F3/nMZh66xfTTOe/gTBiqo+aYho5gir9jEkepuBtRWDjU9dlMrbNt0Da t0Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769331125; x=1769935925; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iT5OFvQeF8zMVf/PxrofZtaIbAS6SSbifWcBi3L0Yu0=; b=KrPVxewoQUGYmPPuMAtGuQsyq3+DQcGENaJ5tdw65zOvRtnv6c+axCq1pisFsoPeG7 HvfzGcV926dbeRHYMXuf9RNrr1w57ETHi/ZAWJ9dqiKWREbszsHWKVWj0Ioy1sN1tG64 lvQxqoTk3dOjqkQN+sUHcMd4Ma+eE88dfwjLjzsJ0fPaN/y1WKxoc2y9R3WssXKrIlXf oCtJgDSNVdN8xjtjLHuVFVwnohqzw2HsCMUCEY9FAewqduVQtW0KR5IMC69Zf69+0dBd pBHKuiGGLYXmUFTDvqKghbyTrgoEMVNSCjS4k/XXqDXsA/jL+WDCvFgQ1DR+Wm3X1Ul5 2uMw== X-Gm-Message-State: AOJu0YxB5Sn1WR29az/GYA9b5qFaPK+GDZ0Qa6JWlRue630xuGtE+2VE st3K3tAoh2hg33nLgYDZ6PT82s8TKqQ2guKdtN5wbJ6tYQz7vw9VhO5bGYTSx54gIuQ= X-Gm-Gg: AZuq6aICN78mWICCTfxmvEISm2XQVF+7fccGE4MYepKhntFt9kAKCW4glnpwrNIspaz pWYD8vrytoIi5HwXgeLAUNqhmQPW7kv9xM4hxJ3JfvGZqNOLZj5+4bd59B0M0RA8A7yYWoCWBLI fPoVmX5/b2gK3pKWAo+gtLO2mSKHqYoZKzch7Dlc/wmHzQ5n+BrETqDQWwPQ9An1szb0ld1nU/8 lCNYyO/X/vJafSkOR+QAd4O0OVZcD6/ZUjOpMRJwUkcbLs8SU2Jm/7b+FAZyQ8praRRTHLpgXHR Ns+Azk8mtQLYKEEDs7vqWyJL9Vy95KCnk6UpQnUPL15rxs7jn5n/LFkSMu+8qXJ12i12N/irWYF Yji8IfgE+z3aitphQJBCAXrhJTfGOx6UVBEyBOCuMTMiHqth9LEocWS0Unm7jc7QiluzsbVu8pO ojQzXsJflbvLBhpPTpEFoAjutgYxO0cySoF23EUHNFXubuFFJz0JQ= X-Received: by 2002:a05:6a00:3d48:b0:81f:44bb:8aa with SMTP id d2e1a72fcca58-823411dba60mr877844b3a.8.1769331125018; Sun, 25 Jan 2026 00:52:05 -0800 (PST) Received: from fric.. ([210.73.43.101]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8231876e5d0sm6442072b3a.61.2026.01.25.00.52.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Jan 2026 00:52:04 -0800 (PST) From: Jiakai Xu X-Google-Original-From: Jiakai Xu To: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, kvm-riscv@lists.infradead.org, kvm@vger.kernel.org Cc: Alexandre Ghiti , Albert Ou , Palmer Dabbelt , Paul Walmsley , Atish Patra , Anup Patel , Jiakai Xu Subject: [PATCH v2] RISC-V: KVM: Fix null pointer dereference in kvm_riscv_aia_imsic_has_attr Date: Sun, 25 Jan 2026 08:51:57 +0000 Message-Id: <20260125085157.2462296-1-xujiakai2025@iscas.ac.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a null pointer check for imsic_state before dereferencing it in kvm_riscv_aia_imsic_has_attr(). While the function checks that the vcpu exists, it doesn't verify that the vcpu's imsic_state has been initialized, leading to a null pointer dereference when accessed. This issue was discovered during fuzzing of RISC-V KVM code. The crash occurs when userspace calls KVM_HAS_DEVICE_ATTR ioctl on an AIA IMSIC device before the IMSIC state has been fully initialized for a vcpu. The crash manifests as: Unable to handle kernel paging request at virtual address dfffffff00000001 ... epc : kvm_riscv_aia_imsic_has_attr+0x464/0x50e arch/riscv/kvm/aia_imsic.c:998 ... kvm_riscv_aia_imsic_has_attr+0x464/0x50e arch/riscv/kvm/aia_imsic.c:998 aia_has_attr+0x128/0x2bc arch/riscv/kvm/aia_device.c:471 kvm_device_ioctl_attr virt/kvm/kvm_main.c:4722 [inline] kvm_device_ioctl+0x296/0x374 virt/kvm/kvm_main.c:4739 ... The fix adds a check to return -ENODEV if imsic_state is NULL, which is consistent with other error handling in the function and prevents the null pointer dereference. v2: add Fixes tag and drop external link as suggested. Fixes: 5463091a51cf ("RISC-V: KVM: Expose IMSIC registers as attributes of = AIA irqchip") Signed-off-by: Jiakai Xu --- arch/riscv/kvm/aia_imsic.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/riscv/kvm/aia_imsic.c b/arch/riscv/kvm/aia_imsic.c index e597e86491c3b..9c58a66068447 100644 --- a/arch/riscv/kvm/aia_imsic.c +++ b/arch/riscv/kvm/aia_imsic.c @@ -995,6 +995,9 @@ int kvm_riscv_aia_imsic_has_attr(struct kvm *kvm, unsig= ned long type) =20 isel =3D KVM_DEV_RISCV_AIA_IMSIC_GET_ISEL(type); imsic =3D vcpu->arch.aia_context.imsic_state; + if (!imsic) + return -ENODEV; + return imsic_mrif_isel_check(imsic->nr_eix, isel); } =20 --=20 2.34.1