From nobody Mon Feb 9 23:14:58 2026 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 269791632C8 for ; Sun, 25 Jan 2026 00:23:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769300600; cv=none; b=r4G+zd9WlUaWlCe+Wvihgjz1UC2N8tJRz36qN7s8HN+8xlSQZbKpzEJMrpug/iLP5H1T4CQ4uiqOV9+PXHtz6Idb0KYFsX25dfpF5FC0bPI76tnug/exF0gtHAFKT7PvwCYi4lm0gjtpYqcMVvZBwVkBG5VtpumXUcMeZHdIPi0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769300600; c=relaxed/simple; bh=Dkt7XUKoNz8No9f4w1DysgLslYRIpWby92iVG0WPp94=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kr4wrBMUoMqwQbPEohSS2+I2Y/Kcerj3jBoJDY9zZo6uk9FwhdGXuuLhZym/ZfmbF6mZZJeNcaxr9GseRH6DHKDtyo5SDAeTpcdPF7Nz3BWkD3lNu5nF1gMajaAbHEX+Qwuq2VD/dlmJVtRT2CLnzo7m3AY6kJD8AmsBQpfci3g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=n2xnIsLv; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="n2xnIsLv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1769300592; bh=Dkt7XUKoNz8No9f4w1DysgLslYRIpWby92iVG0WPp94=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=n2xnIsLvoAXpHGT1vyM/+GloI6ddHidFoauO6ef8vRAkL6h+OPdCZ0mQOJwraB5Jf QAg5JKOQLvDPtlJG6/lpCRufCrBT4G9y/Z40KyK/akll9Bz+5dAV2fLP9s4txlfl0O qRyksU8vpPuSmtZUlR5/c7Ze6sdD9wfvoIKdw6Njsk7SulGzSdgSZCEzfwBZ9hJ2Kz 6mGxLFDnh2HXaZnXaoFabxOUbiq36fp9xCXfUJhvrwu/iuSDGAYxXTOoxBW63EHwy3 UGShZSSBYLS129EIVnt83E+BLjAqtzdWbBXR5BsEc1kVNP9/CBDCzvnTdrhy+nogXr R16wlowXewLpg== Received: from localhost (unknown [82.79.138.145]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id 0B8F117E1427; Sun, 25 Jan 2026 01:23:12 +0100 (CET) From: Cristian Ciocaltea Date: Sun, 25 Jan 2026 02:23:01 +0200 Subject: [PATCH 3/5] drm/bridge: dw-hdmi-qp: Rework AVI InfoFrame handler Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260125-dw-hdmi-qp-iframe-v1-3-e0f7649ecc4b@collabora.com> References: <20260125-dw-hdmi-qp-iframe-v1-0-e0f7649ecc4b@collabora.com> In-Reply-To: <20260125-dw-hdmi-qp-iframe-v1-0-e0f7649ecc4b@collabora.com> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 Make use of the recently introduced dw_hdmi_qp_write_pkt() helper to simplify the writing of the Auxiliary Video InfoFrame (AVI) packet header and body registers. Moreover, since now having dedicated callbacks per InfoFrame type, move the implementation to dw_hdmi_qp_bridge_write_avi_infoframe() and drop dw_hdmi_qp_config_avi_infoframe(). While at it, also discard the superfluous infoframe size verification. Signed-off-by: Cristian Ciocaltea --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 52 ++++++++----------------= ---- 1 file changed, 14 insertions(+), 38 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c b/drivers/gpu/drm= /bridge/synopsys/dw-hdmi-qp.c index 429736486d85..ff856f8bd53b 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c @@ -748,43 +748,6 @@ static struct i2c_adapter *dw_hdmi_qp_i2c_adapter(stru= ct dw_hdmi_qp *hdmi) return adap; } =20 -static int dw_hdmi_qp_config_avi_infoframe(struct dw_hdmi_qp *hdmi, - const u8 *buffer, size_t len) -{ - u32 val, i, j; - - if (len !=3D HDMI_INFOFRAME_SIZE(AVI)) { - dev_err(hdmi->dev, "failed to configure avi infoframe\n"); - return -EINVAL; - } - - /* - * DW HDMI QP IP uses a different byte format from standard AVI info - * frames, though generally the bits are in the correct bytes. - */ - val =3D buffer[1] << 8 | buffer[2] << 16; - dw_hdmi_qp_write(hdmi, val, PKT_AVI_CONTENTS0); - - for (i =3D 0; i < 4; i++) { - for (j =3D 0; j < 4; j++) { - if (i * 4 + j >=3D 14) - break; - if (!j) - val =3D buffer[i * 4 + j + 3]; - val |=3D buffer[i * 4 + j + 3] << (8 * j); - } - - dw_hdmi_qp_write(hdmi, val, PKT_AVI_CONTENTS1 + i * 4); - } - - dw_hdmi_qp_mod(hdmi, 0, PKTSCHED_AVI_FIELDRATE, PKTSCHED_PKT_CONFIG1); - - dw_hdmi_qp_mod(hdmi, PKTSCHED_AVI_TX_EN | PKTSCHED_GCP_TX_EN, - PKTSCHED_AVI_TX_EN | PKTSCHED_GCP_TX_EN, PKTSCHED_PKT_EN); - - return 0; -} - static int dw_hdmi_qp_config_drm_infoframe(struct dw_hdmi_qp *hdmi, const u8 *buffer, size_t len) { @@ -1024,10 +987,23 @@ static int dw_hdmi_qp_bridge_write_avi_infoframe(str= uct drm_bridge *bridge, const u8 *buffer, size_t len) { struct dw_hdmi_qp *hdmi =3D bridge->driver_private; + size_t i; =20 dw_hdmi_qp_bridge_clear_avi_infoframe(bridge); =20 - return dw_hdmi_qp_config_avi_infoframe(hdmi, buffer, len); + /* AVI packet header */ + dw_hdmi_qp_write_pkt(hdmi, buffer, 1, 2, PKT_AVI_CONTENTS0); + + /* AVI packet body */ + for (i =3D 0; i < len - 3; i +=3D 4) + dw_hdmi_qp_write_pkt(hdmi, buffer + 3, i, min(len - i - 3, 4), + PKT_AVI_CONTENTS1 + i); + + dw_hdmi_qp_mod(hdmi, 0, PKTSCHED_AVI_FIELDRATE, PKTSCHED_PKT_CONFIG1); + dw_hdmi_qp_mod(hdmi, PKTSCHED_AVI_TX_EN | PKTSCHED_GCP_TX_EN, + PKTSCHED_AVI_TX_EN | PKTSCHED_GCP_TX_EN, PKTSCHED_PKT_EN); + + return 0; } =20 static int dw_hdmi_qp_bridge_write_hdmi_infoframe(struct drm_bridge *bridg= e, --=20 2.52.0