From nobody Sat Feb 7 16:04:43 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4520923D7DE for ; Sat, 24 Jan 2026 16:47:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769273224; cv=none; b=ak7Dw5WYpjqyC8tYhAdLYbK8DsdXNHMiMKEJ+DoR7ccz7YLAsibtB2y/Kfj0jqe0w7frFlVPyqcRQVWNR+4s/o91L8g3TB1ukok41CNw7rEGlftSmo1++cSZLJn4Y3fjLChU5ViCw4hH0c4SiOE9JGau5qQYlrjfGEmsX4iaqe8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769273224; c=relaxed/simple; bh=hThp9jWUk6Tk7E1nVmBKT0kjFbhl4aOu0CxfuCZ50A4=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=Cm6TlqhEt+BihI3F9aQpEtnC8oEC9EaYUaksrjDnBNqIREF85vG+H/pvFSEfNWtYch+0rbsE7jpsUdh7CQFU8Z2uOGvn6B+DhdX/pxmBMzF5N621j3UwFUD5bwMzU0knb8m7feVnNT+Ik/t6dnJmc0yRh2InPw3HkxC59b7fDgc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=s0ssxfap; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="s0ssxfap" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03F20C19425; Sat, 24 Jan 2026 16:47:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769273224; bh=hThp9jWUk6Tk7E1nVmBKT0kjFbhl4aOu0CxfuCZ50A4=; h=Date:From:To:Cc:Subject:References:From; b=s0ssxfaphbKgGWg+MdJ+lLyIztoSNhWXoFw9up6KJOmWgztqDq/ucuR6RK7tkai93 k92gWTGOi1PMuC6dvSmagnKb53QwU4z2lFb7gu1shm0oUI9SJb6TFLACFxXuL94xAF Vre6rj/w70qntkkMdOm856su6xexjbcApbdSrwfN15QDqS02wItnPkkU6WmuVUS28f fp1ABQ8rDedN9y1iA59ToLU0rRhqi4POCHLDlQk41su6VuBRytdyJ2zeFnAKU6rr7l kqeksjNEU23/whr5ji1DgfBVLyMH0dqn1tKptvcyGly52VlkNGQc3bBrt79wsw8CGq 3S6glEcjJA+lg== Received: from rostedt by gandalf with local (Exim 4.99.1) (envelope-from ) id 1vjgnO-00000003CnN-44x3; Sat, 24 Jan 2026 11:47:34 -0500 Message-ID: <20260124164734.844806094@kernel.org> User-Agent: quilt/0.68 Date: Sat, 24 Jan 2026 11:29:45 -0500 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Ian Rogers Subject: [for-linus][PATCH 2/4] tracing: Avoid possible signed 64-bit truncation References: <20260124162943.928691049@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Ian Rogers 64-bit truncation to 32-bit can result in the sign of the truncated value changing. The cmp_mod_entry is used in bsearch and so the truncation could result in an invalid search order. This would only happen were the addresses more than 2GB apart and so unlikely, but let's fix the potentially broken compare anyway. Cc: Mathieu Desnoyers Link: https://patch.msgid.link/20260108002625.333331-1-irogers@google.com Signed-off-by: Ian Rogers Acked-by: Masami Hiramatsu (Google) Signed-off-by: Steven Rostedt (Google) --- kernel/trace/trace.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index baec63134ab6..8bd4ec08fb36 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -6115,10 +6115,10 @@ static int cmp_mod_entry(const void *key, const voi= d *pivot) unsigned long addr =3D (unsigned long)key; const struct trace_mod_entry *ent =3D pivot; =20 - if (addr >=3D ent[0].mod_addr && addr < ent[1].mod_addr) - return 0; - else - return addr - ent->mod_addr; + if (addr < ent[0].mod_addr) + return -1; + + return addr >=3D ent[1].mod_addr; } =20 /** --=20 2.51.0