From nobody Sat Feb 7 15:11:42 2026 Received: from mail-dy1-f177.google.com (mail-dy1-f177.google.com [74.125.82.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F22FDEED8 for ; Sat, 24 Jan 2026 01:49:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769219361; cv=none; b=bcL/GEdt0umsHXLMhAp1rFGcu+y9J8Bo/vemTJn5WFbsmr5ni6zlnTxw9dnIvecaDS/BAc6IcKTyCitvRjAEY7AaPOk8B91Rn+XbhQWqUHYLMewBDRiovKXQ7JswrDOBETKz04kkALFTY2PSfL+ss0ILqACJq9uBDctGOmwfFMI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769219361; c=relaxed/simple; bh=Wali2wUCu0Y7HgALDpORP+ztHcLB1gdHLlhLhjF4bkE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rmEA4uHvZuitkdWsBWjRtKiX4Eh+JbRt7ArFlfJqNuo+h7VRUoeRpLt6KmQOaB5Mei0w73oCth+qBPbdANtWUbJgJWQXeDfmrf1xyvXDYSYh5gLo+CBImsWU7XvdiSnlipq/BXsxhRhLVlgf6TbMR3pBJdzOUDYZhl9PKqxm7Y8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Bz+/RZxv; arc=none smtp.client-ip=74.125.82.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Bz+/RZxv" Received: by mail-dy1-f177.google.com with SMTP id 5a478bee46e88-2b6b0500e06so3716129eec.1 for ; Fri, 23 Jan 2026 17:49:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769219358; x=1769824158; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fB+UXdbJZv/kqKsMjEjhslIic6Ng4MiMJztJEz9HC5M=; b=Bz+/RZxvHzLDCZ2By3WcP0Q6LdzpXS6msIMiCAv26g39f361OTWyKjMaiILuFPPTqe x2x9JAUXof6FBSvzwrQ3bPB6aze97HgG2iwKcyyYKmhpFNlk2WAy7YJf/qtfaJGlLEUC KGh3qJpDVCvAM4slsSvZuBJ3kz53cscGAkxzjshaf+VHApN8OwQRXhZpfTaJeEavdfpF yJWUzgiWabImQFbb6fwZtFMqNILvGMzH5Kil3dOkF/OAkyvso5OYpLd0FRnm2UNX6ROK zcZyD4d3RUyJ2dvjnr+mrf/tv7+KPLLPl+k15mtgNVPEiWlgj8GN7+KWjKEavCjrIcyB e6pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769219358; x=1769824158; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fB+UXdbJZv/kqKsMjEjhslIic6Ng4MiMJztJEz9HC5M=; b=q5l7Xc/aQSmnnKitoo587GOxLAhXwdnQQb8EKxvRSdTp27vm87yOLsozev8uPnJul9 oW7FylqqChVdzRsaJkYmOeFdouc+VF3yXhrPv1O7Z8e8SLSg2Q8T6n6pRKErpi0san1W GaAdJQGj0mCUJa1XaAsxrcdHF1k/OLY2dR6zfnQ6uVFVFTwPvxtqirMYcUHSkZ1jQsd4 eFxyQiqzdT+zOtbzPIVyYVGwRlSuHAwp2OD5qbyn8wqFxBzb6vG9QoRcx0Xh4b+mzabZ nFkSidjYqJotL7980FZOwJii+Xsx3zttbmEaglUNK0XhMbsw0Hav/nezacSSjCvQn44T V9og== X-Forwarded-Encrypted: i=1; AJvYcCXPezKuBTz/1NDKWHIQnGC4yU8Mnx9SmvYHEVWZ4JITJ/ynMnM2Y/bugxTMp1D76jZZKL1+X7S88Oh4IOo=@vger.kernel.org X-Gm-Message-State: AOJu0YylzitOQgF2xIF2cnR8p1xu1pqk/W6L8toOQE0PLC0shBy706ob cjoRqeoqjra+EThIn5N+NbdfkxsjtzgO34M/dKS8w1KQDUBHb5YEF6rh X-Gm-Gg: AZuq6aKFycxEscnd/uHwDDdTpbF38xfgJMmvO67R3euPSapMsmIylRHVZ1xTiqRGI// rZaNE6H8d7c0Sxj30uuSbA9CiQbripTG6AB2FFbiHB7CnO61ZfID68R+jv+kS4/1+apcGXOI3Up rZGOyePAPZnAWnLnQO8Gz5/AKF9V9S8LVF5FEzrbY+njQ6F4XdaGNujoSlPSk9QOw36vIlcaNgQ 2TBwoBgQypy/4c9BVCfEVlSDWq7gCpue5cx7Ank6+cfkyKSjrScYUkyP9b5GlR6TuppX5x3bStY pOWRAyUE6N1ssDciN8Yt2k1CiMIXgTH4vy82qoCON/zAj0Yxd/TE3zr0nY/1XFXi0Ijz1GGoIcg /QKkBLMnvFMnGeFaoUTGOrXrjkx2HdyIjl1Mr5BeqIveeqUCei7JlUI4GaiB3nV3IG5zkb7OnNj VJIidiIuA+NBpTn2B3zEPvKcWhPfX/pZ05sU81RxAvJz7gxZ4emmsf2n4H+wit3kM= X-Received: by 2002:a05:7301:4e0b:b0:2b7:1253:3d4f with SMTP id 5a478bee46e88-2b739957211mr2193612eec.8.1769219357800; Fri, 23 Jan 2026 17:49:17 -0800 (PST) Received: from lappy (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b73aa22707sm5160014eec.29.2026.01.23.17.49.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jan 2026 17:49:17 -0800 (PST) From: "Derek J. Clark" To: Jiri Kosina , Benjamin Tissoires Cc: Mario Limonciello , Zhixin Zhang , Mia Shao , Mark Pearson , "Pierre-Loup A . Griffais" , "Derek J . Clark" , linux-input@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 07/16] HID: hid-lenovo-go: Add Calibration Settings Date: Sat, 24 Jan 2026 01:48:58 +0000 Message-ID: <20260124014907.991265-8-derekjohn.clark@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260124014907.991265-1-derekjohn.clark@gmail.com> References: <20260124014907.991265-1-derekjohn.clark@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Adds calibration enable and last calibration status indicators for the triggers, joysticks, and handle gyros. Signed-off-by: Derek J. Clark --- drivers/hid/hid-lenovo-go.c | 284 +++++++++++++++++++++++++++++++++++- 1 file changed, 283 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-lenovo-go.c b/drivers/hid/hid-lenovo-go.c index 91eb61037a2c..6326a559fa73 100644 --- a/drivers/hid/hid-lenovo-go.c +++ b/drivers/hid/hid-lenovo-go.c @@ -43,8 +43,11 @@ struct hid_go_cfg { struct mutex cfg_mutex; /*ensure single synchronous output report*/ u8 fps_mode; u8 gp_left_auto_sleep_time; + u8 gp_left_gyro_cal_status; + u8 gp_left_joy_cal_status; u8 gp_left_notify_en; u8 gp_left_rumble_mode; + u8 gp_left_trigg_cal_status; u32 gp_left_version_firmware; u8 gp_left_version_gen; u32 gp_left_version_hardware; @@ -52,8 +55,11 @@ struct hid_go_cfg { u32 gp_left_version_protocol; u8 gp_mode; u8 gp_right_auto_sleep_time; + u8 gp_right_gyro_cal_status; + u8 gp_right_joy_cal_status; u8 gp_right_notify_en; u8 gp_right_rumble_mode; + u8 gp_right_trigg_cal_status; u32 gp_right_version_firmware; u8 gp_right_version_gen; u32 gp_right_version_hardware; @@ -227,7 +233,41 @@ static const char *const rumble_mode_text[] =3D { [RUMBLE_MODE_RPG] =3D "rpg", }; =20 -#define FPS_MODE_DPI 0x02 +#define FPS_MODE_DPI 0x02 +#define TRIGGER_CALIBRATE 0x04 +#define JOYSTICK_CALIBRATE 0x04 +#define GYRO_CALIBRATE 0x06 + +enum cal_device_type { + CALDEV_GYROSCOPE =3D 0x01, + CALDEV_JOYSTICK, + CALDEV_TRIGGER, + CALDEV_JOY_TRIGGER, +}; + +enum cal_enable { + CAL_UNKNOWN, + CAL_START, + CAL_STOP, +}; + +static const char *const cal_enabled_text[] =3D { + [CAL_UNKNOWN] =3D "unknown", + [CAL_START] =3D "start", + [CAL_STOP] =3D "stop", +}; + +enum cal_status_index { + CAL_STAT_UNKNOWN, + CAL_STAT_SUCCESS, + CAL_STAT_FAILURE, +}; + +static const char *const cal_status_text[] =3D { + [CAL_STAT_UNKNOWN] =3D "unknown", + [CAL_STAT_SUCCESS] =3D "success", + [CAL_STAT_FAILURE] =3D "failure", +}; =20 enum rgb_config_index { LIGHT_CFG_ALL =3D 0x01, @@ -264,6 +304,13 @@ static const char *const rgb_effect_text[] =3D { [RGB_EFFECT_RAINBOW] =3D "rainbow", }; =20 +enum device_status_index { + GET_CAL_STATUS =3D 0x02, + GET_UPGRADE_STATUS, + GET_MACRO_REC_STATUS, + GET_HOTKEY_TRIGG_STATUS, +}; + static int hid_go_version_event(struct command_report *cmd_rep) { switch (cmd_rep->sub_cmd) { @@ -508,6 +555,44 @@ static int hid_go_light_event(struct command_report *c= md_rep) } } =20 +static int hid_go_device_status_event(struct command_report *cmd_rep) +{ + switch (cmd_rep->device_type) { + case LEFT_CONTROLLER: + switch (cmd_rep->data[0]) { + case CALDEV_GYROSCOPE: + drvdata.gp_left_gyro_cal_status =3D cmd_rep->data[1]; + return 0; + case CALDEV_JOYSTICK: + drvdata.gp_left_joy_cal_status =3D cmd_rep->data[1]; + return 0; + case CALDEV_TRIGGER: + drvdata.gp_left_trigg_cal_status =3D cmd_rep->data[1]; + return 0; + default: + return -EINVAL; + } + break; + case RIGHT_CONTROLLER: + switch (cmd_rep->data[0]) { + case CALDEV_GYROSCOPE: + drvdata.gp_right_gyro_cal_status =3D cmd_rep->data[1]; + return 0; + case CALDEV_JOYSTICK: + drvdata.gp_right_joy_cal_status =3D cmd_rep->data[1]; + return 0; + case CALDEV_TRIGGER: + drvdata.gp_right_trigg_cal_status =3D cmd_rep->data[1]; + return 0; + default: + return -EINVAL; + } + break; + default: + return -EINVAL; + } +} + static int hid_go_set_event_return(struct command_report *cmd_rep) { if (cmd_rep->data[0] !=3D 0) @@ -564,10 +649,16 @@ static int hid_go_raw_event(struct hid_device *hdev, = struct hid_report *report, case GET_RGB_CFG: ret =3D hid_go_light_event(cmd_rep); break; + case GET_DEVICE_STATUS: + ret =3D hid_go_device_status_event(cmd_rep); + break; case SET_FEATURE_STATUS: case SET_MOTOR_CFG: case SET_DPI_CFG: case SET_RGB_CFG: + case SET_TRIGGER_CFG: + case SET_JOYSTICK_CFG: + case SET_GYRO_CFG: ret =3D hid_go_set_event_return(cmd_rep); break; default: @@ -1152,6 +1243,101 @@ static ssize_t fps_mode_dpi_index_show(struct devic= e *dev, return sysfs_emit(buf, "500 800 1200 1800\n"); } =20 +static ssize_t device_status_show(struct device *dev, + struct device_attribute *attr, char *buf, + enum device_status_index index, + enum dev_type device_type, + enum cal_device_type cal_type) +{ + u8 i; + + switch (index) { + case GET_CAL_STATUS: + switch (device_type) { + case LEFT_CONTROLLER: + switch (cal_type) { + case CALDEV_GYROSCOPE: + i =3D drvdata.gp_left_gyro_cal_status; + break; + case CALDEV_JOYSTICK: + i =3D drvdata.gp_left_joy_cal_status; + break; + case CALDEV_TRIGGER: + i =3D drvdata.gp_left_trigg_cal_status; + break; + default: + return -EINVAL; + } + break; + case RIGHT_CONTROLLER: + switch (cal_type) { + case CALDEV_GYROSCOPE: + i =3D drvdata.gp_right_gyro_cal_status; + break; + case CALDEV_JOYSTICK: + i =3D drvdata.gp_right_joy_cal_status; + break; + case CALDEV_TRIGGER: + i =3D drvdata.gp_right_trigg_cal_status; + break; + default: + return -EINVAL; + } + break; + default: + return -EINVAL; + } + break; + default: + return -EINVAL; + }; + + if (i >=3D ARRAY_SIZE(cal_status_text)) + return -EINVAL; + + return sysfs_emit(buf, "%s\n", cal_status_text[i]); +} + +static ssize_t calibrate_config_store(struct device *dev, + struct device_attribute *attr, + const char *buf, u8 cmd, u8 sub_cmd, + size_t count, enum dev_type device_type) +{ + size_t size =3D 1; + u8 val =3D 0; + int ret; + + ret =3D sysfs_match_string(cal_enabled_text, buf); + if (ret < 0) + return ret; + + val =3D ret; + if (!val) + size =3D 0; + + ret =3D mcu_property_out(drvdata.hdev, MCU_CONFIG_DATA, cmd, sub_cmd, + device_type, &val, size); + if (ret < 0) + return ret; + + return count; +} + +static ssize_t calibrate_config_options(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + ssize_t count =3D 0; + unsigned int i; + + for (i =3D 1; i < ARRAY_SIZE(cal_enabled_text); i++) + count +=3D sysfs_emit_at(buf, count, "%s ", cal_enabled_text[i]); + + buf[count - 1] =3D '\n'; + + return count; +} + static int rgb_cfg_call(struct hid_device *hdev, enum mcu_command_index cm= d, enum rgb_config_index index, u8 *val, size_t size) { @@ -1458,6 +1644,30 @@ static void hid_go_brightness_set(struct led_classde= v *led_cdev, } \ static DEVICE_ATTR_RO_NAMED(_name, _attrname) =20 +#define LEGO_CAL_DEVICE_ATTR(_name, _attrname, _scmd, _dtype, _rtype) = \ + static ssize_t _name##_store(struct device *dev, \ + struct device_attribute *attr, \ + const char *buf, size_t count) \ + { \ + return calibrate_config_store(dev, attr, buf, _name.index, \ + _scmd, count, _dtype); \ + } \ + static ssize_t _name##_##_rtype##_show( \ + struct device *dev, struct device_attribute *attr, char *buf) \ + { \ + return calibrate_config_options(dev, attr, buf); \ + } \ + static DEVICE_ATTR_WO_NAMED(_name, _attrname) + +#define LEGO_DEVICE_STATUS_ATTR(_name, _attrname, _scmd, _dtype) = \ + static ssize_t _name##_show(struct device *dev, \ + struct device_attribute *attr, char *buf) \ + { \ + return device_status_show(dev, attr, buf, _name.index, _scmd, \ + _dtype); \ + } \ + static DEVICE_ATTR_RO_NAMED(_name, _attrname) + /* Gamepad - MCU */ struct go_cfg_attr version_product_mcu =3D { PRODUCT_VERSION }; LEGO_DEVICE_ATTR_RO(version_product_mcu, "product_version", USB_MCU, versi= on); @@ -1595,9 +1805,45 @@ LEGO_DEVICE_ATTR_RW(rumble_notification_left, "rumbl= e_notification", static DEVICE_ATTR_RO_NAMED(rumble_notification_left_index, "rumble_notification_index"); =20 +struct go_cfg_attr cal_trigg_left =3D { TRIGGER_CALIBRATE }; +LEGO_CAL_DEVICE_ATTR(cal_trigg_left, "calibrate_trigger", SET_TRIGGER_CFG, + LEFT_CONTROLLER, index); +static DEVICE_ATTR_RO_NAMED(cal_trigg_left_index, "calibrate_trigger_index= "); + +struct go_cfg_attr cal_joy_left =3D { JOYSTICK_CALIBRATE }; +LEGO_CAL_DEVICE_ATTR(cal_joy_left, "calibrate_joystick", SET_JOYSTICK_CFG, + LEFT_CONTROLLER, index); +static DEVICE_ATTR_RO_NAMED(cal_joy_left_index, "calibrate_joystick_index"= ); + +struct go_cfg_attr cal_gyro_left =3D { GYRO_CALIBRATE }; +LEGO_CAL_DEVICE_ATTR(cal_gyro_left, "calibrate_gyro", SET_GYRO_CFG, + LEFT_CONTROLLER, index); +static DEVICE_ATTR_RO_NAMED(cal_gyro_left_index, "calibrate_gyro_index"); + +struct go_cfg_attr cal_trigg_left_status =3D { GET_CAL_STATUS }; +LEGO_DEVICE_STATUS_ATTR(cal_trigg_left_status, "calibrate_trigger_status", + LEFT_CONTROLLER, CALDEV_TRIGGER); + +struct go_cfg_attr cal_joy_left_status =3D { GET_CAL_STATUS }; +LEGO_DEVICE_STATUS_ATTR(cal_joy_left_status, "calibrate_joystick_status", + LEFT_CONTROLLER, CALDEV_JOYSTICK); + +struct go_cfg_attr cal_gyro_left_status =3D { GET_CAL_STATUS }; +LEGO_DEVICE_STATUS_ATTR(cal_gyro_left_status, "calibrate_gyro_status", + LEFT_CONTROLLER, CALDEV_GYROSCOPE); + static struct attribute *left_gamepad_attrs[] =3D { &dev_attr_auto_sleep_time_left.attr, &dev_attr_auto_sleep_time_left_range.attr, + &dev_attr_cal_gyro_left.attr, + &dev_attr_cal_gyro_left_index.attr, + &dev_attr_cal_gyro_left_status.attr, + &dev_attr_cal_joy_left.attr, + &dev_attr_cal_joy_left_index.attr, + &dev_attr_cal_joy_left_status.attr, + &dev_attr_cal_trigg_left.attr, + &dev_attr_cal_trigg_left_index.attr, + &dev_attr_cal_trigg_left_status.attr, &dev_attr_imu_bypass_left.attr, &dev_attr_imu_bypass_left_index.attr, &dev_attr_imu_enabled_left.attr, @@ -1666,9 +1912,45 @@ LEGO_DEVICE_ATTR_RW(rumble_notification_right, "rumb= le_notification", static DEVICE_ATTR_RO_NAMED(rumble_notification_right_index, "rumble_notification_index"); =20 +struct go_cfg_attr cal_trigg_right =3D { TRIGGER_CALIBRATE }; +LEGO_CAL_DEVICE_ATTR(cal_trigg_right, "calibrate_trigger", SET_TRIGGER_CFG, + RIGHT_CONTROLLER, index); +static DEVICE_ATTR_RO_NAMED(cal_trigg_right_index, "calibrate_trigger_inde= x"); + +struct go_cfg_attr cal_joy_right =3D { JOYSTICK_CALIBRATE }; +LEGO_CAL_DEVICE_ATTR(cal_joy_right, "calibrate_joystick", SET_JOYSTICK_CFG, + RIGHT_CONTROLLER, index); +static DEVICE_ATTR_RO_NAMED(cal_joy_right_index, "calibrate_joystick_index= "); + +struct go_cfg_attr cal_gyro_right =3D { GYRO_CALIBRATE }; +LEGO_CAL_DEVICE_ATTR(cal_gyro_right, "calibrate_gyro", SET_GYRO_CFG, + RIGHT_CONTROLLER, index); +static DEVICE_ATTR_RO_NAMED(cal_gyro_right_index, "calibrate_gyro_index"); + +struct go_cfg_attr cal_trigg_right_status =3D { GET_CAL_STATUS }; +LEGO_DEVICE_STATUS_ATTR(cal_trigg_right_status, "calibrate_trigger_status", + RIGHT_CONTROLLER, CALDEV_TRIGGER); + +struct go_cfg_attr cal_joy_right_status =3D { GET_CAL_STATUS }; +LEGO_DEVICE_STATUS_ATTR(cal_joy_right_status, "calibrate_joystick_status", + RIGHT_CONTROLLER, CALDEV_JOYSTICK); + +struct go_cfg_attr cal_gyro_right_status =3D { GET_CAL_STATUS }; +LEGO_DEVICE_STATUS_ATTR(cal_gyro_right_status, "calibrate_gyro_status", + RIGHT_CONTROLLER, CALDEV_GYROSCOPE); + static struct attribute *right_gamepad_attrs[] =3D { &dev_attr_auto_sleep_time_right.attr, &dev_attr_auto_sleep_time_right_range.attr, + &dev_attr_cal_gyro_right.attr, + &dev_attr_cal_gyro_right_index.attr, + &dev_attr_cal_gyro_right_status.attr, + &dev_attr_cal_joy_right.attr, + &dev_attr_cal_joy_right_index.attr, + &dev_attr_cal_joy_right_status.attr, + &dev_attr_cal_trigg_right.attr, + &dev_attr_cal_trigg_right_index.attr, + &dev_attr_cal_trigg_right_status.attr, &dev_attr_imu_bypass_right.attr, &dev_attr_imu_bypass_right_index.attr, &dev_attr_imu_enabled_right.attr, --=20 2.52.0