From nobody Sat Feb 7 11:39:11 2026 Received: from mail-dy1-f176.google.com (mail-dy1-f176.google.com [74.125.82.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15FFD248880 for ; Sat, 24 Jan 2026 01:49:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769219368; cv=none; b=X5z/LkNG/7ks23ZFv/20wmJeOOtnjjhtYSt+cv9/OX79ZJc15KjQONSnPZxKSk1cf/O0+QIo4gqUar0K7HTgyabPaV1xDaOUutlrQrHUBwroYr+vMTXm3Jrv5oOe7aYxHvkX9KHqzxvWqSuXU1uk6Vdgw2yvcbpQewmEj5uvlew= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769219368; c=relaxed/simple; bh=Uq1flWJME9yZBIe+pK57YoX7PNsp53RCp/QQ+B2TBXo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=C/QXZxY5RFRMf0pEHu/ZNifd3SIWuIHNjKwh9Srxi3G+Om+XVG7w/ZSSmDlbhXJ+pGwGPkPwuw/N1HeaAKQcvEh/IIzbZag2SkLekVPvSdEGikt+215d+GRPxl2+6EvF4Ryyww9jOsZ/4S2qGwm1Z/SiK7+mS4VVKQNWECxlC/E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=P4Qr2eG3; arc=none smtp.client-ip=74.125.82.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P4Qr2eG3" Received: by mail-dy1-f176.google.com with SMTP id 5a478bee46e88-2b6b0500e06so3716193eec.1 for ; Fri, 23 Jan 2026 17:49:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769219365; x=1769824165; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=shcSpW9YVM231NFCSd2R8Nn6vQf/8t1cDlRE1ZGCnPo=; b=P4Qr2eG3mnYUDJNURHDGjaNBaIyFHSNKS7DxssfL4lJ28gg/bLO4hBPgjhNbI0YC13 VUmlvjm6Ey/bYoXaOcyVeT6vfu93zr6W7vOGI3i6XlJkvCfHcPMjaRTpbfhL/4gFb1EW /LFYRk5g3DqgwIt3xa1c+khF34iUBfhf1jr8hNN/Xf+f+kbUjXVc6VMFl8m4Cy6chh7Z ubBCuEJJwwasJiT4EGH3A/Vpd1t02nL/ZAM+HhHUE3Iis48ts4Mvyu7xvTxzH1ClA0LP pi5NvadbP9diRk3CWgZ9lHluS8gvl91ArBELOYY876vs8vy1K3XjJ66YSe+0jrlxeJNW 9XDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769219365; x=1769824165; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=shcSpW9YVM231NFCSd2R8Nn6vQf/8t1cDlRE1ZGCnPo=; b=DusRK/piN6nGHAR7Ir3cpmsG+Zv9lpGwrJpiH1KL3MqUGC/wbnV0hS4hNquF9Z0Okb jYJOgb8hw3brOelAydKsYbvnIWtgSQxew5zAc+sQL5GJNw8rUyReyBvIrR370qwvUZ3+ X7HKkJbIc9S5yBuEk3iw8cTxjnmtxI6Q87un1dwS2zxyoGcgQWTB85CnnXxX39XoTVyL siE0MFwPk6mEUU9gT0+xEUzqQQqyKB8rqyHB3CRdcMINH7gvm6IhTec/YOlItidkOmiZ S68EopG23F/V7OU0ODvO4FfEX/0TwGMH/4LlF6CYMcFKzy+nobw8ZF6vIyfn+bwD3FN5 eOoQ== X-Forwarded-Encrypted: i=1; AJvYcCXk8wFxpVEP7EIP202CRFK9/xe5dXsjAExqQg1RJuK8PDZiNTanzld7Ro9vPiJwtj/ODNy5uT/3bvSNXUs=@vger.kernel.org X-Gm-Message-State: AOJu0YzF5SktW0EC89UkHQMWisQ1CFU4mlv9OTnc9s+t+4zpHjSZbwpS xV8YtdxFImHMj0kRcfbCdH+L7fbrz+SvGJQf8EbcbwP6JICDuJhuxDos X-Gm-Gg: AZuq6aJihs5Dklk2OcqzSJjLGg13tyQrLIW/Ux3hxE/Uuh0zfQDmdENHXbpFtd0s2mZ OnuLLg13o9nw6uD6d9kBl4HezVtOCbmo6CkgNdBeUkggNmVudJI/F5/yCugIRPnJQrAr8Iv7h8T iergZXmg5FnjX8/XwzBPke5VhxHmN5TI8Kbz13pe2ucCeFlK407RIWcLxV8gv49WBtbIcCF5Opg wPDdPP1xxH8MS/AZDXlm4P0djTdINij5NRe6wnGwOuX9boy0Q8uPeSdB9KaFlKQzqH+wXBnKOdE h5ZgPw0W0ur1+qv8eGhpgRUyn2Kk9ldq96ln8n9Lw5PoIv4lk/GSNj7y9LYddVi7bUwpNZrVNo6 XmrvZwwENFhlqzlrYkiFUFn4r0h3LgRvy0KYs4seXyN12SNizLDI7j2XSYBOoP1cB7lBKDRq8dQ xUMpr28ntlOHY2nBq5SnfNBCtd8jLC+L5WSO2NMGPmnfdF4XHMy6+vj9zYR6h4PHM= X-Received: by 2002:a05:7301:fa84:b0:2b7:98d:7b54 with SMTP id 5a478bee46e88-2b739992976mr2783751eec.14.1769219365156; Fri, 23 Jan 2026 17:49:25 -0800 (PST) Received: from lappy (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b73aa22707sm5160014eec.29.2026.01.23.17.49.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jan 2026 17:49:24 -0800 (PST) From: "Derek J. Clark" To: Jiri Kosina , Benjamin Tissoires Cc: Mario Limonciello , Zhixin Zhang , Mia Shao , Mark Pearson , "Pierre-Loup A . Griffais" , "Derek J . Clark" , linux-input@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 15/16] HID: hid-lenovo-go-s: Add IMU and Touchpad RO Attributes Date: Sat, 24 Jan 2026 01:49:06 +0000 Message-ID: <20260124014907.991265-16-derekjohn.clark@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260124014907.991265-1-derekjohn.clark@gmail.com> References: <20260124014907.991265-1-derekjohn.clark@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Adds attributes for reporting the touchpad manufacturer, version, and IMU manufacturer. Signed-off-by: Derek J. Clark --- V3: - Fix bug where the touchpad attributes were assigned to the touchpad _show function instead of the test _show function. --- drivers/hid/hid-lenovo-go-s.c | 108 ++++++++++++++++++++++++++++++++++ 1 file changed, 108 insertions(+) diff --git a/drivers/hid/hid-lenovo-go-s.c b/drivers/hid/hid-lenovo-go-s.c index e422f3977517..d74a37c1980f 100644 --- a/drivers/hid/hid-lenovo-go-s.c +++ b/drivers/hid/hid-lenovo-go-s.c @@ -43,6 +43,7 @@ struct hid_gos_cfg { u8 gp_mode; u8 gp_poll_rate; u8 imu_bypass_en; + u8 imu_manufacturer; u8 imu_sensor_en; u8 mcu_id[12]; u8 mouse_step; @@ -54,6 +55,8 @@ struct hid_gos_cfg { u8 rgb_speed; u8 tp_en; u8 tp_linux_mode; + u8 tp_manufacturer; + u8 tp_version; u8 tp_windows_mode; } drvdata; =20 @@ -201,6 +204,36 @@ enum rgb_config_index { USR_LIGHT_PROFILE_3, }; =20 +enum test_command_index { + TEST_TP_MFR =3D 0x02, + TEST_IMU_MFR, + TEST_TP_VER, +}; + +enum tp_mfr_index { + TP_NONE, + TP_BETTERLIFE, + TP_SIPO, +}; + +static const char *const touchpad_manufacturer_text[] =3D { + [TP_NONE] =3D "none", + [TP_BETTERLIFE] =3D "BetterLife", + [TP_SIPO] =3D "SIPO", +}; + +enum imu_mfr_index { + IMU_NONE, + IMU_BOSCH, + IMU_ST, +}; + +static const char *const imu_manufacturer_text[] =3D { + [IMU_NONE] =3D "none", + [IMU_BOSCH] =3D "Bosch", + [IMU_ST] =3D "ST", +}; + static int hid_gos_version_event(u8 *data) { struct version_report *ver_rep =3D (struct version_report *)data; @@ -279,6 +312,30 @@ static int hid_gos_touchpad_event(struct command_repor= t *cmd_rep) return ret; } =20 +static int hid_gos_pl_test_event(struct command_report *cmd_rep) +{ + int ret =3D 0; + + switch (cmd_rep->sub_cmd) { + case TEST_TP_MFR: + drvdata.tp_manufacturer =3D cmd_rep->data[0]; + ret =3D 0; + break; + case TEST_IMU_MFR: + drvdata.imu_manufacturer =3D cmd_rep->data[0]; + ret =3D 0; + break; + case TEST_TP_VER: + drvdata.tp_version =3D cmd_rep->data[0]; + ret =3D 0; + break; + default: + ret =3D -EINVAL; + break; + } + return ret; +} + static int hid_gos_light_event(struct command_report *cmd_rep) { struct led_classdev_mc *mc_cdev; @@ -362,6 +419,9 @@ static int hid_gos_raw_event(struct hid_device *hdev, s= truct hid_report *report, case GET_TP_PARAM: ret =3D hid_gos_touchpad_event(cmd_rep); break; + case GET_PL_TEST: + ret =3D hid_gos_pl_test_event(cmd_rep); + break; case GET_RGB_CFG: ret =3D hid_gos_light_event(cmd_rep); break; @@ -742,6 +802,42 @@ static ssize_t touchpad_property_options(struct device= *dev, return count; } =20 +static ssize_t test_property_show(struct device *dev, + struct device_attribute *attr, char *buf, + enum test_command_index index) +{ + size_t count =3D 0; + int ret; + u8 i; + + ret =3D mcu_property_out(drvdata.hdev, GET_PL_TEST, index, 0, 0); + if (ret) + return ret; + + switch (index) { + case TEST_TP_MFR: + i =3D drvdata.tp_manufacturer; + if (i >=3D ARRAY_SIZE(touchpad_manufacturer_text)) + return -EINVAL; + count =3D sysfs_emit(buf, "%s\n", touchpad_manufacturer_text[i]); + break; + case TEST_IMU_MFR: + i =3D drvdata.imu_manufacturer; + if (i >=3D ARRAY_SIZE(imu_manufacturer_text)) + return -EINVAL; + count =3D sysfs_emit(buf, "%s\n", imu_manufacturer_text[i]); + break; + case TEST_TP_VER: + count =3D sysfs_emit(buf, "%u\n", drvdata.tp_version); + break; + default: + count =3D -EINVAL; + break; + } + + return count; +} + static ssize_t mcu_id_show(struct device *dev, struct device_attribute *at= tr, char *buf) { @@ -1085,6 +1181,9 @@ struct gos_cfg_attr imu_bypass_enabled =3D { FEATURE_= IMU_BYPASS }; LEGOS_DEVICE_ATTR_RW(imu_bypass_enabled, "bypass_enabled", index, gamepad); static DEVICE_ATTR_RO_NAMED(imu_bypass_enabled_index, "bypass_enabled_inde= x"); =20 +struct gos_cfg_attr imu_manufacturer =3D { TEST_IMU_MFR }; +LEGOS_DEVICE_ATTR_RO(imu_manufacturer, "manufacturer", test); + struct gos_cfg_attr imu_sensor_enabled =3D { FEATURE_IMU_ENABLE }; LEGOS_DEVICE_ATTR_RW(imu_sensor_enabled, "sensor_enabled", index, gamepad); static DEVICE_ATTR_RO_NAMED(imu_sensor_enabled_index, "sensor_enabled_inde= x"); @@ -1092,6 +1191,7 @@ static DEVICE_ATTR_RO_NAMED(imu_sensor_enabled_index,= "sensor_enabled_index"); static struct attribute *legos_imu_attrs[] =3D { &dev_attr_imu_bypass_enabled.attr, &dev_attr_imu_bypass_enabled_index.attr, + &dev_attr_imu_manufacturer.attr, &dev_attr_imu_sensor_enabled.attr, &dev_attr_imu_sensor_enabled_index.attr, NULL, @@ -1145,6 +1245,12 @@ struct gos_cfg_attr touchpad_linux_mode =3D { CFG_LI= NUX_MODE }; LEGOS_DEVICE_ATTR_RW(touchpad_linux_mode, "linux_mode", index, touchpad); static DEVICE_ATTR_RO_NAMED(touchpad_linux_mode_index, "linux_mode_index"); =20 +struct gos_cfg_attr touchpad_manufacturer =3D { TEST_TP_MFR }; +LEGOS_DEVICE_ATTR_RO(touchpad_manufacturer, "manufacturer", test); + +struct gos_cfg_attr touchpad_version =3D { TEST_TP_VER }; +LEGOS_DEVICE_ATTR_RO(touchpad_version, "version", test); + struct gos_cfg_attr touchpad_windows_mode =3D { CFG_WINDOWS_MODE }; LEGOS_DEVICE_ATTR_RW(touchpad_windows_mode, "windows_mode", index, touchpa= d); static DEVICE_ATTR_RO_NAMED(touchpad_windows_mode_index, "windows_mode_ind= ex"); @@ -1154,6 +1260,8 @@ static struct attribute *legos_touchpad_attrs[] =3D { &dev_attr_touchpad_enabled_index.attr, &dev_attr_touchpad_linux_mode.attr, &dev_attr_touchpad_linux_mode_index.attr, + &dev_attr_touchpad_manufacturer.attr, + &dev_attr_touchpad_version.attr, &dev_attr_touchpad_windows_mode.attr, &dev_attr_touchpad_windows_mode_index.attr, NULL, --=20 2.52.0