From nobody Mon Feb 9 05:45:34 2026 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AF7F270EC1 for ; Fri, 23 Jan 2026 19:06:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769195210; cv=none; b=CYitPbqN6Kvh+ixtjBSFV3toCUfouqEZpp1dulh3MgC9iIe++VuKaW2K+oN2sSQ8NUKozNg9D1Z/RH8wRQ+IXVPGkNI+cAoJ0D7kS2x0q2MeyDeR+fGYYSEvnVEP7wExkpIqEXQvmspsp0DBS6xoSdKKHdUU1kep5hc0LljVMDw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769195210; c=relaxed/simple; bh=qdOEb1TELuVRMyiAyReucWqeGMrYnZ8kzoChaPtElBI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=CIkAbDnEdi/yt7nImZ7A7eHdMpq9w5nruin0lAEU3/O/gbvhlaYdvgiZkUJuw+JL+MH6BRzbPs3zTIMMpWaf+hLc5Qskn1GI6meRW9z9wrO1o4WlyTQnqJKrY+2bpEh8Q214GNEaye2uz17Jd9IBbphJSSOVqipZvD2R5H8Ud4g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jYS3usuN; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jYS3usuN" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-35338b3dd31so1217723a91.2 for ; Fri, 23 Jan 2026 11:06:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769195209; x=1769800009; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=VrGf6D6fRUKgAu958m67Gc/e+p765gm2Q2mQPt54JfY=; b=jYS3usuNmqaur7LrNBDwvE/oW/DSRMc2q6ykrgPmhjvxFo0pbRhqfx5BE01k5mjfRP lI+yHcdCh8UbFnBPJljKqcjVYuJMM4moAhmKKURRvIOppJC5pqU67q1XcMvtIiLehexk ZBZ9WDiMEgCYx7GmMQ0UcZJxWlNr2SPX0xwD+VjexUU/2oHnH/EUk71oPxgunWjRD9U2 nG5BDUqJjrZ4MsHJAyUL4DZ1gxOuDGeqjdntUiE9MkhGRWnwTURlhZghcoZXNJgSUoar gsuKp/QvH6k4XaDeQwDhOHaaIP8vCLzEzxS5cZQG8YLSUv61VtVDK8vH6idq3GCpqbvH XFTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769195209; x=1769800009; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VrGf6D6fRUKgAu958m67Gc/e+p765gm2Q2mQPt54JfY=; b=o39lz8r+pGAbKpCm5rOUK9HtLsFXGRKFIRO45PD3HgY3m2rRjQirJl9nGZWKJBbD4I xKbfo9/TF1xtKrUxzRX8RVQTRs9zuj254nI8LZ+FzWgV08moOKZOPkV3XPNJsM4KfHPo 4ckhCU1CZqlZgKqfvMx0Wci58MqlrlUp2WZ/KysXcjajW3+0MxveKLfsJoFACis3/JIV 4LWLz9cBzxAW/ibMESVMr6zbtgYgdOltik4/sJGPLo/mrJkGgDlhD7eORiw5VBx/RxKG NnoFEfaRj1liZFky7KNkRVc95KI6VxFaW0QOAv3BbWAS8RxEd06qgf45UC782Fv1y/p4 MCgg== X-Forwarded-Encrypted: i=1; AJvYcCUn9yUP/uIkfY66fyEpA0YJ4JzB5fckbGouFouZNZPP5bAr3Iurys3NuAWRCYbP6yd2vER3sDw14Ykrspc=@vger.kernel.org X-Gm-Message-State: AOJu0YyTR10AIZitIgAF141VeajeNjlukVT2k1sOvCRiTi2smyQdEkPp GeYD/X192EILtB/27bEPwBZXE3BZPy0wjMK3OrOaariPpgh9+rbGDmca X-Gm-Gg: AZuq6aLUO3gmgNI5886+HUTzXAUB65oaD6kFjUtwbX6pD3CL53qZy+jhgvJO8NtaDrW GGGedsrrYhLlwir1bSJQbtwsb0y5+ROFfONS1SI39jtmFFSbHKe1DqBGlxT+NsG4KkQVJXtaK1w c9kavqpMZG1TxG6Q8AXh1BffzjHi8sL5rJ8633t0Qbf0Bbt8XYk9U4k8W5sUITY31OOpj6thBah QhRSHk595pKbU+2oqLvrpGdR+iTTUgOXtgLpXFf7ZjN8+oDF2ve3Dsx5eTM6/9xrBFd98UlM4fk WaDlBBq3Rvm7KKg2LXtq458/26lT6q2fZho88dih0EvTtxQBEu89VqNwHvG4I63+OQagtlCQ876 vhW+LrDYGt+oxRGmG2et+4YWVCBQoBDxcMY2yWMoFg6atyXyV27xondgDxjXhCXT4uN3EdUJGgi +uEFnfnVmLZKz5x2fJbKj7rZql X-Received: by 2002:a17:90a:dfc4:b0:352:f2a6:334 with SMTP id 98e67ed59e1d1-353676fc2fbmr3199076a91.16.1769195208687; Fri, 23 Jan 2026 11:06:48 -0800 (PST) Received: from junjungu-PC.localdomain ([188.253.124.89]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-353355e1161sm5720924a91.17.2026.01.23.11.06.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jan 2026 11:06:48 -0800 (PST) From: Felix Gu Date: Sat, 24 Jan 2026 03:06:40 +0800 Subject: [PATCH] thermal/of: Fix reference leak in thermal_of_cm_lookup() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260124-thermal_of-v1-1-54d3416948cf@gmail.com> X-B4-Tracking: v=1; b=H4sIAL/Gc2kC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDQyMT3ZKM1KLcxJz4/DRdS0Nzc5PU1ORUMwtLJaCGgqLUtMwKsGHRsbW 1ALqxaURcAAAA X-Change-ID: 20260124-thermal_of-91774eece689 To: "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Yu-Che Cheng Cc: "Rafael J. Wysocki" , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1769195203; l=1177; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=qdOEb1TELuVRMyiAyReucWqeGMrYnZ8kzoChaPtElBI=; b=3piP6dhLDDZmkys9vdmEphHovqfbXRPnhmzLIM794MNBLaAT+v3m+HBZ5AFou+xUAPH0i3an8 kD7XIFV2UNwAlhulEl6XkgNN2gnwGmsJ7EdKHCh603ORjafluC3X4iH X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= In thermal_of_cm_lookup(), tr_np is obtained via of_parse_phandle(). But it never be released. Use the __free(device_node) cleanup attribute to automatically release the node and fix the leak. Fixes: 423de5b5bc5b ("thermal/of: Fix cdev lookup in thermal_of_should_bind= ()") Signed-off-by: Felix Gu Reviewed-by: Lukasz Luba --- drivers/thermal/thermal_of.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/thermal/thermal_of.c b/drivers/thermal/thermal_of.c index 1a51a4d240ff..b6d0c92f5522 100644 --- a/drivers/thermal/thermal_of.c +++ b/drivers/thermal/thermal_of.c @@ -280,10 +280,10 @@ static bool thermal_of_cm_lookup(struct device_node *= cm_np, struct cooling_spec *c) { for_each_child_of_node_scoped(cm_np, child) { - struct device_node *tr_np; int count, i; =20 - tr_np =3D of_parse_phandle(child, "trip", 0); + struct device_node *tr_np __free(device_node) =3D + of_parse_phandle(child, "trip", 0); if (tr_np !=3D trip->priv) continue; =20 --- base-commit: a0c666c25aeefd16f4b088c6549a6fb6b65a8a1d change-id: 20260124-thermal_of-91774eece689 Best regards, --=20 Felix Gu