From nobody Tue Feb 10 01:14:52 2026 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 207C51EB9FA for ; Sat, 24 Jan 2026 04:29:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769228979; cv=none; b=lVDbTlDRM7fDP4aeaSEaGwVWaE5JijMUXP22F/HcH822DSEd6ebR/uZDfY0aIkBy8qqIr2yaudi/liYe0wCHFWE3j12VtlReSoBUl6lJFw/MKuz1/KXck5L9uS08GW3a5cXR1gTX5jBKweECvGZt7w/Qfmk8GIfV8F14zlGi4Yw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769228979; c=relaxed/simple; bh=sx3UyKFDuIEPkkHlPx4r27kZUF2Y5+jMgWB9/8tyLq4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DWpdoLB2WjWu7t4AKNxfvg78hLGcPFsrYSDRfdE2I/dzNdRS6j/KTpuBRVDPDnLMv3gKpwRQIFnYJVgMrwQIC8OQDPRHmqlH/RP33gKmn20j0MNhWs+1RfsOfxjnKxkIutH4ks07mYejLjxfjZd7brzzTWCdUnsGgS3rktmjlV4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=gfdvjo7w; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="gfdvjo7w" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-c56188aef06so1200927a12.2 for ; Fri, 23 Jan 2026 20:29:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1769228977; x=1769833777; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=jzuiHQbYslZI5xHIBCbYXnuCh07OaFGFeD1UZM8yZnk=; b=gfdvjo7wylGC4X+jvyxUvvSQAoYHkuG0ADUfWtmCesKRpuQ41rFr5vj5vRNfO+Omwb HN8umpDqgLKwXorwa/HuXqrj2JQsQcVuMZFDrZU92K5wQEGf72jsxhqVyhYtosBHUzNQ vvPYXm3j3V+53K8LEMEf9X3XxIgknddoYxn98xWvUf0W37FMgnKwm2VGmaSjcyiIYhHr d7HN1pRCabR4kaebevOSfadevYHjHWf0GRBeho18nEm+10zHgVT3AIFUx8d/8Z+PEr5r mWJEiq18CaasNb3X3JfPEjmQIfNFMV/chUcrj43F3JWaPupkyROTihjJhaB0Q7wjRzoA UK/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769228977; x=1769833777; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=jzuiHQbYslZI5xHIBCbYXnuCh07OaFGFeD1UZM8yZnk=; b=jrbSychw28H5ue9aIadqH9xis+QHNF5aXev/VSSb6rzvMHy8c56d7wHS1TU0ByC7c8 QrWetFdVAmjkU18mL5K2cIYDIJm4IeMLUFH2284Lplk6hEBxr+sgHZjdHMi9FfD9tl0A NzkIf0Cq2hehjJzr4Uur8hzdK59eZkvnytFT7leoUKE56+lcQzsMZWvaLkcwTSTG0MWs 3VgKnhdNvAu4JdElGv2gB20LybLwmSqrhhPrPS84rTh2KurtX2GJdysInldffsJborAz gJ85e1n0s//ouLKq85XTK9dVqGGhIsDQ9TdZENYVWOAwtVnJlHGuhFmCC4aLvlRvQeat u33Q== X-Gm-Message-State: AOJu0Yyzp2XlhM91eyDLHjYbwgo5xljoQFYEmJGl+eO58BicGPagYIze WFcP+IzipjrEjd1bqCOcSNyI4Aup1NuImeKOR6er+A5soM7KkuuAoBYYXt9XBjP2lyU= X-Gm-Gg: AZuq6aL2ONEoarBH7pLR7X5cAr/p5shEdLBI56OlbU16ovGrWJHuf3k72jsdNd9QhLu eTq/qjbg2B5Z1GnbTstl6z1EXrfoWlrTHHFZmz3GjhsxpvX8UWF8RZ7DOXRT5sze3SGQNzEi8jr fFlUxVDKIlF1qNO7IQ/nNznpdSrofdg7vIq2rVzQapVv6V8X8qDBE6tO9CBLUVl0h4Z7+utqBty drxf1mjph0/7IxOESL1Ih2JrtvIRgMdQRXAGKiFmPwNA92vsMO0FQjHEPGWJaFA1XYU3YBDKBwm Qo4ixsYHAIEYPHjIsQEGmdW4XrklySmNL7hdeGqHNxAmwXcIbAaConMkgkQrq/Z5iI9x/+RCKoO pCgs0xbOjgHV5rk5Y4BMYNIovPcn6TLxt8/Rg9dozC9Sxmlv/YjUXO6n4fM4YPl3lUmAK72alhT RJ8jDCKj2VmVeUVR8l7iflP7bEfcTv5r8= X-Received: by 2002:a17:902:f68c:b0:2a7:99c9:1086 with SMTP id d9443c01a7336-2a7fe74572bmr45740975ad.47.1769228977300; Fri, 23 Jan 2026 20:29:37 -0800 (PST) Received: from [127.0.1.1] ([2a12:a305:4::30fc]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8231871d51esm3469423b3a.38.2026.01.23.20.29.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jan 2026 20:29:36 -0800 (PST) From: Guodong Xu Date: Sat, 24 Jan 2026 08:20:16 +0800 Subject: [PATCH v2 1/4] regulator: spacemit-p1: Fix n_voltages for BUCK and LDO regulators Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260124-spacemit-p1-v2-1-2c86b06694ba@riscstar.com> References: <20260124-spacemit-p1-v2-0-2c86b06694ba@riscstar.com> In-Reply-To: <20260124-spacemit-p1-v2-0-2c86b06694ba@riscstar.com> To: Liam Girdwood , Mark Brown , Yixun Lan , Alex Elder , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Troy Mitchell , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti Cc: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, devicetree@vger.kernel.org, Guodong Xu X-Mailer: b4 0.14.3 Higher voltage settings were unusable due to incorrect n_voltages values causing registration failures. For example, setting aldo4 to 3.3V failed with -EINVAL because the required selector (123) exceeded the allowed range (n_voltages=3D117). Fix by aligning n_voltages with the hardware register widths per the P1 datasheet [1]: - BUCK: 255 (was 254), allows selectors 0-254, selector 255 is reserved - LDO: 128 (was 117), allows selectors 0-127, selectors 0-10 are for suspend mode, valid operational range is 11-127 This enables the full voltage range supported by the hardware. Fixes: 8b84d712ad84 ("regulator: spacemit: support SpacemiT P1 regulators") Link: https://developer.spacemit.com/documentation [1] Signed-off-by: Guodong Xu Reviewed-by: Alex Elder --- v2: No change. --- drivers/regulator/spacemit-p1.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/spacemit-p1.c b/drivers/regulator/spacemit-p= 1.c index 2bf9137e12b1..2b585ba01a93 100644 --- a/drivers/regulator/spacemit-p1.c +++ b/drivers/regulator/spacemit-p1.c @@ -87,13 +87,13 @@ static const struct linear_range p1_ldo_ranges[] =3D { } =20 #define P1_BUCK_DESC(_n) \ - P1_REG_DESC(BUCK, buck, _n, "vin", 0x47, BUCK_MASK, 254, p1_buck_ranges) + P1_REG_DESC(BUCK, buck, _n, "vin", 0x47, BUCK_MASK, 255, p1_buck_ranges) =20 #define P1_ALDO_DESC(_n) \ - P1_REG_DESC(ALDO, aldo, _n, "vin", 0x5b, LDO_MASK, 117, p1_ldo_ranges) + P1_REG_DESC(ALDO, aldo, _n, "vin", 0x5b, LDO_MASK, 128, p1_ldo_ranges) =20 #define P1_DLDO_DESC(_n) \ - P1_REG_DESC(DLDO, dldo, _n, "buck5", 0x67, LDO_MASK, 117, p1_ldo_ranges) + P1_REG_DESC(DLDO, dldo, _n, "buck5", 0x67, LDO_MASK, 128, p1_ldo_ranges) =20 static const struct regulator_desc p1_regulator_desc[] =3D { P1_BUCK_DESC(1), --=20 2.43.0