From nobody Tue Feb 10 01:15:32 2026 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66F3E18FDBD; Sat, 24 Jan 2026 17:31:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769275897; cv=none; b=Z9GbMIfgXZWwIC6JpmVS0z+nn2o6HaO0r+uiaTbqU+Foj1alQBxRE1XH0+r6AB5ZYeTyVzjG0i+ByAlu5PCSpV3RxwgkGtPPk+Wbwb5LxA2PyZtILk3Gh+/xu7WuDsPaq1gyGMQCJgS1KtMk8LvDlVWEyy+rDW82vceUbynlxRo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769275897; c=relaxed/simple; bh=VyJNORh+kqAENWPGajL+8qZsG7n89eFpUynRgv2k1MA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=G9E2+XUdiTz+4EF/X1WGOgCKHGMJJFmLlHuwlD+eRt9uezvih8VdhMJEtLOEcZHNYJuSTuqQF3kaGFbuf2rwc3vjwgQcB/RXzgUOhvmY27XioxzwO0Vd1586Wp9rNkIR9CR4E2H8KCvGONAorXHgJFCODsyIg/BTLOtUE2/YsQA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=Xrg4c5Wb; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="Xrg4c5Wb" Received: from [127.0.0.1] (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 407F527DC1; Sat, 24 Jan 2026 18:21:30 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id vTPiSNRYof_E; Sat, 24 Jan 2026 18:21:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1769275289; bh=VyJNORh+kqAENWPGajL+8qZsG7n89eFpUynRgv2k1MA=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=Xrg4c5WbW83SYcMqZhK/qfDm/MAy8Ba0qAIvijWc0K1XeKunNtV7vcdS1Tl3xnGQp oRhq89ao5I0w2Z5t+0nlFVbTJHo4WfbELsbI89VFyVaO4g8WBLfgk2960506dCnYu8 mhWbNQO3mbIcrAXrmbNwf4IbPA5GlY+nh7jyVAFEZvjRjWBM+5HZBAkdCPzzEG6l0J VLnbyfhumw8bS1I7GLSlkzT6Q3YvaJc1jOVQ8SyANp0AOmSDg2voA1RbFRBexjPqJ1 TTKmgTLWVduEzQaGgEoVR/pygle86jll+dSZisUG1TLYjKxlVngu7+hzOp0pazosV+ 99EYdAKSoD05g== From: Kaustabh Chakraborty Date: Sat, 24 Jan 2026 22:50:46 +0530 Subject: [PATCH 1/3] drm/bridge: samsung-dsim: move bridge init sequence to atomic_enable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260124-exynos-dsim-fixes-v1-1-122d047a23d1@disroot.org> References: <20260124-exynos-dsim-fixes-v1-0-122d047a23d1@disroot.org> In-Reply-To: <20260124-exynos-dsim-fixes-v1-0-122d047a23d1@disroot.org> To: Inki Dae , Jagan Teki , Marek Szyprowski , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Kaustabh Chakraborty , stable@vger.kernel.org Since commit c9b1150a68d9 ("drm/atomic-helper: Re-order bridge chain pre-enable and post-disable"), pre-enable sequence is called before the CRTC is enabled. This causes unintended side-effects (abberation among potentially other things) in the display when samsung_dsim_init() is called in the pre-enable part of the sequence. Call it in samsung_dsim_atomic_enable() instead. Cc: stable@vger.kernel.org # v6.17 and later Signed-off-by: Kaustabh Chakraborty --- drivers/gpu/drm/bridge/samsung-dsim.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge= /samsung-dsim.c index 1d85e706c74b9..975f8b50ae660 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -1655,6 +1655,13 @@ static void samsung_dsim_atomic_pre_enable(struct dr= m_bridge *bridge, } =20 dsi->state |=3D DSIM_STATE_ENABLED; +} + +static void samsung_dsim_atomic_enable(struct drm_bridge *bridge, + struct drm_atomic_state *state) +{ + struct samsung_dsim *dsi =3D bridge_to_dsi(bridge); + int ret; =20 /* * For Exynos-DSIM the downstream bridge, or panel are expecting @@ -1665,12 +1672,6 @@ static void samsung_dsim_atomic_pre_enable(struct dr= m_bridge *bridge, if (ret) return; } -} - -static void samsung_dsim_atomic_enable(struct drm_bridge *bridge, - struct drm_atomic_state *state) -{ - struct samsung_dsim *dsi =3D bridge_to_dsi(bridge); =20 samsung_dsim_set_display_mode(dsi); samsung_dsim_set_display_enable(dsi, true); --=20 2.52.0