From nobody Sat Feb 7 06:13:32 2026 Received: from mail-vs1-f53.google.com (mail-vs1-f53.google.com [209.85.217.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6201026A0A7 for ; Fri, 23 Jan 2026 21:13:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.217.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769202816; cv=none; b=Lf94Wg5LY4BRCv4qmeylNdg5nNBjxX49E9oWqu9Rl/h44l1A8aZ3XV7n7QZi88M3Kkbf8WHjoTMwMy+gTGBfFLaRStAjJ3i0csSspEXUloodROfooYLrpo1GQiEHiTFllUJCqr62KSRy4zNDMOGpxtsm9/rEciunTGCmJPI3VOs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769202816; c=relaxed/simple; bh=yrXNODIr7BomkmwbFTfdc1dmWE/M85IjDSwFYcpA9YY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=UTMyJHCSJWH+yB4GrwsreNUt3bCBYSxKl8ijiUE1v5l4gbIT2sRXDrAEJuJwKySoD0JBI8GB97H3JBwgSkqD7HApJ7SHY64YaAwvv2DMaRF+7U9jGuE/VWayoEziCRtA/S14dAxTIjEI7bKlSXezEKUhq9DHLWBpvnhbZZYg2aM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YSceV1SR; arc=none smtp.client-ip=209.85.217.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YSceV1SR" Received: by mail-vs1-f53.google.com with SMTP id ada2fe7eead31-5f526c39718so2683987137.2 for ; Fri, 23 Jan 2026 13:13:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769202814; x=1769807614; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=xOKBsrYlyb9CGTosX89C67uibLCQdicC5e/4vrZsIig=; b=YSceV1SR4EJbop+VzJjBC0JFnN0NaKo0DYYkhK0HBQDjawlb2ecpHlfv9H7FRaC7Gq 8NAe9x0q79QHJ0Kg0JKulGasSg19MWhKlgr4Ny4ngK7C5lMmTb60AS2vBe/yowxf/f9N HSPThiMNU7loN3peaVhZM6pHrWAkqhHMfDvjfSc2llU7yXbAJixaRWZBHuvV8RdyvN4i ePFXDwpvU/+H9x3Dgy+NGpSOF+7iW2O3eF1sYTzKNCLvlK8sdxjGrs1txyPfkupdvXT9 VWyx0jkZF9I+rGaXlAKUVeNldJ8W0IFNUCixTUXwF+Ro2J3tV6Vt3T3KF+6ZD2gfSyQo z0Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769202814; x=1769807614; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xOKBsrYlyb9CGTosX89C67uibLCQdicC5e/4vrZsIig=; b=g2S1LSyg72EZilM7hed41kwebvE+0HeyfCS254AwbM2nIa157S39Qkrmcomld49OFZ 04XcFI5FUu1condAghWCONaB8qIjKisVV8Yan3PcewohICrIF0dPJ8I5nj8Vp3b2GBuA zVMpkqzwxMspN5nn3FXhfXzAmdz6XMyjb/Vnb30FZMQCe1ETn4ZU/HI3f4EEmyjEW7DV F5WgWSTf/ByFH3+WCBGvCuzAY9LltPN5h1RElD95GCOi1bAc6zKRL3EbjWIjHB54tKaC f6VzOlBZAl7HszyCi1ONFXG/8t5Dx1jT13l8Erxn/tQFCHHsHbnygPhXxlgJFfkTuFKn ykDA== X-Forwarded-Encrypted: i=1; AJvYcCVSkasaEeYUgYPii2+z2i14+2xQd/riNQ8m34rc+RXes5uRBNH8tC4Ag9hpeFozTin0dyrwHWVJUTNY36E=@vger.kernel.org X-Gm-Message-State: AOJu0YxTEIIIZV6qKpWv1ytV8XtoY2UtI/rCcHEjdvx/W4PqADrHbp24 kSWTvwwNTojpjLIxF1MKkWjX3ny8RRmy2HSw4RPwwXWFcoJ2nmtqBGtOD10VqmntsAE= X-Gm-Gg: AZuq6aLkt4271qP5z94LpZjl1P+pyFiGStV3vdaUn8AqPJH5HLHHCNIShRXUKQn3Gz8 hkE3rB9VwBDZq/nJqk0UTahgMgg9OmgluWfusKUbGIXC2BxznMcgvxW7SCn7Dqn4DJr/htizAAs QNcTasbX+wLxNRTt+19P8njlzK8hwBNve/HxEKKAwWQIRBpi7JZ7dpetwr5+OjPnxuKs3p9EtCS R+7NW6qIHbtU50Mp6NUZqJSOOj/P4EHKGsm8M1Y0gP+4iqsz+ZFM3rUC1Q5gRvo8AZ+D0KVzOFD vspq5rJmOu8yt5p3hdwhkGhN+SOUXa7qHWeeWrVkFcHRcpL31mZWHRE98rJFqoJP1GJpEJSjclE ucK3qGQZxXr6p20xVz8QLMik6k1Ff3liLqhcDS9atM4vqFMYGokrHWmvplW7KcBanqTQDdcyvvf Tp2CqTCDRYi2+3laY3Z4jYahoD X-Received: by 2002:a17:90b:6c3:b0:34c:3cbc:db8e with SMTP id 98e67ed59e1d1-35368b45324mr3047519a91.25.1769196870985; Fri, 23 Jan 2026 11:34:30 -0800 (PST) Received: from junjungu-PC.localdomain ([188.253.124.89]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3536d8b8f7bsm2731215a91.6.2026.01.23.11.34.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jan 2026 11:34:30 -0800 (PST) From: Felix Gu Date: Sat, 24 Jan 2026 03:34:23 +0800 Subject: [PATCH v2] drm/msm/adreno: Fix a reference leak in a6xx_gpu_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260124-a6xx_gpu-v2-1-86a1dcf85e13@gmail.com> X-B4-Tracking: v=1; b=H4sIAD7Nc2kC/0XMSwrCMBSF4a2UOzaSpLWoo+5DiuTdC7YpiYZIy d6NBXH4Hw7fBtEENBGuzQbBJIzolxr80ICaxOIMQV0bOOU9Zbwlos/57tYXUVLRy0lL0/EW6n0 NxmLeqdtYe8L49OG9y4l91x/S/ZHECCNWUHWWXCsr2eBmgY+j8jOMpZQPzZC/r6AAAAA= X-Change-ID: 20260123-a6xx_gpu-cbc095dbe423 To: Rob Clark , Sean Paul , Konrad Dybcio , Akhil P Oommen , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1769196866; l=2364; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=yrXNODIr7BomkmwbFTfdc1dmWE/M85IjDSwFYcpA9YY=; b=JgU/mPDrjPcXojazLX4qDQiHBhnqfv8QLohkDcjKBfaKWjkBRHhGiwsK40juItBCsPTUMbGsj /xEXYoqT0yDCiLEQMLR3tJNMRtRSyCbYJcmWJmFa90fSMpi9ncOKNJb X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= In a6xx_gpu_init(), node is obtained via of_parse_phandle(). While there was a manual of_node_put() at the end of the common path, several early error returns would bypass this call, resulting in a reference leak. Fix this by using the __free(device_node) cleanup handler to release the reference when the variable goes out of scope. Fixes: 5a903a44a984 ("drm/msm/a6xx: Introduce GMU wrapper support") Signed-off-by: Felix Gu Reviewed-by: Akhil P Oommen Reviewed-by: Dmitry Baryshkov --- Changes in v2: - Explicitly add header file. - Link to v1: https://lore.kernel.org/r/20260124-a6xx_gpu-v1-1-fa0c8b2dcfb1= @gmail.com --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a6xx_gpu.c index 2129d230a92b..604b0f861d27 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -9,6 +9,7 @@ #include "a6xx_gmu.xml.h" =20 #include +#include #include #include #include @@ -2640,7 +2641,6 @@ static struct msm_gpu *a6xx_gpu_init(struct drm_devic= e *dev) struct msm_drm_private *priv =3D dev->dev_private; struct platform_device *pdev =3D priv->gpu_pdev; struct adreno_platform_config *config =3D pdev->dev.platform_data; - struct device_node *node; struct a6xx_gpu *a6xx_gpu; struct adreno_gpu *adreno_gpu; struct msm_gpu *gpu; @@ -2660,7 +2660,8 @@ static struct msm_gpu *a6xx_gpu_init(struct drm_devic= e *dev) adreno_gpu->registers =3D NULL; =20 /* Check if there is a GMU phandle and set it up */ - node =3D of_parse_phandle(pdev->dev.of_node, "qcom,gmu", 0); + struct device_node *node __free(device_node) =3D + of_parse_phandle(pdev->dev.of_node, "qcom,gmu", 0); /* FIXME: How do we gracefully handle this? */ BUG_ON(!node); =20 @@ -2702,7 +2703,6 @@ static struct msm_gpu *a6xx_gpu_init(struct drm_devic= e *dev) ret =3D a6xx_gmu_wrapper_init(a6xx_gpu, node); else ret =3D a6xx_gmu_init(a6xx_gpu, node); - of_node_put(node); if (ret) { a6xx_destroy(&(a6xx_gpu->base.base)); return ERR_PTR(ret); --- base-commit: a0c666c25aeefd16f4b088c6549a6fb6b65a8a1d change-id: 20260123-a6xx_gpu-cbc095dbe423 Best regards, --=20 Felix Gu